From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65EB2C369B9 for ; Tue, 15 Apr 2025 23:53:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE7E3280001; Tue, 15 Apr 2025 19:53:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B71256B0200; Tue, 15 Apr 2025 19:53:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E9A4280001; Tue, 15 Apr 2025 19:53:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7DFC66B01FF for ; Tue, 15 Apr 2025 19:53:36 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4D7BAC1A46 for ; Tue, 15 Apr 2025 23:53:37 +0000 (UTC) X-FDA: 83337932874.22.E6349D1 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by imf09.hostedemail.com (Postfix) with ESMTP id 6BEED140008 for ; Tue, 15 Apr 2025 23:53:35 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="DVQk/aw4"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.210.172 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744761215; a=rsa-sha256; cv=none; b=cfgy89WeteNJqCCXWOUXApVYbnGm/nWFFYXCf9Lu26uBTnWQ3farG+oBPV5sVn5sekK608 tYd6Dz0iyaT3u+5WU++qo8Pfbp0PjMhejxHW5PCp6Q+X0kFEzEQXYy0OmQrdm0K0fg8+FC avuOqVPl4csqtJeMOPKNfm2grB5d73E= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="DVQk/aw4"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.210.172 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744761215; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HYQb/vAVflfTMHmxSSvin2OsSyxjzOK0qvbBWBFGiXM=; b=tbEiy34JNQgTF1V4Qo/s0u9bOertaRmqEk5TudQW1Y5gpsZNDyXuby0UFka/2iRely2LXh Yxcpl07l7Zvtyf5GDQcLU3lfWVRc/Sg6RVVCSroP7QIsqtzSH3ISgRm2o2HGSNuVvfbntB teMzhmwVtlMlb+wd0/2eS4jXZOtXal4= Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-7376e311086so8092733b3a.3 for ; Tue, 15 Apr 2025 16:53:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744761214; x=1745366014; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HYQb/vAVflfTMHmxSSvin2OsSyxjzOK0qvbBWBFGiXM=; b=DVQk/aw41NJbCPRVHQ4B0lwUEi8UMuEMqSP9Rl9QvNu9wwv3k6A0GRWyMdN1WADTB0 Z7qbQvlZGmFSsDORQO2FXWR/j/8djh3Z1PqyBDa8ccGx5GCcmfkfvhlYLlTU2ZtbR+4C b3OLj/NptAPkvYIGw6Fc9rAJFVM3Pxd5aTq8htgKsPJE0BXvC2CP4XKV6qaUp9DehLXl ks/xKw6X59hnbmwfCyzZFAuaoYx30OmGq75vb9HvgZdk/9Dbobk5wQXLHoR5iOLpsK/H qm4UTzVRvZqSWq6rRekcxsKDyqNOVnJ0nX07iUIf6+oxux0lfgIrfCtbBHeko8Jl94WP RjCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744761214; x=1745366014; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HYQb/vAVflfTMHmxSSvin2OsSyxjzOK0qvbBWBFGiXM=; b=D9Nqw87sTmyFmbRbt20DiaJ+TlmXX1jyQydzlbDkwE/SNthqsBw6sYzQ0R6yeddQTb 7lLY3dITEBErgkiAe8XEoKJSzUL0RbkHr7cCshmEnbVr+jDhtM0f8bAnah0iYKxbuPGd DT3wN2J4fZZuMmaFBO0AXZ07PzKt0flt+L3dCMf20SJJMeRgtYTCvMvg+8d6tbl8rdpB GzkxaA6SsSwl2oPaAgDHJXOLf/4AekC07/9eEgNGXyA/zLB4y5gaaRGtifZYc6Z9zU0R uVbOlue4ZSgpZF5mNqqRpubsK6k3fWOhUELDWEHZk7bFDKmAlRIVHL3/dEHrS7Y2Sv1A CcCA== X-Gm-Message-State: AOJu0YyTHrXUUYga1PyElBWx99YtHxv74m+pOtMEGDNRUfw/GN+oL/ev cMBPkUkjs7smVkCGzjDVp+vkjbc6ctfd4xLxpSFci4TQMwXFiYTNX/oEWDF2 X-Gm-Gg: ASbGncuAMuIQaVMFouJAwnBIqUQKXVjYXQbI0j8h7imRKFnzHUJ9JefcVF+xj0/268m Ts8h7vCGCVL/jO7Hr14K/AYUC9SpkyjtGWDqDjnSHZ3GWlBTqmWKcMv/Eq5JDc1UDLgsIi8Sh9E wQenOTGXv9t8a3+lSJ3dG9qYQy0F19Bcax6nx3TguN18/mtY+0eb/dBiMCEuvVdpzhNX1Dryi16 rtGNgAvRpoBfy/i44pgK1KLmejGR9KJoLCYFbFZH+LYZAEnjVsF/O9Je9txhutEBIZVVqK9c5Hi 8c7kF0i6kGnJwHuuHCrGr+ADosgLxtpeUR5xKSne3/ObwrTMLW/OlcCKW1zex5GQ9rI463wV X-Google-Smtp-Source: AGHT+IF9AGYaMGmU+YAriBxrgwOx89adt7HoWOhuVq0Fg95nw1pi8fJCQ6J9UgCYtMmgen35WpsVwg== X-Received: by 2002:a05:6a00:90a8:b0:736:4b85:ee05 with SMTP id d2e1a72fcca58-73c1f925dbdmr1909994b3a.11.1744761214209; Tue, 15 Apr 2025 16:53:34 -0700 (PDT) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73bd230db26sm9439188b3a.134.2025.04.15.16.53.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 16:53:33 -0700 (PDT) Date: Tue, 15 Apr 2025 16:53:31 -0700 From: "Vishal Moola (Oracle)" To: Baoquan He Cc: linux-mm@kvack.org, akpm@linux-foundation.org, urezki@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] mm/vmalloc.c: change purge_ndoes as local static variable Message-ID: References: <20250415023952.27850-1-bhe@redhat.com> <20250415023952.27850-2-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250415023952.27850-2-bhe@redhat.com> X-Rspamd-Queue-Id: 6BEED140008 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: acquiew7phj87y5hfdqzwexitd6ob18o X-HE-Tag: 1744761215-131888 X-HE-Meta: U2FsdGVkX1/rUrVoXCeg2AOvZyofnIXdhh/Gu/REvl5s1fCz1v5TwrXApS2Co1M2q2CONqNqUhJ66uezUjzsZVERm8wtRPJe9hWI+9FLlRd0ppo41ehADgfwdTULQ4dgbRxzs+FxbJT97WX4E1jKJyvbgwyELSKCseUPZhPkBDcrg4Pagov3t/TGMP6pYwgYoLYauRwxb7ifm4+0i8+ZZSRWiiQR8v0CcX+3mlTw0c09Owl+RlnBxkP5G8Qkm0SxMZ7n2N0v/fTfx0IwBndabZ5141AY7h0/RFAwA+FV8mzRNWVU239ObaVfX/Td4X8lhB/7BBcfc7PvE1HzCDjJv3uKWDBZzI02kwuHop//Xk2b/Tb8uiO9v2gDdHZZhhZ9VSq+nLqHw3WNEAZww9uqEL094ZLHdLinfJHgSW5fra5UtCZYLI0k8Q50tWjdFhyluWCG/SYkuxr/7v+wHASu/ZTm87u9NS3xpeMd3zoj0aDHQksq74PFMA0FeZXcoZrPpfh5SyBuOPq7L8oDZ74EafuH2xG2QGqRUArbj9sBAULTZAAnR9e9gRJwAKJri4mlmGPdU5b2wxb4Py7d+1+J2mL+l6oNLn4eOqSle1PPXUzop72z4PDpFQJQ+gW3iNYjhrrnx0dFWFLhS0TyXembkIYr2uqoFRSX2wIQcYL1TEJdMuYUdl4N6I4rR8I+tIBDD+Ijr1KyIgMZVTWwpYy+6yeCfVih8PW8tzy7pPZ6HsWFLGOIZq+wgDlLgQoWMPZTFyPeNtBgxFFiEsC2C8+euSjh5uPNBEwGtG5xqzN1O2pgdEnVwfMn9VMfkbd+lf2TfV/763rbzXbDkZHjkvOTenVWUjYdcWO5e5ADj71f8sKM9AaxO+tR6hDZ1uvCEEu0y87OpR/W3slJdvQ0ThTIr1Mq1046oc6dAgg308hZEn+ODWzF9VaV/DDQVa6itk13Y2UwTYHKqvIfQih79FP 2EZVHxAw 7eY9iKNH0XSY4QGjRUpdNU10q/vkBztTRxAABkHZIaHectnMtZwTZeCSPsZCkWcs2bmfpPaafc2ocdLX5wAPWZVK8JYTHsQprwTn0A4H0HsJjP5LF1YKIjNzG6SQhsrYh8OjyvHr0d4TaapAvhlFD50mfWe79kjymsrgtFA/nyDHeCTgQ9rRI5PmEbD2uKyiTDh67AeiVv3VsgYw84roaVd1VPg8T3GX8FqDSrGyC7emQByKAN+L9C8yDdgml2ai1pdwAwqUCIYxRc01p4uK1W4EOQ8DxgdZfxtVprxfcosw4ox7jSRgFbQCwtkr2FV6ZU1KtWc0svE3AXBF54El33UivTZZmXqIOHpjOdrK1G+7bmYsMZrNoYvXtimwGteK1l8nI76O+ZcCqXtLccfeNIMkBrJI2Tb/ReiA8g8Xzo+XQA6E/Fc/qPWJ2mvCCr55zvUNUfah4U0PfYbRqTJC7i779QFGbcUQcPDmIbB5JyTraYOZblMms65dzvGAjkEcBk2efvkqOhGExTe3GddnWGCe00bMzEeIdv2IP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 15, 2025 at 10:39:48AM +0800, Baoquan He wrote: > Static variable 'purge_ndoes' is defined in global scope, while it's > only used in function __purge_vmap_area_lazy(). It mainly serves to > avoid memory allocation repeatedly, especially when NR_CPUS is big. > > While a local static variable can also satisfy the demand, and can > improve code readibility. Hence move its definition into > __purge_vmap_area_lazy(). > > Signed-off-by: Baoquan He Reviewed-by: Vishal Moola (Oracle)