From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E48FC369AB for ; Tue, 15 Apr 2025 09:46:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A83FA2800D2; Tue, 15 Apr 2025 05:46:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A30F32800C2; Tue, 15 Apr 2025 05:46:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8AAA82800D2; Tue, 15 Apr 2025 05:46:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 69AB62800C2 for ; Tue, 15 Apr 2025 05:46:48 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 05744140D5A for ; Tue, 15 Apr 2025 09:46:49 +0000 (UTC) X-FDA: 83335798938.28.4A21008 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 49398140005 for ; Tue, 15 Apr 2025 09:46:47 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jHOwiFK5; spf=pass (imf09.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744710407; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DH+PnRmYquzTjQkIdD59pQ2mwqH/W7jZPNvYdcpxI4g=; b=5c51IKp+wtgVm1VfNMvks6T6lbNQmfiXzHn2i1zuSrBe6uRdjQ6EYWBWG2zx+ecdIa0Qre nbTfVyzGVKxm84/AJBkIZ8YLyU1NoYCmFPGpuYQBlwk7pY24OvpryIkijrrRKdwgagzCIt Fx+gVjmTQZq/Nf9kA8rIbx7WoJs17nU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744710407; a=rsa-sha256; cv=none; b=0njJOurMYSpS9GT9/D5o/oXYm3S79CYJR5a46HLfI0zTXtUUUDWSaKVPl61O20U+pu7xvH RRzpNpOmiZqIEUBuAC3jRw2QvKmBjKYgc1NNpnRxPI3qZ6dQb/aYwlC/KzCCaN8jmBoLc6 Gyx0S0uZUt0jEPyzBZaZIEiMi2m8e48= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jHOwiFK5; spf=pass (imf09.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id DBDDA5C5606; Tue, 15 Apr 2025 09:44:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 998E6C4CEDD; Tue, 15 Apr 2025 09:46:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744710405; bh=ubJuCgEktYeJEwKzyfDHYPMVDAymZjfYVt5jrt9RCgM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jHOwiFK58QsfAjPzjHIg+oH0ZYQngiVsdrzsdtT78pukFUHkW/mo0akv2YvuiYP/6 uc4CZkIOOXIlI5UZUsys964/wx90L0lBq5uobZDXpzpa/1pHkXcG7zi9dkXTHGzj2f +iLZ6CqNDUYknfoXLrNpMuwu+3gdtkU89gLzw4xesdg7GugZGW6RSyyd8dKo+VoIsr qKHzpkdlC5ZOvtvjBDOc6C6ERot8KlhM7oChdWDBPUFcGWZv8rTm49vi/eI0IAPBGh eMssZ890SgtE8jJXTasxvlBbuGRR/xj+WyCb+aMGl9hGoGr6ZoGM5l1E3+Chmi6k+3 e+GOR7GoeNFSA== Date: Tue, 15 Apr 2025 12:46:39 +0300 From: Mike Rapoport To: Donet Tom Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, David Hildenbrand , Andrew Morton , linux-mm@kvack.org, Ritesh Harjani , rafael@kernel.org, Danilo Krummrich Subject: Re: [PATCH 2/2] base/node: Use curr_node_memblock_intersect_memory_block to Get Memory Block NID if CONFIG_DEFERRED_STRUCT_PAGE_INIT is Set Message-ID: References: <50142a29010463f436dc5c4feb540e5de3bb09df.1744175097.git.donettom@linux.ibm.com> <736ca451-8adc-4c5c-b721-6b78eaeb4699@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <736ca451-8adc-4c5c-b721-6b78eaeb4699@linux.ibm.com> X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 49398140005 X-Stat-Signature: o34zwqqne6gzjdzipaohq5rnrfa8ejen X-HE-Tag: 1744710407-251598 X-HE-Meta: U2FsdGVkX1+I73+AUMvML0vrSkLSI7dERubexQR07cyqR7QeNjsPsJ7Y7OFvJCYzqrDNAJCcsNv4TEcdlF8pMSO3TMkdMZCz38ppsEqdjQXFtbVKsGckUqXr0/jSyopIkvXGmSk8Xhhuzkls7NA9C3WzwvanmmLo2DFKqcHuAh/46A5pLiOMiqpLuOy7CzyS3VTBxJDMNt0k/oMt4fU8FK9psgqtzdBY5PTQ89zMjvNi6+C2RfgAdnm/T57XZEm7hWHo5JUjQvpwJdv7h1UKgKEl3ZCC+t9sWH3QfbTZenQLk51jOPvn3rhYKYnhOu4abTtegnGCu51ldJdv6eFZNyss32UakXSGSm9HkXe9a06f8pMYXQJcmQ5YpC93bpWHDfFQZYVtUUdpNX9al4g5Eq3UnBhYK9Fib9BHMhr/tOczTLd9bb39F9njfuF6y7x/DjnnnE7RFdtkOyGT+eOJFjiRE1p8/XM91v/aRL/75TjbubYTgHw1bfAd4fk+77fdA6cDbDIFbY0ylnJctpIANTTxw0kYlnMhojsjR9mLDbprox748wWmRcuzr6V5uKstZN2A1W5ivJDCeJa+8RMMx04ghCc/gUtIW888RBhXSpPySZwokq9H/iwdJV/5xVrH2c9mcMgzP+6zyzHDQYXzk5tteQuOhF0E48PlnvWrqvqfprOMlpwtfHh1RO4GP153TEVcIaFQ4fCy/4NXR9/xkHta2a/kfxBXK9WmALSxyd+d2FB42JmOMdZmfHyfDTlDMxazEs+eOs5z6yxDwLfDxXURyPLMl0bbv/frXUqzPRVbNRDk9/aJU2RzpsIvpT1lJC148Y6lNpeGDnJSEycFLtaL5I3lj++Gm2JMHv2ElSdFPLBKoFsf7gtnH0KL7eYMIFqc1TQmxGUdDBfZBYXOga6dsXQpbu+RPH+a67pe7JcU0i8XdEK6NC05dp+jEkzitU2BeF35eZ9D1a1Purn SAmWaMCw HrJ6feO6/CRdJmm0Z8MKn4GDIa+iTDanXR/FL5rfzDYfpHO70GL3gLmCmADT8ybWkwjg0VKcti0qwpLnhnfORYCzJT68D2PmRvbgmp8G6Bwo3zMPl5Qi+kdxDepCU2IOf1yAtoQpaYZXdM+RUTykvFSw75xSCnvx3B0euBqEM35O4gzjpI6wnxbQUmTvoDGtAwEVIHvNQMVy/CgDJc2NKjLFQtSmUtDrk65pXy5/VJe7E45v/j8zMdZpccmthhehQPgujEPQARHx7pmjw31UFlcF1H5b5rAk72Khk5OEFnYdESywDsUG8y2fzYj7DVTsTZDAMKfQym8JoL6I5sh1QGNR8MiEMpuUF3qLjLuz38cHBdPJbMmbRbR6ohM+8jLAMI94kRdywpgUpRDc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001827, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 11, 2025 at 05:06:55PM +0530, Donet Tom wrote: > On 4/11/25 4:29 PM, Mike Rapoport wrote: > > > > It might make sense to use for_each_mem_range() as top level loop in > > node_dev_init(), but that's a separate topic. > > Yes, this makes sense to me as well. So in your opinion, instead of adding > a new memblock search function like I added , it's better to use > |for_each_mem_range()| in|node_dev_init()|, which would work for all > cases—regardless of whether|CONFIG_DEFERRED_STRUCT_PAGE_INIT| is set or > not. Right? Yes -- Sincerely yours, Mike.