From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F11DBC369B4 for ; Tue, 15 Apr 2025 10:47:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C5C982801D3; Tue, 15 Apr 2025 06:47:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C0D472800BD; Tue, 15 Apr 2025 06:47:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AAC542801D3; Tue, 15 Apr 2025 06:47:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7328B2800BD for ; Tue, 15 Apr 2025 06:47:06 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 81B67BC159 for ; Tue, 15 Apr 2025 10:47:07 +0000 (UTC) X-FDA: 83335950894.26.0D84AF4 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by imf25.hostedemail.com (Postfix) with ESMTP id 81247A0005 for ; Tue, 15 Apr 2025 10:47:05 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SgeVkMLL; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744714025; a=rsa-sha256; cv=none; b=TNqfE7qlfDOmw1jDI4P2xHH4+4XMa7rnUbFzH7yeB8ftnqo/izKiNX8qgEc0+F/nQSKz33 AfqEnbFwgw2aEVQeOTiKC9RABlWNGtplKbzsJFUVnRFTNQTuEQ8ygIr5KmywtjZ3AYP777 aflNcFOUmc4Xd5j1k9yGJkjKNnUAbEA= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SgeVkMLL; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744714025; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7EaxcguEM3rJbY1RIVvFAlZVp9grS7NZ2N0I7IWJKeo=; b=qWgKuGuOCC/swe1EfG1OI2kcMC6PSl5s6A/ZRfJbzil3IsrDtGMM1XoPRwSJpbosvr0NUU Zx7dKZFRTUc5djNVPoX+pCmKEdSM5BF1JUEItmYUs0PRi8v5ayiIuZY6T3wQV8D20tIU7V NZx/1igSNBpWwBG7hxGw2PPX0Hiougg= Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-30dd5a93b49so46793111fa.0 for ; Tue, 15 Apr 2025 03:47:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744714024; x=1745318824; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=7EaxcguEM3rJbY1RIVvFAlZVp9grS7NZ2N0I7IWJKeo=; b=SgeVkMLLymf4/31uVB2bQNV2PT9plUdsl7si7Asp2U/A8bIJ6eqCapTb4AzJJtFdrR Ld0cmft9M5uZ+vwlrdDUbtxblrKs8of4fDDrOG5t6YI7Igx25mMa+VLmHstgyspx4cvX WrjMoGSu6cN0/JCjzyrnGe2D+DxAHdi4zMJpdv2gL72+iLpbBQbQ2G1KHIR3V371l/lV GWH/yldfCvwnjfK9y/DW1Ayy5sULkjJnUq/vlM/1g1A+LuW47Gn51jDGGglYJan9aqgh fpKhOOaZ1Z2hYHZUZNcQ9I4vZ2O1VEWEizE3nuTYKoLKAowXmrdzLK1dQR2TQJORst25 ea8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744714024; x=1745318824; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7EaxcguEM3rJbY1RIVvFAlZVp9grS7NZ2N0I7IWJKeo=; b=E2UX3dlPn7XgndI45HYO9Xp265tB7LxUVfyrEybXlGJO/GKLa9EKk6YAxfTVQ+YhaW qlppceqIjZ/QfE0nKM6FWPNcoJ6ioBSFt2ANEE0/hfnTPwoNmnB4ApOjoCh9gDp9mxtG zRwxq2eec3J5DAuWuxnwW8CoJnrc9igEQwxfBdG0T6PPyvB8ZlvSmTCdYmVezxqyBcix lfFEmhDI7wUgEj/QjgBOFbDAQ0Sx6JwgY8nWKLNkBkYYvBdtsblMQvmTzeV0sXz1uxJC 2pK6xbFBPBeSqII9luoGG5uSh7nTBjE25CMVRCCTA7cls0vs+PEv0pH5YcZZ8yM1jiyA inBQ== X-Gm-Message-State: AOJu0YynL0GODpJG3qJeNi4Pelctc9DvtPm1ItyCpj8rLGpo97Om50+2 wyLrjgwaB4dXMaaMSxE9DbCW3d2ytYox8CvufCvS7P6D0lMe0eRUjMWaQ+ny X-Gm-Gg: ASbGncsisLkiAmO0mGBIFswTNRv6SvsGjl/GhOSLNHN+p4RaQsmam/plcbitD5rhgKp Uc4HKxsh9JJp6JnKV7nvQhF3eqVoLSYRSYcx+jDxSGte3OFxWqK8j0f3rEpdtfv7GRvV2YLHfkv hwbnNGI9lGvxeG4XDInKdH4se3OPjqP/QiytP/5gg/lZS2lcnBhfUMjRgCCqbur71cKjVnVq7oe kh+KM+BV3X3eL0R7EA547CUeALPTd6Zi78oTVPhGx7DT7Yd6VWhy0k7h3n+4bAkzKvxdZa/bXxv 8LBoNgYFeZh9DKTUzzlqmgCkSuYc1qmYaZ/OjdtJwZeyRWDOqu1nHslpKmLZUStYpfHq X-Google-Smtp-Source: AGHT+IHYak+E+5q483HjsGOLaiHh16gPhmjBX5yXJX9pbtSJr9Ts0hG4ikjxr86NGfabxz7MIzRV6A== X-Received: by 2002:a2e:be14:0:b0:30b:a92c:7dd9 with SMTP id 38308e7fff4ca-310499ff63dmr47915501fa.17.1744714023594; Tue, 15 Apr 2025 03:47:03 -0700 (PDT) Received: from pc636 (host-90-233-217-52.mobileonline.telia.com. [90.233.217.52]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-30f465f779asm21455651fa.91.2025.04.15.03.47.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 03:47:03 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 15 Apr 2025 12:47:01 +0200 To: Baoquan He Cc: linux-mm@kvack.org, akpm@linux-foundation.org, urezki@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] mm/vmalloc.c: change purge_ndoes as local static variable Message-ID: References: <20250415023952.27850-1-bhe@redhat.com> <20250415023952.27850-2-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250415023952.27850-2-bhe@redhat.com> X-Rspam-User: X-Rspamd-Queue-Id: 81247A0005 X-Rspamd-Server: rspam04 X-Stat-Signature: f3myhi4rykypt9yo5mhmtxnohnfgksjr X-HE-Tag: 1744714025-488302 X-HE-Meta: U2FsdGVkX18opyAYnoS+XEuJ+AqRULWRc+5O+3vtoFhJ8c9gT7rzugD0DLhK3Pus2+rZtOPdqvqI7pf8gHV8x3YDDP67i3WmO5QuX8x3K+CuLWUwTSwhnBstyuvmqUkIOZIyriMMvN6B3z+omnTyl6rOh0TGyecYapjWiqCtCkNKa2MawXVFVFqN/Q9cH78KQppp77d+7yRFp1HWQP/gCz3tfjYo1BBAJ+cllSgL35oPjokFaCmBNDKJgtoEctZMGWw7WxAQkHvsXTPqDBtuAy+U07FV6xHiWWvkTSRk6Hjl/HN/j4ENoVOKwZEKReTDsw4KEdCH8HCj+ltlGyFFj2nfp8UHilz5aL8kBuYEdtfGfUKxDfH3ogddMKO9QvPLH285WFhcHU69+OfqTW0XeHnOKbuAfpO4APczyUtyf2e6nzVRQTY8uyZZrBXhpXSRF2t57YGTjLmyKAcUiMMOnCvGx2zbQ5KE7dtSHVW1ROOZ7dejXRFbxyrtaDPZjI417PwuFZ79gVfyuKzEZ50gkiDPR31Pfz/2F9LndgHz22tC5/doSyk5v0+i9SC3pU7yPCXA8+dnNfelgVSaoElyD8usZO6YJLMG62JUfSq1Z5tFyXSYKlHYbdHewH1kChS659wfoPucO93Pn0HxQNqQ/IFRdyWf91rkO5BU3+G65UL9gHP5d4po0B8SPtVGsjtZ42q4f31/VB7V0MFsRlYSVN216lC/Losf4mV0qtkYElDk3f48pIVpqDkSBzZjt/7VxkqVPdnI7+4qX3hVrZybgJrwVglGSSbz/0je6uXEze1lcAzcuavBHV2aVxyvFFxVXiDVJKz8/7sS3MWQZYb9EUbDlBetWjTelTCfMg+IAwEPN9Dyss7F0ZPHOCdWrtoY2jZn6LM/Z9EsM3hvT8/UI3WJvt6Ker6jLGVjjXkJKAdamEVopGGu0sVgKMr1b9dv/fY//xjXCIDjpPm2HCG BRCRzpQ8 j/EdkN8Q2oScncmOMBMzGKCp1PTxKbIPFFEfcDAcCBAqfYgGwKLqaY4vmfz9TGVjkjwYhfO7zkxMzaSzCZjISpGRM8TNNt2OTCJdVykRTcL8oMwTqpohJUjF/TWPUSz1L2EUHBeSxpUnFyaPhM+B2NyyzIf9LYeeGrNsyhRxRu8UgAC8N49X/7cedMc/zIiIOzxj1DE64nf/GqxoOv9I2VkwAR+DUTrWufVt8Q0Sh90ho0yk8FXtAIJYnm8+CtqHWD40+SKoRIU7i1AMiG2AH1vMoWt+vb+AUv9tG+q3Woo4YDttMoDrFAdy8GC8SRq3OlHMef4dZ+FoDgn60ze4rnObGkzMQE3CYMGkehx/JnvMK7wJovyMvJg189m1+k78U63lZSYvcTmaJ7qeQ8GdEqVnPHzUdqSF+8UoFzGwZ0vuCIWxo8bZdseNDyhV5nQvtRliww70F2Kb8pA3+IMzANmajKbLiiw4Hxl0NMBasrFjD5HQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 15, 2025 at 10:39:48AM +0800, Baoquan He wrote: > Static variable 'purge_ndoes' is defined in global scope, while it's > only used in function __purge_vmap_area_lazy(). It mainly serves to > avoid memory allocation repeatedly, especially when NR_CPUS is big. > > While a local static variable can also satisfy the demand, and can > improve code readibility. Hence move its definition into > __purge_vmap_area_lazy(). > > Signed-off-by: Baoquan He > --- > mm/vmalloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 6ee7fc2ec986..aca1905d3397 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2128,7 +2128,6 @@ static DEFINE_MUTEX(vmap_purge_lock); > > /* for per-CPU blocks */ > static void purge_fragmented_blocks_allcpus(void); > -static cpumask_t purge_nodes; > > static void > reclaim_list_global(struct list_head *head) > @@ -2261,6 +2260,7 @@ static bool __purge_vmap_area_lazy(unsigned long start, unsigned long end, > { > unsigned long nr_purged_areas = 0; > unsigned int nr_purge_helpers; > + static cpumask_t purge_nodes; > unsigned int nr_purge_nodes; > struct vmap_node *vn; > int i; > -- > 2.41.0 > Well. I do not have a strong opinion here. But right, it is only used inside the function. Reviewed-by: Uladzislau Rezki (Sony) -- Uladzislau Rezki