From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 697E1C369BF for ; Tue, 15 Apr 2025 10:44:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 80C492800EB; Tue, 15 Apr 2025 06:44:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7BC5A2800BD; Tue, 15 Apr 2025 06:44:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60C7A2800EB; Tue, 15 Apr 2025 06:44:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3E1052800BD for ; Tue, 15 Apr 2025 06:44:13 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CFD65811F5 for ; Tue, 15 Apr 2025 10:44:13 +0000 (UTC) X-FDA: 83335943586.13.C683A4E Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by imf02.hostedemail.com (Postfix) with ESMTP id C8ECE80010 for ; Tue, 15 Apr 2025 10:44:11 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=E4bm57R7; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744713851; a=rsa-sha256; cv=none; b=tMra6t9+1sB/luc/Odrvnj44SDR5/7WTgBsY789S9GFdXVHY+AFpUo92aQlpSfS6OFnzMG sgadQ0lZm7GOt2jloO+ApMt/VRSKjgaNSs4soa4FsJw6nlIcrENcPPKtKlVDQIW8tqff7J Fvl+63xR1OiURPmsNGpYjIHvqFPXJnI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744713851; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VrLvFpuHTSAZbRxj4a3Ca45pKQLXAVqNxC9uOeGwapU=; b=5K3QQ9YXCT9WMaT5EDuk5LYMENr8VnRP1Lom3CKbeqGiGX4zED6ktzslcp8BEKPJO4Sj5M Q6ujjjbn7B5cr/O4VZu725w9pEgcJ9/uzL57UiF1otYwYSMyObEHGwYFamSStUEzz7h2l7 rI+u28+A3eJn9iqE+2cfbv4KoJ/+2HE= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=E4bm57R7; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=urezki@gmail.com Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-30bfb6ab47cso49587021fa.3 for ; Tue, 15 Apr 2025 03:44:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744713850; x=1745318650; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=VrLvFpuHTSAZbRxj4a3Ca45pKQLXAVqNxC9uOeGwapU=; b=E4bm57R7ZpBOQxZnN4AOR6S7z0W2kaTU88q/fJF4NShXkvsC7InnKpTdOBeQgf50UN pXPAczHVeb5bNjbrBd6TKDPqIxqFTuEmc6kEPCQjAcULAZWj+KWWGnaJAlitz9F5FAUG M2EAmsNjHwUaQ+ed7xGKBDUAb/D5xmsydsHj6QMe1vABioUKqfsy7ssJh06z1fx0OElu 92Z8fHDj1wpXmtpG0AMsoowyRQ7jklmPmTFnwBw7COY1sxOS3+wY9MEE3QUlnwXj1iD6 VBRAlCBXTe6LTxR1gSTntwaNfx2iu6WZhUp3+gZhSEcrv34MsRxwXl8skO/aY8MVlL8C h19w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744713850; x=1745318650; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VrLvFpuHTSAZbRxj4a3Ca45pKQLXAVqNxC9uOeGwapU=; b=LscpRXNZ6FR5NNaRyYvcIVa8Z1hW3eMi7nHR7Yt4jpLmWzKAQfZeh3yZ9MoScz7yx7 yym3CuRm9+DQogiECeflqQCY4GmDNl4lcZjw3Ox35gWHp9UFXPeONmCe9El/lOoaMpYt kbjSGexqp0MlgT8kePgZPFr0ATmRmYBSB3S7jq+WtTp3tIFaG/Q7c5oflWxLZFK5BgU4 kbcx/KiKgA4lWZV8p+lhxsarv4OxvNcDwXi8gH92COvaeAohLUcNb8nLOD1S0kA2sczo bcWoAb6lc+Wgls62LX3zHUDIMOTGJQ3npzEiR/C6aV4WDIXFJHnGMUOd7evS0SdwIaVA HWWA== X-Gm-Message-State: AOJu0Yzj+N0cnZM5ZlwTtkvGlRLgYei92xARHlzPmswIy+hyMrQNRivS pdh/prON6H0qet9MXFpcL00EAsoxMNRKygN1qSRkuxNEo+n84vGn X-Gm-Gg: ASbGnctfAJygApAMfixKqisYEDDVV6usnTv84RXKbRfZtKNUs3trDB35l0erdGemhO4 lkXUDRTNHsCLkJAC46garqTnAJ8TCvKcsFcGW1FA/uHxoD2yTXVLVREZUEYx4SS2mnL9AYOo4Xk ILkiCMSHBwJ0OdqmQ0ZRhkn/LrgyDiyL4xr4fVpjtQrmmrg7c5iRTV2ZDPZQiR8s8TLL8Ij4SzI rHb7+dbiLNhTDouosrZRsImdf53E5d7JHijte6W9+fIBKRjWM++ihqz3kTRLsP7E5jGJME1ERW0 LJ8ZhpFodejAwp5JAc4BJC8/U9vb+RaUFmQtRz0lnBf4+772pk90RdsqP9cYOXO1fQNZ X-Google-Smtp-Source: AGHT+IEq/npw1FKWrK84Hcg467AIj49xSaKauOvtLI8LfcqRE1zz7NBCC2GkNPBmA5sg5WHHTC0CfA== X-Received: by 2002:a05:651c:210d:b0:30a:4428:dea9 with SMTP id 38308e7fff4ca-31049a807e3mr51421781fa.30.1744713849631; Tue, 15 Apr 2025 03:44:09 -0700 (PDT) Received: from pc636 (host-90-233-217-52.mobileonline.telia.com. [90.233.217.52]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-30f465f84f1sm20090601fa.102.2025.04.15.03.44.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 03:44:09 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 15 Apr 2025 12:44:06 +0200 To: Baoquan He Cc: linux-mm@kvack.org, akpm@linux-foundation.org, urezki@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/5] mm/vmalloc: optimize function vm_unmap_aliases() Message-ID: References: <20250415023952.27850-1-bhe@redhat.com> <20250415023952.27850-5-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250415023952.27850-5-bhe@redhat.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C8ECE80010 X-Stat-Signature: of771zdcfmkeq7788oocrhditkzsutit X-Rspam-User: X-HE-Tag: 1744713851-160120 X-HE-Meta: U2FsdGVkX187iaJN7Y6l1lYng3osILHhHoRXYSMJaF9sfGv40oV8Hz1chCnGOoe+WD95xVW9YwQBbsZEyAsX9O8GRnDCsq6/o4bQaLt15X0XmnT19V1j4WgvWWfIXUV271DVNocwAWNEFLyNGjrnUKibN4MklPh9Dp0Du+Yq7vdf9lsU3goGZ8Y9B7Fff/ez+NVvHNcaOttDuP5MXFaZR9R3LhMOP2yj3W3e2Sz28Ss7h7rCeOe9wCFMryaCOrD7oMkjlXBUKXkK2tfQTYaY4Kty9raNHvgZFODMUYMTDR4WDXDaKgx8qaH7bs7VML5cNlf5tsDh8PDhlZ/egI9ke3FEXyr5hyvmac3x4Usla5tfapSzvK00Ww7Z2/pgFnadnTcQT2UCmsEVIYR9l+RDu7u6ELRGgEq3+Zycbx+HXGtL+eLgpFJ/DC55/MltfM/2NDTf1paIX/bIlBYnlLYQkxswUj4S6ShGX+kndvdhYx2a/M6NZ6wEbQb50YF4ydS0aH8f/Y/+UyQHnyN8Kd5rQ+pg9uZDL5VO47xWmFnxxlG+ccgQqLhQz34PTODCS9oKJo8cWRB2n1criA1E4rceE5Qq63twgo61H5hJVO5t4x2ARXOF4Qz7iifYvtZYgiSv8AFUDru7l8XzbGmACAPu5hmwILNXUflJXcJT/3VcgsSy716SW/EhkAxz7QMxQZt22pPd3U+bWpGijKGVvVdPGVgCwcXaQdDBuvfMhXtZkI1RTZ/jVdhV9zAuU4vayiWwa1ZuqF0t1SeICy5kztWpcyFhlZowyOGS5ToTXZzxLE8xOYZiRVvyWsTtiRoqLghq6uoKlSu6PKgIG2sRCatbn/LUndIlHSfGKyzo9s3mwA6W788K1t1slKKR51HSewrXiuPanvT/YxuCMeywye4yxaplNpN69inFK7Cuhq0dBDiRAoXPYNCHKH+I4FDZpobn5o2Xx1lYlGE/IjDklnK j3Z2ETzO maLCYY+qqUrwMMTElNqaPlvIcOev2JYT/fjKPUWt2VcEydtBZfIt9o/1pb963tSL1H0SmmX0cGx1vROJlDdiESKxMVR1HWZljTfvJRHwjM5r3Kyn2a7mefyLVUn9SjpCbpefeVQiOcYqEhBbgBoXUR67nvzB35g3hFqyuuJYn/FLVwJRSPf0lQ3Avp8e8ZNjuAzRD21x8KzaDHi2zk+r6jkcOsA+P6vSF8uKHU/ldv9ouvUais2PTOD3gWUHOie3roQDEs+hoaERQ+FOmFY9CfQ0aBeKmBAItasyrDpawU31gKkuJBQYly7pZM8t+G94burzZrZpvmh/nVBrnrt6uBkPt3tkwllMaOEBrBcnbl7WJznGz1vCu+PvdWb4m9bIsH1ET4H3PJLriYR0MSKVygakdGELygtMDtvY6rBEkmqbW+nWyCttlA76KhI48EzIBYfVqLC7GdqwhaFniLtvNSww6AphsKKWg60dEj0RW8uResyE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 15, 2025 at 10:39:51AM +0800, Baoquan He wrote: > Remove unneeded local variables and replace them with values. > > Signed-off-by: Baoquan He > --- > mm/vmalloc.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index bf735c890878..3f38a232663b 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2930,10 +2930,7 @@ static void _vm_unmap_aliases(unsigned long start, unsigned long end, int flush) > */ > void vm_unmap_aliases(void) > { > - unsigned long start = ULONG_MAX, end = 0; > - int flush = 0; > - > - _vm_unmap_aliases(start, end, flush); > + _vm_unmap_aliases(ULONG_MAX, 0, 0); > } > EXPORT_SYMBOL_GPL(vm_unmap_aliases); > > -- > 2.41.0 > Reviewed-by: Uladzislau Rezki (Sony) Makes sense! -- Uladzislau Rezki