From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0282C369A2 for ; Mon, 14 Apr 2025 16:25:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0BE6280065; Mon, 14 Apr 2025 12:25:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ABB07280029; Mon, 14 Apr 2025 12:25:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A861280065; Mon, 14 Apr 2025 12:25:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7C2A0280029 for ; Mon, 14 Apr 2025 12:25:09 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A833CB8B3F for ; Mon, 14 Apr 2025 16:25:10 +0000 (UTC) X-FDA: 83333173980.21.E8FA8FA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id 19F47120014 for ; Mon, 14 Apr 2025 16:25:08 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744647909; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B47q7VuSwb+/KbgR7SpRudbZnMLCz0OlCGXA+NFqc04=; b=TqVMG6vlDEiWF7jsnevkQ41wdfr4wCIU201Lb/kP8wJ1Fp3He4gyi7khoyGrHhiJfAILq8 3fVp4iT2zLumrdxjAHlH//7igzuIhGx9NcVM2Ym0BP3IMJDmic/VZ3lNrBpBN0LvELXXfj m3sz56FFecI1pchj5ifllU+TwYZ3FzQ= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744647909; a=rsa-sha256; cv=none; b=rF5KEbSbctaWhCb2+mpHpOVIaYy6hKCisBUc/uDVicfnNMWyQPR2+em1DdovR4Plzaorez c96KQgBRQJfLp24FFJ1Ok+NUb2P9y8ay5ytRcRRPQWA5U1K0vNC+Q0NTaReI6eDHYklX4s a776A5Sjp1njA0p/aEf6rDhXDv6cfZE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1FE925C4795; Mon, 14 Apr 2025 16:22:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E2FEC4CEE2; Mon, 14 Apr 2025 16:25:05 +0000 (UTC) Date: Mon, 14 Apr 2025 17:25:02 +0100 From: Catalin Marinas To: Ryan Roberts Cc: Will Deacon , Pasha Tatashin , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , David Hildenbrand , "Matthew Wilcox (Oracle)" , Mark Rutland , Anshuman Khandual , Alexandre Ghiti , Kevin Brodsky , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 04/11] arm64/mm: Refactor __set_ptes() and __ptep_get_and_clear() Message-ID: References: <20250304150444.3788920-1-ryan.roberts@arm.com> <20250304150444.3788920-5-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250304150444.3788920-5-ryan.roberts@arm.com> X-Rspamd-Queue-Id: 19F47120014 X-Stat-Signature: aqfy3ns4aphh99a4bj1z8fhuz1u4xgzi X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1744647908-806644 X-HE-Meta: U2FsdGVkX18HzeRXEgCS9ytptLrwx7A15ohW+SYsXOn+NrcNI0ir/VQToAcm/eIfRAy6zSo+vXVrgI/Wx+GSRYCwBuGIQG3ZXpAJI5AulfukqteWoHUluNKsB0eTTdeFFmKI5JrQdyyqdP/+pyAHTRdFie+ivISYpc6DCh0KzagrKcIBTwsKz/vovc1/5zeQLliWsqptxcQuRUz3zIGBOf826BTdO/IxNT6wjofkgjMkIr3AvcbFHlecLXsyVYHlu9k1T13Ht/0GqQ8kgHTItK1bwsS9krTJPc9OwqS6gAtCNKr9EgtUjYnGk+8AbCsrje+Ypf/dd+tt8P9MURnZV2p+zDsoQZZVtyQIF/rc2yUAZ8hgov0bz6kzye/fOWaN2unEqOIUNE/cXzTItiNLBGCdqDDlkFjchfCVTbPC4RcA1RIkE0KZj7JJKPyCZScEjR1lqn1anpV4qrH1kANvDYcoRXhl36WvN28+mDx19PV6w83eyoZlUliycl74/GkP9diIM3OUQhi5GfDn4aEFd0yhrVKzP31iL9Oecc6RFI0C7Vq8djSFtk2q9sm9YbufFbHZueKaB63UuC4QHx6sZxnMGVvcbUee/2gxpdL2Wdb3Ea7L3AyMQzf/wkAiS4HuKsCtcemN/YtzT8IG+65Fd61R0FU35nIHlHjx6CkWiKme6cEFiRpDRIAvVF9CO1jSegyHpIiSqvmH3HgaV6YB+LPCel2H63Vmz5ZhtisRT7s76qI/scsWO9jb8Y6lYOlSHeGiFlEHzLoOiplMrru89NWsuT0ZCKQlgY0Lh2SjpUdpovA8NLHyoHO69SJNN+60ykhLGN9uJtXJ0jbJCynQOK2UkTjYhifnKvo1RSawdO8iu0edyKzQ+Z5lticTcvDlwdM8posF5C4tS+pdLLVX4t3TFtLh+MZV6KpsnF9H41a8semevl7VUBoulVAGEizsE/g+JjtmDp6Cil9miOo OZ6ELtC5 sw1vdWwZvwD4p7zqDd+Bm3/350VFfJTRnjBefeLzYXRhKqri/kRgyKQkdEqeRrP1Y8kdru6tXjPTg10Zu2HrP/RL14dASH1+M6SUs/YY/E4P0gvAjR5CPF1HjSA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 04, 2025 at 03:04:34PM +0000, Ryan Roberts wrote: > +static inline void set_ptes_anysz(struct mm_struct *mm, pte_t *ptep, pte_t pte, > + unsigned int nr, unsigned long pgsize) > { > - __sync_cache_and_tags(pte, nr); > - __check_safe_pte_update(mm, ptep, pte); > - __set_pte(ptep, pte); > + unsigned long stride = pgsize >> PAGE_SHIFT; > + > + switch (pgsize) { > + case PAGE_SIZE: > + page_table_check_ptes_set(mm, ptep, pte, nr); > + break; > + case PMD_SIZE: > + page_table_check_pmds_set(mm, (pmd_t *)ptep, pte_pmd(pte), nr); > + break; > + case PUD_SIZE: > + page_table_check_puds_set(mm, (pud_t *)ptep, pte_pud(pte), nr); > + break; > + default: > + VM_WARN_ON(1); > + } > + > + __sync_cache_and_tags(pte, nr * stride); > + > + for (;;) { > + __check_safe_pte_update(mm, ptep, pte); > + __set_pte(ptep, pte); > + if (--nr == 0) > + break; > + ptep++; > + pte = pte_advance_pfn(pte, stride); > + } > } I thought I replied to this one but somehow failed to send. The only comment I have is that I'd add a double underscore in front of the anysz functions to imply it's a private API. Otherwise it looks fine. Reviewed-by: Catalin Marinas