From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA304C46CD2 for ; Tue, 9 Jan 2024 06:05:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E4E7B6B0071; Tue, 9 Jan 2024 01:05:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DFF306B0072; Tue, 9 Jan 2024 01:05:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CED776B0074; Tue, 9 Jan 2024 01:05:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C0CD16B0071 for ; Tue, 9 Jan 2024 01:05:36 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6A653A1971 for ; Tue, 9 Jan 2024 06:05:36 +0000 (UTC) X-FDA: 81658735872.14.7D30224 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf12.hostedemail.com (Postfix) with ESMTP id C72014000F for ; Tue, 9 Jan 2024 06:05:34 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UniqjT2u; spf=pass (imf12.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704780335; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ruocV5UAmDtdtARc9DyyApm2bHKFWmgs/NbTU1Zqb+8=; b=vLzu65zPTTCmc1+PTU1/bhoihuPHhN1vQkdnkjKnVONzpja6oAyKVxy+GDwUBDQjXdtrlQ nrtt4S+Exv1ErCxkH+ZeLh/ebCf5ioemFT691y49IXs1a2j0ilGQDsRAwADod1JYQGMMQt po7E4+sVSJdHU0+w2sGIcWpezRPT3Ow= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704780335; a=rsa-sha256; cv=none; b=VgC7gFOA5iexV0GX5juRwSdWcDjZe26FCWH5Vm8kcITHajevIYVzEQzLzq63+od0hlDt/x qr0Xi1YF+y8Crzw2qF0VCp18S1BxpQCFhjXtugiAqj9spDPSTeLMOaGzAnr1Kp4mNpRm9s 4Q1gItkWEO+j5mKUYRvnHe9YDbP2zZg= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UniqjT2u; spf=pass (imf12.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 20B1CB81A1C; Tue, 9 Jan 2024 06:05:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C862EC433F1; Tue, 9 Jan 2024 06:05:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704780332; bh=XPd0RK08tWKOZINB6b6dqpbqY/JsdvIb4rb1JcNGbh0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UniqjT2uQSbEWk9DR7Gyj5TlU4bsscbhMppvDMl1CKeQWbyj0/7Duu9+WFjkQRiXg +0VwpTibsiZI0CxW98HdwKO3yFXMphC2Slz5GGwzK9UwGwnoHcO9pKT2Dq3RgSoPpR MPnT7lWfyUxy0TpSNkAaX+qVBhwkNcsnxGLUIysFHb+0Hz+W/53j2nCd3nRPavstZP OALIy6yn9Ca7qXrGurgw8kMc9amlBqhd800wDtAtI0Dn55BvNaSMcXkUyQFJ0dKEs8 lXQjS5OCq1+wMumKJEB+qcGHon6T1uH7Sp5aYET8Xw3Zcd5xHfcZbE+5dagsSolXPO UYuniVAYlB6oA== Date: Tue, 9 Jan 2024 08:05:00 +0200 From: Mike Rapoport To: Wupeng Ma Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] efi: Disable mirror feature during crashkernel Message-ID: References: <20240109041536.3903042-1-mawupeng1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240109041536.3903042-1-mawupeng1@huawei.com> X-Rspamd-Queue-Id: C72014000F X-Rspam-User: X-Stat-Signature: qknchqjyxsiexk83atoctw49x4awicq9 X-Rspamd-Server: rspam03 X-HE-Tag: 1704780334-295727 X-HE-Meta: U2FsdGVkX19rj4tMKZCdUF9LRcQ4ddFR0ssdq2OG1uNWVUxLubnqMO1V595KLWXN5grASRizByBeyj7F04YtETDVsME6ulpwHNL2K/QvmtV4FermzDRwxKfJjZWju0PHsME+uGUHHP8WuXysln1lLh1wt+zC7UiDG/WYT8Kq+voNSvQTjo3AnyiGxPtInFPdPYoTaCiSCygWJejzq7P912VuPET98x+72hePqeQinbAX7wadnOL/5QPt2FciailsfcZ1YIMgNEGH5TBW9wH8hCmKbG6jyHtFHYD17AP6kYY7xc1IvSCdOJ25E6vNXlqOr+o9yR7POx3VSiPjI/4bNHV/qiUQRVqQwUnmnK6CCu9liQu6DJkDGz9SCe4RE1Uj8m5IbykHtY9IP6fQdM17zLIuSNKlCfF47sAl9nAM2hFN5Uz0BYwuITt2SDsPD7MGpoEtCqpZXzON6cZOB5hy3BHnquQxXDqZBLZQ1Wh5Y2FJsxk8W0Ok8UuEzK4IwJAsNKpIo8ez3SshMfZydpzzy3bm3Rg+/AwTzY0zBloJanQQrsNkNqopAepR61LRoQFXwMH5uTlUhEIhsd20OUHzYXiGEWctBnKmqOU30uR/+2flH4MY5b9+QwXi1y5qUGVjFbuJaGchYn8w4t82Iv0Hxw4fbK4xOw4RfiiwPInEngtaQJYxB70QaODQ2GJ2kWdUEsUo9eye+Rdp6HkBQtPCdXCLLV4x2NXSaSPQzy4NmdxTCqoaTPXjOe1CykWQ0sJIDy7H51AkEfkC9DXGZQK4qRMOgooUaucNcEfCQ9NUbhUw8IazKPnatd6e41+8JbSSzu9hRg8j5O9hOlFd5qc98XEs5OuGCxPORnZPAA3gDRn2qLmC8Sbp88Pk8+ojJ/IeL9QCIqNJlYA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 09, 2024 at 12:15:36PM +0800, Wupeng Ma wrote: > From: Ma Wupeng > > If system have no mirrored memory or use crashkernel.high while > kernelcore=mirror is enabled in cmdline, during crashkernel, > there will be limited mirrored memory and this usually lead to > OOM. > > To solve this problem, disable mirror feature during crashkernel. > > Signed-off-by: Ma Wupeng Acked-by: Mike Rapoport (IBM) > --- > mm/mm_init.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 077bfe393b5e..513bad672708 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -26,6 +26,7 @@ > #include > #include > #include > +#include > #include "internal.h" > #include "slab.h" > #include "shuffle.h" > @@ -381,6 +382,11 @@ static void __init find_zone_movable_pfns_for_nodes(void) > goto out; > } > > + if (is_kdump_kernel()) { > + pr_warn("The system is under kdump, ignore kernelcore=mirror.\n"); > + goto out; > + } > + > for_each_mem_region(r) { > if (memblock_is_mirror(r)) > continue; > -- > 2.25.1 > -- Sincerely yours, Mike.