From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F8BAC3DA6E for ; Fri, 5 Jan 2024 17:21:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2243C8D0018; Fri, 5 Jan 2024 12:21:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D3F16B024E; Fri, 5 Jan 2024 12:21:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09BFC8D0018; Fri, 5 Jan 2024 12:21:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EB15A6B024D for ; Fri, 5 Jan 2024 12:20:59 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C56191A0569 for ; Fri, 5 Jan 2024 17:20:59 +0000 (UTC) X-FDA: 81645922638.01.A753A89 Received: from nautica.notk.org (nautica.notk.org [91.121.71.147]) by imf15.hostedemail.com (Postfix) with ESMTP id 9EF3FA0023 for ; Fri, 5 Jan 2024 17:20:56 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=codewreck.org header.s=2 header.b=CvojuvDV; dkim=pass header.d=codewreck.org header.s=2 header.b=CvojuvDV; spf=pass (imf15.hostedemail.com: domain of asmadeus@codewreck.org designates 91.121.71.147 as permitted sender) smtp.mailfrom=asmadeus@codewreck.org; dmarc=pass (policy=none) header.from=codewreck.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704475257; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=G5QLtqgPgUPlhX16D8cxgZSrhZwA8FdHTj67GHw0qi8=; b=5tEi570ukCjqzhGbLzPIuqnJyd98wZk0OeBmAJfVs5xutCrevZ8V82jsD8dqDeXwxLIRjC /N+KGSxRteQkjqifA1qw/GcbNQ4F7Hi2yDj4jRRliogkf/2pQNp/mtbzeKy7OmOA1KRlf6 MIyR96LGKaxnF7wfHkKDz7EWQ1h6Knw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704475257; a=rsa-sha256; cv=none; b=kZPD6EwCXoM+A6h7xjq9INguRz1jlOjmI9+hYoPBVqc3rfsrHVX3TIoOK0vsba4BicHSSF rcGTLTsCnu62kZ+1ODIS0IZ8k3ywQBpIfXgN1vog4by00eJM81X8seQH7eW2OWaG59YzBu jvWZOrA1vdauNtQ44GQ1mj0M9eNAqnM= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=codewreck.org header.s=2 header.b=CvojuvDV; dkim=pass header.d=codewreck.org header.s=2 header.b=CvojuvDV; spf=pass (imf15.hostedemail.com: domain of asmadeus@codewreck.org designates 91.121.71.147 as permitted sender) smtp.mailfrom=asmadeus@codewreck.org; dmarc=pass (policy=none) header.from=codewreck.org Received: by nautica.notk.org (Postfix, from userid 108) id D420FC01E; Fri, 5 Jan 2024 18:20:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codewreck.org; s=2; t=1704475254; bh=G5QLtqgPgUPlhX16D8cxgZSrhZwA8FdHTj67GHw0qi8=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=CvojuvDVolRZkDDlIyj4uY5hFwD/G9sunkTM46WaLCaS3QIrYNL/Um2wFEN1Efbub AMgqrgm0WuuDyTu9RFhh8PxIVWprskRaMfCAUwhNw8adtnNMYHs5Bky4OntLrV86/Q XmU2feeoZdQm8hdpDIY+BLbeIyzFOjK2HbobG5a9E+yEpXx9TfaYR70WhcumYdlH5T HkCWSMxrchak5K5WPOkEkbPG2H9CmhaW1116sshIwrG/ZnK1AyARzAH5rYoKYuS2Jk AqxoyHMYpNvvuolbdXa2aaLMFmQjd42lAcZqTp8w5LAgtmHV3I+9GZc8lkKE5jXWtd swfGIM6q8sjVg== Received: from gaia (localhost [127.0.0.1]) by nautica.notk.org (Postfix) with ESMTPS id 448ADC009; Fri, 5 Jan 2024 18:20:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codewreck.org; s=2; t=1704475254; bh=G5QLtqgPgUPlhX16D8cxgZSrhZwA8FdHTj67GHw0qi8=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=CvojuvDVolRZkDDlIyj4uY5hFwD/G9sunkTM46WaLCaS3QIrYNL/Um2wFEN1Efbub AMgqrgm0WuuDyTu9RFhh8PxIVWprskRaMfCAUwhNw8adtnNMYHs5Bky4OntLrV86/Q XmU2feeoZdQm8hdpDIY+BLbeIyzFOjK2HbobG5a9E+yEpXx9TfaYR70WhcumYdlH5T HkCWSMxrchak5K5WPOkEkbPG2H9CmhaW1116sshIwrG/ZnK1AyARzAH5rYoKYuS2Jk AqxoyHMYpNvvuolbdXa2aaLMFmQjd42lAcZqTp8w5LAgtmHV3I+9GZc8lkKE5jXWtd swfGIM6q8sjVg== Received: from localhost (gaia [local]) by gaia (OpenSMTPD) with ESMTPA id 39ce6c8b; Fri, 5 Jan 2024 17:20:44 +0000 (UTC) Date: Sat, 6 Jan 2024 02:20:29 +0900 From: Dominique Martinet To: Matthew Wilcox , David Howells Cc: Nathan Chancellor , Anna Schumaker , Trond Myklebust , Jeff Layton , Steve French , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , Christian Brauner , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fix oops in NFS Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1197168.1704465212@warthog.procyon.org.uk> X-Stat-Signature: gp3o1zraho1s9qwgdyxqnukj86wbifaa X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 9EF3FA0023 X-Rspam-User: X-HE-Tag: 1704475256-962688 X-HE-Meta: U2FsdGVkX19B4L3sC6HlzsyfaO/8HhXiQyexxIGoY4K0KwLOISnz+d5T+T1xtLCto346QGe9tWs7SzBCaKEWrMULM45ex5iFAPh7PCcD8R4W2h7yMsBNVYP+sh3m8hAhrpHI+5J7fSHVzZLHIV2vXa16axluSWisIHxdw/y3FTtUmSHvJWbcA8CQSZnE/yWBg0nvmw7oJjCCrh7DJW/rrNSFR2oQOww34JrIiom53CwuncOSY6qNBkMrw1oQhxUqBsQfnrKGgomTUkjhGuO6jTlQB55V4v+ouLQxPB21FFSogwG9JOjK4iWPNDdrZCSsOm/NaKZopQEV58/8UbbvKJRsbhami/inkCcrvbLVVi52+XW+lFnMYTKUUk5d1rFXd5vFRUOt8ejNsXpjT79IqH0xLihDCUtRdLbY9de+fz/aairN0ro/CLb0OvXFNvjXbv57Yz63Z6ZQ7613Gy9npptSAWgsczLaafOwlx29bhSuO5orEyQoDw5nd4LM5ce9comUCH+wtezu5n5TJ9Kmdidji4BQdUJ+79J1nOqTfINz2ovaa9vLcdczyfAPdIoJoY/UTrSAM6pLBl2Qk3OHNmGH4EhiGTTswYrAhNtx5nrSQ0922u+q06RNsJKT9gOTrMTFYa6qlHVlZF28JQP6zn91ia/oP/oOt356DQgdYDMTcgh3NP++rFX1XY8TycSx5udQAwlKvfeRL3MLDgVh34BFLLoEarkGIBkhqdOroTMDxM2vQ/3G8FafwpqbutDrSGiHUML2zawed289u4oysv9Z8jRKZB9+jFP5+/4sEWKDxaA9nroqz3J3M6C9JiTf3lZ9KClPI5VXEiGUe1jln+taie94ntg1NR7GwxFS9sEIwIBZlbeUAfC1GxtUd93Inex+L2pb0UEAn5xRZdgqI+5iGctt5G9SC9ICoHigLXGjinMoYtQpLBgxmuOB1gBmvjx9N7Jb+2oy/+1QXX4 KSYEtvJr 2NiccyfhxUdroaxUqHwzXR83YkJj2hmqgcK9k9mhBCBIlqVQXlhFc3NQDuUm/rJk02OjuN+ohqaBL/NmatGWFAe4pZmEWCOZPS4iCbU0JFOYwgdUOE3Rm5xMUt0Nkm1GsUxfyuiWLc+sdCcwZdzk8DUCj6H0RwyJVCMXpi+Se1FjuaH0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Matthew Wilcox wrote on Fri, Jan 05, 2024 at 01:17:36PM +0000: > host on /host type 9p (rw,relatime,access=client,trans=virtio) David Howells wrote on Fri, Jan 05, 2024 at 02:33:32PM +0000: > > This commit (100ccd18bb41 in linux-next 20240104) is bad for me. After > > it, running xfstests gives me first a bunch of errors along these lines: > > This may be related to a patch that is in linux-next 20240105, but not > 20240104 ("9p: Fix initialisation of netfs_inode for 9p"). Yes, you'd be reading zeroes without that patch because the netfs code thinks the file has 0 size and doesn't bother reading, that'd explain the exec format error loading other modules... One thing that surprised me is that this also affects cache=none, I thought we had different file ops going straight to p9_client_read in this case? But turning my brain on this would be the read-only mmap case that we need to support for execs, which module loading also uses, so this came biting there alright. -- Dominique Martinet | Asmadeus