From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19288C3DA6E for ; Fri, 5 Jan 2024 04:53:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 022BA6B02EE; Thu, 4 Jan 2024 23:53:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F14ED6B02EF; Thu, 4 Jan 2024 23:53:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E038F6B02F0; Thu, 4 Jan 2024 23:53:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CA2BD6B02EE for ; Thu, 4 Jan 2024 23:53:02 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 88F7AC043B for ; Fri, 5 Jan 2024 04:53:02 +0000 (UTC) X-FDA: 81644037804.21.E112978 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 5203F1C001A for ; Fri, 5 Jan 2024 04:52:59 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=VTLZVg7n; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704430380; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mJPEL62eVi84Xk7Scl6XWRFXGzmJNpF/Y9oGJQjtN1Y=; b=Pa869bJ0EFxo9i/xyoOmjwwdH1XdUwqXdBgSXjSr0NyyBReyFY9xUSb2WsdRgcppaUNrKn 4uurQykZoaHUa2Wh7FnLN5/UQ3rfGh1rOil7nQiygmBFJpGm9rohgerECnOXKG82Iw76sm LD193xH+GDgR1Ui4Z/4t40Ny18QCshY= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=VTLZVg7n; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704430380; a=rsa-sha256; cv=none; b=NIGL5/Dpi+98c3YGzYzhC4AlTTSZPlNZmV1SxgJTItscyTCIscjVTP4pSRl4K2N93Wq8KB VuTBaVs9kO8Fu+Gyxxn3hA4mgD9AtXX1NhDdhiLlGLCZfj02LJdTd+0PyMZ2UVwLLIyPoi Z+F3SSXupu9+2IuG7erdqRuOgALO3yQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mJPEL62eVi84Xk7Scl6XWRFXGzmJNpF/Y9oGJQjtN1Y=; b=VTLZVg7nKMZm2KMb7lg5o9PvD5 EuqpAOQdauiVq2ESgt9amfX38XAf1Eqi30RKATfAQwiC/S26DRQe7Xg551K/uydbVKqSrYBHhgzkQ HZGLojzYHxm4D70Yt265+wjirR1nF8dkpWKbkjDzu7U75qpfE0vlUkN07fYxHbtZEcVQ/SNlbqES4 /MN3Pbux3ZFtP4r+fR6Y2T67jx1rtDwl0HLQy38FmRaUjcNxCm0kup5Lqq9a7ASB4vAHdaJN08D6G 7RUGVMngFqMssgEZomd1Shj2d37M6lrh7x3H+GYVkuVoLkd8u/f15GD5BFjMiqwewHWlMm3/pAaZ/ DtD0tYiw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rLcBs-00GuHr-UY; Fri, 05 Jan 2024 04:52:17 +0000 Date: Fri, 5 Jan 2024 04:52:16 +0000 From: Matthew Wilcox To: David Howells Cc: Nathan Chancellor , Anna Schumaker , Trond Myklebust , Jeff Layton , Steve French , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Dominique Martinet , Eric Van Hensbergen , Ilya Dryomov , Christian Brauner , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fix oops in NFS Message-ID: References: <2202548.1703245791@warthog.procyon.org.uk> <20231221230153.GA1607352@dev-arch.thelio-3990X> <20231221132400.1601991-1-dhowells@redhat.com> <20231221132400.1601991-38-dhowells@redhat.com> <2229136.1703246451@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2229136.1703246451@warthog.procyon.org.uk> X-Rspamd-Queue-Id: 5203F1C001A X-Rspam-User: X-Stat-Signature: 68p6dndzykhg8h4qgp15uok5hs814w8s X-Rspamd-Server: rspam01 X-HE-Tag: 1704430379-200146 X-HE-Meta: U2FsdGVkX19jvaFnVuj+gtrcQxlySxSRXICocrwNp41t64tbyUot7GFz8gGH1fJRvCvAycvrli9nY+qFrJFUvrltMdrmMMjPqAFSQkIN2AhkVrK9eEMmLwJjTAiYQhpNG17AqDZvfBeEOBIA7EpRLEisUTPIEiC+v6RVEcV36a+LTQuvd4HX5AoSbFeXhwiJ0cUa6vWRlKYMyJ7g4gidfL+nVOM+qvaSUn5aE1tYERabdTEIIwgPYZb3y7Jjn2BjML9bYhdS76R/IZVUMqFrAXw53AVeUFjeydyBhwigNJ2mk9kjg+MdtaLJdXD6KXcCsoy4NZB2XeFxpdilM15oH7cM1nWjQicpM0YPNkneHc0ADBSsHAxPjwCSxicw8J8OnRL1cKD/TgU3xOMvrRWIhXSovUz1koc34O3nbYRyST+9MgylHgLMv5fvJUfe+iuwLKNv/xeWpxeb+dyjVm+bO4GGPmi4ayQC5wa2F1ZFssTwgXjJrcUipw5jJTI7grZ87fTt7boJrkqzX21Lpe/8ZxhjgCyMT5DUHHZesZdBRL0FYrGcd+83ZDp3B4QH+pTQXoxzQFWtzUqFi6uLjqowiNYkWt7Ui80wL0+GHxON7Ny2IQUx4cr4oSNuyKEVXH4ujAgzwwfeEJ3V+Q8p3q/6oLN1qOARF0zoSbQxqY5PqmDQ5QoPQvl7jKtgpD+zyizovvCXMQDlBFNAMWWvQXkrFZOaT2m4rXqeDwZdS0saJ8rcoXnVLKQHnG4iacPhif3L7JTdABAtq1TURxyxEAWsaDel47ko8mixGfBqgWohuHU8tHhdmAs828g7XMWb32UGNJ8w3DTwX6Jp5qo9PIswdt3oYcBxwVgF0Ty0qj8fMYauWDIuuab5cSW6+vrU+UnpV5ryXtu1bv61zZZ6vRBy8Qmb+MZwshIqAc4SwTyYVWMrorPYPkRnNZgsDdkbp+8xr3Nk9P7I97/lYRyWw2I rcTo24js PsFuSQXdJCaH0yvwFo576snRLpts/IkIfYfEz34eVILkWtZWMuVudv0hV0/LGGPaBTL8P2yy2B4I3x+OYKc0zZcL7MWijn7qy4z92IxeMRMJs9wQYN1G7xGQ1ioj1/GU3CUB0W0PVsNYccjcUCeNIEKKZGHrUdb6wzoc8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 22, 2023 at 12:00:51PM +0000, David Howells wrote: > David Howells wrote: > > > A better way, though, is to move the call to nfs_netfs_inode_init() > > and give it a flag to say whether or not we want the facility. > > Okay, I think I'll fold in the attached change. This commit (100ccd18bb41 in linux-next 20240104) is bad for me. After it, running xfstests gives me first a bunch of errors along these lines: 00004 depmod: ERROR: failed to load symbols from /lib/modules/6.7.0-rc7-00037-g100ccd18bb41/kernel/fs/gfs2/gfs2.ko: Exec format error 00004 depmod: ERROR: failed to load symbols from /lib/modules/6.7.0-rc7-00037-g100ccd18bb41/kernel/fs/zonefs/zonefs.ko: Exec format error 00004 depmod: ERROR: failed to load symbols from /lib/modules/6.7.0-rc7-00037-g100ccd18bb41/kernel/security/keys/encrypted-keys/encrypted-keys.ko: Exec format error and then later: 00016 generic/001 run fstests generic/001 at 2024-01-05 04:50:46 00017 [not run] this test requires a valid $TEST_DEV 00017 generic/002 run fstests generic/002 at 2024-01-05 04:50:46 00017 [not run] this test requires a valid $TEST_DEV 00017 generic/003 run fstests generic/003 at 2024-01-05 04:50:47 00018 [not run] this test requires a valid $SCRATCH_DEV ... so I think that's page cache corruption of some kind.