From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8619EC47073 for ; Thu, 4 Jan 2024 10:04:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B2FC6B03A7; Thu, 4 Jan 2024 05:04:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 163BA6B03A9; Thu, 4 Jan 2024 05:04:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 004BB6B03AA; Thu, 4 Jan 2024 05:04:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E4ADB6B03A7 for ; Thu, 4 Jan 2024 05:04:09 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B41EFC0356 for ; Thu, 4 Jan 2024 10:04:09 +0000 (UTC) X-FDA: 81641193018.16.80F388A Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf07.hostedemail.com (Postfix) with ESMTP id 08B8C4001A for ; Thu, 4 Jan 2024 10:04:04 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=PwamUfyZ; spf=pass (imf07.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704362645; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mEC9RU/7gJsuNRS5VA9HyG1hQ3z9kUtySW0uefqhic4=; b=BioWqj9n/NJjLii0K4hEr9zlYxQAF6i054T4VjAEB4osUEg7HECmtmE6m3TzwxQwcVKlbA /dFWFqR81Lb/CNEAkA4JorSP66ytCvQy4OmJMhztmPptH2Oe5xpd62EdzkAesVigD7jZ2i 2vthR4cfsfhhsUkHqH7V/o5lrPZrCGc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704362645; a=rsa-sha256; cv=none; b=AdOf7e3E6OXtZfxXIy0Vacm5jPoUARX3e/qyWmdFJMg01srHIPSPiqTnK1RcAlh5Qlyb3o kVW5LRk3xpE1cCkFvVPS+zu1cvPqky7Gr5QpbHDMVaVTCvtokpIYziHv4YyWCCmesqkO6E tAyMSc3dGOax6q+qZ916f94x1fc90PA= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=PwamUfyZ; spf=pass (imf07.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0353728.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 4048r1Vv014717; Thu, 4 Jan 2024 10:03:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=mEC9RU/7gJsuNRS5VA9HyG1hQ3z9kUtySW0uefqhic4=; b=PwamUfyZQwMs7zqqv7AyyQ4T/H/ZuwF2rNasPDug3qz4BcWe4HRu5C2VzK8O2nzthgtw IpjAN+oFwhnI1JsI8v0VlD2eEPeVRMFs5peKPXBAIEb18WLGyIS5m2FmtBXuz8XVEM54 RiAxrADaVI5Heg3TcSrUAcuyog3CU2Y2VzWsuXa87vQ1rd/DoH+p1uEV/qPhmGAC2MnR 0mduIbJXj8fJIuY7CwHXivFZpfoXaVQ5xipNO5Nb2UgW/CWKHgid7soEY/ZbGE/bZEeY 4u3h339KxfgLQqk2gVkSMVcDySTQhYIncIR1M8F9AMphMM9GYwxv0zVCBSP2UgUgUDtW 0Q== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vdsj1a7rh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 04 Jan 2024 10:03:50 +0000 Received: from m0353728.ppops.net (m0353728.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 4048sLms018434; Thu, 4 Jan 2024 10:03:50 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vdsj1a7qx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 04 Jan 2024 10:03:49 +0000 Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 4048PKj3024643; Thu, 4 Jan 2024 10:03:48 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 3vb082g0ew-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 04 Jan 2024 10:03:48 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 404A3jJr5178108 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 4 Jan 2024 10:03:45 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9B53B2004B; Thu, 4 Jan 2024 10:03:45 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1D71A20040; Thu, 4 Jan 2024 10:03:44 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.171.45.37]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTPS; Thu, 4 Jan 2024 10:03:44 +0000 (GMT) Date: Thu, 4 Jan 2024 11:03:42 +0100 From: Alexander Gordeev To: Heiko Carstens Cc: Ilya Leoshkevich , Alexander Potapenko , Andrew Morton , Christoph Lameter , David Rientjes , Joonsoo Kim , Marco Elver , Masami Hiramatsu , Pekka Enberg , Steven Rostedt , Vasily Gorbik , Vlastimil Babka , Christian Borntraeger , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Roman Gushchin , Sven Schnelle Subject: Re: [PATCH v3 28/34] s390/mm: Define KMSAN metadata for vmalloc and modules Message-ID: References: <20231213233605.661251-1-iii@linux.ibm.com> <20231213233605.661251-29-iii@linux.ibm.com> <20240102150531.6306-F-hca@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240102150531.6306-F-hca@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: nbfM0juIhZleyeD13N0-vwHlSIw9D1PP X-Proofpoint-GUID: 48fRanwL7QTj7BMTM-SFy1C7v7RSY4Cv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-04_05,2024-01-03_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 bulkscore=0 mlxscore=0 suspectscore=0 adultscore=0 malwarescore=0 spamscore=0 mlxlogscore=676 clxscore=1015 lowpriorityscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401040075 X-Rspamd-Queue-Id: 08B8C4001A X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: z7b1y346ypk6fr6xiskmozbjd9fbhx14 X-HE-Tag: 1704362644-327017 X-HE-Meta: U2FsdGVkX19PnQwOBE9qsIlqZ9EkyMZ/S/vuN5FU4d3KZosmYs6DMspKgC4dwb3T+hUXCX8mbnRs1Yyu1IPXkje2uuuTholFukBsb8aiorZcIsiz5UDuHlx4+hCSrDKfj87lBKmv36O4FPl3SrsAf4LynNGQZcBsHdJWE95FcP76DKa4Hltv9oVbMok8DtOvh1snHffB72z7ZnU/i2Yp8dzwup9yvBSmc8/DrypT2XjXkQwWcM4EbhYnDwkqDulAIRmA216uoJPjoLFIlIhLqRfAej//xex7P2B4BdbfhrPpi4qz2zSdTiRUCmLi7ixp4zZUJ80vk55Y60TnAQoH18gCbE8kLVvUbeeG1me5bjBt+LKUCd9KIv/B9Z4XzKWOcbWGxaDlSAZAu0c2Upnv3bgqErG99HAo2b32BM6osXFCnDdrdUj8A4EKmcFjqPbaMHxNqFWbBtprsF8dakhjXG+kj1/OSu3ThQE0dGh7lJBr/2MYqFzO2sVdtbGcFPxEtHpNOCGbAaPLPKIXnGGBC5gww/7Qi9uISryTFe97tcEuwxnQjQaoWdtgjAuYqHeLo1z05eSN89ZuebY/RBKEaNpLoLfZb4kZ0Pz6oVcP53erh5wkIAAGmufVUPwVqsPYMjnpTRJFt31u3UxNSfL81skP9KqIpdSy4JF0T3T6b1H2SoI0cOFiF7DA+MCbtoUWdn1RZax+UDkoyI8DpwRLRSYEoe8YJhDZeqVaFdR+uJbn7QpD/Noh6/VLnFbkR7/4HYkrA1S/DX0rg8+2hzJogZZ7knjZvr1J4ASUZb3D5dC4y6eDHuvPOnwHhupQstqqbx06GoQ1ngFui2XQZ0yTbAbyAsFB/oblvxulyC4E6N+zFz84mYQB1VvFqolPe+d0KN/Y1RTyLae2pBvXSRYMumqrvOMAVSUIY9qt/cjInp+j557qoeMeMu8eRTD2wc5YrjDYHadqBisuM7w43H4 6k1WBEsd smtWOjwLtXmi6a1UAlJykKvIxGgEBqPboMzNQHxHzxw6SDnxse4RPEkg7lZKYdMlLBY49UNZbJnnWfnQuLdPNzAyfba0/+QBngFqwW5uKefiNGCcQ0B2UrhoyuXVWCW2rEyb2tCCsKD00dheBK3+ErnhagyH3y227u1ZrZyP+6yuGd8wCJpq1q1wxT4JuQtVSs459ZM5yYNcML3nDl2JJbdtk4AOUd7VZerOQ0GED0xCNXMJOYQvpXGiTCDQgQc3bnmoxcYL7ARfiTiM9n8C7ClGL5mJLjxCZaGuNLBO+6WMxg/M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 02, 2024 at 04:05:31PM +0100, Heiko Carstens wrote: Hi Heiko, ... > > @@ -253,9 +253,17 @@ static unsigned long setup_kernel_memory_layout(void) > > MODULES_END = round_down(__abs_lowcore, _SEGMENT_SIZE); > > MODULES_VADDR = MODULES_END - MODULES_LEN; > > VMALLOC_END = MODULES_VADDR; > > +#ifdef CONFIG_KMSAN > > + VMALLOC_END -= MODULES_LEN * 2; > > +#endif > > > > /* allow vmalloc area to occupy up to about 1/2 of the rest virtual space left */ > > vmalloc_size = min(vmalloc_size, round_down(VMALLOC_END / 2, _REGION3_SIZE)); > > +#ifdef CONFIG_KMSAN > > + /* take 2/3 of vmalloc area for KMSAN shadow and origins */ > > + vmalloc_size = round_down(vmalloc_size / 3, _REGION3_SIZE); > > + VMALLOC_END -= vmalloc_size * 2; > > +#endif > > Please use > > if (IS_ENABLED(CONFIG_KMSAN)) > > above, since this way we get more compile time checks. This way we will get a mixture of CONFIG_KASAN and CONFIG_KMSAN #ifdef vs IS_ENABLED() checks within one function. I guess, we would rather address it with a separate cleanup? Thanks!