From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFFB8C3DA6E for ; Wed, 3 Jan 2024 15:47:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 671E66B02D8; Wed, 3 Jan 2024 10:47:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 621686B02D9; Wed, 3 Jan 2024 10:47:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C25F6B02DE; Wed, 3 Jan 2024 10:47:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 37F756B02D8 for ; Wed, 3 Jan 2024 10:47:29 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 10F621603B2 for ; Wed, 3 Jan 2024 15:47:29 +0000 (UTC) X-FDA: 81638429418.18.49D7476 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by imf24.hostedemail.com (Postfix) with ESMTP id F24B518000F for ; Wed, 3 Jan 2024 15:47:26 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Hvn2JbUa; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.174 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704296847; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hhrsogcA78u+i7VN1yFSxBLITouejwykBZ4THZ1vf8s=; b=jYeclcevg3lzNm2ZWNjS/qfQYARz6ESRi9OqNPM7rcLB2eQeSOBZoJ8HMulHj9/GA4ujyz w2m9oldYcVrVvf69wcln1iufywDOJp4PMvzIgsQB7GOJ2e9FGg8vhUvdEkETGpEgzO0SLg TnmYN6vzJKhiBp73wT+my+O9Imz8PRE= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Hvn2JbUa; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.174 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704296847; a=rsa-sha256; cv=none; b=vGu4yZzo6wgM9DhvVCusDq5vXO4FMhu/ZatJygDQbP5t1Ct8QVEFH3vDjzOneecrOsC5+x mPeaCfF6iTybLt7Euo7Rrlyls0HzLpV8k2pH6lwWcq6C/UrO9Gbv0bSJIDvPOb2TQxZTi1 Pzahvy7hJiAMo5gPyqX8vdplIa9LhAU= Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2ccb923c4d2so79260861fa.1 for ; Wed, 03 Jan 2024 07:47:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704296845; x=1704901645; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=hhrsogcA78u+i7VN1yFSxBLITouejwykBZ4THZ1vf8s=; b=Hvn2JbUav/2EP+ygE4t/1q6OrYu5k0Pe6U2hwzs9XPeiJ1KHhGWT0/Hd+Pb/UGjeAj zVylTYfrvo6BOSR3up91v1QydROD9iaPVnGFibErTLuoa0/7Q4LfIw/zjP2U2i76CzwT 7f6DgUhwVFQYOOwDmH4IXa8rQRd5odCtUCbuLjjogYF01RaSAbME5LDP7XDKyUg/EAwq 01JLZiZ3aDC43ZO4FsfEXqoOiF0Q/ddPov3nDRDbxvAk59us8xsjfPrTG6+UzvvANCKw yS3yjejZjp9RgeWQjtZuovBf2Qu0fZI59sbpwf9xE7yahGUtiIG84U+Jb620qvW9GRWw LGPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704296845; x=1704901645; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hhrsogcA78u+i7VN1yFSxBLITouejwykBZ4THZ1vf8s=; b=laTcp37wHtLq1NQ4m3V+6v7q7K5eswsw0mnfcohps3OlLnP5yE2alHPQF/vuhyLsaN nvHlofpa1R0vzhhnDFVWC5uGKOmN3bXbOBjdql2TQgrPTPBYoCDRXI13VpfKsnmS0nMx 9tgPdXLNAdkx+sFGOgTzYR9YyHhEYnjdUu0ia7OpvrMkpYrcrFX17KAmIpco5TXPx9RN EGcxmqJzKwqw5tEGBUbzATd00311bEZAt7Z8tRvW7fIVBy1549dvQLAvB1Qp1lJz2oUS 34h/00ZxyPsurHql5oQXRVw3csV2E7F3ERKd5ZRYmcmfhBU5OBBlLOfShvHRNxg1o0wO L38Q== X-Gm-Message-State: AOJu0YzYpysvQwNqUMzCwpIo1Pem53Xan/knQLlEoOd0yli5TfaODQpf nt/fXY+lUPvtnKMDo6HVHoI= X-Google-Smtp-Source: AGHT+IGDiz1q2l0RgIIbnA0a3DEiX6deZvkBeqr650S9Hmp7190zH254RFaKVwJ0jLkllJcG8sGeoQ== X-Received: by 2002:a2e:a585:0:b0:2cd:348:94a6 with SMTP id m5-20020a2ea585000000b002cd034894a6mr1551015ljp.92.1704296844737; Wed, 03 Jan 2024 07:47:24 -0800 (PST) Received: from pc636 (host-90-233-200-64.mobileonline.telia.com. [90.233.200.64]) by smtp.gmail.com with ESMTPSA id s10-20020a2e81ca000000b002ccd39eeae4sm3518354ljg.100.2024.01.03.07.47.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jan 2024 07:47:24 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 3 Jan 2024 16:47:22 +0100 To: Hillf Danton Cc: "Uladzislau Rezki (Sony)" , linux-mm@kvack.org, LKML , Matthew Wilcox , Oleksiy Avramchenko Subject: Re: [PATCH v3 07/11] mm: vmalloc: Offload free_vmap_area_lock lock Message-ID: References: <20240102184633.748113-1-urezki@gmail.com> <20240103110832.2711-1-hdanton@sina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240103110832.2711-1-hdanton@sina.com> X-Rspamd-Queue-Id: F24B518000F X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 6u6karfo78t9r8pnqdqmcaztkwpp1f4b X-HE-Tag: 1704296846-289940 X-HE-Meta: U2FsdGVkX1+mrgwMD+owsklMS2vYct65IMYdK1+SHdEl6wNL3GKs0j5XIBFjEen2Z0zY4x5vq7PSA1kdgCOiZF6azAuMPk5vWavznSoeiM2KMQgt8Rnw4fWWqSrgH/YjMoyNfP/nashF2evXSaR/1efWaF4CvktEs+/YF393GXLbk6CIxYcU0XfgyHfI4wZDjthU2VvKtvv2ZqcS6rKLA6r9cvAnisI/AM0WXtT+0+QHWY8nYKJDrVCu+qG8lM15mbGulVBLf1ksEqDBgIFLRjYx0HTc8ozy4mFjZBrwfOBnDLl7Ckqyc3p9YkkxjnmOZXuytFnz9+9764SjTWVx9oRL5j17zV2MMc6NP8lzk4W5/VYDLG0qnwRzhQR4P8GnhSKNDbZgsNqEmv1H1Fhh5Ne408iu0qGTRJDHU5ZXU/edDwazTuqrinjZpVhF6EzjlEMB9uEzQlevoEJFbIw2bzJ6hq1zIfg1PB8ELNZ1MESiSLh+9GbLjs5PqNt9d256a2KkGgna3phw8NK16KYTG1qygxNvHHWAp3Myh4/SL9gKIUFwmLOZZmZzzPxdFuScEW0nc50gAnBwc7b6TfWKymI3SiiJIJU3wPbXKoho0Xu+jCGScQwUznLSbciyfCo20uXh4VRGDzonyTZqfW70ztcL4cf2R0bI0EexGc8txX0t8qDETfOGR+Ha0kgQDw7Sh+EaMWsRQq4ETLTiI7DCVMICr0Y5ZKbUvq4JDH3L64sBd7KLrvPShX2XeR6JBdj0TeNtqQhO8s1JbJhtCJMcemnSBBOdaDpkNfECCbTncNxfQ2wfLdFZ5ZLX9gPiOYbBQE4Sj3tx1D0B6x2qNi4T5XpXw4sg2DcfTUypP6FWCpsQ9gOdC9DSC4DgyAYue8W7oSU1ZpAs2IKhq6UqRNCHDaE+FTcgB8H7w9NgVimbfYWMzynjXXUYD5PFAW+MlYQxYFiqJtAbQLrdhk/W2dP 4S0YXl2h jQdToNwT+85/goqiVrFrq1GyyGsV7+EGgomqAQJp0heXVxJ9NiDNhooDzzm/+v5h/J/iKYsau6zhaXwbRsawwq56XNWMZVvh4f1rE066zqFUNy4QCHFCp9PdiiTTHr8xlm8r/Rdm76ZbPtRHMLM2yC+tfabhYGpbZkhSDgKrkDXnc9gNYdy6FU/vU4WhYKrZgBXSJG2lLkm61TRTUXMqtrgFuUPRlCh0MofqNkWG/Y1hamVBu2V2gsm3MJK+J5Ks/IRtBGcdd7fFQ9mgmL2h75opLV/HTVtpoVtRdJtqzlj8B6Vaoefm86Hn+JMlPR51D/aRblWaKJN2AllYGP8dHBSc1luWGXuAdaUxYtxU8h+VAa7jX33naKwY6KnCmt0wl5cSYDMZwj0Rt4dYi1qxeIOi4l2dwSkBhsA4AJ9TckUEjiGvNCFkiTfCcH7/Yp42XJXHn1gfuxiwjmotgQs2oMlF3pE9dldg06IK7+aMihwuN6pyhxxkwPKSszg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 03, 2024 at 07:08:32PM +0800, Hillf Danton wrote: > On Tue, 2 Jan 2024 19:46:29 +0100 Uladzislau Rezki > > +static void > > +decay_va_pool_node(struct vmap_node *vn, bool full_decay) > > +{ > > + struct vmap_area *va, *nva; > > + struct list_head decay_list; > > + struct rb_root decay_root; > > + unsigned long n_decay; > > + int i; > > + > > + decay_root = RB_ROOT; > > + INIT_LIST_HEAD(&decay_list); > > + > > + for (i = 0; i < MAX_VA_SIZE_PAGES; i++) { > > + struct list_head tmp_list; > > + > > + if (list_empty(&vn->pool[i].head)) > > + continue; > > + > > + INIT_LIST_HEAD(&tmp_list); > > + > > + /* Detach the pool, so no-one can access it. */ > > + spin_lock(&vn->pool_lock); > > + list_replace_init(&vn->pool[i].head, &tmp_list); > > + spin_unlock(&vn->pool_lock); > > + > > + if (full_decay) > > + WRITE_ONCE(vn->pool[i].len, 0); > > + > > + /* Decay a pool by ~25% out of left objects. */ > > + n_decay = vn->pool[i].len >> 2; > > + > > + list_for_each_entry_safe(va, nva, &tmp_list, list) { > > + list_del_init(&va->list); > > + merge_or_add_vmap_area(va, &decay_root, &decay_list); > > + > > + if (!full_decay) { > > + WRITE_ONCE(vn->pool[i].len, vn->pool[i].len - 1); > > + > > + if (!--n_decay) > > + break; > > + } > > + } > > + > > + /* Attach the pool back if it has been partly decayed. */ > > + if (!full_decay && !list_empty(&tmp_list)) { > > + spin_lock(&vn->pool_lock); > > + list_replace_init(&tmp_list, &vn->pool[i].head); > > + spin_unlock(&vn->pool_lock); > > + } > > Failure of working out why list_splice() was not used here in case of > non-empty vn->pool[i].head, after staring ten minutes. > The vn->pool[i].head is always empty here because we have detached it above and initialized. Concurrent decay and populate also is not possible because both is done by only one context. -- Uladzislau Rezki