From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3D87C3DA6E for ; Wed, 3 Jan 2024 19:47:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 771BC8D0070; Wed, 3 Jan 2024 14:47:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6FAF18D006C; Wed, 3 Jan 2024 14:47:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5508B8D0070; Wed, 3 Jan 2024 14:47:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3DB298D006C for ; Wed, 3 Jan 2024 14:47:08 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F34A1A0172 for ; Wed, 3 Jan 2024 19:47:07 +0000 (UTC) X-FDA: 81639033294.11.FBD3276 Received: from nautica.notk.org (nautica.notk.org [91.121.71.147]) by imf12.hostedemail.com (Postfix) with ESMTP id 16DCE40011 for ; Wed, 3 Jan 2024 19:47:05 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=codewreck.org header.s=2 header.b=KqCLgCLv; dkim=pass header.d=codewreck.org header.s=2 header.b=cp+ReJMB; dmarc=pass (policy=none) header.from=codewreck.org; spf=pass (imf12.hostedemail.com: domain of asmadeus@codewreck.org designates 91.121.71.147 as permitted sender) smtp.mailfrom=asmadeus@codewreck.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704311226; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rchUNxdMCqpxIcXW8Gd8rSQ5mpefCht1oHNRmrwB1pY=; b=8IRoYcSaJ0SMZC2WtQ1vwlX0XCt6kcQVduCrt7Zm9JhxxsNsIE6uJyVykVZhAiWFqbtBwx PGCmFs436/VvUguprZmJqKtBHszCaWvay/eYGnrUk75BsTh66vZ+DnEFfkpQxUjBE5RL/1 Vmh32hm6X34uGXWuKRUrwR7PEgr5vpA= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=codewreck.org header.s=2 header.b=KqCLgCLv; dkim=pass header.d=codewreck.org header.s=2 header.b=cp+ReJMB; dmarc=pass (policy=none) header.from=codewreck.org; spf=pass (imf12.hostedemail.com: domain of asmadeus@codewreck.org designates 91.121.71.147 as permitted sender) smtp.mailfrom=asmadeus@codewreck.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704311226; a=rsa-sha256; cv=none; b=mvuxjcsefkQTvqGp95xCdF+iDyLdWbMU+3UgIOKaM3n8gkcdwArvINtmO/ENi2PR6ustTf im/D08HBOKE9yNEzCNy2QGSEUiiqgIdoL72uY6GXCPkAAzkq+l0UKkg9/00hhl3e5fLqEe e/YkVwNLxufnLCANpfIwct7ENxB+AUA= Received: by nautica.notk.org (Postfix, from userid 108) id C7681C028; Wed, 3 Jan 2024 20:47:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codewreck.org; s=2; t=1704311224; bh=rchUNxdMCqpxIcXW8Gd8rSQ5mpefCht1oHNRmrwB1pY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KqCLgCLvNFzqohtP+Q00yasRxvDCYWdLlzzFXvHOWe9rBinElOfDxYU9K7hZf/nb5 yzmsz914DpXIublCq4fenyPl790/cWrEV7Kv4otTyDddP9sHmecTY6qkluQNeTRw7w GKv1xUqnqtUTL42Y2EPdQ80fY9FfEXuGjGRjLZs9Qr5bzV9qoaM3QhgjSJFjppKcmq rXQmZLjbTyRKgOPCBhHEQGlvLYtEwr/yOK1sq/ZJvt8pX0twrYja27PDZZqd+TmdMk WRzeilNoNFYXeYNhQ9F8HKU2gyKS8QlDNkTR7vC3ErTf43wXbMoYLC/aypxu8I24Fw jrRHmZJW8oL+g== Received: from gaia (localhost [127.0.0.1]) by nautica.notk.org (Postfix) with ESMTPS id 7F88AC01A; Wed, 3 Jan 2024 20:46:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codewreck.org; s=2; t=1704311223; bh=rchUNxdMCqpxIcXW8Gd8rSQ5mpefCht1oHNRmrwB1pY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cp+ReJMBn4/XifVWwL9GKWjgkdtOemo/VHptMfuCAey1eLCbRlXG8C98KiVBZWxQz akAQ/UbdziobN/oM86x455uM+VDXCfHi0FGn1LyWCSLZ+O0lcIM1epqEAlYR/oI3bW KDoePmBGHzUHJfEwETut5v+EXyKaJQl3IsJzqKvrTVSxz+zFiA7glGc3YoQxwb3kZG Dk8V40uXy4lDjOa4efxjrsPampxxMLB0G9RZK+y1M1uBtZ2jO2fVIGlj2hdwqGPJ5b cnZIsrl4Zu+sK1EsxMTzzmiNyNw1eykicrjIUmzOzbzIkTLPStHaI5hlFt4HU2Gojv twZElKdDAeHDQ== Received: from localhost (gaia [local]) by gaia (OpenSMTPD) with ESMTPA id 34cd8836; Wed, 3 Jan 2024 19:46:53 +0000 (UTC) Date: Thu, 4 Jan 2024 04:46:38 +0900 From: Dominique Martinet To: David Howells Cc: Christian Brauner , Jeff Layton , Gao Xiang , Steve French , Matthew Wilcox , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Latchesar Ionkov , Christian Schoenebeck Subject: Re: [PATCH 5/5] 9p: Use length of data written to the server in preference to error Message-ID: References: <20240103145935.384404-1-dhowells@redhat.com> <20240103145935.384404-6-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240103145935.384404-6-dhowells@redhat.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 16DCE40011 X-Stat-Signature: zostydx59emf3mqaq8334w3o5u5twypw X-Rspam-User: X-HE-Tag: 1704311225-106536 X-HE-Meta: U2FsdGVkX1+V3LHGF0jFc3KHWDu5pbKqqpGbmMMplxwmaIS+/iANi7PeC/K54J3DltKYgWsGuEA5bhnrvLxApNpG4tMA8qCy/S+Orw35W2RAfyPEQ0SE3NUMaRvDKQms8cRkZOQszNAF5uz4zOv9+Jha4FAOzNt48MptppaN/hTUol9Hw31dK9Z4P6fSShu0RvwzG2YSiM9/X+EPZooW78gE428r0H8Sqggzyal3tQfeBRRCIRNLqzk6rYsIEsF6fARTcoGRp/laQAO/TSglR5nGn7CMUEG3pzC0edZgELqbvCef1Egt4hBl2YHJe/pgFM0Rm6wvGdZMIozns9WCzklR6UwaMQQfUTTTbwtOsacbA1D4GR/fHpbIfRxvWjrSUIl8M1aziiGIL/RHc4xqvWZ81SIuqsAJYj+YWLHmylxNbOyL6WLy5mTNMU4wU/ur3JvVNdurAmQhEK3HULKQz8OkRIQdDQo+A6+W0CIKqaEFurdL5f19ya/ln3q2zwLf1/qJeJu7VD2Qsa3SWL1AlIR/G64haSJiTQjZj7LSyp3y0BysxubIBUVL4bF7gNHxWv+ou+WNDodyOta1s4cbwtNh6ZX0AY6TFsiEYXP9Ul8xko5BDz5+AE8SB+h46NsUMumCzC1q/8h+5AidOJGnXlufutZc8d7dRd2IHTh13twqVwYdn7SuGdJGJ2QgG4gRRX0oxHAUCHL3MuIHcyJsd8YenYVZbA/QnMmpB8/NpBmNc0UuxHH0dpVDvFkjOgJTmQENu0wueNiH9cM4vxb8xDCfuoajAbKik5/rsRoQasZIm2ZF6fhODLgJxuiLEthxQea3Z25MDPlXx3ZkU5MDjHqXbrNyshTIVB0+846QYAM+DSrMh81RdUOeEVDNI/74ukmzthItArL0zZGtgtDu/gFNradH2qAVYIG0+ODRDDSyKwPnBlwQxz14KHouXePjEBeUgHX6vuHX/u7vx+L 4LV3fY1v TOM6ch3oaKGZqy5o069wUEBUnStSOkDG9Q8wSL5sGoudZvaEBPG80qRHFO6QOZokgsrUf1ieh7sZKS3e3no8LtxA5A3BzcIEwzqM1gdhzLNX+h+LsWQJ5WUZ4PV4Q0YDC+UBtEXVtak/Ay7VH8DLZJNEuylKj6/qQrfi5+VkdJXCCMjD8N8fE72auokEn+4RPbrxTgSCt74znN8fERknnUPEdAMTxTUfoQ8eNHpWYWOkRSBzdWBdtLpprAAIUjczEK3Im X-Bogosity: Ham, tests=bogofilter, spamicity=0.000033, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: David Howells wrote on Wed, Jan 03, 2024 at 02:59:29PM +0000: > In v9fs_upload_to_server(), we pass the error to netfslib to terminate the > subreq rather than the amount of data written - even if we did actually > write something. > > Further, we assume that the write is always entirely done if successful - > but it might have been partially complete - as returned by > p9_client_write(), but we ignore that. > > Fix this by indicating the amount written by preference and only returning > the error if we didn't write anything. > > (We might want to return both in future if both are available as this > might be useful as to whether we retry or not.) > > Suggested-by: Dominique Martinet Thanks, Acked-by: Dominique Martinet -- Dominique Martinet | Asmadeus