From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE76FC3DA6E for ; Wed, 3 Jan 2024 19:46:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 59D128D006F; Wed, 3 Jan 2024 14:46:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 54C8D8D006C; Wed, 3 Jan 2024 14:46:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 414048D006F; Wed, 3 Jan 2024 14:46:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 357778D006C for ; Wed, 3 Jan 2024 14:46:05 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0CDFD120814 for ; Wed, 3 Jan 2024 19:46:05 +0000 (UTC) X-FDA: 81639030690.22.6E908A2 Received: from nautica.notk.org (nautica.notk.org [91.121.71.147]) by imf26.hostedemail.com (Postfix) with ESMTP id 2470D140015 for ; Wed, 3 Jan 2024 19:46:02 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=codewreck.org header.s=2 header.b="B4k+m/q8"; dkim=pass header.d=codewreck.org header.s=2 header.b="B4k+m/q8"; spf=pass (imf26.hostedemail.com: domain of asmadeus@codewreck.org designates 91.121.71.147 as permitted sender) smtp.mailfrom=asmadeus@codewreck.org; dmarc=pass (policy=none) header.from=codewreck.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704311163; a=rsa-sha256; cv=none; b=0fVNOsZ7sy/uKX8z38jkB3m7Q46Ic71jZ0zlU5QiBMxDpDi1lxFEZqOeD+eIRYEgNy/7Sc mfxFjks8FIKy9SgpAlIxR/7FcTtG/MWmmDOr0J+PSvt6TVDw8UDjM+I9Bv7cTkbm79igti YZn0EDdxH5e6IxcxcXyZiz8Z4h6HKSY= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=codewreck.org header.s=2 header.b="B4k+m/q8"; dkim=pass header.d=codewreck.org header.s=2 header.b="B4k+m/q8"; spf=pass (imf26.hostedemail.com: domain of asmadeus@codewreck.org designates 91.121.71.147 as permitted sender) smtp.mailfrom=asmadeus@codewreck.org; dmarc=pass (policy=none) header.from=codewreck.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704311163; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DYpAMKUEr4ZUo/A2V1G5Stqgcj7W2gBmNsNpjPAItNg=; b=2O0L4d9TPrXc/5aV/WtRaB+OA0UTTqOqYxbXNSVHEtOksyDsZ6nmmVWKekj5tLnZ8vR/K9 SW/G8fhFYCfqVsQJEaRaGzEs0zuqePzffVpZxYOp7cSjISEuKfwpVA1DJvI3LJfVT2WQ5g dYuKBS1Eu053lUUKeXnKiSb+W9IJYOU= Received: by nautica.notk.org (Postfix, from userid 108) id CF4BDC023; Wed, 3 Jan 2024 20:46:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codewreck.org; s=2; t=1704311161; bh=DYpAMKUEr4ZUo/A2V1G5Stqgcj7W2gBmNsNpjPAItNg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B4k+m/q8vwyz1cmJjWarRzlV3PUa/4GYuScLc3MH9IP8RXLMxQgNKo26pq046ww1w IXiwt0dLInSvuNJJhA69DW/3p05amxvZHcQYMeEGw4S0aXDDnM+hfwt6n23bW8rE0j 321wZwAkYtQ2G2n2+mY3DL2D4JIsNe02StYEJsq7JutX4onPpj3vRyZbc1iQzVvJau BhSK0FEsTlhA3v6B2bG4rvREluC3TF7JpZvOXy8473obAqXXGRVKv9zNB9Ekw5yCRB P1E0WP0KYgz5HWK4aIG7D+g2rhNpqeTEVLUtzx/r4CDXibmlMLGrVTN1XCxXzGJmdX SKwuMgP0lMVHw== Received: from gaia (localhost [127.0.0.1]) by nautica.notk.org (Postfix) with ESMTPS id 13998C01A; Wed, 3 Jan 2024 20:45:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codewreck.org; s=2; t=1704311161; bh=DYpAMKUEr4ZUo/A2V1G5Stqgcj7W2gBmNsNpjPAItNg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B4k+m/q8vwyz1cmJjWarRzlV3PUa/4GYuScLc3MH9IP8RXLMxQgNKo26pq046ww1w IXiwt0dLInSvuNJJhA69DW/3p05amxvZHcQYMeEGw4S0aXDDnM+hfwt6n23bW8rE0j 321wZwAkYtQ2G2n2+mY3DL2D4JIsNe02StYEJsq7JutX4onPpj3vRyZbc1iQzVvJau BhSK0FEsTlhA3v6B2bG4rvREluC3TF7JpZvOXy8473obAqXXGRVKv9zNB9Ekw5yCRB P1E0WP0KYgz5HWK4aIG7D+g2rhNpqeTEVLUtzx/r4CDXibmlMLGrVTN1XCxXzGJmdX SKwuMgP0lMVHw== Received: from localhost (gaia [local]) by gaia (OpenSMTPD) with ESMTPA id 7038adea; Wed, 3 Jan 2024 19:45:51 +0000 (UTC) Date: Thu, 4 Jan 2024 04:45:36 +0900 From: Dominique Martinet To: David Howells Cc: Christian Brauner , Jeff Layton , Gao Xiang , Steve French , Matthew Wilcox , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Latchesar Ionkov , Christian Schoenebeck Subject: Re: [PATCH 3/5] 9p: Do a couple of cleanups Message-ID: References: <20240103145935.384404-1-dhowells@redhat.com> <20240103145935.384404-4-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240103145935.384404-4-dhowells@redhat.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 2470D140015 X-Stat-Signature: iktijy3ee9icrn4afuum7ktnfwaaemgu X-Rspam-User: X-HE-Tag: 1704311162-335828 X-HE-Meta: U2FsdGVkX1+hf1KNwqvYJNCzROJ+JsUgvJqdQUvi/r0N1VAjPRcTXA5jLESmTdlcjNpwGnLjVLWnz5L18U7QVlfLg9iqnADqoDmiw7+wEpyr2aWRWcDPYvF12EInQAXCOiFa4xPm3rNRrAse16FtcDOh8L00tQn+Y5tIN7Kg4zin39NAD2nSw+vn1Jit0pT+Bw+fravTYN3XnkKGe9TpribINcJA4I7G01OmwkZccEE0YKzPltH3NP2ItqOoyfsSWboGCe8XvQ8u0eQyhpDa32PlMW7xhRAqsAYpGHseSrH/b8BeCRbcGB0KLc+lhtnGbL6Yrq92kt7z8Zg77qscOipV21QU/8uIysa74sPXoXkRfSfsZ2qOoi3vbsScgWt+5t0BYp1sp9hqNjZSTYKbB5q45m0EQ2cgV1sfsawPmVnnEZJHgWbyK+mukoraLYxopJNagGOiYEnu82p259Tkhag4uVMcyNZPx6ram20gajkFmnlR4zG8LFyvqefzKEKfU/4hg2cKxQBo5itUw+NQxjOxkvSen5IGElZKfbB+GEETr48vXfAwtivRFY4hlvDdtyNSMedC7xPYMbzuvnKHjBmJ9CnsyxE5UjeNZfe5r+IivczRBHGJxcdtVKSOUHpKxlxaHTfGL2rpl4Y44Wzrq3pzTnQ0p+S2MjxXb3exuyP5u2jSopV6otI+fQagljqhzp+f42clru3rL+R+8VkfE1csBpqegAByk9vVswCcXV+jKiAY85IRisI3+lHki81W74uGYr+NVzMGvR6uw3EJ9qHbQIVaoPM1FVniXwJw1Gq6n7JqNvQiVi4EPZp0174j2eeeMCkN4+y6+9XP9vnAcpsrmA1OqTJ6hnIVbQLfTQd4l7cZfU3kuOtV/wMUKDYYMZ6PnuqGanks9Tvp2U7hJxe+AxRNMQklD+P/R8L9Jxjkq/PdFerMdj8qpbW+1Rke8KQ70OLbU3WFOY+P0Hn dKaelJea ktVVH60YC3fbkwVkuCzn/K6A3Q1LhiPZcJyF9DHb/s+Wv33ypz3EwYFKvrxevMvUhSW8xSZZ5BjJh6h8g4buciDKQIq23lFtyFhvTRiLhSYMKOmycraE1TMLMtGWQz9M81Q4OShNzEAjsdjI0YefazZzWe5aIqWbys5dQFRI8zWdmqnjBPD4GECvYyE61ttAKRtx3UyFe/Aau8ItC3s+JsG09CeULVprE5ler X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: David Howells wrote on Wed, Jan 03, 2024 at 02:59:27PM +0000: > Do a couple of cleanups to 9p: > > (1) Remove a couple of unused variables. > > (2) Turn a BUG_ON() into a warning, consolidate with another warning and > make the warning message include the inode number rather than > whatever's in i_private (which will get hashed anyway). > > Suggested-by: Dominique Martinet Thanks, Acked-by: Dominique Martinet -- Dominique Martinet | Asmadeus