From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C19D8C3DA6E for ; Wed, 3 Jan 2024 15:15:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 45BBB8D0041; Wed, 3 Jan 2024 10:15:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 40CED6B0171; Wed, 3 Jan 2024 10:15:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 285048D0041; Wed, 3 Jan 2024 10:15:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 169A56B0153 for ; Wed, 3 Jan 2024 10:15:11 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D216F14092A for ; Wed, 3 Jan 2024 15:15:10 +0000 (UTC) X-FDA: 81638347980.05.FC3AB07 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf23.hostedemail.com (Postfix) with ESMTP id 2639814001A for ; Wed, 3 Jan 2024 15:15:08 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=k39ifGsG; spf=pass (imf23.hostedemail.com: domain of jszhang@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jszhang@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704294909; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x7rey9bg5nfMiaKitaWHsxtZ6xYTBstr5E3ItASV6NU=; b=tOeliDz+P0UvZjUhq+ajqiOm8aPmoQSOUZ+wJUwClz55XMlajpFjxe9Yp7lPLNGbk0hHkZ zfYGJlkGLxqz5/zP2UFcxvGf6JSes2KOQir2WOZw43BO6uUm9dkwdTdw+iT48HvJ8O8vUV 3f+6vT/aw/IDwFYhjEabrSJ1IjKSpH8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704294909; a=rsa-sha256; cv=none; b=mzWs8Y7zlFpo/Imay2hVcSg61KIZ0QCccV75SfZyiJ0DJw4APyOO5ghp2I6IkK5hJDcowy CvZYimykmxrHy1dyXp99pgUEcy7GCN9wcd8VDJN1Iew5J4hfuGqHALhP7GkmHFJSM/HNEH Qn0fX/IPa13GTmCt1kuXdNs0k81aWSY= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=k39ifGsG; spf=pass (imf23.hostedemail.com: domain of jszhang@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jszhang@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 43C24614B8; Wed, 3 Jan 2024 15:15:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D84CC433C7; Wed, 3 Jan 2024 15:15:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704294907; bh=RERYlAnfEwJ6yjyyBYDUmO53kwh/sm8G92j6F6VTE+o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k39ifGsG7hJqiX4VzXtNDzU7d+dMKFHWaYdlznt63uRqTUTArCSPYJgIJTe4jf+1k QXsNVce+ofWLwhWwmA9EpGDuic1hESXQ2qE3jofzADEBI0+7ccSXrs/OgUYDsJEHzF CQ248BfTX1PdCAk2RVXOceYWe5bMZGrlfgYxWavqSag05+l00AQezKDRFmNtj9F0/n l5ci2ji3jHxOeg7sf4lderXtbRVibH3pwj/ob6ngG9BC5HnuVAG3dqI1LOyM4eRGAo QaY+dxeNWj7mvuQMEtFV/UUVdSg94S47qm/w22cjcGme+BAFBuHJI7YFVp9R8nZrYC LC+/S7oNw0GBg== Date: Wed, 3 Jan 2024 23:02:24 +0800 From: Jisheng Zhang To: Samuel Holland Cc: Palmer Dabbelt , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexandre Ghiti Subject: Re: [PATCH v4 12/12] riscv: mm: Always use an ASID to flush mm contexts Message-ID: References: <20240102220134.3229156-1-samuel.holland@sifive.com> <20240102220134.3229156-13-samuel.holland@sifive.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240102220134.3229156-13-samuel.holland@sifive.com> X-Rspamd-Queue-Id: 2639814001A X-Rspam-User: X-Stat-Signature: n1a94xhuy4454uej8iymaehxhexuqzjd X-Rspamd-Server: rspam03 X-HE-Tag: 1704294908-816857 X-HE-Meta: U2FsdGVkX1/cugHdmuDCxeE9x15tWqqaj+3ltIVYu3sZKilnis3N6ZYZ9j7Lqqw/+SOW8r7qGYNAIup1tBW7bm2b+LvulShWXUx0EhQDU0b6d25NxHSYD0+Axga2BigJ7wQCq31OS6HwsO5LZMBH2/rZEzmSenTxi96tklOCVxO3ue88SkwHCl6MGSXFby8Ac2JDdtfxNR5cybNu60c5K1lpRkJ3LbOcJfBSaEJYqJAVzxpA/0F3lSpZP+NcmD5uUOK+l5442Ibo4Ep8UjPShfgKsl9uP/QSsZ7ECSye1nQ+jf5sUjXKLdjuwLA1aUY386wmN6qmdzFskvkbAg35T+ska0mLqMcxr1npuBrxqB3SQ3jKZhLKydpxOG8HpG9KwkQKa920N6ooKUg9MRJ7UAB/HM2Yw3Ftrvc0xjyTieNf4UBH6G+23H/bS37sRXRBD9KRCkA9kLDwwArI8I3gYmTWBHKMjhxw2ZkAcRIMTXMJoFpHAK8ibnDywlnKBFISLS0UFqWCz3zqu9I2JuQuSLlxzFlMxK3XC9+8JfAcINH/KBg4aFL9tn9AePHhvTFV4Z667N7qKPEt/B9XtlY/ctVM3E5OzXRfGnif2U1E0l7Lzh0YtB8fbBrqkfi5BnUfEA6hcO+ZeqmrrCVmGl9a6BpysV4PBJDFKWQCrSwQQOZiEfM2MIFcI4H0BufxHhCl7ns23YGrntFUQTt3IFoK7t+domsinirrVFFfzEJ3sl2av9KPRVg5tZYrU5xmqmEuzXyGTblQtVFh1z9vpGAaIZhHjl3cqVOQqQ/21NMuN+AuK7+9sAzqcsZy3WUOCmULO8yaFIpoOOhODNWi1dV2uDGgMZQdJ8s614hFKp/asGt6+hNc//QlTDgO6K5dgvsD9Bet8HEVL/bYAWBYbNJBe4Nc1lzAm5nOtsYLWA3OJqnmgK0dy+NgKbDOEvmTaP3Koq3VY9rr88CEvVSN5+r AN+Kmvn5 0wAw3qkRSMbvReGNWwVbNluKoq/lzrB3xvA/yRt+PgahgOkDrCfRd2V3uFc18VjJa0FJ/3EjF62G7FiqetH9P3BBJKxdZ/Pij3dZp3ajcGec1UHpr0a0LiNk6Z8nqEnLIcj4NBn2C52nvzovYt8WuXxjlqh5JiDBOV3nCqS8o7FZjI0RFo5jC2Y43G6DETUbXuRwl4m+jCbnbL8rKle5mK2fz1kJ/gcOXdhozYRnGMU0cpjj641/JCv5FZq7+VDD8l2v3Ln8Y3tFJjRuRCCTEVeqaIEy2aiEAaNOBLeN08Y0dtXq9XYNWYrcqag== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 02, 2024 at 02:00:49PM -0800, Samuel Holland wrote: > Even if multiple ASIDs are not supported, using the single-ASID variant > of the sfence.vma instruction preserves TLB entries for global (kernel) > pages. So it is always more efficient to use the single-ASID code path. > > Signed-off-by: Samuel Holland > --- > > Changes in v4: > - There is now only one copy of __flush_tlb_range() > > Changes in v2: > - Update both copies of __flush_tlb_range() > > arch/riscv/include/asm/mmu_context.h | 2 -- > arch/riscv/mm/context.c | 3 +-- > arch/riscv/mm/tlbflush.c | 3 +-- > 3 files changed, 2 insertions(+), 6 deletions(-) > > diff --git a/arch/riscv/include/asm/mmu_context.h b/arch/riscv/include/asm/mmu_context.h > index 7030837adc1a..b0659413a080 100644 > --- a/arch/riscv/include/asm/mmu_context.h > +++ b/arch/riscv/include/asm/mmu_context.h > @@ -33,8 +33,6 @@ static inline int init_new_context(struct task_struct *tsk, > return 0; > } > > -DECLARE_STATIC_KEY_FALSE(use_asid_allocator); > - > #include > > #endif /* _ASM_RISCV_MMU_CONTEXT_H */ > diff --git a/arch/riscv/mm/context.c b/arch/riscv/mm/context.c > index 3ca9b653df7d..20057085ab8a 100644 > --- a/arch/riscv/mm/context.c > +++ b/arch/riscv/mm/context.c > @@ -18,8 +18,7 @@ > > #ifdef CONFIG_MMU > > -DEFINE_STATIC_KEY_FALSE(use_asid_allocator); > - > +static DEFINE_STATIC_KEY_FALSE(use_asid_allocator); One of my optimization "riscv: tlb: avoid tlb flushing if fullmm == 1" will make use of use_asid_allocator, so could we remove this modification? > static unsigned long num_asids; > > static atomic_long_t current_version; > diff --git a/arch/riscv/mm/tlbflush.c b/arch/riscv/mm/tlbflush.c > index 5ec621545c69..39d80f56d292 100644 > --- a/arch/riscv/mm/tlbflush.c > +++ b/arch/riscv/mm/tlbflush.c > @@ -84,8 +84,7 @@ static void __flush_tlb_range(struct mm_struct *mm, unsigned long start, > if (cpumask_empty(cmask)) > return; > > - if (static_branch_unlikely(&use_asid_allocator)) > - asid = cntx2asid(atomic_long_read(&mm->context.id)); > + asid = cntx2asid(atomic_long_read(&mm->context.id)); > } else { > cmask = cpu_online_mask; > } > -- > 2.42.0 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv