From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E98CC3DA6E for ; Wed, 3 Jan 2024 09:06:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9FE958D004C; Wed, 3 Jan 2024 04:06:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 988498D0035; Wed, 3 Jan 2024 04:06:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 828518D004C; Wed, 3 Jan 2024 04:06:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6ED588D0035 for ; Wed, 3 Jan 2024 04:06:00 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3A162120265 for ; Wed, 3 Jan 2024 09:06:00 +0000 (UTC) X-FDA: 81637417680.01.18055C4 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf09.hostedemail.com (Postfix) with ESMTP id BC7C0140007 for ; Wed, 3 Jan 2024 09:05:57 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OXxrEElr; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=eiUS5Rvv; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OXxrEElr; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=eiUS5Rvv; spf=pass (imf09.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704272758; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9YHgEMpLm7folf5G8Ij+ZasKgK+9OLJsmoPBAUvLJ/8=; b=43plBH2j1H/F+ByHeoYJeWoMtYf+glEkBtcfabcudNcmszxvpINBVCuluZCvw003KQ4CvE WUZISNQbXZSzcYmQxOYPkVPBeWAAmmlVeyegkz0rnvtINzZiZQ94wOpk5xdA87kF9ntQdN P2c4A+27cybJE7kPpz4qtjQHRIGD1/Q= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704272758; a=rsa-sha256; cv=none; b=pwz1PZu8xAG8xQAIE1Vl1INSpKwf1qoYs5EdLyI3WZsm7yG9OAe8WplXljTI9S/2XIGwuE ANkJl8Z6kj1qsS+5Y2IFl3qEj7vzLHynYpu7WHnNzMGGXqjEDYvhZRggyI7F+zmXWFHPKs rcBGl3Ya6NNc4FEp+nP/cJ4mjJnHaJU= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OXxrEElr; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=eiUS5Rvv; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OXxrEElr; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=eiUS5Rvv; spf=pass (imf09.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0712821C64; Wed, 3 Jan 2024 09:05:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1704272756; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9YHgEMpLm7folf5G8Ij+ZasKgK+9OLJsmoPBAUvLJ/8=; b=OXxrEElrNfC+/T5mY1izxFruu35404m0j3OipElyrHhk70EhEVSjlrTgu1vHsM7m2zzddg wfDLOFu0uHl2077tXTxU2DOG2tMOxxzwt6Ejg3BoTFg8fbvshfCghQeO5fMoiJP4SejDlv 6bKYK1+hsT557oQjts72D0rfr15YI6E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1704272756; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9YHgEMpLm7folf5G8Ij+ZasKgK+9OLJsmoPBAUvLJ/8=; b=eiUS5Rvvpde2p9gy0tfi2VBTJMrDVIqjkFif9iFzaiZJR1Yf74nJIgN+sL4NhjL8LSRVN1 J6Y5ZmX1tSoldzDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1704272756; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9YHgEMpLm7folf5G8Ij+ZasKgK+9OLJsmoPBAUvLJ/8=; b=OXxrEElrNfC+/T5mY1izxFruu35404m0j3OipElyrHhk70EhEVSjlrTgu1vHsM7m2zzddg wfDLOFu0uHl2077tXTxU2DOG2tMOxxzwt6Ejg3BoTFg8fbvshfCghQeO5fMoiJP4SejDlv 6bKYK1+hsT557oQjts72D0rfr15YI6E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1704272756; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9YHgEMpLm7folf5G8Ij+ZasKgK+9OLJsmoPBAUvLJ/8=; b=eiUS5Rvvpde2p9gy0tfi2VBTJMrDVIqjkFif9iFzaiZJR1Yf74nJIgN+sL4NhjL8LSRVN1 J6Y5ZmX1tSoldzDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3C2421340C; Wed, 3 Jan 2024 09:05:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 2UebC3MjlWUEaQAAD6G6ig (envelope-from ); Wed, 03 Jan 2024 09:05:55 +0000 Date: Wed, 3 Jan 2024 10:06:46 +0100 From: Oscar Salvador To: andrey.konovalov@linux.dev Cc: Andrew Morton , Andrey Konovalov , Marco Elver , Alexander Potapenko , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Subject: Re: [PATCH v4 10/22] lib/stackdepot: store next pool pointer in new_pool Message-ID: References: <448bc18296c16bef95cb3167697be6583dcc8ce3.1700502145.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <448bc18296c16bef95cb3167697be6583dcc8ce3.1700502145.git.andreyknvl@google.com> X-Stat-Signature: c6izbg511ezu1teoif8wjsc3nm3hyezw X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: BC7C0140007 X-Rspam-User: X-HE-Tag: 1704272757-33456 X-HE-Meta: U2FsdGVkX19YMr8yGOLYdTiVippcqgLNq32Bk5AznNUjnhRdBxuTKoqfLP0+BIIYRxQEQzpsDWJ35sIBKOHe2gil22jecGKOjC6SHLgUvqm7Q5u1tSFQkmpUe7sx8A0M2TtdpJYrbKBRyxZdMJiaxb4THR07c6X7qHejg1+ynRp5t6ayU4jQSqxcxr9wfLiL80EGhnXqdspu0vW7mZmt3lREy+OebvqMjonjbuJWjA+CY+qzyrAQoRqOAUFLV84A4uVMCDEwM7fJln7k88/f0/2cjhdre5J2NhruUqhfipd5nEwzWAMQWTNM7wr+YqyomYlD+TIYTYRRNxFzKSzfi0wgmw0uUIdJk4vdeA162c4r11ovkpGsJiUmm9xj3wK4dX9dfQ7NnB1YU/Fq98YyqJQKR1ydMMOhbiZrkLW4LaM0Xf8AlgkrAQ+3UefRLuT1cShAhMPpWmaPy+gKfJcISQA/pBU8CTwguIbQpXxL70GU8IJ6VxY/EKS7/p13a9P9UD2sWu5vcIQCrzGv9nQd6sIlt5TzchG5YUeHicpE6LhT0WZ+fVgINURgPmQtpxGWc4fZWmTn3MdG/OU28lOrcXAteFfOE1G5cww1IbGIHIzxTT5nr3Wxli58LBNLA22CttYVcOBTYPp27wb0sNb2Ykjqf9UBmTkdKrk6YGfw/q8r3IkY1Mp8L+eupf4YZvXoE+CmDLLa/Ee4W6LU42qm31iPXaL2MNju4QmJTkd+37Za+NbwVrSk6FRPepdV3t/X2pHB8h8fs0Qiw0zFnb/IabFnKckmkGwsSrLsraaO5sg7M1v2c+UkxF01RIder+dCdgjX9yIcmI9dYUy4u2FDKYBKdtJ9kdeYe0MUccSo+6qRwglGk/T8yi88HMG5qI95k1o7mKHgls8kU3YBjf7wObOXKbBIQGKAOPNcdHaRsqVYdRhPCfdcVvC2PoPO/NPdX18uNiFdC9ftwLVdriA tr5zJdd/ VhujU8bmCGn2+CjV3lA7VcId3FcMQSyUXMxwEIIoz++xSWxxZRVs655LMGfRMXygvHOZY5E7w5PklSqRaxAVMxSh8RaxB0gpgm+A/6qlnyPiELonPTYc5EEAfz8+2+sPohRyIqxYDz+uShX6DlVc6PUMyIES4HLy7lcecRMA7DaTlwRVGtFiESEPDGL3kB+WtF3qoO1TM8vwBKQH9TexnETMFvPiOil1mc8mLqVxJcByMcKI+vQgS2PMIY6V6xtee0+cKpvF8LT9bxVsRAlTNM2M7DTrgDpwEiPnJClvy6wssvvMP5Rhlxk8sFw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 20, 2023 at 06:47:08PM +0100, andrey.konovalov@linux.dev wrote: > From: Andrey Konovalov > > Instead of using the last pointer in stack_pools for storing the pointer > to a new pool (which does not yet store any stack records), use a new > new_pool variable. > > This a purely code readability change: it seems more logical to store > the pointer to a pool with a special meaning in a dedicated variable. > > Reviewed-by: Alexander Potapenko > Signed-off-by: Andrey Konovalov Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs