From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B955FC3DA6E for ; Wed, 3 Jan 2024 08:59:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 195228D004A; Wed, 3 Jan 2024 03:59:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 146038D0035; Wed, 3 Jan 2024 03:59:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F01AA8D004A; Wed, 3 Jan 2024 03:59:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DFD988D0035 for ; Wed, 3 Jan 2024 03:59:09 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A79ED14068C for ; Wed, 3 Jan 2024 08:59:09 +0000 (UTC) X-FDA: 81637400418.17.2CB4807 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf04.hostedemail.com (Postfix) with ESMTP id 6EB2B4000D for ; Wed, 3 Jan 2024 08:59:07 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=APqPemPI; dkim=pass header.d=suse.com header.s=susede1 header.b=APqPemPI; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf04.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704272347; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Yv2lvBBY8zygbe4ymIzZMEvU6ASa58iPZBjgLvImPuI=; b=4Humoq/BdX7b0BxVtN1/Vf3neoCTe0eOo570GywyY6K3MYlYuwUm4wnPyBobr8sH4f4jX0 cUi+6VrIavojvJZ7RL54i3K8mcqBRYk8ciwGIip6qzeMtbTh6OekrqVM0U2RTJy7QRS/iL FEzb/lw+WxMP8upUhBauiOaJi68xZj0= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=APqPemPI; dkim=pass header.d=suse.com header.s=susede1 header.b=APqPemPI; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf04.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704272347; a=rsa-sha256; cv=none; b=bxWMca7bmYp2PfwoIZ5gvECM+kBMVabES9Yun6vq/do8B2U3b2HvC6pQCB8U0ZmXY+hCqG bw5X+sKQYwcJ9W1dic17NmkLoA/3b+VrY0E+ISLsATix5ccJpsM7Q0vCR1pMTUhiQrPBX3 E2MXwEK6lxaZPsy4M7PSr9EF2f4QJuY= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A245A1F79C; Wed, 3 Jan 2024 08:59:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1704272345; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Yv2lvBBY8zygbe4ymIzZMEvU6ASa58iPZBjgLvImPuI=; b=APqPemPI7W1Ua8LkRyWzDPC3sHMyuQJIj2v0Wy/brDFHbMHaNs9wPvYHRAMtyyNXW3d+3z 8RehXl/VOkKgLwf4LWpLD7xpzYDjHNQPhmsa+H+vVnIM1tLMZOWbvTH0HuCLap65uwqTqG XnebmvetCeovBhh7ESJOxfdx14eDXsQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1704272345; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Yv2lvBBY8zygbe4ymIzZMEvU6ASa58iPZBjgLvImPuI=; b=APqPemPI7W1Ua8LkRyWzDPC3sHMyuQJIj2v0Wy/brDFHbMHaNs9wPvYHRAMtyyNXW3d+3z 8RehXl/VOkKgLwf4LWpLD7xpzYDjHNQPhmsa+H+vVnIM1tLMZOWbvTH0HuCLap65uwqTqG XnebmvetCeovBhh7ESJOxfdx14eDXsQ= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 796401340C; Wed, 3 Jan 2024 08:59:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id QqxWGtkhlWXGZgAAD6G6ig (envelope-from ); Wed, 03 Jan 2024 08:59:05 +0000 Date: Wed, 3 Jan 2024 09:59:04 +0100 From: Michal Hocko To: Dan Schatzberg Cc: Johannes Weiner , Roman Gushchin , Yosry Ahmed , Huan Yang , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Tejun Heo , Zefan Li , Jonathan Corbet , Shakeel Butt , Muchun Song , Andrew Morton , Kefeng Wang , SeongJae Park , "Vishal Moola (Oracle)" , Nhat Pham , Yue Zhao Subject: Re: [PATCH v5 2/2] mm: add swapiness= arg to memory.reclaim Message-ID: References: <20231220152653.3273778-1-schatzberg.dan@gmail.com> <20231220152653.3273778-3-schatzberg.dan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 6EB2B4000D X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 56gy99b5zi6znm7kh81958ifqm7jrry5 X-HE-Tag: 1704272347-169748 X-HE-Meta: U2FsdGVkX1/UJpTqcy9EiO+0zUZNcjAvAqjYwON6d09lE/JaqbTZP50yCNjtwpb+klmmaZfUMivlz36RGUQMEIC/5paMRFhgnidPdEKXZ+EUhSDyTcVUKqpLvpJvqOnrAhep5ffNQfZC8KNEvisn4/mLbesocpMB0jfnSJdduhPM5/iORP5ukEr5skPazDuqCHy65sUN7p36kZ9nZAdpaGF4B0InLXxIXALeWSyk0OT1F/VAKC6yTIG49yb1csLCFBAmQsWi79G+CzIefZXyQr77XfTgW8ePQcdK79J7KogCWe6eztA/5DRpzsepPJoR5WP4b3pkFHKxSjfVGMV/luy01aPt8CWhFRUPB68HdkVjhVJLYHCOe902nIgEPPO7yhwHJBEFBDKpx/3KlBfUkobgEaJHKv6mt4dArWo1r96IcMb/AQNy7vGN+vXU8IqcJ8ocff+5zQZzt3sBqX06tnkBCCvpmYPWyHPDN4/8IH4lvHkfs5PDkVHLPuRw09150D8nPAT5skE5sKM6G3+3LASdPf2onMbS0k1Wh/CGLgq5Swdy98vo4S8QKnAJLKNyVUzk8VZhbqhYKc4iDKvsLJ/bbQnzFgx6ssMkaD9rAArRI3ydMKaDWv82i3cbxoqsqoIG4OztrrF0IpSWaLwGhCxVvWV4k74mRAAmOxOM2mRVQak9/loCmNZK6WixDHPnr5lJN4OSz/urF5uGZ2a2x5R6QbP6GZ83LX2OedbnxmlmcPnwThw3z+dTeg7yUnPKhi6IVhfIHX4P7F09+RUA8pDR8F/Cwhwp4/6MidZBLMAnE2wlkVRV7D3Oa38cAGzGjJYy43zgzTvoCcQhNgtpjDxTZ+nr7LC/nmB0Fb1QNPTXpaGlsRQkx4aWJr7wTPq8ebtfD0eTV30cLKqXcAN8r2RdjiUmd7q2x6mLg+LYyJIjWYVhnNUau82NrGRZDC4BBNpnhbpV/GA3aG4M9fK zwruaLpO 8R+DbeI/TPRczcsG9y2NwxZuUcSsgd6bhBZsVV+tF3g2awOS8o6Bjt+agllmbH+Zwj5lyFiQGWkxjbspDi7EL8J3PK/8l/E/LMFhw+Y4vabbdaDQtefUrsm698wbHaXAov5M2MTdMQkcRigaveC80lBfsSkgXMdFv3pC7AgIbmWwe0TJVZo4hR2riFfo+cOF28szyM5ZkPXoMj39zy/dkPECDxwi1Gl0RgQjXACKWYZ6xIfGHAunRpFhpQOFMSElUo0bGD1jBlburvM9IhpY9OWT4jA4w4bPFx2Oi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 02-01-24 12:43:49, Dan Schatzberg wrote: > On Thu, Dec 21, 2023 at 10:29:59AM +0100, Michal Hocko wrote: [...] > Thanks for the review Michal and sorry for the delayed response. Your > patch looks reasonable to me but I'm a bit unclear about the need for > #ifdef - mem_cgroup_swappiness already works correctly regardless of > CONFIG_MEMCG or not - why not make sc->swappiness and sc_swappiness() > unconditional? We do not have a different user than memcg pro-active reclaim. Making that conditional makes that more explicit. Nothing that I would insist on of course. -- Michal Hocko SUSE Labs