From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE74BC3DA6E for ; Wed, 3 Jan 2024 08:41:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D6CA8D0031; Wed, 3 Jan 2024 03:41:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 356466B0324; Wed, 3 Jan 2024 03:41:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D13A8D0031; Wed, 3 Jan 2024 03:41:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 09EB16B018B for ; Wed, 3 Jan 2024 03:41:28 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D5FE31A02B2 for ; Wed, 3 Jan 2024 08:41:27 +0000 (UTC) X-FDA: 81637355814.06.29DAFD4 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf28.hostedemail.com (Postfix) with ESMTP id BAF28C000F for ; Wed, 3 Jan 2024 08:41:25 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ucZdsDp3; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=fXGtwbL3; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="Ma2sj/R5"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=oATMvH08; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf28.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704271286; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KSXZ40//AYfGpTVhrABXJB2R3UQrzV4ODHYRuNkyzfE=; b=oKXQj3E5kfMWYjQpvP2eYoOtYBMffK3wFYwlTLplrL9/gwXFe5qLdtJCEaKzezM5aEtMwo Mg5BBAT9bK/kNh0cvBj6pEXa90Glq99BA/R1EaZqS+SAZmZh6c2Eq+K3Q0oTI/7+QapH3A 3GFt/+1bgOn63tAbysYvFG0IO3y0si4= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ucZdsDp3; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=fXGtwbL3; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="Ma2sj/R5"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=oATMvH08; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf28.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704271286; a=rsa-sha256; cv=none; b=u5zP6UuHI0D/7OOwgz2cZFUk0l5dZ0JYLv1RmdXhK2ykU6Ph/ecHWGFgiLbeGuKOs3k8pF suhrsUy/J9INCcDwuWOch2UcAbPeR2OKM/1qUECtG9ZEdH92LGKYqjW4BSK6AFjt8iAjkk XpDIAtffN0bcIZ1VN3d8OAy2Ont9nFY= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2005621EE8; Wed, 3 Jan 2024 08:41:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1704271284; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KSXZ40//AYfGpTVhrABXJB2R3UQrzV4ODHYRuNkyzfE=; b=ucZdsDp3G1QU7wyS1tbCWPGDbrEp7jfi56NtxE/7NjYHEgIB0KSyULh3P0bak9qRvoxHR6 nUGAwL885ROXJU/ftF6qVzJeP2XNRoVPY92S69Re3iPYBJIFNMWWm+hph+TeR836CRNJ96 VjX3v6OZjo/F6s7iF+TahLab4s712Co= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1704271284; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KSXZ40//AYfGpTVhrABXJB2R3UQrzV4ODHYRuNkyzfE=; b=fXGtwbL3BZedIp558ARok3Nn5QbLfN2sWkY81UyZkX3cqr8rWOM5vumUXP3V5NM0LTSJHI g1D2eQV3EVgK4LDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1704271282; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KSXZ40//AYfGpTVhrABXJB2R3UQrzV4ODHYRuNkyzfE=; b=Ma2sj/R5kscROfb0lAuySLyH3RgAXkMVyFs6dpgYZjRU45RpV7q/tSaB4hmdBIi+3iJFA0 uovt8nLZxWsFGEib9oW2wHMVbt6CxA0n7pZi1omoXZxB8Z+HcH4w2lcyGTBWXEZ7ZWiVQv UjFrHkJ0hqTP1LjHEl8WpkS4Q6VzKAw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1704271282; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KSXZ40//AYfGpTVhrABXJB2R3UQrzV4ODHYRuNkyzfE=; b=oATMvH08SKXWT0vGQHEaYzKss9g1/fLGspZnuxEw/hYlfPEacwbnvC3wSQWNr78+FT1Js9 OuehUQ/Ja9OyM1Aw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 674AC1340C; Wed, 3 Jan 2024 08:41:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 8W8DFrEdlWXVYQAAD6G6ig (envelope-from ); Wed, 03 Jan 2024 08:41:21 +0000 Date: Wed, 3 Jan 2024 09:42:12 +0100 From: Oscar Salvador To: andrey.konovalov@linux.dev Cc: Andrew Morton , Andrey Konovalov , Marco Elver , Alexander Potapenko , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Subject: Re: [PATCH v4 08/22] lib/stackdepot: rework helpers for depot_alloc_stack Message-ID: References: <71fb144d42b701fcb46708d7f4be6801a4a8270e.1700502145.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <71fb144d42b701fcb46708d7f4be6801a4a8270e.1700502145.git.andreyknvl@google.com> X-Spamd-Bar: / X-Rspamd-Queue-Id: BAF28C000F X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: k4x9ane9jy51r7n1k14s5d4sz4rokcnm X-HE-Tag: 1704271285-177622 X-HE-Meta: U2FsdGVkX19HurJ0OIxYsTqcPU2xpzhckrsDLaG7ewgiCTuyYAvuCrl8+qi5okaXIvVPLkI4pu9rD4C5bmDjw18Lvm2xN9X9on8gvmSPrbL1RG+X+QlrEG/EBqVPtsW+iV7EISzwp+MU9CDQIVamnN1IW4F+QBE53Z384CfySNKM3W7yQ2Xrn7ohRatSycA3mXPUMnLzLbmg+iWJQ5ot5N2D2kmghz2QyYELGhHVlPHoB5C4cOp/kgAWHkLmZD+f9H1x/wBTTPIBjo+0gLEdZqmdlDPLML0YJwj5su5O0Jn+/iQDNF8tzGZu3cNuHNIYEMHbYwsNtW4QU9a4wK+6cA1cautOZPWpRLOjUiLENeHFmkuI3lfoWClZy8Xe2BwUFlbP6shH+e0Lq5FO47FK3PA8LgU1ZRou8IB6vi3aYvsy/QwHym7B1/C4+86SXhqU46g46pf0gAW7AksMIBeTJRik1OXpS6zqpTrjsQ/z5GVqYv+PQQWyL9JB3v76TSzqdJYts5e/A7aazQpD1w8pm6o3wZyC2OPKVBGgXFUHukxSxuAZ09hAmjhmntYq2FG7w1qI9aX0MMN0YaUYudzHRtn9iIl6r3h0MGZw4q8rBBQFZL9bzIDysoH/c28g/ZcCa3zQPQDvSB/spsmx8CVOBBMsnB/fYrvPvQFiKnVlaoDgWUotiXWr6PFZRhbVINOXUBgkItiJq+88nLgKhTanDpLEAp/GBevJzgFJa7xnzvWk9Lkl5OymkmlcfmRi/Ds6H+T0Vwb6rvGfaaOyno7Rwhh1+Z6u7XZHzGvpITjb6IAZ5sPNwtWRDu1/ZLlqFTykYJ3x9XMMc2H0HxuqgTcqwMjPgwB5E8odJoch2/0P85AJDDbNTSL+AWrcxtIP1N9DpcusAUlI5TzrJy9y32H8QbrG+KkH0V+xZfN7EH0DHvE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 20, 2023 at 06:47:06PM +0100, andrey.konovalov@linux.dev wrote: > From: Andrey Konovalov > > Split code in depot_alloc_stack and depot_init_pool into 3 functions: > > 1. depot_keep_next_pool that keeps preallocated memory for the next pool > if required. > > 2. depot_update_pools that moves on to the next pool if there's no space > left in the current pool, uses preallocated memory for the new current > pool if required, and calls depot_keep_next_pool otherwise. > > 3. depot_alloc_stack that calls depot_update_pools and then allocates > a stack record as before. > > This makes it somewhat easier to follow the logic of depot_alloc_stack > and also serves as a preparation for implementing the eviction of stack > records from the stack depot. > > Reviewed-by: Alexander Potapenko > Signed-off-by: Andrey Konovalov I have to say this simplifies the reading quite a lot. Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs