From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CA2DC3DA6E for ; Wed, 3 Jan 2024 08:19:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B12816B00F2; Wed, 3 Jan 2024 03:19:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A9B106B00F4; Wed, 3 Jan 2024 03:19:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 914D56B00F5; Wed, 3 Jan 2024 03:19:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7E4826B00F2 for ; Wed, 3 Jan 2024 03:19:11 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 521011C1054 for ; Wed, 3 Jan 2024 08:19:06 +0000 (UTC) X-FDA: 81637299492.26.A78D9EC Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf22.hostedemail.com (Postfix) with ESMTP id 10BF4C0008 for ; Wed, 3 Jan 2024 08:19:03 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=1fiIcHij; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=cHM00vUP; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=1fiIcHij; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=cHM00vUP; spf=pass (imf22.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704269944; a=rsa-sha256; cv=none; b=ujZpYhqgigjIKHv56SNwmjX3xoHOV10FB/BmdHrgFKnwQl6l3SJBEwJsk7IwrcnJMFl56x l4sG/u3ZgdLGsgLFVPCRpzwfLTMA9nG/mvEzBrXswVxlE2ZtiVxsraPHCn1LMvV0+3/Hv7 +6B4/M7fP4ICO5URCPRRDI2Myrd8+RQ= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=1fiIcHij; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=cHM00vUP; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=1fiIcHij; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=cHM00vUP; spf=pass (imf22.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704269944; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V9esiW43PFp1nOnTYVzDQBW7TFJkdqXost6VpQW1eec=; b=gCJmMn2cjXOW+zmnExlZwdAihW6p6PHI2twI0UBzaVP30/Af3yPD48k7miSEh0lGQkladA mKVzdWyBaPXD/UtgQ2I3LOaKogXE9brkMdbKcEaMfu3ZGLhQpo0HP+EFL4U+wQFphx31kD UJpiHuZgdPVkEVC+4NlHvB/HNMTAY14= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5950B1F79B; Wed, 3 Jan 2024 08:19:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1704269942; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V9esiW43PFp1nOnTYVzDQBW7TFJkdqXost6VpQW1eec=; b=1fiIcHijtt/C7H4dnD6zvu8S4TD3gVEXvhV1JBV03KIs8NYvd/gKYBveAyFxwVrmflm4wa ILCK6eMtISbyqXFDJUmhd7nwY/5ofMrmHi8RLWtVx6wq30teAIjotN7FoFmHb4zKW+qWTu VWEIux45Ie+VNI+mgK/H32odgNj1tC4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1704269942; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V9esiW43PFp1nOnTYVzDQBW7TFJkdqXost6VpQW1eec=; b=cHM00vUPN2qdxoooabvyuX4QeQCzpsOlVZtaWuX9MxKTCNHMKDSYcaL4UaCaakpFCtdewK ojKvHao7963ZXZAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1704269942; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V9esiW43PFp1nOnTYVzDQBW7TFJkdqXost6VpQW1eec=; b=1fiIcHijtt/C7H4dnD6zvu8S4TD3gVEXvhV1JBV03KIs8NYvd/gKYBveAyFxwVrmflm4wa ILCK6eMtISbyqXFDJUmhd7nwY/5ofMrmHi8RLWtVx6wq30teAIjotN7FoFmHb4zKW+qWTu VWEIux45Ie+VNI+mgK/H32odgNj1tC4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1704269942; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V9esiW43PFp1nOnTYVzDQBW7TFJkdqXost6VpQW1eec=; b=cHM00vUPN2qdxoooabvyuX4QeQCzpsOlVZtaWuX9MxKTCNHMKDSYcaL4UaCaakpFCtdewK ojKvHao7963ZXZAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A6D5C1340C; Wed, 3 Jan 2024 08:19:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id pYkFJnUYlWXsWwAAD6G6ig (envelope-from ); Wed, 03 Jan 2024 08:19:01 +0000 Date: Wed, 3 Jan 2024 09:19:52 +0100 From: Oscar Salvador To: andrey.konovalov@linux.dev Cc: Andrew Morton , Andrey Konovalov , Marco Elver , Alexander Potapenko , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Subject: Re: [PATCH v4 03/22] lib/stackdepot: simplify __stack_depot_save Message-ID: References: <3b0763c8057a1cf2f200ff250a5f9580ee36a28c.1700502145.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3b0763c8057a1cf2f200ff250a5f9580ee36a28c.1700502145.git.andreyknvl@google.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 10BF4C0008 X-Stat-Signature: mmoi8p9xim4ehi78zsyye4tj67jcac79 X-Rspam-User: X-HE-Tag: 1704269943-452015 X-HE-Meta: U2FsdGVkX19UH/quzAhCgY/J2QR4iv251VDCVTYSXltFP+GtgFQ+UP8zDgZ49HPmrnM4q4eksGzzqPb3GD+HE3JM0EggdnqyvbWDvRtBQ5HWQEXjK65Kgu4F7q2sHhP0RNJrVzXX5BUP3eFI24zZXpqslLURClUtMA6gWfIpniT5Bq0rCI95WZgV7+IxrIWsmGKAdYvFVzOmRbsjeHhWnJu5EG6K2r7sPxBmjXSxQP+ux1FXWK39NdrmRol894b+HrXI4t7hmE2FMo/twYCGvjrWBYcpi0eLKr5BowwkPcTyYP+YO0d8N1FjrTLau0g7OGWpvJav5Kz6LyywIF22CvuAY07AMBtKKmUB0pKzWx45cKeQndo5AZxQxPYlf7KKARB/zdbwEcRJ7seGox+0xgTjS/J9SF8ocmORUMiFpKbxZmyYUjES6hp+cZWoFjjuZe7xw/U0MUbMj8HueAy51PdgLx9v+5DEpOVs0104qOrO8TcDTF1wlhNHc18fdHujuP0PE7nULPwawgZrJJrEiqn+nbNcHXIP7qmkqAISXEO/Ol4IWe1ThvdVh0fMENb64m8ulXzHCOTz/qf2qxpVQvw/OD69yro8CfS8Von88m+1GfqIlpNIZfIYihWm4sbKeTtskQDP1iPY+gItmGVZC0ZLyXBnRzdWjnQ2NIYvGsf7RrL9Hejz5CdxOkbdg1unpwLqsu+zJ3PxThOXhG2GyrvMNcvD6g00EgGGWxDYS1O5KlClXZ6dFwn6LM0mID0oVA5t3krbxs1gjw9pt3R3neXkyCK5E1meF6kV7o7fuX+IbO/wJ4/JzVEpzHYzZv4w4hTHDXuzfDXTCbI9jf9MO3B9AdlfcCQzcEj1YpgQAyYZZWJUu7EGN32BpdgfIgDB/MDO4ipYPlHzLc8jG8TeqI1dntZlcY4DwB+LmK7PSJpPsBP62ofwuJX2P9kualgl71bil4lQag0Qp68g2gf cWWW6Xkp EtS6N+Mh1Y6+J9Qqwehz5p6DP7jAaKmrM3SOQYgD7CLbnOD0i3IFSvtiM5OOuv4QXA6kPB9wipC91OKQjFSlUZ3exFnH2B3ormpy42vvSBAXozSJclWDc7NAfp9CEVphVbi8Vz51qsm3sfiqqRfMJ5nrp4YN7ekHQvUAo49anuh0d8aCJFLn+rxgFaAMfwLwzJGma8Fr0tpRQnPBy6SBxvp5wd0efYMXciyIkxFuf21qDVRFvVBi6ZVawvYTF2fENFx+XTuH/FaN0ZbheITuTB/cpR/i+jvlV8qyRxJaJBl9jjaRUmxfyPpoblA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 20, 2023 at 06:47:01PM +0100, andrey.konovalov@linux.dev wrote: > From: Andrey Konovalov > > The retval local variable in __stack_depot_save has the union type > handle_parts, but the function never uses anything but the union's > handle field. > > Define retval simply as depot_stack_handle_t to simplify the code. > > Reviewed-by: Alexander Potapenko > Signed-off-by: Andrey Konovalov Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs