From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 446AAC46CD2 for ; Wed, 3 Jan 2024 01:53:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD8536B01FF; Tue, 2 Jan 2024 20:53:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A616E6B0200; Tue, 2 Jan 2024 20:53:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9292A6B0201; Tue, 2 Jan 2024 20:53:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8370A6B01FF for ; Tue, 2 Jan 2024 20:53:46 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 53E31C0227 for ; Wed, 3 Jan 2024 01:53:46 +0000 (UTC) X-FDA: 81636328452.17.F878A2D Received: from out-176.mta0.migadu.com (out-176.mta0.migadu.com [91.218.175.176]) by imf10.hostedemail.com (Postfix) with ESMTP id 5F670C000B for ; Wed, 3 Jan 2024 01:53:44 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=DX4kW3vT; spf=pass (imf10.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.176 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704246824; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wiVWBuGZIydpDJC/yno1hNw/poDUjUAbK2fa/TQ5+Y4=; b=lVnEXEpYJ3AR8iV+HS30W4Wvn6RWPUFxJxphf2HFS+/XnkjTZFxmLn0TqjYogxIWm5oF+A A/cwFZJpk2nNdYAziyDhFmN6XlLrCnJr3ZI2SLmSBknPCL8N9pAkLqTLtljcDN5plI6j9C hsju7kUtVlxlUAjsZ6Ysy578hRpkCZo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704246824; a=rsa-sha256; cv=none; b=Ud7SC4dU30KQmoXtRS4doA81ATOC7OqMFswL/9oPl8irJ8dqMxnWbsum/C763oKUC97UQD WBXLin+aSu/XXjQVU4bJcsH+qxDn6Ug8QXom/nJaWHC6XC1pHYUwn/3PTtqm7+fWxlf5+p dSHY/zMTUsfrQUlSJCMGqHj1zDMBv2E= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=DX4kW3vT; spf=pass (imf10.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.176 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Tue, 2 Jan 2024 17:53:36 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1704246822; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wiVWBuGZIydpDJC/yno1hNw/poDUjUAbK2fa/TQ5+Y4=; b=DX4kW3vT1n+jkYbgYChJ+oqAtMuww/aSZPs+bccffY5xO8nFb5qkzqQW2oMZeWl9XSolAD 8jW+SRw8TzJmqwOdcFaibdkamk5V6UUco2ssEl+zdnrb0sc8ccIlTz6wH30Abw2CM6MXV+ GLYD7shtTkKdDQUOlbmcEvX99Xqey0M= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Haifeng Xu Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@kernel.org, shakeelb@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm: list_lru: disable memcg_aware when cgroup.memory is set to "nokmem" Message-ID: References: <20231228062715.338672-1-haifeng.xu@shopee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231228062715.338672-1-haifeng.xu@shopee.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 5F670C000B X-Rspam-User: X-Stat-Signature: z9eqi6fiy7w1m4749wgidwtqikbw4oj5 X-Rspamd-Server: rspam03 X-HE-Tag: 1704246824-473593 X-HE-Meta: U2FsdGVkX18wMSWwcmXWIPY+SQr7uUXppY07Eh5LBUftfhbUqteNP1aXl507XzdDnp/fzjgrA419CbPNnNqLre3TusiMI1eiI7MFBxdmmb0LpXQBxEKHH4RxTHGkoPR1zVGZISOjDHp0QJX/ntTOKWLBiSL/eSJzTQ1yh+rZjiPO7B7amAWvQ8OMLmG+BEUZlH0kA2y13XgjL14rdhpM/PJpKcvAEmnk5GxXuBMcyxvqn3SrdHb5PX7cU7piY9PYXhW0bETT4AwX4oFmtrIf0CqUaCkNGM9nQXX4WuAwS2k30kBxdOKmR/hC1HmDk2egwhDix/jTSMUBeVj6Fjvo69ErF0qQ6iqXyPKUbUsvccFJJ5/HOrZBPdekdw2cTTiBq8kk9tiGuJfaivSo1tYEt3HwBj0/iiHcRXdnT3sarutAsiuNGuioqh0LOEew+m5AHJGF6wPm1gp11sskdhUwiQ8U/ODZO/tJzRiUfEI50SwUbS0I7NdJT4wYnTL9SCuyutknSJ+BHBBAbvV0iQUw1rVGGYzFXPNyqUEi+EKHIvjDh3Uww6m/pSIQkYuBLNicdRgaVxZJsMWNwjq9/vLE72w7Rakbbu2s1p2an3+cKIWnUkfwojzG+DDAb/mj3m8Z3mEE+E1fJN3lHocx4lDQwBr52lsXau3TaIcbsfogD8VVlSJ1DoWELQoFpR6FkEaMXyPG/kKU7Z2DR9oFbfgs2dRQ/RaAPXQeitqHlRGOSW0+RiJ4PTa9r+O4k3/mMrIAv6CoDlhBn6dkpNAZG7goLVNSA/uyw1a10yAAwqQWAuP0+8lWOgDGNTdHd0onjX2y3EprjG41lAjxOgVJPVog2icO0xjOlxUFT4e1gpK+xqo6HhFsK6qV1dB0x4ExUPoHZHJdJd+QmcGYQuZkOxv2rq/J8txHBGymFbq/ddAlJR4pwADuaT+qv7EY+X4nn8BepA6SequOqo1glkcI6ey hAUIJsTs XsUiQ1/klC/mpmBlIMTfAdiTXR4VCX+agVTqoRRrtCcz39JGSNMOzN06wTzOPB8/DWSf3F1WOIEUMPI9dlftTPKkVN/5OYn2ThS9/Wi8ParEK5SNVQ55lx/THAI8xRBZDthCxPxuoabl4WPcUWkPyg/sn3NeSL1uQs3zorhjLrJ7f5I2iozAXlCPM/UV5KSRwAEdFV6L9xx8QDG9uTwDyFa294g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 28, 2023 at 06:27:14AM +0000, Haifeng Xu wrote: > Actually, when using a boot time kernel option "cgroup.memory=nokmem", > all lru items are inserted to list_lru_node. But for those users who > invoke list_lru_init_memcg() to initialize list_lru, list_lru_memcg_aware() > returns true. And this brings unneeded operations related to memcg. > > To make things more convenient, let's disable memcg_aware when > cgroup.memory is set to "nokmem". I guess it's not only more convenient, but also should save a bit of memory. But _probably_ not enough to justify messing up with stable backports. Do you have any data on memory savings? > > Signed-off-by: Haifeng Xu Acked-by: Roman Gushchin Thanks!