From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4939CC3DA6E for ; Wed, 10 Jan 2024 09:18:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A60E36B007E; Wed, 10 Jan 2024 04:18:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A10696B0081; Wed, 10 Jan 2024 04:18:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D77A6B0085; Wed, 10 Jan 2024 04:18:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7933A6B007E for ; Wed, 10 Jan 2024 04:18:37 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4AE6980AB2 for ; Wed, 10 Jan 2024 09:18:37 +0000 (UTC) X-FDA: 81662851074.01.A15A231 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by imf14.hostedemail.com (Postfix) with ESMTP id 835B310000F for ; Wed, 10 Jan 2024 09:18:34 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of breno.debian@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=breno.debian@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704878314; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zf6aWngDm6PCCoPwvV8Wz/ElrBZHYRFAEEcA6Tfxtkk=; b=47uLolcP7zFtgMKPfbmabclLZnnd5NCl7l9rz+MXLifQ98lJ0Q5SSP4u9I1feAYzcX31GS YTdZpFz6PdQ/m128DK+9OQdHXz8/QpAhbcjcvuPbWlNd86jz2uWPIiC8l1RbKWPHqppJvT twtwKn5z9optfxEz78zu8jz27x3Eyn0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704878314; a=rsa-sha256; cv=none; b=WkNtEguSFhmgadt0I8S3tYF17PA2tDfHKPnXPjpDndwSSfmXH5dCQdIQ8svk1MNYvY4RL1 Sb2aGlz97wDatxEACJOo7fNrGh8dqxQtS/A6KSZcqvHRny4Ft9Bs3DipbFxXnet9hU+V6H glWo6NjNg/IcdwcbldCxVwwNWl3oPQI= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of breno.debian@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=breno.debian@gmail.com; dmarc=none Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-557e76e1bd6so2586882a12.1 for ; Wed, 10 Jan 2024 01:18:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704878313; x=1705483113; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Zf6aWngDm6PCCoPwvV8Wz/ElrBZHYRFAEEcA6Tfxtkk=; b=tgjAUocbS62NQXt9msknh8Hi8O0J14NISKJdruUHDWLsk2cgsiGK4cDtt9PxnipifP ThM2gL+KO+glzEOvGWqBasUWhGqBi/Zw5vMkbPNkNjYGMrUZpNeUl5uLjMWBod6JGSnv jlI9hI8nirCqxIbfxjJoqvStI8kRBbAzBvim4T88kGyZPG7j9jaMeRbETdlkGFWNfZ5r aztkAflyS2ZfGwffClW1tT6Y6szf4gOsnymSlP09BOK6vnSYeQ50fxRhiUp1h+6qzDVp ngN/ynbt5PFAX5xP/IlvFgJs6UIubeuI4V94+8qlyb+Q6KG+bhlS/tFB4fA67VL86uom t6Gg== X-Gm-Message-State: AOJu0YzMfr4RkmXQc9d/ivbKCMocPcY9Rc63TxiSarlG8mR1WC3ciT2E o2KT3Vtnx2Y/Ey1YrcGoiZs= X-Google-Smtp-Source: AGHT+IG+x/cTJ8rCUu/ixa5PQDfz8WNBPdxJYJ7zgxjYD6RYKIwgJSbC1+GFbnMEwz+4gm+IWIadJg== X-Received: by 2002:a50:ab5b:0:b0:557:7871:67f7 with SMTP id t27-20020a50ab5b000000b00557787167f7mr296202edc.26.1704878312840; Wed, 10 Jan 2024 01:18:32 -0800 (PST) Received: from gmail.com (fwdproxy-cln-020.fbsv.net. [2a03:2880:31ff:14::face:b00c]) by smtp.gmail.com with ESMTPSA id x8-20020aa7cd88000000b0055751515a84sm1795987edv.51.2024.01.10.01.18.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 01:18:32 -0800 (PST) Date: Wed, 10 Jan 2024 01:18:30 -0800 From: Breno Leitao To: Andrew Morton Cc: riel@surriel.com, linux-mm@kvack.org, Shuah Khan , vegard.nossum@oracle.com, rppt@kernel.org, songmuchun@bytedance.com, shy828301@gmail.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] selftests/mm: new test that steals pages Message-ID: References: <20240105155419.1939484-1-leitao@debian.org> <20240105155419.1939484-2-leitao@debian.org> <20240109214731.a7694ae4a575be838b40e9ea@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240109214731.a7694ae4a575be838b40e9ea@linux-foundation.org> X-Rspamd-Queue-Id: 835B310000F X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: o5xmsxpnohjybxtuzbnu1j9mxup17bn6 X-HE-Tag: 1704878314-272068 X-HE-Meta: U2FsdGVkX1/FHJkdHrcAsrR45ENx8J2sHBCVegB0sAZDGhTui25Eo4rFR1oUN1liNixbOUwFna+Bo/UXd+zZ3qqDUcr/M00/8btWeJqxhnYBlisi2+cgD2IBDOqDq9hLfMnlncUBaQfPJhikoNigOvl4Her8qmJO/6hvmvu6QEfPNqM4OIcud7xU/+OWnmBqSyvgAVe53BBF1GZfv2HhdfwfPX8ugroj8IoTQI/XBo2dBW98pBPl4LY+pEqjyKIeJm5Vj/ViSRm+YYrF93XLjfu4l5A972LFJ5fSBVY/dJspnYfp4JpMXFhtWxl5fOJ7gJ05E7w629RVUnsokhH1pkVr1VyqHnG8m1hl1adtOzlCcR3GwUL3GY3RawF+U5Ou4o9rCTcnUtVu1EQ+aFiKh6P2SlyKKHu1Dk1ZlBn5JJFBGQYIhx0ynYhlKEbm3eHLCugFREwbYJ884jNVOO7k6Q9gac9hphtxhhIA2oyLNisQmfVKmMiMg+V2j7hwWvjvWuwpWolQ6j/OyBSIwpIkYkIxGvnu4KZwzD54H8UW8DPnFMcT2q+UgVVZ4/f/ObYGgIjXsn0D0uWn2rjIMga2AOo4dBlbnzD+qSzhn22NLXIi01eRq+d3W3J92NpChS0ciYPJHvom7GwXwyi3Zk6PPaZoDcG0Q2T/Dc6rkWKgfyl4Lv51s1IQWE4FYX5IO8oQSwMywI49LzmdrDAWlrocScVxwSzsGFcx8GmhXUfWHDV+Uma7RiR0oDznXUBWdcpmLlFYhggEDSvRxuz9s0d4fxyMCNPPnFJgMH1hD5+QxFYY7mqKRnnotkZ9JkQ2TLJC5Ns7cjnHTVAEHeMapjmd8TzCHyiiXwD3MGT6MJ6ssvSUK/I4MPin+votqWuWztlIcZKi+6kqhB1rORmV8VsD1bF466xZHCjtPrpoi2Tq0cGm2pMbn2yzXWvR//J4tEslTHmRwkX3KA93tZYmy74 8zlFcfdS VUFj4LZb+I2WME/loAUf/tQ9BkAMMFR7gbL/S/3QRMLDlX39u0EeVLzgTpzwyDjnF9sKPVKVuqv5iS9ywOUfU8ooeCfze1aKuQgEr8v+3oji0esEPGtD0WF4U/4sEuMmIkOJxo4vw2W6KOhYFJnpeNmOsGEH7BOayR+SfrpYYNGDdXqSG4Z4wojj5Puy5U1N88H2TVd+yr12vhqZS/BBG6gXxNlYX1wiqyMZC/TEmkFCqFfE9+BV+xcA+ECwC8oud4n5fZNLuY3fAuM7yxj6tGbsgl+GTMetYNxEpIGwlCcTPg0bxFifKZQfh9O8ImutLPd44U2dAuXwVqHtu3Qmw5M89kpeTRtpC4zXlHzFs8U2oK1mpaVnn6tKtgzvGlTzzlnPZQRViW1JIILznUt6jAiSAHhU9uOWVuGVekhXS5V75LU8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 09, 2024 at 09:47:31PM -0800, Andrew Morton wrote: > On Fri, 5 Jan 2024 07:54:19 -0800 Breno Leitao wrote: > > > This test stresses the race between of madvise(DONTNEED), a page fault > > and a parallel huge page mmap, which should fail due to lack of > > available page available for mapping. > > > > This test case must run on a system with one and only one huge page > > available. > > > > # echo 1 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages > > Can't the test framework perform this configuration prior to running > the test? We have this infrastructure already set in the run_vmtest.sh. The "hugetlb_fault_after_madv" selftest needs the same configuration, so, once the fix is ready, we will just add something as: --- a/tools/testing/selftests/mm/run_vmtests.sh +++ b/tools/testing/selftests/mm/run_vmtests.sh @@ -227,6 +227,7 @@ nr_hugepages_tmp=$(cat /proc/sys/vm/nr_hugepages) # For this test, we need one and just one huge page echo 1 > /proc/sys/vm/nr_hugepages CATEGORY="hugetlb" run_test ./hugetlb_fault_after_madv +CATEGORY="hugetlb" run_test ./hugetlb_madv_vs_map # Restore the previous number of huge pages, since further tests rely on it echo "$nr_hugepages_tmp" > /proc/sys/vm/nr_hugepages