From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 574C6C4707B for ; Tue, 9 Jan 2024 20:36:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BAA266B008A; Tue, 9 Jan 2024 15:36:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B338B6B0093; Tue, 9 Jan 2024 15:36:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FA866B009C; Tue, 9 Jan 2024 15:36:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 889076B008A for ; Tue, 9 Jan 2024 15:36:57 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 56E5B1C0D60 for ; Tue, 9 Jan 2024 20:36:57 +0000 (UTC) X-FDA: 81660931674.08.32CBDF9 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id E6FF840010 for ; Tue, 9 Jan 2024 20:36:54 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Ceez6eWN; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704832615; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b2HomVXY7FzMXkiwOxrMKlwOQEHDYNZAL5sKCtuBtfk=; b=0L9+Y405Jcs8QgEm9go0XYeJkczciZhDF7nTXds4KwvcBb1CxWDgTmo0aeAPLzd+dAlrgD lof95fz+gxCmj8GpOmA3+e2/SEmc/IkgdSonOJ9GBjqh/tAbEgx9JvGvFqIZG+ZFtMDIQd p6nfvg5Gtjdlq0ETaqy4H9+He3RFHsM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704832615; a=rsa-sha256; cv=none; b=cIg4+E1maG0tWQUksPMkqKnfaGNL9enNCHr2RPu35y92JzCP+FtGlLHHr/ZGhUj6oxyXb+ Ua+Ga8/UDY7YYxw8n00YTKIm771OTMNUa0FLnBVjwoDNCarZV/GfMglfWhO+AHrg98BM+e vQ90obg+hAyZuLnk1X2LPnYvGDW2jts= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Ceez6eWN; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=b2HomVXY7FzMXkiwOxrMKlwOQEHDYNZAL5sKCtuBtfk=; b=Ceez6eWNOAP75GYM7O6sxoxLMK sEyjYspnASHzv4goTZkwM3Azj9T0S7OArOGxOU0BOxqwe41T54sximqesBg7tYZ2EljvmUQbzuqfs HtwprQ1pepzRo3YWq4OU0ZII2MeOfSxGvO9mWRXg+B1f4bGSCsXK93nokeodRy1CNMbURutmgvIXr 0KZ+RyDs4RA8S5DouFLHfXW22t6qXMqJWoS2/KlDbl+InFqT8xmW7WSXCHnEoq+Zz7ODVYHdpWcbX 4+8Ux7WmXEdCstEG7wBE3mnDIhmtbpiK7ct9wzwe/d/z5PliZNsv5D0yOj0TOzGJyppNW3vNYrnVF herDEtbw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rNIq7-00AIGa-4i; Tue, 09 Jan 2024 20:36:47 +0000 Date: Tue, 9 Jan 2024 20:36:47 +0000 From: Matthew Wilcox To: jeffxu@chromium.org Cc: akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, sroettger@google.com, gregkh@linuxfoundation.org, torvalds@linux-foundation.org, usama.anjum@collabora.com, jeffxu@google.com, jorgelo@chromium.org, groeck@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, pedro.falcato@gmail.com, dave.hansen@intel.com, linux-hardening@vger.kernel.org, deraadt@openbsd.org Subject: Re: [RFC PATCH v5 2/4] mseal: add mseal syscall Message-ID: References: <20240109154547.1839886-1-jeffxu@chromium.org> <20240109154547.1839886-3-jeffxu@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240109154547.1839886-3-jeffxu@chromium.org> X-Rspamd-Queue-Id: E6FF840010 X-Rspam-User: X-Stat-Signature: 44n97mwf6xgquz48891gupqf4u4f6m5h X-Rspamd-Server: rspam03 X-HE-Tag: 1704832614-463115 X-HE-Meta: U2FsdGVkX1/7bIpbmdpXiKteRtRgnszJvifTyNc3An0pmUlQfcfa8udtFFgpaYDE7q8ADaU4HDVd1Jh1IW/v4OWJwiydosPOvQOfAn1dxTNlESN9yqAveFs+Pws9UVMRRaESkexHP7hsK9e4bhp6869F7NDGrvKBD4l+pAgIqh5SmgxKSFW2PZwseA0iUN7nm+gfv9rnEOvX6FqYSa11JEgp1f6oIgSEcERV1VbWDgYjEAd5bsNjMofjh/q2T7e2mK05y8WAaxyydw0ydWCMYQfIkvxyzHyPqQtB+yRqa+a04UBMlv/3CH0ipkFpI3ZzRjefuhpqPL49V6CB+Rccyz8m1E+pCSIvo43aBISuCL9S/vmGDKDF2C3HOxbT6D3IFXnAXY58Q4HSF+YODn4CluWRJPQ87zEdEffKfB+tIWPMrOSTB6Q81b8PaWfGbtBDwPTYUwCmyU97B35X5gbpD4Bq3Brt9RWNixS21vantp5P2DvaIgA2aBDPS1k4Lwq6Kml1I/heMc+SnBPALkX2xenbdBQevy0AqtQMaK4ABE8Z5oX4tBmRBHIN/UeA53vptB0qmoydagrnZEw6lXrWMf2kYYn0cwTjOiRg/uliVKPzEcUUdPP8MbYWTvhqgflbLXc2ULLQuhaOv3eCsKPL3rIX+ilA6ieiLAA9GEz0WZHwAlsb15omIf8QPSpCjtvwzYs+0/qkB0B+bb/otznzku7wJGqqKkiYjxGR47u3XED6WHuNCuldkhU7pP19FYVyRZg5twhw/AaIMHxmOcRyCghQNapqpWEBmBjv1HFK4YevDTTFiLynqxZZ+//pD2V5Dxm1OJr60KWpMdglwnw96MZS93OYoW7mG8j8iPI5BxH77SplIXwUe40KxHa/LoCo05c8S27/Jj1qBxn+a6/zfL7Gfh4xqkSldcW2eVm+5PnEl3FUxypCSKDxNMccWrkrqtqeixAQFo8t+Axj/h9 1gkk7jzR aMtL+mYmzCtrEpxIFk/jjG5dcgCWmSU/uc02CLVN4u1UENPHic7pwkGxgcQZIV/YNyFNgqx74Mr9wQ9sujr3ZnHV1ItJTvZCagGTcViFonW6yejE6RzKSTSYiux2UOxC3h/JuIH6vu+uH+HDUOOxDlbWXqkh3luaSofArSE1jMuQuOY+IBpvkbvTDGj49VPTItyHrUY4Vr8oyL3gYXIgrcyWmMEKcrXlo09mqspe/gdfYMFQXPN68bM4eoxPW6XNJdqqtiJBKM/UsiHE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 09, 2024 at 03:45:40PM +0000, jeffxu@chromium.org wrote: > +extern bool can_modify_mm(struct mm_struct *mm, unsigned long start, > + unsigned long end); > +extern bool can_modify_mm_madv(struct mm_struct *mm, unsigned long start, > + unsigned long end, int behavior); unnecessary use of extern. > +static inline unsigned long get_mmap_seals(unsigned long prot, > + unsigned long flags) needs more than one tab indent so it doesn't look like part of the body. > +{ > + unsigned long vm_seals; > + > + if (prot & PROT_SEAL) > + vm_seals = VM_SEALED | VM_SEALABLE; > + else > + vm_seals = (flags & MAP_SEALABLE) ? VM_SEALABLE:0; need spaces around the : > +++ b/include/uapi/asm-generic/mman-common.h > @@ -17,6 +17,11 @@ > #define PROT_GROWSDOWN 0x01000000 /* mprotect flag: extend change to start of growsdown vma */ > #define PROT_GROWSUP 0x02000000 /* mprotect flag: extend change to end of growsup vma */ > > +/* > + * The PROT_SEAL defines memory sealing in the prot argument of mmap(). > + */ > +#define PROT_SEAL _BITUL(26) /* 0x04000000 */ why not follow the existing style? > +static inline void set_vma_sealed(struct vm_area_struct *vma) > +{ > + vma->__vm_flags |= VM_SEALED; > +} uhh ... vm_flags_set() ?