From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6654EC47079 for ; Tue, 9 Jan 2024 18:18:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C2C9F8D0002; Tue, 9 Jan 2024 13:18:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BDBF48D0001; Tue, 9 Jan 2024 13:18:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A54F78D0002; Tue, 9 Jan 2024 13:18:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 91BC78D0001 for ; Tue, 9 Jan 2024 13:18:40 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5E731A1D79 for ; Tue, 9 Jan 2024 18:18:40 +0000 (UTC) X-FDA: 81660583200.21.C5F7E1C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 31AE2160007 for ; Tue, 9 Jan 2024 18:18:38 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="TBWI/mgx"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of leobras@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=leobras@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704824318; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KzzgvE0gIC11hFErVwmkGJExGtvPilC4PjYEKFATcqE=; b=SUbwH1uuU7e5EvFbvpzRqkw121ok4uNoDehlch83ssylnO9LfXSuTjAzDllUZmmMxIN2o/ 8SJ1+c1O9IPXhCtXPkmBFRlIkur+xtrseoDrXg5UFfGoOVIjovzEk0ntpIgM2Oq8RkIFkf 2JAmE8aU5guXD6XLN9SWQbYUpldtp/A= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="TBWI/mgx"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of leobras@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=leobras@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704824318; a=rsa-sha256; cv=none; b=urd1V37p3bGKz3sNVx1nWbpbZ6Mz/t91tDrCytsHljrGr4bEs7wWvk4nWsAEG9u1SHG5Sk iupak22LvGCFkR0caxKo44QbCYbdGCCtr2BoK0L9XCoM/jVpt7/8jpY/o40ym1lv3+RLVt 9JjLvk6t464pDaHfi+XChMzyekJnfuE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704824317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KzzgvE0gIC11hFErVwmkGJExGtvPilC4PjYEKFATcqE=; b=TBWI/mgxGPG03N/isNRkhF1aTL55xY7M40sBrKFD0RVHdVvO2DnG/IMKL+EvL2PSKOrkDp z4fPxkQfZ5yyYf6tHLKGXQgROIQryq0YcGH9FdAhoUgCwJSeBBxqprwlQ6onlHjqIApEtE 3p6cBus+vgTt6Ys/LHAH2T22jpNuTg8= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-202-s2KRDvulP36LKAT9bAMN5g-1; Tue, 09 Jan 2024 13:18:36 -0500 X-MC-Unique: s2KRDvulP36LKAT9bAMN5g-1 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-1d455b34723so31307025ad.0 for ; Tue, 09 Jan 2024 10:18:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704824315; x=1705429115; h=content-transfer-encoding:content-disposition:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KzzgvE0gIC11hFErVwmkGJExGtvPilC4PjYEKFATcqE=; b=hTYtnjeqc3QyE1mUGldHDLhxPGP7gj3zOmeK+AvRga8w2rilIuTDgK/9P0b5i/21OB BliztKwBmXXo2ZE+21tMfG7+jKaMmHK2wGFi08vdIy+VYemBDSRzj+4d7Bq/+jmxvtqM MOD4GXQkAIxbJ0CUrqAKZaT+7ijqBLNGG6cPdUssF6fP01fsB+0GdgLuKqThBQFi3sDk 7nPZ+rQZ9puabBGjs1cGKj3qleMvSWPyuwpNfuSLRv1JnhAB6phsdLePLu6Deo52R5Ao OxB9oR73Jj5dE6VC0IcLbNaEP7QzicGcdiNMMDusy5iwI3XUELiEPPxWondIsiL73Z1h ialg== X-Gm-Message-State: AOJu0YyWyBYg2JUuxdz6HdlyE22bA3EhI5p6xVCY9Ch29FEcu3ohwVa6 bpbx/YZ5ocZoE3l21OwaSoIMbubbHCC51NX+uiHV9HiY/Nh777o320R8w8KDtA+YducFMNlGOYs TWcf8n8gOYPU/QMic1BU= X-Received: by 2002:a17:903:228f:b0:1d5:6cd7:6d41 with SMTP id b15-20020a170903228f00b001d56cd76d41mr115968plh.86.1704824315322; Tue, 09 Jan 2024 10:18:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IEYBvNo74Agm9CQkIKURXpO44BHS1rks1II+1CfrivxQ/3t8wFldRXmijXd1pjefSzIYwyH3g== X-Received: by 2002:a17:903:228f:b0:1d5:6cd7:6d41 with SMTP id b15-20020a170903228f00b001d56cd76d41mr115943plh.86.1704824314978; Tue, 09 Jan 2024 10:18:34 -0800 (PST) Received: from LeoBras.redhat.com ([2804:1b3:a803:26a5:3f32:e12b:5335:3c2d]) by smtp.gmail.com with ESMTPSA id iy4-20020a170903130400b001d3eaab64a3sm2086232plb.219.2024.01.09.10.18.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 10:18:34 -0800 (PST) From: Leonardo Bras To: Arnd Bergmann Cc: Leonardo Bras , Catalin Marinas , Will Deacon , "Eric W. Biederman" , Kees Cook , Oleg Nesterov , Mark Brown , Mark Rutland , Steven Rostedt , Guo Hui , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] arm64: remove unnecessary ifdefs around is_compat_task() Date: Tue, 9 Jan 2024 15:18:28 -0300 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: <2f2e8df4-d8bb-4eff-8e70-0ac38736bd74@app.fastmail.com> References: <20240108174330.472996-2-leobras@redhat.com> <2f2e8df4-d8bb-4eff-8e70-0ac38736bd74@app.fastmail.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 31AE2160007 X-Stat-Signature: iednbcfmrbz3msfof9shk7iepn381fuo X-Rspam-User: X-HE-Tag: 1704824318-947227 X-HE-Meta: U2FsdGVkX1/qPe10rpBNjhS+nIr5rI0c+9W53JMKqVXtAq+qnkOHNJoeykJ2SugWjGTIM1Asp+t62sVTeHfEzH42KbK7BqQ8nsOTrd0TGXD5lJ3tS+AxWb1kJjACM/EWHVx8xgM1BSaHVyrnlyTJWY3mI05z0Y+nbDXiBdNXdsjWW0IEHJSYkLbAdJ4aS186dQo6eSlU5JIASLFbRPjFTDA755yWKNaMql2LmFAC7m6XKjbmud5sqL/tgoaXuSVsqCQgAk7t6bfXMOGQedgfXo7ZknTt03rSSj6Jfqm+p5HOSmoGIYlNRGphrdgrV/aXulJB54yD7vbooek85SjkrAHhdcADHQtzy+MJnkjmIVmqKbx7nUT8MveloTKwVveDU+J+8XRvXyzkdek3iuTmBGYRTT2gsTzUT76TjHOR05VHLc9oWFdwdnBDZmuuYJUtMouhkS4Icelcw8eV7ba0L6kLhRcz1wh5b6643P4Cpq/9uv4FdLB2ugFqpCPXZVbTfouRofLl/jc5Ztnlj8g51Cuj8MOypnKgd1WdpskkcTeavvyqtmJ7Z8zbndZT46jVQeJRlvkRNBxo/NeKgVe03FyI7QjAR4Uq03SDzMnyoEETPet/LZRD1NqQfiX34eJKMDicEs/2yf9WW/ODzMU7TaUmSLVsHlBE+iRkHVQTNspMdWgswqhBP/BcnTd03zrIoFia67b/xg+BQ8mjLASBzN18bXK01Xl/KBVtlVQbIxjq/yBoI3oRJdXNeMTiqMSp2o8wMyhvXnQ/U68KsVXmULX6x/PSOxohhbCTbC6UC9i2x8wujkw2Vg0jCthyHwTWOQJlarnfxfOZQKyR+NReHy9UnBfXoRka64dbS9W2MJ9830IgsVCssk/j9YkgBNStDrdc2ebYMIej8i+JQliH4kx7TlM6iJfvU97DNqbnq9At5IFa/g+JdkFKAPuEJoGM1P9d6I98n6cpNlDPcZN FRGZ2H+M ubHpVBE5500vMkVeVSBwUkpPUmX//mm6x1/BDih3UgIVk0y/bp3dg2S5oTm5AVtDGYJtE8N2OrfnMrUL42yratbynsFZGiLjP8XwfbRlaCebh9opTR3SXAE2UjIMf/oWh9HbNyIoPMh9DDjGB2CRcT1LvMXzdrQtcq23yV+uSP/sEqNVCm2qlqWlbGwXbpUzkzaPWwKwPyo/ZISvptb/u0QLxj+k+sgO6DPpmrAIRfLiMJ/ZF5xXLqwdlvD7ZQgeRbp9QrZcuaQMu2BM0w5KE+LRCsKoVx2G5BGI8U6Ru2HQL0tXP8QnBCOtFIYO1K+Pashr9G6iXiI6xtGwT24g+iCe0jMVy8H4bJggU/GrlUsDEE+pm6yy5HrQ6dINrcYg/IsvBnstuFMXICnRl9ad74kduXMmXm3GOkRTlDyigmlG+Dpe3NBcrO30+PGN80bVm0RXGoJhpr5YEPzH4FMYiuvaMjXLm4y8/+7BEzElzBV3HX8lfgxzv3siLhy+nlw9oyACQ8jMa5Eqfp+Wvhb/UF6PfTx5UqUJLPHCoMTudJBZvWC9vNZsy+ieCLA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 09, 2024 at 07:18:46AM +0100, Arnd Bergmann wrote: > On Mon, Jan 8, 2024, at 18:43, Leonardo Bras wrote: > > Currently some parts of the codebase will test for CONFIG_COMPAT before > > testing is_compat_task(). > > > > is_compat_task() is a inlined function only present on CONFIG_COMPAT. > > On the other hand, for !CONFIG_COMPAT, we have in linux/compat.h: > > > > #define is_compat_task() (0) > > > > Since we have this define available in every usage of is_compat_task() for > > !CONFIG_COMPAT, it's unnecessary to keep the ifdefs, since the compiler is > > smart enough to optimize-out those snippets on CONFIG_COMPAT=n > > > > This requires some regset code as well as a few other defines to be made > > available on !CONFIG_COMPAT, so some symbols can get resolved before > > getting optimized-out. > > > > Signed-off-by: Leonardo Bras > > --- > > Changes since v1: > > - Move some regset code and other defines outside of CONFIG_COMPAT > > - Closes: > > https://lore.kernel.org/oe-kbuild-all/202401061219.Y2LD7LTx-lkp@intel.com/ > > Link: > > https://lore.kernel.org/all/20240105041458.126602-3-leobras@redhat.com/ > > Looks good to me, and did not cause any regressions in an overnight > randconfig build loop. > > Reviewed-by: Arnd Bergmann > Thanks! Leo