From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 864E1C4707B for ; Thu, 11 Jan 2024 09:02:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 02BB56B0092; Thu, 11 Jan 2024 04:02:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F1E876B0093; Thu, 11 Jan 2024 04:02:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE5556B0095; Thu, 11 Jan 2024 04:02:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CBD626B0092 for ; Thu, 11 Jan 2024 04:02:25 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A052E1C168D for ; Thu, 11 Jan 2024 09:02:25 +0000 (UTC) X-FDA: 81666439050.14.B36042F Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by imf24.hostedemail.com (Postfix) with ESMTP id DC110180043 for ; Thu, 11 Jan 2024 09:02:20 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=1fug3d6a; spf=pass (imf24.hostedemail.com: domain of david@fromorbit.com designates 209.85.215.182 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704963741; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+g8rx/Js9kR9z/v7+Mn1kTVZXJSN4sbVOGbBgK7rO7Y=; b=IfnWwCRs/cygBIjzxNyrTd5nKjjoaRCECspyxP+j8stfjU/TyLWPnYUo2op2yqLrwpzmxJ rs/7QNEkh8tVJamTDSePxo5o92jy24Unar0+78stIsnI3kwS2Japp6tPkqjoeujgd/ys8U ze61iG6JLyQS+YlDRxAXIctlGm4iUxU= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=1fug3d6a; spf=pass (imf24.hostedemail.com: domain of david@fromorbit.com designates 209.85.215.182 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704963741; a=rsa-sha256; cv=none; b=RS5QMnVIMj834+mFFhUYFVpVVpH8s1e8Ir7XjCmX9I9DhpGf/ShteiAoz5ZhhhxsGzusl9 l7UilJoJEby7vRB/5oT2wLGNIKFYBWtreoNe6DZuDiqPc/cQShJALbuBcvoanD9LsXf0N3 j6mjI2uMYlUhADAQNf0HlPAZmgGEIpE= Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-5cda3e35b26so1950462a12.1 for ; Thu, 11 Jan 2024 01:02:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1704963739; x=1705568539; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+g8rx/Js9kR9z/v7+Mn1kTVZXJSN4sbVOGbBgK7rO7Y=; b=1fug3d6aOnU+fy8tAt04Y635QL/dr+rABT/exU1jq+FKLRIpTPrGkdlW4z41WwWKxH q8Tld6W7LC7bE7nwSH2p0N+Lf6Yt4j7718uWwOUfYCye7X6lvheMsUs1fn/wi4u8P9op KXKKPNRdMhLzXP63NyiLIkQk6khqWIHW9O2FzMMX5SNkW4mRwd6sUwkLuEQOWSdUajOi 2bHLJ5/zp3M96hzZ7nz1Onmo71IHuDBL/DwTEVzUI8bgLuRL1gHbIDEatOmMXQrhh+vm aPDu3vE7OkGepZ9/NTK0Joqgry0gE8X4oLvCw78D1sbYDBggjX4cVjpok/u2A/4+mEea A6cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704963739; x=1705568539; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+g8rx/Js9kR9z/v7+Mn1kTVZXJSN4sbVOGbBgK7rO7Y=; b=w2u9RE4mrdiqZqipUiN1+cVGRxn4KRCJoZ8ADGbKDZktVOLqQgDSnIhhJtgvmf9GeL BwgbiZOwBlHrlMJUXozom77N83sFg+ZLqVsoACC7ncCzfccmBFKVCHWO04xL6gawnrVq 7+aqzONJ6xiQlauHiPIpEnI5k5EkkQ8/UOhs7lSIA7+Pjhs7EfDe17b2awzwlO7MieNr QS+f+27nsbjgCHrCNkgPD4xuk0bmwKNnbJxupZW9HFwY/09pqpYpFCnH3wSeXKAp6FUt th+ha5mfvzA1871lOBdlz+Ke3WDZ+xug2s8EcfkC5YLALQuXGbuOvTO1rZwokB+WzsAI XpRQ== X-Gm-Message-State: AOJu0YwRX2Z1NOa6GQAtNsdxvoCE2hNZJ6ZpyuE0jqqAFAexTPfB6g8J XeJdG7E9yTx2Ac1G+jmM5ZQwDP32/hqJM0WMGp3zno3LSU8= X-Google-Smtp-Source: AGHT+IG1anub9IXtnzE0NkJV8/hkigke48pXyoI6NhvhVXOStVvkDJD/vNcvk7XrJv0ekhWe9d6Eug== X-Received: by 2002:a17:90a:df03:b0:28c:8eb9:3029 with SMTP id gp3-20020a17090adf0300b0028c8eb93029mr692801pjb.50.1704963739586; Thu, 11 Jan 2024 01:02:19 -0800 (PST) Received: from dread.disaster.area (pa49-180-249-6.pa.nsw.optusnet.com.au. [49.180.249.6]) by smtp.gmail.com with ESMTPSA id sb8-20020a17090b50c800b0028be1050020sm3144238pjb.29.2024.01.11.01.02.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 01:02:19 -0800 (PST) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1rNqx6-008svE-12; Thu, 11 Jan 2024 20:02:16 +1100 Date: Thu, 11 Jan 2024 20:02:16 +1100 From: Dave Chinner To: "Uladzislau Rezki (Sony)" Cc: linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko Subject: Re: [PATCH v3 07/11] mm: vmalloc: Offload free_vmap_area_lock lock Message-ID: References: <20240102184633.748113-1-urezki@gmail.com> <20240102184633.748113-8-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240102184633.748113-8-urezki@gmail.com> X-Rspamd-Queue-Id: DC110180043 X-Rspam-User: X-Stat-Signature: xs3st4bruaqssdbx7q91aqf1hszhgedi X-Rspamd-Server: rspam01 X-HE-Tag: 1704963740-26528 X-HE-Meta: U2FsdGVkX19gnIemFy1xvhXjn6h8RmVGqHYJ/881CffIuwxLCF5KCSwxnU6IrW5Maf25asHE7VAsgk38mi1POQuGHgBUZ757DR0qn7Hz9WGEDYhrFovxbKio+bZ4DF05/xEI4lmHiBr1EbXpQ+4UxJZapIMpblr0hq1hx9M8nM3VUliauakaqmM+oX5xfthEDsTxjldCo0gdSPaiBdE2Q1OrD0J1yDkJ1WweyOBnVvZ8RFfvFUt0rlI0a4TxyW2YB2Ol7wXynq/ypgiPT3O+NOF2jZXbm2WaTrb0+CW/wyQzWIEhsfFYJJ5UsSHnHSzFjvC6l6LvzCkK/jbVbnXsinYKrvVeDsiQMLphEiNnGhcC9pimtjhpdMDYzFj3a/1zg5A9tUz5lDQsOgnqbx1yTaOeGo95fZHMJti1zm1m1ewIFLp7qLN/gcxogNIiOIKUeJjrlBiZA3glG5nHTaQGL3oW8Kdor2UYvbC3h1Hh3pLmmAl/pRld2KBH8hwFYQPJ2N/kghpyjT+Pirb9XyLGFxZWxhlOAUTGTlyN+wgf/WaUSJambh1WrtvGaBKfOqDbZM5NmGAHTXwzBcFYqLbwVrl+r5ykiPOU3iCTnL6fV8vplhLFtGpSLCIGbZd7omLCU5QiVMZ5yrLFm0/j77Nu/sCqZRZ+Lr6vOCJ/LLwMH40xIoNtSxbEkIJJmBf8TznSqdCaRuD+gpMHB2v9mOlq4IRzGF5WdlM31VmGZmCEtEbDeePtixrogcNuIe0f0JUg8phFsO6SLInT79jgl7cLdTjlQ1yO61ljK2pejNzj9/siRBMQS6YTF0ux1bzFz6Pxm1ZylPfV6BW8xzYdCnATd8IjIg84TCPeJrSkFwueBKgKDVG5yMAqP/zX5NGSBiIMFi5NL6tvzrnJh35yQNmYuR1DSHJOfZxtomM30BE7CkyJUZ8ea4QrLFbPoKazSBArPPpYmJYJbYQFCbxwKm3 SQ3JFhxn nFsVSRiA5Sy9bIJLIvZNXhPcgNFElG5YSasorvMZs/5pFgAVP17MCL/PpZOmyjo1dgtODHkVLhVG9SZKGeBTtXnfxtEn5N6AafWGGRnI3K9A4SgveWpW8ejkKC0QQn0ZD8UAV61ddQCYbjf88aTZnXGXBWhYynCNuqdH0hPZkrPEv6wENarMN5/LxhNRJZU4D7KqpzLwjBL0cO/IenTehnwsm4ohp9zIAN9HVH3xCiNUZg8+GPXS1BOrQCiLDgUL/GB911zn8P8a+bXaMDNQ3tVOr/O4enm/Py68YgNk5uZH96xtCkcLkaJ7H50CIlPuiiOTLbBu1Qrn8H3oC8zohQ0e5goWAK+yoBaodgspts6b1YwMe1hLbAk6+DIcI9D7nq1fEuSlOmL98nf2Pt5xJ6NH9vHwNepXCq68mkXsFzK+KVszxXQHcEva+g2Y8qbp8KGScIf+6AFmEIBppz6g17h0NZZWDnh+1P63/HnJ00ns1U41oidkuEj/u+YKX+ZHEyk/uD6q/Pb1nVYauSP8KifPfPmd4KVuhLSJDarPrU9JraiIwgdsYVGeWDbjRlCmk8oxEgX+Eeb3hs5dSmvnB8zYObA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 02, 2024 at 07:46:29PM +0100, Uladzislau Rezki (Sony) wrote: > Concurrent access to a global vmap space is a bottle-neck. > We can simulate a high contention by running a vmalloc test > suite. > > To address it, introduce an effective vmap node logic. Each > node behaves as independent entity. When a node is accessed > it serves a request directly(if possible) from its pool. > > This model has a size based pool for requests, i.e. pools are > serialized and populated based on object size and real demand. > A maximum object size that pool can handle is set to 256 pages. > > This technique reduces a pressure on the global vmap lock. > > Signed-off-by: Uladzislau Rezki (Sony) Why not use a llist for this? That gets rid of the need for a new pool_lock altogether... Cheers, Dave. -- Dave Chinner david@fromorbit.com