From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0ED3C47258 for ; Thu, 11 Jan 2024 14:39:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 640CA6B0075; Thu, 11 Jan 2024 09:39:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EF856B00A0; Thu, 11 Jan 2024 09:39:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DE226B007E; Thu, 11 Jan 2024 09:39:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 35F916B00A0 for ; Thu, 11 Jan 2024 09:39:34 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 08FEE40BB5 for ; Thu, 11 Jan 2024 14:39:34 +0000 (UTC) X-FDA: 81667288668.11.247EAE8 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id 5A9E21C000F for ; Thu, 11 Jan 2024 14:39:32 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=UxZKmTe0; dmarc=none; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704983972; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eyV353Gb3rs9D7r5JzxpgJQ7hyZY60SX+2ttc0hiYio=; b=BrIKHsRAQIKFR8DOUUZZFttKU8zdesweOV0wGVtw53b818WS8QLuus7ZtoJvYYNTl+3MYS a7VYLiSmdEd4b3mr5PYrED1xGaVtWBxd80xUonlPEghO8Q9p3mP4tFtmAuW/6z4+bjXHDD VOuMcv/47/fjJ6Ya0KrDUSfl5Gvak+4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=UxZKmTe0; dmarc=none; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704983972; a=rsa-sha256; cv=none; b=eQ0jGoN1M7ONdL0Pz4yLblOrbYPuLHFVdFDooNX2s/AHxZYZNqO/DQYLbH4LDDQ4ZbzJ5H HTKymQjjlEzgwRmXXP2NsFdy7ykV7jyN4gx0qu8R8ySpyb8xL2zozbNysE4bE8oX74cpFs shdKqk7svn3qIyNKpoxma1T9KQO359o= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=eyV353Gb3rs9D7r5JzxpgJQ7hyZY60SX+2ttc0hiYio=; b=UxZKmTe0o39V6jtqPpN1r++qn3 QvmHm8Z1fGYtYLQxLwJ1Yj9QpZjZCZQ0yG0Z7LzIMIuSspNBLa85Yk5Lw37IxZpJ5UsyUFtBRfocT Qi7VYvAgzO8A7QLvICl7VjBMo7x8dZOgdrpPtor6oittNSXMmRwNpTYvn2IItMK+9YLwHV1tJZGcH KHcoc9nuhGm8RelzJv81LEruaIvmY2arDd8YdoO3tmQD/wXMAR6CYActZpOXPUuQy+vXfDezqUj5G glEM2QQknqRd1YyCNmzZyksp74mbcFuLYU+Y/rc1U1WqFqIQ1bzq+33kR4LNWkCITZV2A4Ecmv5jc DNcyKaGA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rNwDP-00E3bj-Rz; Thu, 11 Jan 2024 14:39:27 +0000 Date: Thu, 11 Jan 2024 14:39:27 +0000 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , linux-mm@kvack.org, david@redhat.com, linux-s390@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH v2 1/8] mm: swap: introduce pfn_swap_entry_to_folio() Message-ID: References: <20240111111239.2453282-1-wangkefeng.wang@huawei.com> <20240111111239.2453282-2-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 5A9E21C000F X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 1z35xdnyyi84r8g3ndwxjobh7bt67g3y X-HE-Tag: 1704983972-165085 X-HE-Meta: U2FsdGVkX19XyP77m7gXsIkrd9M13Xg2ai/zC3JYCt77TnREq+9Y8f2QFv3WWx17w9qSlmyVncGnJwNqoIR7JGDaIonT4FJGup32hQdBSlZOgaexqMbjNnOKHI8UMpWQYgXcq+nMobXtGisLX2yUnP6AHXkhNpPkhCovGJvEYSRnG5ap4jRMSTLiA3bA0jHpBfXUoXSqg1gRtEFu/d5HLzxPSc/RDPMztEl6qLqusCge3dpcWDOAO553xehpmVZOyp2DZSsIepHem7OKZpMVHVVf810xvRjy6NZG47XeoW1qmog7+IMbg42/KJTFMaDnSYQOMh8jAZ3WORX9BWcvmd/57JwjyfDrpShi7IkkzV5WwP5Y/cHCu2UiKPGYry4E0P4sKNXVgAtOc9XFFzbnjLmlIr/Lv16bZkCH7QXy8PB5TOxtg2LwtEn6+Qhsg9d9VTu9GlNhKUu2Tn/PNsqU3nsNKB96jroIkDuZH6PQ/x4e23kYnq+R/fTVSIj8Vk6g4v+J9zBlcyM4MXkWMTPsizAINBXGoEuR+Hwk1e/RFg1dRRvMwOFUe8Lx2JUIWEzwO8qygEB/H//kHlZ/bxHQ1UAxMpIVnFHI+b2ofmF5pOIZL8KbPQaUev7XHQR50EoEgbiGjZaSFOMmAv630cROImpUYSWV0EFJ9TpozJTLRDx9fqwf4pEzpBiyggJSvhe6tp5x7jwfjnv7B8ER7t48FNLNBOFvcGXCMlJQGEcdtCtrqjNHoAN2OCbyypasUTOp3UbtAhSRnsMsU8Q4i5WO0PZccxFjdIJrW5+6DiwXZFM/lM7G5Kzr3sZ6DctaESYQ1+LK4i+oIhRuIBPk4qw5xA3FJnoGTGFRP9xr4SNAW4pJtUNRogM6ZKebBg5fEB8Ts4WgPYP84iyhNgJngcG31+rZtKvcvEc5FItlrtlu01yUITorXE7z4q756YMQqOV/qC64LEEjHyHRqQfTMCB RU/9mrCl wZAt1tG0oQUzoxWmWR1PS6XmR1XuJsHInhEABu0H3QJ8erZ1OL/e+G90JnviPhodWagPEsiaiw9RC8/rJdGHnOEj+QiR83bhegCSvO8aag3IpNPEpsF282muZSXECFc2HCzH1YuRc7vELj3jUaMBCz7SoX3EII0boVQrJOgeMz/z8eh6Ygb2H4c/6npxsCnYZnI/Eh8l4PgX/ypyrkoU9IZhoLTYPBIWKwInpZG4kXtNTv3qIvb0rVnvGmJk7igX681vVQkjLxAD3OXQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 11, 2024 at 02:37:41PM +0000, Matthew Wilcox wrote: > On Thu, Jan 11, 2024 at 07:12:32PM +0800, Kefeng Wang wrote: > > Introduce a new pfn_swap_entry_to_folio(), it is similar to > > pfn_swap_entry_to_page(), but return a folio, which allow us > > to completely replace the struct page variables with struct > > folio variables. > > I have the exact same patch in my tree except I called it > pfn_swap_entry_folio(). I also noted: > > Thanks to the compound_head() hidden inside PageLocked(), this saves a > call to compound_head() over calling page_folio(pfn_swap_entry_to_page()) > > > Signed-off-by: Kefeng Wang > > Reviewed-by: Matthew Wilcox (Oracle) Oh, and I converted a couple of callers ... migration_entry_wait_on_locked and change_huge_pmd. Those should probably be added to this patch.