From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9B0DC47077 for ; Thu, 11 Jan 2024 14:37:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F97C6B0092; Thu, 11 Jan 2024 09:37:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A9056B0093; Thu, 11 Jan 2024 09:37:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 049C46B00A1; Thu, 11 Jan 2024 09:37:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E26336B0092 for ; Thu, 11 Jan 2024 09:37:54 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B86151A0C9C for ; Thu, 11 Jan 2024 14:37:54 +0000 (UTC) X-FDA: 81667284468.30.64104FF Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id D9AE016000F for ; Thu, 11 Jan 2024 14:37:50 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=kYTvwOvR; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704983872; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=46hDqLrBU4o+X3RCK6SwhB9WIHISUx+3GZIkcU5jLBc=; b=5uzIW4fKIjlIClk3HFNlfFRMwqq5eiKeSex0nSqtKBPiG12D1lIhWgsD82Der2+U6vyB5A HHcarv1xtUW/+NOzqgv4Hbqgeykks4k2rc1CiO7YoUA65vmKIEuHFQs2b7Is7ouQIhEZ8i Y4OaheDxgAOMEAxpCVyBkvKAbqWrdhA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704983872; a=rsa-sha256; cv=none; b=U532HpNVJhQWq+ZUe8e+jWlkah5XVnPB0fuqptf1xe28IyDXQy8o+AGfECPJmeAlOdTP/y 12DvvnFFOI9FE7jUt2MGhEyGgZGCHWPt/XXw255q0E2q+fbpE/U+o0V10NHD+cnKqUoy9a cnqgXdeSGl6mjm9TAglcL2Xr8Yk41aw= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=kYTvwOvR; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=46hDqLrBU4o+X3RCK6SwhB9WIHISUx+3GZIkcU5jLBc=; b=kYTvwOvRfo/CvjW9j/ib7X2Zdx JiKN2FGwsbNHLtV5fXZNA7ai43GvyJ6c8nZKlRxrR25ggTTeF0RXCZGDuHnR9eTi0iKqLySttryug wzUsjVhlfGINbxqYvMtmP5mPWIOvqt4ulOmQdMOH82/zpAp6+hBRWCrSUinfqOEjSg0sov4durCsr 2IO8urhz82cX6/6CSbGG9eQOy/2GeutnqEaDxtJz/SOIEyiv0KJ+fRGXOR7ePOkQhpz8eHNCMndYA VuKOTpB917pcNrU06Bq7ItazjrA9lq9gI12RPNV8xDLJewbc3RgfF2ewso0lsdYYFk5ZzeTM3C1Mu 4MYT3sEA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rNwBh-00E3Xt-6Q; Thu, 11 Jan 2024 14:37:41 +0000 Date: Thu, 11 Jan 2024 14:37:41 +0000 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , linux-mm@kvack.org, david@redhat.com, linux-s390@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH v2 1/8] mm: swap: introduce pfn_swap_entry_to_folio() Message-ID: References: <20240111111239.2453282-1-wangkefeng.wang@huawei.com> <20240111111239.2453282-2-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240111111239.2453282-2-wangkefeng.wang@huawei.com> X-Rspamd-Queue-Id: D9AE016000F X-Rspam-User: X-Stat-Signature: ptt4qzbsxbbhhrrj6aqbnk83gmi86t3i X-Rspamd-Server: rspam03 X-HE-Tag: 1704983870-16478 X-HE-Meta: U2FsdGVkX18wEkB5BzXm2GPXJyfU+563cc2eiWw4X7upk3qlvLEIN/2YF5cN+67FmJ5rVJHipz1hb9h5n56fw+B9w0EcN/A4ePT57dWuOGheH2vtv6EKDOND8VQHEBIJ3MMmaFPnxM+w88+ofb16miOC+geD9vJB3HiRL3nsoW5X0jPSxoltmYfQR7KEx3wEMv/kbqv6QBLpKa1pLJmHJFKFhinkEq9o5plFWCBGf25o+j3qfTTN/wht3Q6y8qAl/fG3ZkNrsUmnL8GbpbHikuwe6/i88VxCIo84TbdnjQgoU7NoFq6kgNyB4I5cGLaWJYVK66GObEIdXYPL9ia7V+YQY6z/C5brztaJ4VO+cBNLYZCx1gV2DTGQQ1e3dJkoHwac/2ceJbsSLeO94K3roYL0r73AOFTn6xNCgoq4+DWYXSeC30tjQkqSVb4RpuU4M/9Qt3fEVAGkUYeMZnxgxQoMljyTRKMn0viNCs1gIm7iCMqMHUbjh1TyajeENQda/COfLBbcPztcf+8dXfNbBHCQkTBa7DTkxgOv6zgMu6HjI3CwEYhjP7cpqHq+ASaeB2v9QRzui7fGfAXhutroCSqICj9sodNbPaEP57L9wqmO1HNPoGcFjLELBQ8ZPyQSxkXd4Dp9xAByg6GOFW6+/nLG1f4njqPBFB88ewQrKkuCsKZJodRQ0z0RQ4GAB9cNbzQVh46pSFUXFRZspetIrMS925zcIpry2kwzSyRYNJBl8gXN/40svX/ZnLRIurGIjEe7AXeK/4l6XOIIyZNa1opippgRbiohjXx983Af5aGg6+3W3OTnZ1Pt0xBpPLQ+fNRGBxNnXshqQQzSm4wlrcc/RDKzrshy1XkzyM+Dn4h0Kv0snsqd1pG+Lg5tBT99B02CH02ERlV7RFrMvnx+XwWzkrLTbeWgLjzTNHDAv2AHfCHnSLxAJqZm7j23IXLhntSEaAgM8iS8SQoPXif fsUmH2Un qug//M/hO+E9+bqIc+8EtDVEoewnVu3Ztj7X7uIWZJx8544TRj5e/4WelvYpJI3u0gKwoDLPsWxMFGUnqKJFFUgwy78aQCim+YFXHyour9mWHvrSEaBibKfxZGdyF7Qy36KzRynbbq48Q6N7+YWlJ6wQNiDRdhZSwM6rWZZz6NOy4BxY1m9ly91qsQz6thWjaN/VaqdsO9IhyLxtzLpW2Vjvz88DSueJ/6ISUKqtJzLJtZBBObF5WFwV0YtICYVwvyyYf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 11, 2024 at 07:12:32PM +0800, Kefeng Wang wrote: > Introduce a new pfn_swap_entry_to_folio(), it is similar to > pfn_swap_entry_to_page(), but return a folio, which allow us > to completely replace the struct page variables with struct > folio variables. I have the exact same patch in my tree except I called it pfn_swap_entry_folio(). I also noted: Thanks to the compound_head() hidden inside PageLocked(), this saves a call to compound_head() over calling page_folio(pfn_swap_entry_to_page()) > Signed-off-by: Kefeng Wang Reviewed-by: Matthew Wilcox (Oracle)