From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 999BAC3DA6E for ; Mon, 25 Dec 2023 15:42:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E87AC6B007B; Mon, 25 Dec 2023 10:42:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E37BE6B007D; Mon, 25 Dec 2023 10:42:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D26666B007E; Mon, 25 Dec 2023 10:42:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C32646B007B for ; Mon, 25 Dec 2023 10:42:33 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9B86D8038A for ; Mon, 25 Dec 2023 15:42:33 +0000 (UTC) X-FDA: 81605757786.22.366F4B0 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id E84EA160019 for ; Mon, 25 Dec 2023 15:42:29 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ArDZfHgm; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703518952; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yfsKP9bIoO8NvpKIkLPbcIhRdzO+flqkLdSJDquLXy8=; b=0y5u5DQkCuQiLXnlkdQ3JAGyW3ffBTZV2Oy9wIpnAQUsiixXQEgDEJBcLvNoPL8jQXGRZo t63JA7MafBFSkXg/V6etE3RTmTmoahRvD1ZsOFo8c9pdnzO5dhYvpUI1Frzhbb89AR+oyN ye0qnEsbY43WMq1DYEdsHan18SpAUSc= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ArDZfHgm; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703518952; a=rsa-sha256; cv=none; b=KqKRjsrYOdbacy/qSJT1YsvZN8UUymFOlZfMAcinRNu4vlprX4jQrfEfCPDYkOSXWQ1CNM VB/HifYlp/lPsXx2jwtfbNJw9s8eB+yfvEv0SBFHqSUzdXEmS8EjOd1iThjQfys2KXlLbF QaUxjiEAN+h2/l2zbbZOGzMZ6hLUoco= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=yfsKP9bIoO8NvpKIkLPbcIhRdzO+flqkLdSJDquLXy8=; b=ArDZfHgm9NpwhpmuBY0DyuZTCr WXWDp+yexk2QHiIYRKXyILgsMsnGit+sw+bIMtRbyxEuoUv49jtE9FI8HTlMcXOLx+QVMzSA/eYrb IvILvCEvaIYoS1NV5qR25qWofarizrqOydBNUAoLQkoMZ1T2AXJsk4tApgNxIaQFjboNLLNi6APj8 PMBB60TdoW7qDQHpy5ptZsaF3T+eQXILKoJkkeZxSGt//3KNplRhujzEsEsjDqTESXOdfsKZed4xm EHo6GtVpwG5JXbDSNc0bfpYZ/DEQLo56+zdt2b96rjfDJeAyrt8WCDdos+FZCOCIHG3pYr72Hehu5 jRA+h5lw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rHn5o-00GDb6-6W; Mon, 25 Dec 2023 15:42:12 +0000 Date: Mon, 25 Dec 2023 15:42:12 +0000 From: Matthew Wilcox To: Yu Zhao Cc: Kairui Song , linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, Suren Baghdasaryan Subject: Re: [PATCH 3/3] mm, lru_gen: try to prefetch next page when canning LRU Message-ID: References: <20231222102255.56993-1-ryncsn@gmail.com> <20231222102255.56993-4-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: E84EA160019 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: ea6xmsk4rg15rxrcgaq8p8mxtnaukd4a X-HE-Tag: 1703518949-3133 X-HE-Meta: U2FsdGVkX18m7NfaDo/fhrw0NTK22gXfJCbGBgTMZH72vbcuwG3oEaEbWO5ADXb83T/aM5hyJHGge/QugoHzJkR6/H6/Y8sQulRy/98/yNklIFHETFf/dUbgw+LrowCBgXVZS2PffBmzyAqZxaKRwp3AToFIW5VsEuTUC7/y2+wfWmYo1RdVVfqJP/hzOjGwdpaSvRj3sVSAuq1YGzDHmTdNaqyzt7e0/uSgQCm8F9jZlBme4mHshqw2o/sltQyJEVIe0vzg1tvGed+K8P1BcXOXti9zolkxirvcWP5xqyy7VwSLvLRdGWaxLrCBVXU6qLrdmb87pIBV949q8+GLa5s0sG3+iJybSKp5wG92fls/giU0VKCDJtZF2HV3K9OCJYjSVy83TzMZXkpBhbTVDVEptAFux63cc7Yq7c0ieHn6lmmV29PWn8nUSJ093HnTA8kNuJN0YksGf1taOP0v9ckmm9OKSem2D+e7WITTnwjitPvghCqLHTXLko84foHKPEhwP5vWKYHYD5B9CyfP28WZEXyy5Y/rsviiKqzE+elF0NXqpC6LO0hF0ZnVQACFW+c1PsRX8uFrGrDhYds8eu10nMHvjQMKHKK3kSF+mUVQeRskOULMVHL3oUOMS8jHXN/gF1Hyc0icEG4czS3+ofaPVTf5ZzzspK4ScJBK6utSKfa3u6wtFDN61qX2zRo3hP2/6oTxwXnVLHxXydSOr1cgxtYkJYtSEJ+GpDxHtBiF2U9q9X8leUk76f6NTeMTkzlUm+D/DBI8uUDiT0v8ucyFizFEN9ODZXLTkO4E9+u91MH/7qb8RQegJ+maUdixtnYHju+ovCYufw+s6qk98EQmo21ghMG1a3KhC4Z6aENZMSjA5QiJocpbyZ6nrAuA9r3k3ux1oHcl8tJUU4iLxdITtro5M59x/MBLFCDioqRglOZ6uFYl/JUpusGAiz44g+cDhSeExNsj6r++e+P 1HfK3EHO G50OQjL1PbWiQu9faKvze/cXwY7X5LvI4lUXVz2ock7fkQ6wsjgU7s2VLB0EE6yV0voIn/uq0JOX6f/Jr+hjW4QOh6sGJnfmlveIGamqZXIcRgQDlgkpQcAExy+LuCzHXHqxSL9wYNIkkpfh7m21GeA/gbIItru/lHNGf3Miq7eytsVUbiq/20Gp5vAVKkPKYHVWhe/AzaKubl5g1K1OQQ0WoKob6QK30TG6x4ShMhsraFXiDilixHiDmLo+wb3rZBQfD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Dec 24, 2023 at 11:41:31PM -0700, Yu Zhao wrote: > On Fri, Dec 22, 2023 at 3:24 AM Kairui Song wrote: > > > > From: Kairui Song > > > > Prefetch for inactive/active LRU have been long exiting, apply the same > > optimization for MGLRU. > > I seriously doubt that prefetch helps in this case. > > Willy, any thoughts on this? Thanks. It _might_ ... highly depends on microarchitecture. My experience is that it offers more benefit on AMD than on Intel, but that experience is several generations out of date and it may just not be applicable to modern AMD. It's probably more effective on ARM Cortex A cores than on ARM Cortex X cores ... maybe we can get someone from Android (Suren?) to do some testing?