From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07B28C46CD4 for ; Sat, 23 Dec 2023 03:31:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 728AA6B007D; Fri, 22 Dec 2023 22:31:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D83C6B007E; Fri, 22 Dec 2023 22:31:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A0516B0080; Fri, 22 Dec 2023 22:31:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4BA5E6B007D for ; Fri, 22 Dec 2023 22:31:00 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1DA161C1250 for ; Sat, 23 Dec 2023 03:31:00 +0000 (UTC) X-FDA: 81596656680.09.45325BA Received: from mail-il1-f175.google.com (mail-il1-f175.google.com [209.85.166.175]) by imf11.hostedemail.com (Postfix) with ESMTP id 5589040014 for ; Sat, 23 Dec 2023 03:30:57 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=C2QGJxuD; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of yuzhao@google.com designates 209.85.166.175 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703302257; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mKUKzM+6ifcXsunzZjiqCC3leVlDqBJ+JFGnvTMz+AA=; b=mJJiJD4isHAdh0R0DBHP6CAvQZMOMY3fh/jYg71UAdXq+JxFJvG/T474xId/ZEwI1D9XpH H+wzwK6wPi9T3UJTe9TTLoP3rV1uC9d6UGVXewXP9t7neubiyM2ou7O7eBdfseIVA1Qs06 CaSp3jSVRXaPrqEnaA6xf47pj4k7Ph0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=C2QGJxuD; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of yuzhao@google.com designates 209.85.166.175 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703302257; a=rsa-sha256; cv=none; b=SlxBXIoA1dvARcEB5+Lv8VV5LI/EMwc8xwHLU58aCxwQHUd6zi8Xgjmj7GIr3hNCEthR/U +ruG0Nd8XuJ770b4PYs1Jcx4SFxt91Pp6cW5vcO9uDjx8Tv6oAe7GsHtKXbV6GdWr9v2BB 2WfedDV8JF1yxsLgYUogSV6fiL1iL4Y= Received: by mail-il1-f175.google.com with SMTP id e9e14a558f8ab-357d0d15b29so174135ab.1 for ; Fri, 22 Dec 2023 19:30:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1703302256; x=1703907056; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mKUKzM+6ifcXsunzZjiqCC3leVlDqBJ+JFGnvTMz+AA=; b=C2QGJxuDjA43BDGDIoexSGnkT9Lax5xqGnb9Q+p2AOG7CBwtb/fAQYTVum1K0QBDk4 uEFAOW8EXHCBgIlchp5aItkeY8iYhWDed22FAmwj3LRY4yTVO5QN6kfmYKMvOHz5EC7E E9H2Ojn6MTbPGxG2U8A5nPtjJ7CLTXnqD1AfJx+xFgKDHnpuhW+9JMCVXUdG4Hx1tu16 xedhpCm5M9xzPxF1SKBdY58gvSeIV+dXbJqFDeOooZPUvFDNUn8vX3MJzRzJJjOSYe31 8vtgDmobzCEVqE1EiuHsCWjeUK1pK8NrMjaQ3GKz+c/t7nOIDLsNm7sq37IGHuGG2GMG ruYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703302256; x=1703907056; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mKUKzM+6ifcXsunzZjiqCC3leVlDqBJ+JFGnvTMz+AA=; b=miU08UAc1q/UC6JUfmqhLUv5WJZrhemzhH+he5w7Q8JImt/LD7tckO4GcDxHLtG1rw R/a2oU6iQEwCyOhc3tCxwRCNb3iVST7N2liJsZG/KpTAUOpQ54T3pOBRDw7Ty4RM12t8 In5qZsTq7MIj3mehYIX525UNKGcSE8a7UX0dEO/WrKxnHJcMx3GBXSfBFjLBayWH1qNi Mufkw+pnJOnMHhRSCpGjScBg18TuzrxROs+g8qYLvr35YDDsfnhy3g2TjB6SwFCrPjIR cbIKfYmGqJL06/S9JLq9CQeFB/ETc9p110W3tUornxT9/RLarTXSgeWxa0Xxg/+Mnw1b TQ6A== X-Gm-Message-State: AOJu0Yy/Q0aYb2qab66h+HD/CjJ/b2I0TWowmDk0n8U2WdhijiUnc3vL 2vsrp4+8JadQCMPW1CkCs469thpv84dP X-Google-Smtp-Source: AGHT+IGqf8TH2N7OR0ICuaHZpx7wnuWDnl0ZbZwaxvo0ZYgzK8CgNYCVQOn1vsdkFaJssQZO57bSwA== X-Received: by 2002:a92:d28c:0:b0:359:c80d:f75 with SMTP id p12-20020a92d28c000000b00359c80d0f75mr218341ilp.10.1703302256295; Fri, 22 Dec 2023 19:30:56 -0800 (PST) Received: from google.com ([100.64.188.49]) by smtp.gmail.com with ESMTPSA id y21-20020a5e8715000000b007baa4dbcfb4sm482689ioj.0.2023.12.22.19.30.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Dec 2023 19:30:55 -0800 (PST) Date: Fri, 22 Dec 2023 20:30:50 -0700 From: Yu Zhao To: syzbot Cc: akpm@linux-foundation.org, axboe@kernel.dk, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [mm] WARNING in get_pte_pfn Message-ID: References: <000000000000f9ff00060d14c256@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000000000000f9ff00060d14c256@google.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5589040014 X-Stat-Signature: 6ppencxm3bw79hgmj8tzu3wi31zdtsti X-HE-Tag: 1703302257-605176 X-HE-Meta: U2FsdGVkX1+ZxW1LKZ/ZtYVHGqcQ5WNraox1RfWIhBLz2nIPxA7x8JdE3MppRqW8cmp24gC/MqI5t4RwmwZWr5zDmhsWh9P42IZ0B7RYSi9n7dInjH8TmCZ2Snk1kbAH2pQ7s4s+gW2IgSOYqSsX4X5jpbjEkxOYNDqm4HV8wkMJ2WaypqC2KoIrceLLwSCmqLQS+6G1CbcWIwm1XoJ2mTvIPn/fcsuOGwRkNJsMoIVQNNbMLQQBpGIvYzVFjIIRG47AEMjxbLoMK35G4U5fuGB/PRXajh+8AUMI4Ctg+KqxUwajjAKSJRgcnMqatdFQZEsAZ7PYK6P55To9cNYOWh3Ljzi4T0iCxrbV5Z+R/H7aPF5HfGmH+41766FXWFwakba/dqn4386h8JQp4ZrgZ/j9JsaldJc6riWTljrT5ABQkHmM3xXexfpeyjYU02NBVz9C296b41TGN2PM1yJRrk5BPYOBnJn/CRxb44yz69Q9NgK+S+hPE0+UsF5sW6+srPEbM7xvqXpNe7Gr1ognCxjgqJCgNk6O2ImcDlW9sGtBFzAFXs8eRj61iNLwtq5f0f8qNUyQcPKxB2dOj9xreVQYCLmooxAUG7pavV7M5vQFe/EdhRBBc5zjvx3DoOUjW9ol627DwubcaYV9o38deXtv0LpoFQt5SLWCB54xOtJRdVc7ozsgR3T5MBENsrFrn58G+KOnyuI1+QSxzE2GCEcH7tOgYixkNLO5EcbbDgfdolvwhHeF2UfJRDAFmlfOzHwHH4zr0OzmFTl9KAYXQY8ybcTuAy66zEkDZM8LeUl61BA36+fZ15TbbNrzwJyFvFcvqm1w4VezKlyLy+b1kh3t4iNQP68O/Izo/ivkTaxTDtbxM2p/nvtGIPQHwP3+UdCMQ78rhCczQu8Qsni5cQSq0GXnyXuO6+Iwm3pFh6A9YSM/aOW97iW1NNITE1EfSU1oOXCl9H0V/7Q82PX NAHnjkIJ 2HdaYKR0nSH2s9Zd0l8URQRBpYRF5qXS0nVIhWIF1GS0ii+cpmc9SwifKV/ZHcnyS7N9561w8lcQ5r/FuFo6/AwrUfWpOyj07G6WNY0fKIHI62TNsytAx1NwGu9hyQJrQ+hwMc2EMRAxskzXTQKFEA0AFMFw30OTjZihmmetVzPmt8rxTjVSGKDn6FvJxvHUYyFBsEv+Cm8dN7acssyZHiHG8ppXduoFZCySgl/qeH2yzlw2SyVYC2VE94eBCkNqx9rdGWEaNVSDWxeHV7pVVrRve3iEN2gw8nTBJYVLinwPoIHamRwf/6ZKl4M4nlEepVuocXBQXXRD43qPAyFRFh8kjMDo3ZhW/wsLTIor0nIoKJnOVlegrfsB3kdoDiKmcjnxOs/ScQWaVcQT+kCHhKubGfQ36fX1Ru1sJ3y6bd1dHEbTl2L99GsIYd4jcG70tRYpyKcCFt53joz60KT8uejRanppa7YPbsIeNUG2rVVHRCkotrQr0WxrSzz55ZcrVfudrJyEB4Mw3nU2v3MvMNq6Gx5+5AoG9i9fvXotGPCDxrICX3Qo+roo+pQ7Cm6nFj2jqiak9cilv0DxUMVlousFzQG/NJQO3X9xuX0vZACEj8GNAFu4h5KLcwDtupOz7ddo/TYpy1UPGK5FHy10yo7MIIAqxpQN+jpAkG4DkVyqoLDq3uYqTn3jo0Hezzw0l8qie5C+5KdXHNtcrpztd0jjciUpXuHZXem2Zehx2O4rylblHKs79f0PL8FNztxR8xgtLc0EllKn+gzJNTU7fKL9xRnbqsXhwCE2U8gMEogEFfmAlYR/S+ct94daUC4E+fWdDauucg5kyeDP+MM/+t9k8rQLqbwN4TfwssIlfgTQ+mNFR4LFBan/Z0KwlcJ7OJ60uIub5CK5B7z8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 22, 2023 at 12:11:21AM -0800, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit: 0e389834672c Merge tag 'for-6.7-rc5-tag' of git://git.kern.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=1454824ee80000 > kernel config: https://syzkaller.appspot.com/x/.config?x=f21aff374937e60e > dashboard link: https://syzkaller.appspot.com/bug?extid=03fd9b3f71641f0ebf2d > compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40 > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=13b4ef49e80000 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=118314d6e80000 > > Downloadable assets: > disk image: https://storage.googleapis.com/syzbot-assets/e58cd74e152a/disk-0e389834.raw.xz > vmlinux: https://storage.googleapis.com/syzbot-assets/45d17ccb34bc/vmlinux-0e389834.xz > kernel image: https://storage.googleapis.com/syzbot-assets/b9b7105d4e08/bzImage-0e389834.xz > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > Reported-by: syzbot+03fd9b3f71641f0ebf2d@syzkaller.appspotmail.com > > ------------[ cut here ]------------ > WARNING: CPU: 1 PID: 5066 at mm/vmscan.c:3242 get_pte_pfn+0x1b5/0x3f0 mm/vmscan.c:3242 > Modules linked in: > CPU: 1 PID: 5066 Comm: syz-executor668 Not tainted 6.7.0-rc5-syzkaller-00270-g0e389834672c #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/17/2023 > RIP: 0010:get_pte_pfn+0x1b5/0x3f0 mm/vmscan.c:3242 > Code: f3 74 2a e8 6d 78 cb ff 31 ff 48 b8 00 00 00 00 00 00 00 02 48 21 c5 48 89 ee e8 e6 73 cb ff 48 85 ed 74 4e e8 4c 78 cb ff 90 <0f> 0b 90 48 c7 c3 ff ff ff ff e8 3c 78 cb ff 48 b8 00 00 00 00 00 > RSP: 0018:ffffc900041e6878 EFLAGS: 00010293 > RAX: 0000000000000000 RBX: 000000000007891d RCX: ffffffff81bbf6e3 > RDX: ffff88807d813b80 RSI: ffffffff81bbf684 RDI: 0000000000000005 > RBP: 0000000000000000 R08: 0000000000000005 R09: 0000000000000000 > R10: 0000000000000200 R11: 0000000000000003 R12: 0000000000000200 > R13: 1ffff9200083cd0f R14: 0000000000010b21 R15: 0000000020ffc000 > FS: 0000555555f4d480(0000) GS:ffff8880b9900000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 0000000000000000 CR3: 000000005fbfa000 CR4: 0000000000350ef0 > Call Trace: > > lru_gen_look_around+0x70d/0x11a0 mm/vmscan.c:4001 > folio_referenced_one+0x5a2/0xf70 mm/rmap.c:843 > rmap_walk_anon+0x225/0x570 mm/rmap.c:2485 > rmap_walk mm/rmap.c:2562 [inline] > rmap_walk mm/rmap.c:2557 [inline] > folio_referenced+0x28a/0x4b0 mm/rmap.c:960 > folio_check_references mm/vmscan.c:829 [inline] > shrink_folio_list+0x1ace/0x3f00 mm/vmscan.c:1160 > evict_folios+0x6e7/0x1b90 mm/vmscan.c:4499 > try_to_shrink_lruvec+0x638/0xa10 mm/vmscan.c:4704 > lru_gen_shrink_lruvec mm/vmscan.c:4849 [inline] > shrink_lruvec+0x314/0x2990 mm/vmscan.c:5622 > shrink_node_memcgs mm/vmscan.c:5842 [inline] > shrink_node+0x811/0x3710 mm/vmscan.c:5877 > shrink_zones mm/vmscan.c:6116 [inline] > do_try_to_free_pages+0x36c/0x1940 mm/vmscan.c:6178 #syz test diff --git a/mm/vmscan.c b/mm/vmscan.c index 9dd8977de5a2..041f9ad8f95b 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -3230,7 +3230,8 @@ static bool get_next_vma(unsigned long mask, unsigned long size, struct mm_walk return false; } -static unsigned long get_pte_pfn(pte_t pte, struct vm_area_struct *vma, unsigned long addr) +static unsigned long get_pte_pfn(pte_t pte, struct vm_area_struct *vma, unsigned long addr, + struct page *page) { unsigned long pfn = pte_pfn(pte); @@ -3239,8 +3240,14 @@ static unsigned long get_pte_pfn(pte_t pte, struct vm_area_struct *vma, unsigned if (!pte_present(pte) || is_zero_pfn(pfn)) return -1; - if (WARN_ON_ONCE(pte_devmap(pte) || pte_special(pte))) + if (pte_devmap(pte) || pte_special(pte)) { + if (page) + dump_page(page, "get_pte_pfn()"); + dump_vma(vma); + dump_mm(vma->vm_mm); + BUG(); return -1; + } if (WARN_ON_ONCE(!pfn_valid(pfn))) return -1; @@ -3331,7 +3338,7 @@ static bool walk_pte_range(pmd_t *pmd, unsigned long start, unsigned long end, total++; walk->mm_stats[MM_LEAF_TOTAL]++; - pfn = get_pte_pfn(ptent, args->vma, addr); + pfn = get_pte_pfn(ptent, args->vma, addr, NULL); if (pfn == -1) continue; @@ -3998,7 +4005,7 @@ void lru_gen_look_around(struct page_vma_mapped_walk *pvmw) unsigned long pfn; pte_t ptent = ptep_get(pte + i); - pfn = get_pte_pfn(ptent, pvmw->vma, addr); + pfn = get_pte_pfn(ptent, pvmw->vma, addr, pfn_to_page(pvmw->pfn)); if (pfn == -1) continue;