From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BED76C46CD2 for ; Fri, 22 Dec 2023 23:13:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3CD518D0013; Fri, 22 Dec 2023 18:13:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 356528D000D; Fri, 22 Dec 2023 18:13:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F6F18D0013; Fri, 22 Dec 2023 18:13:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0D25D8D000D for ; Fri, 22 Dec 2023 18:13:30 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D448A1A01D6 for ; Fri, 22 Dec 2023 23:13:29 +0000 (UTC) X-FDA: 81596007738.02.D9D271C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP id 0DFC94000C for ; Fri, 22 Dec 2023 23:13:27 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="FCy/EJLX"; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703286808; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d6x4Wv9DQAfYSPylEQlY5yEyrvX/nOJJPXY+ukW5hLY=; b=iBtYss6KJt/Lm/bv54GHuX4UmJFo/456WHxiB+IitFBpSjhcerePTndToAMJL1CjfGNpoP m3AEZ5tvXj1jn976lHkTPYW+1y8zIpeeuedPXuWV1HQVocyHqbcu/9Juf2khboIPfxkGZ3 k4sqbqXSFvK6JZ5XGNatMUIOTO8tblo= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="FCy/EJLX"; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703286808; a=rsa-sha256; cv=none; b=6/5vZIhvvULgHfIaDCEzCSWM3IG+5MfyNluGH2EuuMyG2ghqviT6/lqqYckc6hdarS0XTn OYtfFYWHeiPSACbAV5SjcXkl088k8NVJWszjnV6UrjIqjtl8MSsPJVhWvB8alXcl/rMSp8 CQ+O4bigPnVdFwSCAbNyE5ho9LpZMAo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=d6x4Wv9DQAfYSPylEQlY5yEyrvX/nOJJPXY+ukW5hLY=; b=FCy/EJLXCgKSpjbyNpt+3bK3Z9 w7uAYtqcHwQ8mY0S5R/uqAWXoQnQ6uMESATbRPC/I9UFCShW67+TyK90oxOTvzPxwaf+5b/VpcQbn qJNHf4pqrLjRHB9rVFb2ACUXljdKni5FSbHEreZyIti8xYUP+UT4Pue4MZLaHQLSrYPc6J/iQxUNP nWLPhjZ/wIwgDcnuW7FOvWka9x++umq9LSGbm5CBwQttAql3osxLHWPk+loMgqUIjTXJY/LgXfTL1 stNlhNBMQP3eMkDVUsQ5jC+lytSbAfLfmgTFI3d18H8lZFFUZjAqqWyW52zF+ERRd4tBH2m4yxz7R Tmt0XzlQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rGohn-009FwM-AT; Fri, 22 Dec 2023 23:13:23 +0000 Date: Fri, 22 Dec 2023 23:13:23 +0000 From: Matthew Wilcox To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Andrew Morton , linux-mm@kvack.org, Johannes Weiner , Vlastimil Babka Subject: Re: [PATCH 2/4] slab: Convert __kmalloc_large_node() and free_large_kmalloc() to use folios Message-ID: References: <20231222202807.2135717-1-willy@infradead.org> <20231222202807.2135717-3-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 0DFC94000C X-Rspam-User: X-Stat-Signature: w5wr4zcmd7h4p1ymz91u87cbieo89yuu X-Rspamd-Server: rspam01 X-HE-Tag: 1703286807-226094 X-HE-Meta: U2FsdGVkX19CAbq3ztyO/21GcKkIw/3HHCzUA8OnieHjHHToBHUIFiwAZVXgV6PPM+qCbe5MJEwH8CFVxFtpcm3LFECVtRK1/t0yhJij/nZVJpqXp2ZBGfjYV2VBDJvStor0ZbUzoGe/Gl7almepA5qSDOYgKa2RMd5qpnYOUPwdwIAaY3RpT/2L1M0C0sHbyjg3VnADejkV1/ksmwaIYWriEAle6sdhntEBXfDWMAmZx94vXHTtfsjTDcUQpheEWaIUCSE+lRlBynfmKY/XoNr0mPWdcaS06vTMZqWcZM2NuvBonmOwZ843wJg+6OYcZLl67pg3AiNCUViK2GDZ2qBHlGoxwiisoEW6Rh6sUwsrX6W54MOyq8blpd9pWzTtYgbTXfBTuED/xdg1ixWvAEpaUYijjHiPp8xbZIpgTEvZOKZxkC1H9dhxoAt6JE8dNGaI+fDnbQU2VsU/BQJDNCoujO08AOAn16CaLWsN2p8JjyA9u9hndFu5WIUy3s6QR7pDizkSZkrG9822g7/Iz8tY2eskzmlQNMcANZpufLZJbt1vYiqs4xCvbYoRKRegZfvQoYqo0tvBlQssTyIzlz/k+PPCtsjWXQxO+OSNGftel4l/vJtCrZcL7Uu2Z9p242XIdgbyq5uJbqsr6axbwIsLdUT//hkcssrvfzBuLOdOW77Ur0g6E7wGoKJAmFCmRIHs9QtLXCqgvZW+w+jdzcCE8ZpW8NuVoN0/LGiiMtL8E2byrfKc4L8Mq+k/tB378eULqi7UXi9k7aR2DPTUI1p41VvgqKU04OyyO4MAndvQ77ZLB8W5e0VcFiN0kWlYxwl1t+Qr9GXIa3eV72PrGHAhGOiOlNYlqfyp/ji+hEo6976Vxp6CdoHU5PjVbbO1uMoOND846CGdlx0dY77DxHowDwCpjoBGSFTO+RpwTGzq1hpagh0vUnxZA7vavjo0QU36kdBNffBz2R53Ll6 Dc1tZqNV mPZoKWi6oLO1AQ9DkP+szoiUuMkUN/Iz1dgSpDGijv97U1FnhdWvBFn4w1bwbHPeLKBN2Ar+x0pwgwifrBk14sdVBEvQ1MW1/1U/PApDvNqCAwA0gaYkviCqAtk067193oc2uusd9arlHvF7HFBh8dDrEySPp0rBqydkMCiyhiAmyqIyVjcD3oDWZ9CLYm4jcwG2PzWv25EQdmhVIF50PYZpNMakc/xoRsuxsbo0C9vaU3fPwUCuOcnZNzisWCZ5uqXzH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Dec 23, 2023 at 08:11:11AM +0900, Hyeonggon Yoo wrote: > > - flags |= __GFP_COMP; > > - page = alloc_pages_node(node, flags, order); > > - if (page) { > > - ptr = page_address(page); > > - mod_lruvec_page_state(page, NR_SLAB_UNRECLAIMABLE_B, > > + folio = folio_alloc_node(flags, order, node); > > folio_alloc_node() > ->__folio_alloc_node() > ->__folio_alloc() > ->page_rmappable_folio() > ->folio_prep_large_rmappable() > > I think it's not intentional to call this? Oh, hm, you're right. I withdraw this patch. I need to think about this a little more.