From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 577DFC41535 for ; Fri, 22 Dec 2023 17:14:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D3FDD6B0074; Fri, 22 Dec 2023 12:14:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CEF686B0075; Fri, 22 Dec 2023 12:14:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB7BB6B0078; Fri, 22 Dec 2023 12:14:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A93436B0074 for ; Fri, 22 Dec 2023 12:14:45 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7B985A09D1 for ; Fri, 22 Dec 2023 17:14:45 +0000 (UTC) X-FDA: 81595103730.17.DD26E88 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 49AEF4001A for ; Fri, 22 Dec 2023 17:14:43 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Nmu6Ckh9; spf=pass (imf27.hostedemail.com: domain of leobras@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=leobras@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703265283; a=rsa-sha256; cv=none; b=rh2IPe5khdbVN75KZZ9FCar7cbmK7kP3UdwKSZ6uPrA/mPV29uFpqFQ+MnIaNnidgA/lTm VojQP3yXALyBdgYotAXc9f73ElJ2gm+UT2j4FhtIvhrinHi9pYvz9hCzD1aAAQOCjsGTyy 4F+xqsLrD1hyXxm4vFPElMXy+5Go0eU= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Nmu6Ckh9; spf=pass (imf27.hostedemail.com: domain of leobras@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=leobras@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703265283; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9cqFAbdxj/IpuKwhr/dOiRTwiBgTE3bII6IeIMBlh9I=; b=rhnXg80a0oQRrwPzYI+PerEYEeFSilEnaFT3sR9uPJFxmnYwLuuYUANTI+he0fWJ0LEn4M m2oymMyzZIrnmOzz4Wq2xVB5esqy3q1/vV1JSdqXofDvsBrAU8gtTURLnmHnzhCAKNWWnL 9uUMpUKn3F8UrGC5fHcON+qdvmy2feA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703265282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9cqFAbdxj/IpuKwhr/dOiRTwiBgTE3bII6IeIMBlh9I=; b=Nmu6Ckh9zYrVboO9SBx/sTX+T/b1U2r+nm1i+TPFQ57yhdeBooJsr0VQdMT/gheapqJ0/N fazE7j07LHJmA0Sj69Qu+8nijy8B13udECpA9w3IQsiHdLvgQr/DtzE6kI4mCKH84dtRDR aGaEVWOevQ1vQyioBJCwewJJmiyYygg= Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-161-b5XOntl4MUC9emf_CXGhmQ-1; Fri, 22 Dec 2023 12:14:40 -0500 X-MC-Unique: b5XOntl4MUC9emf_CXGhmQ-1 Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-6d7a9030c18so2240361b3a.3 for ; Fri, 22 Dec 2023 09:14:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703265280; x=1703870080; h=content-transfer-encoding:content-disposition:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9cqFAbdxj/IpuKwhr/dOiRTwiBgTE3bII6IeIMBlh9I=; b=S0dm2Vv41P/MwR7wuEIdNuJEGR6WSQj38lAzkVVK7pevCyV2w/Fxr8BRQ1aUKiclku ks/oCFRztRHySSWVP+enUohJqKpy9vWs1CWqWqhWNOs9Uk4kPR+1P0o7B3MZEhzzYUXe H50HiJU1sgQfyDzzt0cITrcK/8ViwelhuePYiSIa060YSthBkMvVk24gQg9WQOKVos5u UzFr9dLC7X2ExezbuGrH5YiiWa8n7E72EcqdQKjMpFDGYI8tn3kI8jCnswAGkPX8jWwS 84QWaYzGfkd1RUld+s5eafkLltle9yb80kNmGFltYgGoCBWdEVfkuydhQBtRiapz2PFp nH8Q== X-Gm-Message-State: AOJu0YyZJScTXFcg/g6ttnvFXVnubZMjR7ojOSxO4DvCvSRmGFTjclPz FjZTYm1pIIfelclfUOheiIDF9qgzbN0VKazcTICYLx5qRc+frVpMLBaqHtUGmvXRhEClYh1Gu5m YWoQYf/LpJkX3ylKLtng= X-Received: by 2002:aa7:8611:0:b0:6d9:83a8:658a with SMTP id p17-20020aa78611000000b006d983a8658amr1601766pfn.43.1703265280016; Fri, 22 Dec 2023 09:14:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IGOb39+DJdojm7AE5y4BjhsDq+FHLdKJbJ61vcHGPwAVIRmEbCs30urzlKL/nvpj4gZy9icNQ== X-Received: by 2002:aa7:8611:0:b0:6d9:83a8:658a with SMTP id p17-20020aa78611000000b006d983a8658amr1601741pfn.43.1703265279717; Fri, 22 Dec 2023 09:14:39 -0800 (PST) Received: from localhost.localdomain ([2804:1b3:a802:7496:88a7:1b1a:a837:bebf]) by smtp.gmail.com with ESMTPSA id k28-20020aa7999c000000b006d98f584ad5sm1180812pfh.199.2023.12.22.09.14.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Dec 2023 09:14:39 -0800 (PST) From: Leonardo Bras To: Guo Ren Cc: Leonardo Bras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Eric Biederman , Kees Cook , Oleg Nesterov , Conor Dooley , Andy Chiu , Greg Ungerer , Vincent Chen , Xiao Wang , Charlie Jenkins , Andrew Morton , Alexandre Ghiti , Kemeng Shi , David Hildenbrand , "Matthew Wilcox (Oracle)" , Qinglin Pan , Greentime Hu , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH 3/4] riscv: Introduce is_compat_thread() into compat.h Date: Fri, 22 Dec 2023 14:14:21 -0300 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: <20231222074605.452452-1-leobras@redhat.com> <20231222074605.452452-4-leobras@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 49AEF4001A X-Stat-Signature: hjmqgztyhnjq1t9q33n855534gbdybps X-Rspam-User: X-HE-Tag: 1703265283-993612 X-HE-Meta: U2FsdGVkX1+rEFNS588qfApQimGkAhlgNmCuQUzSEOHeQuirSroLEoDUAgWKfBEfTor4omNDYeMCPTKEtLq0A+k0S7CDhyC8E4TGXJ9QbwhwpEs4tOEmhAHTPQGiIeVs69694XUReK/EMqsr+kyxLHGrD353ZONQRLkTc7B6rA5YZiPs/2QAYLEZipWLlfannjID1w7sU909stc0wG7D+oiM0Q4FZx5WF1dcPzLp8nuco7Kh26DMqZNcscXVKVYrX5xj0Mw+jB9S+tLB0DlEKnvcpv8cZ/ULylkwoI7Esd7TRaXIhiLnn/ofY7WPAOi0qLdnxgU/QosdTModOi3a1r+zmWYRDO4YJV8pgiUJWikMDQARh+cStzvn9xbTbsreulCNltdFX7r43hVhSHLz1hPk4UYOkEqI4Nm4eW7TThIX+H+ruzqu3BY0Lih5OYg+0UiCmktQfc/hRwFwGAyE5WwS/N524YSyrpSSj8+r36yUj409UXioSM+2frxctcMFAC2E4vGTVfRXilHWSVG0waLG/rxE8C5jSlFT9WUITArA47zl1k+leZnam9viWJRwcoB8YoR+PkBFgH1NPQZVyDZMM4LjFLLAAFgB2XSzGHHvfOItXoLbmWzMVWZXZ4a/9s11Qj+wZhVYi7H5WxKv+JPkJdVe+ywAe79XcdVWJpLmEvDZSRJ4LLna7dN4oFrNuDQBnymbvjanHcY6c3hqaQdPVXloIpoKGa5fN7EqQ5D2yPDC8xedj2UlmPmh/wotEdiE4TApLVrWxdZClX9uEkDSJsY03fdAZq+JVh2wZTDUIshLH2P0DURUAY0bpaQ6k/bOEFMK33U58aeLt7vR2tyu6wb6vzkBq+SXvZz2evlWvFC9KFaV5seXi1MimYkCbdCPAih0NXl6pM9Hp1CppWBcmZoZkHMO+H1Intm+cB3mLMXGLL7ppM7JZKwvpVCnL7URw+CPUBFCsuK4HFt kl7b9DGe l1POq2oI/EopxfPQo9pBuqL4FewjeVvGh3cORw6ZmywyEsClkexSSx4UTUgiNMSTGJPixJvLZs9/nkagoKwQbowI0sJ7Un52mVGCebzNHVe7gmii6VWw7s7GhdWDCHao+nTYLYvOUtLuQT/p8RldcTjMNS1K1IDX5qJtFJEHIjsbB6uKNzrayIDMSndqS4ciBZ9BhF1vQ9zzEKKeWwUyvFXGpaAURqZOse4WKHuf8+15dMzOdXFhJsvWcI7hr7vRA9cynxpYRbLuqoYTxgj6MsI5+9R3YWpY9nDbieXJToq5/MEpo87xYbu/d0coWXW/5dpsPApiXswbYC4fclFxbUt7IP1+CQHqBk8xloMtnJneAMZnXfn0VyUVQPoyJ2JFxAw/BrAx2cDWCeysF0lQ4yQOJUzzy7/fe/FhNTle+ZMkCtUMSgP+rYcHe/FcCWwd9BUcluQzDzrinQq46GHFjJg3qFq9dZ9U3drSaaXOEwOjOrmvMJig6HFOeRDP9gXEFAZ0IPSnkd3oCqN1m2ApFpja6ZXMQiSIwLGVd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 22, 2023 at 07:20:36PM +0800, Guo Ren wrote: > On Fri, Dec 22, 2023 at 3:47 PM Leonardo Bras wrote: > > > > task_user_regset_view() makes use of a function very similar to > > is_compat_task(), but pointing to a any thread. > > > > In arm64 asm/compat.h there is a function very similar to that: > > is_compat_thread(struct thread_info *thread) > > > > Copy this function to riscv asm/compat.h and make use of it into > > task_user_regset_view(). > > > > Also, introduce a compile-time test for CONFIG_COMPAT and simplify the > > function code by removing the #ifdef. > > > > Signed-off-by: Leonardo Bras > > --- > > arch/riscv/include/asm/compat.h | 8 ++++++++ > > arch/riscv/kernel/ptrace.c | 6 +++--- > > 2 files changed, 11 insertions(+), 3 deletions(-) > > > > diff --git a/arch/riscv/include/asm/compat.h b/arch/riscv/include/asm/compat.h > > index 91517b51b8e27..da4b28cd01a95 100644 > > --- a/arch/riscv/include/asm/compat.h > > +++ b/arch/riscv/include/asm/compat.h > > @@ -20,6 +20,14 @@ static inline int is_compat_task(void) > > return test_thread_flag(TIF_32BIT); > > } > > > > +static inline int is_compat_thread(struct thread_info *thread) > > +{ > > + if (!IS_ENABLED(CONFIG_COMPAT)) > > + return 0; > We also could put this into is_compat_task(). > Yeah! it's done in a previous patch. :) > > + > > + return test_ti_thread_flag(thread, TIF_32BIT); > > +} > > + > > struct compat_user_regs_struct { > > compat_ulong_t pc; > > compat_ulong_t ra; > > diff --git a/arch/riscv/kernel/ptrace.c b/arch/riscv/kernel/ptrace.c > > index 2afe460de16a6..f362832123616 100644 > > --- a/arch/riscv/kernel/ptrace.c > > +++ b/arch/riscv/kernel/ptrace.c > > @@ -374,14 +374,14 @@ long compat_arch_ptrace(struct task_struct *child, compat_long_t request, > > > > return ret; > > } > > +#else > > +static const struct user_regset_view compat_riscv_user_native_view = {}; > > #endif /* CONFIG_COMPAT */ > > > > const struct user_regset_view *task_user_regset_view(struct task_struct *task) > > { > > -#ifdef CONFIG_COMPAT > > - if (test_tsk_thread_flag(task, TIF_32BIT)) > > + if (is_compat_thread(&task->thread_info)) > > return &compat_riscv_user_native_view; > > else > > -#endif > > return &riscv_user_native_view; > > } > > -- > > 2.43.0 > > > LGTM > > Reviewed-by: Guo Ren Thanks! Leo > > -- > Best Regards > Guo Ren >