From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1717EC46CD4 for ; Fri, 22 Dec 2023 08:28:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 923106B008A; Fri, 22 Dec 2023 03:28:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D2F26B008C; Fri, 22 Dec 2023 03:28:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79B1D6B0092; Fri, 22 Dec 2023 03:28:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6A7B56B008A for ; Fri, 22 Dec 2023 03:28:44 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 35BF64083A for ; Fri, 22 Dec 2023 08:28:44 +0000 (UTC) X-FDA: 81593778168.08.6523A9E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 17DD2100009 for ; Fri, 22 Dec 2023 08:28:41 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="UYeZcfL/"; spf=pass (imf14.hostedemail.com: domain of leobras@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=leobras@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703233722; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UMjkb+AdlxKmri3rBtLZlSDUhTOTefSe341Yp/i+K78=; b=YaXcvEzDy6huQ5BlCrOzPveegkVqc0J5N0fgqCW3d3nGWiEGjpPBlHdhs0hl8jVBw86nNC HoS2kFMS9FSk2b5wNJsHjQ9TwLgAp2XMvMCCk+/SHGVcx6mJaLZugQMk7Z9cz59B7Wletz YmpySC0yy2ca3+hhdUyRNznwtJIBe/c= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="UYeZcfL/"; spf=pass (imf14.hostedemail.com: domain of leobras@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=leobras@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703233722; a=rsa-sha256; cv=none; b=G7twYbXHipjssyE9Gqt66uYhDWAwsDkIjfYojJVzgJVseQy9N1j0hNTeVeO899DSMTBzQU z85V2wOfdVwxlqkLkj00jWXuskzkC6ebZWyEm220x9f+dQny26G9IHK9xwO9FcYY/WRjiI HVbWYpo3mIJnyn8YZIO7j25q6HMZcww= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703233721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UMjkb+AdlxKmri3rBtLZlSDUhTOTefSe341Yp/i+K78=; b=UYeZcfL/cyueZWgU9e/XJgrmYF2nKbCpRQkmThUKsNDu6Yg403FJLfTLLlOdr2HeOBDycF THq2b20z+jK6WvXtMdycJcKsyI3KKWa+Cxu7uISd9INob8RSau6u2bBdKYrPEnvxLPgYZa ZwF6d3g3B8PNyyHkwrIBAiOGebHZWkU= Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-27-W_n6sCKdO6Gr1Qlyo9ZRbA-1; Fri, 22 Dec 2023 03:28:39 -0500 X-MC-Unique: W_n6sCKdO6Gr1Qlyo9ZRbA-1 Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-5cdc9b060afso1550364a12.2 for ; Fri, 22 Dec 2023 00:28:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703233719; x=1703838519; h=content-transfer-encoding:content-disposition:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UMjkb+AdlxKmri3rBtLZlSDUhTOTefSe341Yp/i+K78=; b=Q7vm5Jg9CHmocivtvImgGmw2Kb1CdOY0m027tEmlh4Fy6sRAdYWk0Hix89uaxT+s+r TT0dyf0QuDDn/XZp0HqgR+7cNAUMdZncG9Woj7wbKfuqPPYOWxqDlQpKC45ACzQDVUWS CSSAKmHyiZB4Cn78qNoCjiYRa6ZAZztXi0/iNFU/ukcpoQ/fjwKu9hPw3sjfZAs+B12x PUrkRPccnYKnfA8GA7CtnEetxxgD7fFtPAAg1+6hldpC6fq4/QABK7mucQ18PDTq8hFp anaD4hjB7JUB3PY1iCkGejfufatRFb/86QaixTKUWdPEcMvn2KFGamPSbG/++mjRGmeh vQVQ== X-Gm-Message-State: AOJu0YxjgfFYyM5frfyOzCBdrcvNqB5+gjBH5qWuwvESNcfgVdapGI0K 4lA1QdOVgZPE87mB4IMRqH5omfY15Gq5ViAUWP8D4ttSwoGBLHOxT519LlrZcOiNLBdeUmf2zax AaPf7yJy14pOCsinX3/8= X-Received: by 2002:a05:6a21:19a:b0:195:4690:863 with SMTP id le26-20020a056a21019a00b0019546900863mr45077pzb.78.1703233718833; Fri, 22 Dec 2023 00:28:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IG33qrfp2fIVx3SmQWmemCX48oeiSybC38vfzm6VdXRQ5wpTERAGty1KgAqNyi4XHyHs8U0kQ== X-Received: by 2002:a05:6a21:19a:b0:195:4690:863 with SMTP id le26-20020a056a21019a00b0019546900863mr45061pzb.78.1703233718549; Fri, 22 Dec 2023 00:28:38 -0800 (PST) Received: from localhost.localdomain ([2804:1b3:a802:7496:88a7:1b1a:a837:bebf]) by smtp.gmail.com with ESMTPSA id r19-20020aa78b93000000b006d98ba05776sm657875pfd.67.2023.12.22.00.28.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Dec 2023 00:28:38 -0800 (PST) From: Leonardo Bras To: Guo Ren Cc: Leonardo Bras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Eric Biederman , Kees Cook , Oleg Nesterov , Conor Dooley , Andy Chiu , Greg Ungerer , Vincent Chen , Xiao Wang , Charlie Jenkins , Andrew Morton , Alexandre Ghiti , Kemeng Shi , David Hildenbrand , "Matthew Wilcox (Oracle)" , Qinglin Pan , Greentime Hu , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH 4/4] riscv: Introduce set_compat_task() in asm/compat.h Date: Fri, 22 Dec 2023 05:28:21 -0300 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: <20231222074605.452452-1-leobras@redhat.com> <20231222074605.452452-5-leobras@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 17DD2100009 X-Rspam-User: X-Stat-Signature: a3xjxs4qa13xr9ttzujhok8jqy7hz5mj X-Rspamd-Server: rspam01 X-HE-Tag: 1703233721-790983 X-HE-Meta: U2FsdGVkX1/2NsQxIajfxw8uMjmvJOYMCimdHWmuOQFzUfCEvoTU61qUGU4DhpBiHz7yu8gqgwDBTlGooljMlROdaR/agU1NfRArPh8rOfyqAlTvb9pnWklLEfOy32Ged9TYbxUGqTbLpqBYbDSm0kO3qLb41JWqkV65KgA0OffdMp1eh8j3TmXi07EpnB+dhUnLv4RqCySO7pn1V8jYHo8aDmiDMslD958g5w/LHcJOOE6TLi3nu2Nf5MIpIGzM9v+/YBfmzCH4zImcAiEzrztI8Dmm0SnbinD6tRcl3t4iS1Cu6h5QRxAyWXvOuGYsYfKEBUYhfwRlluYPKNaWyJGf0EBilRcH7nJttDo6yh3P9SscKv2iidPMxqIhiicB1ywBCjIdR0dhCIsKYJiORRCsp0ISb/y18DrGxR3Oofjo42d7ilEJ2VG01dVi1UJCuL8ipb4Glq2vP+5Vcd6S3jqBhMY+mbKOJIlBDE8kbg4sGmyNqeVIQfUb0OjW/ctP1ImQMyIa7nXqJrNP5zcnGsf6Yb5GzO4WkRGDTO0v6/7reSab8etvorULvV+7nHAxKGuCw4FivOYQPAyD+SjXsCOrNCdoZRTrhDgApHV12WDYSG5fzcVKua564Yay7CAJTKlXnUZpwMpq9ZKVasi7rgbgdaMEgCqMGZGZyq5DZDuBj7fVWk3r8tLZwZc8GqXfKkquKrolmHVxpdiQO4gOEoUSRqGM/S+pMT0SxYgw0AC6h1s1m5cl0AMDySSQSn5K9ODDlZ0oJnPIvcNaAsVn3wmwFSP4+pPDh1q4ZHpHA/AenfjcvYfTEhGzoqqYhsIMcDsYM6ntsz3X2ercBo74TRYXxQ/UQyi4Ms8sz0kj7ZrNyOeVpLiikDChP1BsOBLguyBjWcKDoSzXPIJB4cL6FJqprYbPOksLqJbi0+6f61V14jFgkMTd2ZBObhOBmwrqXjRVFtqGHsAHLhktZP2 QNKwt0h7 rd3N9zTmsX3bvuT1aVZADg9689CA/sD6CjDuL4q2e2Zpanoy4CUxst00+1grwomv+7kDwJjXGBBzkDreDDs9YnSsajq29ZJqhQ1gTYKCVDYS+gIALvDsduVfJ6e2FNEJzCKiJ+J8Ml1PPXlreajjAQWkOeO9qqlVuhWjDJxj6CbgSupfjwTP8d3oQIteATRON0xyybcqnDQOnBOv7ThW9Z1g1fIwmjQxh+IMInfm3Q0815TDA2dzof/zlk79RhBVr5EtGpyGW4F3Vyk8pdaFPt3tJTkyeJEOKSEoU+/j7S67fVFlxCxGZ4GDgbczJF3Qq+He7wmMFcHAVIA498nMh1+t2qWnmqhuR2OYuMGR5iqfJ4oCmSIrD5i1TtMH7tGSLtmgGSU3K13sVlXwrf7SOnSMcy7d6B7tXagJ1Ykgm8XQo4SXT9BUKJrUfGnPnCBurbq3wjqnfZjpuQ4RRpSCamb12Oxa3llWYPXAreEjToZ7Yh2anvfDXxxytNRbkydAQO4f+apDAnXjT49bskgqhcYm5hSK9BBBAIa6Q X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 22, 2023 at 04:11:10PM +0800, Guo Ren wrote: > On Fri, Dec 22, 2023 at 3:47 PM Leonardo Bras wrote: > > > > In order to have all task compat bit access directly in compat.h, introduce > > set_compat_task() to set/reset those when needed. > > > > Also, since it's only used on an if/else scenario, simplify the macro using > > it. > > > > Signed-off-by: Leonardo Bras > > --- > > arch/riscv/include/asm/compat.h | 8 ++++++++ > > arch/riscv/include/asm/elf.h | 5 +---- > > 2 files changed, 9 insertions(+), 4 deletions(-) > > > > diff --git a/arch/riscv/include/asm/compat.h b/arch/riscv/include/asm/compat.h > > index da4b28cd01a95..aa103530a5c83 100644 > > --- a/arch/riscv/include/asm/compat.h > > +++ b/arch/riscv/include/asm/compat.h > > @@ -28,6 +28,14 @@ static inline int is_compat_thread(struct thread_info *thread) > > return test_ti_thread_flag(thread, TIF_32BIT); > > } > > > > +static inline void set_compat_task(bool is_compat) > > +{ > > + if (is_compat) > > + set_thread_flag(TIF_32BIT); > > + else > > + clear_thread_flag(TIF_32BIT); > > +} > > + > > struct compat_user_regs_struct { > > compat_ulong_t pc; > > compat_ulong_t ra; > > diff --git a/arch/riscv/include/asm/elf.h b/arch/riscv/include/asm/elf.h > > index 2e88257cafaea..c7aea7886d22a 100644 > > --- a/arch/riscv/include/asm/elf.h > > +++ b/arch/riscv/include/asm/elf.h > > @@ -135,10 +135,7 @@ do { \ > > #ifdef CONFIG_COMPAT > > > > #define SET_PERSONALITY(ex) \ > > -do { if ((ex).e_ident[EI_CLASS] == ELFCLASS32) \ > > - set_thread_flag(TIF_32BIT); \ > > - else \ > > - clear_thread_flag(TIF_32BIT); \ > > +do { set_compat_task((ex).e_ident[EI_CLASS] == ELFCLASS32); \ > > if (personality(current->personality) != PER_LINUX32) \ > > set_personality(PER_LINUX | \ > > (current->personality & (~PER_MASK))); \ > > -- > > 2.43.0 > > > LGTM > > Reviewed-by: Guo Ren Thanks! Leo > > -- > Best Regards > Guo Ren >