From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56AF2C35274 for ; Thu, 21 Dec 2023 22:13:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EFE5E6B0083; Thu, 21 Dec 2023 17:13:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EAEF46B0085; Thu, 21 Dec 2023 17:13:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9EA16B0087; Thu, 21 Dec 2023 17:13:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C7E8C6B0083 for ; Thu, 21 Dec 2023 17:13:46 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 972F0160545 for ; Thu, 21 Dec 2023 22:13:46 +0000 (UTC) X-FDA: 81592228452.11.B0683FB Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id 26817160002 for ; Thu, 21 Dec 2023 22:13:43 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=qYnlUlF9; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703196825; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5jl+j8VoAJ0TH+y6nII30+cXSo3AkwWFgfdB0n28bjc=; b=MvKPDqQfgCILG3TWAr0yXnXK5DYP5996Ky7vp1LQpycabQQdOV5VYmXal4CyUcwTmT3LSF Ve0RFpoZgC4Kf7wrTwgWyvgwbEBNf8cVjNtnrUmZ5QBApIk63q2f21eHrtculqFQCAeJtu sPJsDmozg6iCuC4zhdfZpIgrItUclaY= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=qYnlUlF9; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703196825; a=rsa-sha256; cv=none; b=dBZjUy9ZS6jcxTFU0pwwh9Elxmn2zWxDB6wd81gp+xt+lnJG9kDy23V6zkugCUG12axjd+ cuJMh0ZQT79gEyQYEtLvCbJgccAhmlfWAFZAX2XT1qbxlesomM7CMyw9zT5vqUfMHI0QNu uJ7MznR0I0PSr4S6P6pOyNZyP8QyQsY= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5jl+j8VoAJ0TH+y6nII30+cXSo3AkwWFgfdB0n28bjc=; b=qYnlUlF9BEORe4ao7JNQ8ooRm/ BYv+/cuY5/1MvnSoiroxHyPmtjI2F7ExzVRIYu7ww7EjxClT8aX+Qj5WDVaNblw1bwNrPMW/FaO1M 24Q5U4h9VsQIvZ4BXfRmFkdI3DfRBzbjqAUf98ykniHwcdaVE1/8E4j0jG/I0qKPBYoiN15aQVdfv tAQcX1rd4eVHcX6e8jpR5gY+eUPFdYG8yiVuIKXfqxgXCVQCmYNSjxSJQKkyamoh36G9LxKrMykZx AUaftO04oM+7cMFrhxxVsvjhGEOFFOMFEJ5EAjVbU/s1/NfjDBMcUEFTCmLnybtiMPPQl2W+lZzSj Zk0R0WWA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rGRIO-006J3l-2k; Thu, 21 Dec 2023 22:13:36 +0000 Date: Thu, 21 Dec 2023 22:13:36 +0000 From: Matthew Wilcox To: David Hildenbrand Cc: Andrew Morton , Oliver Sang , oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , linux-kernel@vger.kernel.org Subject: Re: [linux-next:master] [mm] bbcbf2a3f0: kernel_BUG_at_mm/memory.c Message-ID: References: <202312192319.fa8f5709-oliver.sang@intel.com> <20231220141135.cb4241442b657104f0aeae34@linux-foundation.org> <20231221135833.92b8b2a97b28ad0545977f6c@linux-foundation.org> <6a8f2110-fa91-4c10-9eae-88315309a6e3@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6a8f2110-fa91-4c10-9eae-88315309a6e3@redhat.com> X-Rspamd-Queue-Id: 26817160002 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 5jduec4z14ydw7yaotwsubrmfzn54rj6 X-HE-Tag: 1703196823-763138 X-HE-Meta: U2FsdGVkX1/6Ak6t1gmCULC8F0FcDrY1vQBcQfXZ8KOAxnn/QyX+4N2uaqs9932ofHsNTqIFFPDJmGYlDbC+FjWZ3RBPy1jk2eLv1rvTFcjA9acMeKl6hnoSxrE57lKNeVC7zY3EuIZwh16XJ7mtCZkwZUZpx1RVj3zz9YpVms8vrTBAZkcqsyDB4D7SH3/v1ywB1UpOebXYZxjIYPu6TGpg+lWuUvvHN9n40xSlQ5ht9g/p/V6E17+5ftO+k1JNp51IzwWL4bpY4aadu7XV2TzS2l7Eq78F5qHSItRFlug4K4Zco0Fh1a047GKm8zYfKF7NgplJLNuvm1Up5+NS50VOIryvnSpVUushgvOEh/M70wrbAI98pW3t6v9bOizWMpQAcImJIzQJ/LOaMDcI+0wRGV33dnnliCe3PjGKKmgXqSeBGbGNtqsuSfOAauNQZHRoO/L2lhS9VL+tIlT4a0kQpHT2d/w828Pump1Ev0joVoy88eWOkCA2qYvxKV19tZ9y7BK9r2qKmUFmysEc4VqFsuvJMHNqSOkW/PZIlKiJ4xnvnBDNdz2B01vj220tSF4wRhiFaLoFvW3CzBP+CzUNyPpQYGtSHwHoSjQw0AViGrhPpeYXz3xRlAZkhaKmcJhFQofaIwqmBLJw7t6iPLId0GaSDq2VmlulVspeQ53glFrdyBTV3fP1/7p+FBVS8T++2GnYyC+4GyxcJ/BzcmTFi8AKgrv3ed/uKL3xN0/Dq/1be+xpPzTfPchVCiC32+/6TADBBPmee2i7+kWmIA0G7AyqJp74ewnZ8zRmLY6tmVEmJkk7H2kouo6gOGXBEcuB0GKkaW9iaWenCanFVrlpkO5ndZh5Lg/Uecs/RdgPDf1kL0B5HQ88dfx1fZzz2gyCWG8Jq02IFFh5DGiwSvj2qeGADObi9ZyND9CiSPK1MJ67fl3BdOt1SFmBEjUFy5zEJG6lXHrPnmOUKRj IyjVovlp 8DQohHdnne144frz/MJgD0GH96HksYWl3YB1I1gtLFChc3BWPwYpD/XWKW5ywaa90TMlLYa/+910aSyEJm9R/iVzcHuarvq/CI2/oA254pHrd9DhN2kwc4uUDQoOMbbNb+RPB4tp3eGo/2fPzI3W741+fmHUxAYyRiwSZ1ybVjfLPJLacTiGB+9QrPw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 21, 2023 at 11:07:21PM +0100, David Hildenbrand wrote: > Subject: [PATCH] Fixup: mm: convert ksm_might_need_to_copy() to work on folios > > We must only adjust the page if the folio changed. Otherwise, if we > had a large folio in the swapcache and the folio didn't change, we'd > suddenly change the page to-be-mapped. Heh, I was expecting you to be done for the day ;-)