From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F6B4C35274 for ; Thu, 21 Dec 2023 12:15:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7A368D000D; Thu, 21 Dec 2023 07:15:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A03C58D0001; Thu, 21 Dec 2023 07:15:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 857158D000D; Thu, 21 Dec 2023 07:15:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6DFD78D0001 for ; Thu, 21 Dec 2023 07:15:01 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 41D1D80731 for ; Thu, 21 Dec 2023 12:15:01 +0000 (UTC) X-FDA: 81590719602.19.7CE9E23 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf20.hostedemail.com (Postfix) with ESMTP id F1EBF1C002C for ; Thu, 21 Dec 2023 12:14:58 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=XIppQUEf; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf20.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703160899; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WZOSdZ1fWVmBniRZaqNNU9+365ekrwzEre4sZEIZQFY=; b=KVMJBjlXGHlMAKBYMc1Rr01D0C4qxOkWqC4wzV1TXoVC8+/oRonuuQzONyK3kxAqZqCLs8 ha/cu8DMHQJQRtmw9Whff1Thelyb0yXpeuhW+iVwSWTvkV4KvblCHh+63oIaCNKTZZAReE PVv4XnMztJ4t+hCJwlCUAgwjag0+GVE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=XIppQUEf; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf20.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703160899; a=rsa-sha256; cv=none; b=wUC7SfcLfu/rOAXb3rIOy80o1CjiMHKUcx3S0pztgnmeR+trqKAr5xumO46SyNpszQf0Gh i2DmIDdbmAeSDJ8sL7rrjH+KYdrXoBoND5yqkDnCQtMsqiibVd0s0oDunF08BfwTXf7pcu j5NGrUiFUQpTROg+itWwRu9mHpW2DkI= Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3BLC5C9d011325; Thu, 21 Dec 2023 12:14:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=WZOSdZ1fWVmBniRZaqNNU9+365ekrwzEre4sZEIZQFY=; b=XIppQUEfRY1LtrKBhUVMo3bV6Tzft1sy5cmdjqQ0cXYNzq4dQSw/ni5Kya4tKNtkoXRv ILbnFG1UsMSul8QykzoQv1Fj/GaTzKxwJl1wVD0QGW33DcgCLb5q1sIyNTh+3Xa8hxPF bM6D48RMG+N3kjPo+EHPoDIleXUKxKV+i92o4xz/ihbZZY9vXPQCZO/XOTr+kk0b5n6i Pf4mrIwNMU9FTb3FLY4luj3Ib0YkkgrUDOAGlpo/8AIz7mlJ2A0JVGlP4cZ8uJgF0fx7 E/KFLj7FIYf9ee2FNOo5GNuYsJrus8wHusasPj5KAje2VKwQK32ePGoJf4TlOz9gec2z SA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3v4j3fykrf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Dec 2023 12:14:26 +0000 Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3BLBKEuH001091; Thu, 21 Dec 2023 12:14:25 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3v4j3fykqc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Dec 2023 12:14:25 +0000 Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3BLB80DO012308; Thu, 21 Dec 2023 12:14:24 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 3v1rx24abt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Dec 2023 12:14:24 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3BLCELCW19333772 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Dec 2023 12:14:21 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8CFC520043; Thu, 21 Dec 2023 12:14:21 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1D09B2004B; Thu, 21 Dec 2023 12:14:20 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.171.57.36]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTPS; Thu, 21 Dec 2023 12:14:20 +0000 (GMT) Date: Thu, 21 Dec 2023 13:14:17 +0100 From: Alexander Gordeev To: Ilya Leoshkevich Cc: Alexander Potapenko , Andrew Morton , Christoph Lameter , David Rientjes , Heiko Carstens , Joonsoo Kim , Marco Elver , Masami Hiramatsu , Pekka Enberg , Steven Rostedt , Vasily Gorbik , Vlastimil Babka , Christian Borntraeger , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Roman Gushchin , Sven Schnelle Subject: Re: [PATCH v3 28/34] s390/mm: Define KMSAN metadata for vmalloc and modules Message-ID: References: <20231213233605.661251-1-iii@linux.ibm.com> <20231213233605.661251-29-iii@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231213233605.661251-29-iii@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: gQs6F1yHCC4oP4FjDomkOokf6MZGQMPK X-Proofpoint-ORIG-GUID: Ga5RPJKS0qpjMpHhRYad4Qum2jq5TvYL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-21_05,2023-12-20_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 priorityscore=1501 mlxlogscore=999 lowpriorityscore=0 bulkscore=0 suspectscore=0 malwarescore=0 impostorscore=0 clxscore=1011 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2312210091 X-Rspamd-Queue-Id: F1EBF1C002C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 3ifshpqctratmo5r7ikd77o9n97eczr5 X-HE-Tag: 1703160898-170795 X-HE-Meta: U2FsdGVkX19LwkUyCXme1Aa5CfXJDln8khLOh0WwbYMCzy0M53HuUaXkAa1z/zc6eF5/jrXkacFyp7a4IKxNLoZSWgwnRjHvXZVPnQwHmFb6JG/XG+7CaW8o03MKSmp9kukoq60DTcP+VCubd4m+FCvEP1XMXJovcxSveYPT2Z4QgxAZAAD1RQOeM7Tl9a92aiOPyNpVprFWOj5R2RDKHF/uO2XvI1qEKcB1qTjdenMvRpYydhfQ6nS9S2mRfrDoJjcTPlslnkbqWqttqaBB62yCrFz9qc5buybzKi5BuCgx7u8Rlb5OyyzKxvsN+JexLyJXO84CTVhZfXBzOYQKU4yzC0hTkKDdlpC9fCbYK9Ri4t2fLHKRuP4lg+xQ1K7qNEgjXLwpTVqcDQIsjeQg0ZW/N6530ozy+WF1N34SklnZm6NAFULSboSjd+WjF1KxChObyIx3P8JfHsz59WLho6JhhTYdDriv/DDAvN46OrEBWgFvWA4FaXNGnk37LAHF4XYliCQfjDirQTdXlxblsv9y5ycEcSkzcYW08qXSpq2ad/GlT1/G11lemP/OqnCSAwTxVuVnDfsocd4xyjaPm7J3yI5N/5Q3xMikJ3EaHkA0qqNEc/rNGPPcsdWbEavbiXznPC+nNfDmnjyFystzqmOLmpv5+u+nFdD4/ABWRXVyfd/rfN19hp/DGhl0Otl6YxBvg2RHtfjMC7/75QhHhwvhj8uwFNOCgz0Bms6MvlKv/wDWYopnZdyRgDChflsuS2WZGcPsYI7DjWJx7BZ1m+DgF6x2HyjSMvXNy8LG75vusEVf9kf/AZMbuNfdqtMibrtKoKhOjP5qpTxOoRt6LX2kD16ZRzbknfgjz12QwCIrHKZSndkU18kdx9Wt7vU8+LYghQbQBDmfYKr9zuDu+zJgztGUiJsWOhG1SfTbKfXYsk7OlJN/ePIKvEpxhHSpGhuQxJ9vnVR5qIvNmkd /aycORQ8 nyK9raaFgRols1YgEBj8riRZZ4WeJJpBFZaDM+oi9PQ77gPyWjQFmwRVzzIpf1PO3cealUyA8RlakBBnbpeOjDBp2Mbkpvie9E5H0bCsi9MPCYpZ/ocUetyeCxh5Di0UdKNdhaBWZB+Tq4t+PXaBjfA79oKlZUcjAVHWHSVP4XmKSMvc1lYLu5IxKg5iC/eCVFor5PxfHK6nfbqzQLFcGWV6ujTDZ5m9VkoHzPyFdBMgJQKCE6QlUQq/w1i16lJbyB+Yrsl/6nllAxt0yNUbrfU8iktfvvbPEjf8P3mt9iKapvweBC1h0n06MyuFw9c3RX/jGP8v+R9Uh2aABIPt8WByAkQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 14, 2023 at 12:24:48AM +0100, Ilya Leoshkevich wrote: > The pages for the KMSAN metadata associated with most kernel mappings > are taken from memblock by the common code. However, vmalloc and module > metadata needs to be defined by the architectures. > > Be a little bit more careful than x86: allocate exactly MODULES_LEN > for the module shadow and origins, and then take 2/3 of vmalloc for > the vmalloc shadow and origins. This ensures that users passing small > vmalloc= values on the command line do not cause module metadata > collisions. > > Reviewed-by: Alexander Potapenko > Signed-off-by: Ilya Leoshkevich > --- > arch/s390/boot/startup.c | 8 ++++++++ > arch/s390/include/asm/pgtable.h | 10 ++++++++++ > 2 files changed, 18 insertions(+) > > diff --git a/arch/s390/boot/startup.c b/arch/s390/boot/startup.c > index 8104e0e3d188..e37e7ffda430 100644 > --- a/arch/s390/boot/startup.c > +++ b/arch/s390/boot/startup.c > @@ -253,9 +253,17 @@ static unsigned long setup_kernel_memory_layout(void) > MODULES_END = round_down(__abs_lowcore, _SEGMENT_SIZE); > MODULES_VADDR = MODULES_END - MODULES_LEN; > VMALLOC_END = MODULES_VADDR; > +#ifdef CONFIG_KMSAN > + VMALLOC_END -= MODULES_LEN * 2; > +#endif > > /* allow vmalloc area to occupy up to about 1/2 of the rest virtual space left */ > vmalloc_size = min(vmalloc_size, round_down(VMALLOC_END / 2, _REGION3_SIZE)); Since commit 2a65c6e1ad06 ("s390/boot: always align vmalloc area on segment boundary") vmalloc_size is aligned on _SEGMENT_SIZE boundary. > +#ifdef CONFIG_KMSAN > + /* take 2/3 of vmalloc area for KMSAN shadow and origins */ > + vmalloc_size = round_down(vmalloc_size / 3, _REGION3_SIZE); And thus, the alignment here should be _SEGMENT_SIZE as well. > + VMALLOC_END -= vmalloc_size * 2; > +#endif > VMALLOC_START = VMALLOC_END - vmalloc_size; > > /* split remaining virtual space between 1:1 mapping & vmemmap array */ ... With the above fixup: Acked-by: Alexander Gordeev Thanks!