From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D28DEC35274 for ; Thu, 21 Dec 2023 05:26:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C5066B0081; Thu, 21 Dec 2023 00:26:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 526FD6B0082; Thu, 21 Dec 2023 00:26:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A0176B0083; Thu, 21 Dec 2023 00:26:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 248346B0081 for ; Thu, 21 Dec 2023 00:26:57 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DBA50A197C for ; Thu, 21 Dec 2023 05:26:56 +0000 (UTC) X-FDA: 81589691232.13.26CEC99 Received: from mail-il1-f171.google.com (mail-il1-f171.google.com [209.85.166.171]) by imf08.hostedemail.com (Postfix) with ESMTP id 136E9160021 for ; Thu, 21 Dec 2023 05:26:54 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=LF62ZfUp; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of yuzhao@google.com designates 209.85.166.171 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703136415; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/wCCLZM4JqNp3Y4ApKOQz3CzWtQJL0OzMsUEywq65GM=; b=fk2NUPF5Bzh2xgG+hIC/5v816tQzDpl8IVvqDcZh+LhvPX4wpfMdCJK0Bf9Wu1N0JDSetK qOBV03pDBpkOQI1+jY+L6NAJCWN3vNeIU8y0QP5rlk24EXSleO/tb09zSzKTqQTO5y4ZaK O7biB1uHeW27Dx693EneVds5cAL9mtw= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=LF62ZfUp; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of yuzhao@google.com designates 209.85.166.171 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703136415; a=rsa-sha256; cv=none; b=sBMaahEZzRKcHQgwT+pGPdsrkf+aU6Oj5Fb66H2GATkJByOLBMciwiyun8YnqK3NQLaA06 iDHb5lm63NXppZCObQWsn9kvRsqjH6EU4E78xG/J/WuxGQ+ksTEnaFoROrbuuvxBNEMYqX 00AHmAt4sp4KCzkmxEFYMmhffMsWm3M= Received: by mail-il1-f171.google.com with SMTP id e9e14a558f8ab-357d0d15b29so49845ab.1 for ; Wed, 20 Dec 2023 21:26:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1703136414; x=1703741214; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/wCCLZM4JqNp3Y4ApKOQz3CzWtQJL0OzMsUEywq65GM=; b=LF62ZfUpzETpPCBL7FmnAkYPmLaAHn6GklirQKrDpsQe+biYbunYmqjrVmemHndrFk 8EelfxQsaw6UCvyvZdkG+YUu+XNxnPjyfv6fpYdbjSO4yE2S6r7UaDSMeMgj/IcMLIIz p9u6SbI0yevXiRR91IpBFl11Iw+Pgfe7khxp5kIaXecaLmUopfe8ZvYHrsRT3RxDT+KJ OhDbG4RFHgIkmXaBkL/9E5X9BFqKXEHXb22wWWQ6KMMzKDQNk6s1s8/i5eWoUU1nNOEY aJ/meKBXQWb18o05unuQe1rmWy8j2yeAFCrrM2H6qpPf4SXTIg5xPgpNu48NjeLBkjbZ Rtxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703136414; x=1703741214; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/wCCLZM4JqNp3Y4ApKOQz3CzWtQJL0OzMsUEywq65GM=; b=SQhB7P6OjVkXzcoS280rotMVo8TFXZM/JguEwSR96X1csP5keeKhMilpjxRHb3JrhI yJHvCdCszJZUcp12dRtBSWH9pPvRAq+x9WbQnsp/g6URz2hp0KEeYuqZ3JQlOjVxyglj t1phJGufk35HliZ8fFo2PZCUViNh2fPQOAHnw7yPQ83ue4qFF5TvoyqtkF0q0inYKIdM qS6/albs4YkuRqjEHHALE7btVlDfJOFEUmFnnjDGAjDEyk7RSbRDQNru+MBxF4M8+Exy D24KwYdVjWoumpVzUJotGH2hbvSg87bcvotzY41xp1o50fpfunbPTG8yOwRZo8rUSHiG BwCg== X-Gm-Message-State: AOJu0YzhQwUHAI0ogbV3Ji3r9T+5ragXavkcCqB4JESUlMFvIvIIWJfn 1pnhid9wCXXuPW0xIExBZBHrsHMraToizy6CrG2mAW+SVggp X-Google-Smtp-Source: AGHT+IGjNY/faGmARzHzlj2EeW0o1odpyiIHpjdTPytyjny1PI9hn+sKzOiqKGWGZTcSIGOgRvZ9kQ== X-Received: by 2002:a92:da85:0:b0:35f:cb23:89d2 with SMTP id u5-20020a92da85000000b0035fcb2389d2mr31046iln.5.1703136414063; Wed, 20 Dec 2023 21:26:54 -0800 (PST) Received: from google.com ([100.64.188.49]) by smtp.gmail.com with ESMTPSA id a18-20020a6b6c12000000b007b392f4f3dasm293835ioh.23.2023.12.20.21.26.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 21:26:53 -0800 (PST) Date: Wed, 20 Dec 2023 22:26:47 -0700 From: Yu Zhao To: kernel test robot Cc: Kinsey Ho , Andrew Morton , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , linux-kernel@vger.kernel.org, Aneesh Kumar K V Subject: Re: [PATCH mm-unstable v1 4/4] mm/mglru: remove CONFIG_TRANSPARENT_HUGEPAGE Message-ID: References: <20231220040037.883811-5-kinseyho@google.com> <202312210042.xQEiqlEh-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202312210042.xQEiqlEh-lkp@intel.com> X-Rspam-User: X-Stat-Signature: ub19zwj51ckj3scrkdhfqc8abg19pht8 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 136E9160021 X-HE-Tag: 1703136414-609770 X-HE-Meta: U2FsdGVkX1/MLhr2jaCRWssJ/RtOus0Lk1kfFbEdkf5gUZIpzDQjEXeP5CdELgDzDWgiZbx+Zo8lVl6cy4Ny67Qpqu9TtmkOPo+Vrb12D4EZIPfpk2QNbuXyIE0KpwHTTiTnvCpTw5Mk6NYyTIqx5YS8awb4gZ4MJB93icokaX/jhMzXQdeVy+sU7BnkTvtclX9PfNM46wtwE4s/h3zlkk+JcVYW53BK0wXNEgzWqfJlfJxDrQdoccbvj1gDz0TfuR9FOcE2f2fnWNA0TS/2snOs8Q00JQydly/CYCZfdxXP5FWgK8LZZu11wZttBHItU9A7+UZdaxnuN5HKQ+XPUSArzgjWCnOW/NudOb5wEDCbUcM0pIZhuSIB7bPV8TjAUD2xmrwzadVQtum1YbCD0F32JV6XDA3YYezBJsV6agNb400Sn7gGrPiReI+KgxFa9Se2A7ckKo5QBZRpS310en08G9OM4tLyJ3PeX3gVruTMkYiz8FWGrFEv4JvZPQyGJoZQt+uobDwA6q6lFDGKwvNUOc4eYmQ2RMyx/9ZZJ9/rB9x1jB+/9eSO/AqaNGmO8FiA0L+dDQtcDfLBCIMO7u5z82vh76yxh1VgAL/SnvN1gzUURy0E6NwaSvTA9OW6CvqAJ6xd5Irwu6tYpsTx0LiIxQ3fJ1dCE87nF4qmkhBowGMq7O/DlfSwQaw2V3WOUVcc852kw5O5fqb9rVIlFoZ9/pFXy0H4nCov43RKrKmUxS2Fog4AOVt06N+0wbKPgs4Fe9ItwjBXKZAhSwzcD2ChAHFIThXdqcrCx7gjJIxN2huAcb0HpVfJ7PVSvrTvw3mrx2ZeDNAgKkTsBY7WMEtwVZi1EZvO0LKrE0FYPS8j1uXS8XulDaLfWZBZd8/yRQAil9jIt6s31HdddkopC06n7pJOERlXB2BQPSZq9bnjGwo9P42TgyZ60Kqwp+dsn/+QYvkCZasHLTvo4x6 OHLxpML5 4xECsZklz3F62bSnI2mAgKB0/OWLoo/ApL00C5KH5h9JtJt71yKC85P4Jv1VNuyOq3bsnrHVTrwUowRxjs5E9frj8yg+g6gxjQAXCqDrGoe7erSDTX4UDb98zYDn3WpyAI8UybJeFjFu6+sHJWERbbrnyWL3sdAcIaXwjWmvkDG4zg5PNE5iBA8rSHxINLWVSwFJcPawADhz7v8ooMnydWaSnTgsxm6kzS51cj1AV1SLjOsG7/G3qwzR8+Vo5GNdp3cmpuqBJR18FrKc8eNnFHFLL1e/gRaCaSSU8H5VdHtqrJAB7ukWWMK2pFOcwzAYeu08wH2py/m6Xp3wJtliVr+J+KQU5c7HmRVSF+tbGuev5LZMNBILEs1AL1e9BRdawR+5pOXgnZz5lH7E7sa08DjbVNz99VByVZ0MeILsV8N3LdB+4gCJZCYzABgPERkLSX/PvCVhHnA5zvFb43Wgk0jczniwXyeVfRBBjZKzUweBj03s5yQvjeuCsF/Xqw7tthhmKH5hSCLhiq8iYLkQqiUqT2uunid7iOqKwM80gLzVX9bI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 21, 2023 at 12:47:51AM +0800, kernel test robot wrote: > Hi Kinsey, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on akpm-mm/mm-everything] > > url: https://github.com/intel-lab-lkp/linux/commits/Kinsey-Ho/mm-mglru-add-CONFIG_ARCH_HAS_HW_PTE_YOUNG/20231220-120318 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > patch link: https://lore.kernel.org/r/20231220040037.883811-5-kinseyho%40google.com > patch subject: [PATCH mm-unstable v1 4/4] mm/mglru: remove CONFIG_TRANSPARENT_HUGEPAGE > config: arm-randconfig-002-20231220 (https://download.01.org/0day-ci/archive/20231221/202312210042.xQEiqlEh-lkp@intel.com/config) > compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231221/202312210042.xQEiqlEh-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202312210042.xQEiqlEh-lkp@intel.com/ Thanks for the report. Kinsey, please make sure you include the above tags (as well as the Closes tag from the second report in this thread) in the v2. > All errors (new ones prefixed by >>): > > mm/vmscan.c: In function 'walk_pmd_range_locked': > >> mm/vmscan.c:3455:21: error: implicit declaration of function 'pmd_dirty'; did you mean 'pte_dirty'? [-Werror=implicit-function-declaration] > 3455 | if (pmd_dirty(pmd[i]) && !folio_test_dirty(folio) && > | ^~~~~~~~~ > | pte_dirty > cc1: some warnings being treated as errors Apparetly we need the following, similar to commit 6617da8fb565 ("mm: add dummy pmd_young() for architectures not having it") diff --git a/arch/loongarch/include/asm/pgtable.h b/arch/loongarch/include/asm/pgtable.h index 29d9b12298bc..8b5df1bbf9e9 100644 --- a/arch/loongarch/include/asm/pgtable.h +++ b/arch/loongarch/include/asm/pgtable.h @@ -523,6 +523,7 @@ static inline pmd_t pmd_wrprotect(pmd_t pmd) return pmd; } +#define pmd_dirty pmd_dirty static inline int pmd_dirty(pmd_t pmd) { return !!(pmd_val(pmd) & (_PAGE_DIRTY | _PAGE_MODIFIED)); diff --git a/arch/mips/include/asm/pgtable.h b/arch/mips/include/asm/pgtable.h index 430b208c0130..e27a4c83c548 100644 --- a/arch/mips/include/asm/pgtable.h +++ b/arch/mips/include/asm/pgtable.h @@ -655,6 +655,7 @@ static inline pmd_t pmd_mkwrite_novma(pmd_t pmd) return pmd; } +#define pmd_dirty pmd_dirty static inline int pmd_dirty(pmd_t pmd) { return !!(pmd_val(pmd) & _PAGE_MODIFIED); diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h index ab00235b018f..7b4287f36054 100644 --- a/arch/riscv/include/asm/pgtable.h +++ b/arch/riscv/include/asm/pgtable.h @@ -673,6 +673,7 @@ static inline int pmd_write(pmd_t pmd) return pte_write(pmd_pte(pmd)); } +#define pmd_dirty pmd_dirty static inline int pmd_dirty(pmd_t pmd) { return pte_dirty(pmd_pte(pmd)); diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h index 601e87fa8a9a..1299b56e43f6 100644 --- a/arch/s390/include/asm/pgtable.h +++ b/arch/s390/include/asm/pgtable.h @@ -770,6 +770,7 @@ static inline int pud_write(pud_t pud) return (pud_val(pud) & _REGION3_ENTRY_WRITE) != 0; } +#define pmd_dirty pmd_dirty static inline int pmd_dirty(pmd_t pmd) { return (pmd_val(pmd) & _SEGMENT_ENTRY_DIRTY) != 0; diff --git a/arch/sparc/include/asm/pgtable_64.h b/arch/sparc/include/asm/pgtable_64.h index 5e41033bf4ca..a8c871b7d786 100644 --- a/arch/sparc/include/asm/pgtable_64.h +++ b/arch/sparc/include/asm/pgtable_64.h @@ -706,6 +706,7 @@ static inline unsigned long pmd_write(pmd_t pmd) #define pud_write(pud) pte_write(__pte(pud_val(pud))) #ifdef CONFIG_TRANSPARENT_HUGEPAGE +#define pmd_dirty pmd_dirty static inline unsigned long pmd_dirty(pmd_t pmd) { pte_t pte = __pte(pmd_val(pmd)); diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h index 57bab91bbf50..ee83a238ac13 100644 --- a/arch/x86/include/asm/pgtable.h +++ b/arch/x86/include/asm/pgtable.h @@ -141,6 +141,7 @@ static inline int pte_young(pte_t pte) return pte_flags(pte) & _PAGE_ACCESSED; } +#define pmd_dirty pmd_dirty static inline bool pmd_dirty(pmd_t pmd) { return pmd_flags(pmd) & _PAGE_DIRTY_BITS; diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h index af7639c3b0a3..b646c84cc592 100644 --- a/include/linux/pgtable.h +++ b/include/linux/pgtable.h @@ -184,6 +184,13 @@ static inline int pmd_young(pmd_t pmd) } #endif +#ifndef pmd_dirty +static inline int pmd_dirty(pmd_t pmd) +{ + return 0; +} +#endif + /* * A facility to provide lazy MMU batching. This allows PTE updates and * page invalidations to be delayed until a call to leave lazy MMU mode