From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FEAEC35274 for ; Thu, 21 Dec 2023 04:49:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1655F6B0074; Wed, 20 Dec 2023 23:49:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0EE0D6B0075; Wed, 20 Dec 2023 23:49:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED0A16B007B; Wed, 20 Dec 2023 23:49:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DB4536B0074 for ; Wed, 20 Dec 2023 23:49:18 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id ABC0DC0AD1 for ; Thu, 21 Dec 2023 04:49:18 +0000 (UTC) X-FDA: 81589596396.01.9251A85 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id 25B1A8000F for ; Thu, 21 Dec 2023 04:49:16 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=tAvNS7Xl; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703134157; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AyIlzqO6vOAJAUAj7PWWomjTty1LWsROBoYt60pOPrE=; b=dqayGyIufR9vM1wbByx86qv9XWJ1/PihvaeFoZD4tmH3EXcBYakTMJSxmzedj2vutUsjKE av8x7yJwxy6qE7fUqbmPCRSfTnxuunz9A1nvSHxBOdqj+5RuZ2eolnJKZr57ELxtpSAyxW OoIpXVwG73++3NKOG/ckBMe+88x+qJQ= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=tAvNS7Xl; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703134157; a=rsa-sha256; cv=none; b=Yi/XWIwIszd/uu1ghfmLIBZoT6uYxTw3ruTzpVb2r94vEsO0jI7iL+bcVcqUcrvIFbAU4U NhgV+401qZifXdYlr4cDf+xhWwanxs4YEWmZAfDHTkicnFUQTegO9Ti4OCHRO0bjUgoVYg UWOLAyfbibutcUiMNHcIR4/uKS8Suys= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AyIlzqO6vOAJAUAj7PWWomjTty1LWsROBoYt60pOPrE=; b=tAvNS7Xl8O0fkUKjWs04UajCtT +9yRWgDOs6cZmvD56QrpTCFUemOLDhwcYcwrxKbqG57lv0GmEtJfnPZThZCHL6NaTiREXDAZTcs7N 5aUqXYAav3lxfCpjeRs4btWXQF6hJMRpIB9K6W4BQ622FM9OsHx5r0oISVwI6WccbXZBqb5Yau3GG zCxRaLUeYaPqebiZ2vINSaHdPo7fwmh/Ab501E2hJLu6hE8fM27csAV7EHilZBbqOr4Py+Fhnwh3U KIngh3xLxTFNA8kYmLLVT5frWQpepDFF90wOFFB7/XIEI87GDCRA8zBLgFVoOIXOkderM0/sQ4NG0 0Ou2JmtQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rGAzY-004faT-Q9; Thu, 21 Dec 2023 04:49:04 +0000 Date: Thu, 21 Dec 2023 04:49:04 +0000 From: Matthew Wilcox To: Yin Fengwei Cc: Yang Shi , kernel test robot , Rik van Riel , oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Andrew Morton , Christopher Lameter , ying.huang@intel.com, feng.tang@intel.com Subject: Re: [linux-next:master] [mm] 1111d46b5c: stress-ng.pthread.ops_per_sec -84.3% regression Message-ID: References: <202312192310.56367035-oliver.sang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 25B1A8000F X-Rspam-User: X-Stat-Signature: odqujsha1ohtytpmphips6r9718y1cko X-Rspamd-Server: rspam01 X-HE-Tag: 1703134156-210600 X-HE-Meta: U2FsdGVkX1/bdcfgtM27sEMZqWR+xqiOlvfK4g4yCReNW533Fc1ghHicqsWbZZHzpckbTXoz7ZJpOvgkOkywkdFAdh8xfr5oGKuHa2pLTIJWZ3DX9Qr5sAWpk1imVJlW41QV9U7SPqLrF3sLTYK8kmgJyT6c8PAX1cRPsmToLd/tWkkVqSvmnmWmW1daYs80wNCXOnNQgPdyNEgZSABtzx23wwYKylspJIYFJ7kNaesoW3zhNcFx1DZL/MidGXIhvQQbmCvyGGyadyKfOBo3mVOPYWDKpmnTkZGPmt1WNXE/xCiX8+SiFRR8yUf87l9/0b0NYx3dqFpwSrrTg4PtnEtlUVz57w2fTanrOivtM0urNqMqPXxPOnUuvnErgaHLBQXtRrDBPgwOjeUEYz0A7+4n5Rl2bSUNExKwAX0kKpvvMBQlraHW/Gg+6mWZEdzXso8X/fn1P7Tw1u1OyzuqhXd8kolXY5tf+pSpdM9qmzdz6oqg97jrMZOErPsNktEbywIhG8C/LERBOGQqtXD118XTP16fuCDWtub0Fsf5Bj/qnDwOqrChbOMx+UHqyaNE7PHF9RAcqOMaUU8ztsxlq1vHGcar7mDD5qRlR2UpZNSeaNhdf/FebhQUOfQtuHc4X736U7GuhGCc9GD2zccRR5fw9ZjJKlP9NUmt1vyixz9mpwDsNa1sbaqbrutjn04j271CJijQiMcLXRy+ukEj3ezeDqGh6oI4XlbR7glItVSbXzsMAsWMOzJkagGTpu7imeB6g5j0oPyr2+ejBF0oGqG+ZJ4FS0hVobwWNJAjFKd2b66I42IHU+pSyMKanqO/bUFkSYr9ou7dw0SHFcf6taQEgYn1uEX4G9xH9vwmGF6dmaN71pZR1tTI0VKpZ0jK2PGtyl3PCN3c/MQNvrF8LmVLoFd2RpgktapUol9HcfM0dgsgUMbg0FXaqpRVb1z3CqDVX/XU5f18jx4o/23 tvQ2hj1d fhS0UaQvqsC0EceWdScl7vDXmtQilqqjc3OGH5k9VQ7YF5X1+j+ilwFAC67TcCTMhpkTdPdSDinZ7f5GyFIE8z0jmdcdKTDBSqOCSNuGkYRGHe5o2qe/UMGqHf3OAg9d+DmWWqsxDaFxRkHXAPcbuFvnlBJPbF7biOc6sVqChTJzRHaqj7SCOXm9mlDhYpAKjS24bTfZQ7B8UZFFxL6VwGiTE2g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 21, 2023 at 08:58:42AM +0800, Yin Fengwei wrote: > Yes. MAP_STACK is also mentioned in manpage of mmap. I did test to > filter out of the MAP_STACK mapping based on this patch. The regression > in stress-ng.pthread was gone. I suppose this is kind of safe because > the madvise call is only applied to glibc allocated stack. > > > But what I am not sure was whether it's worthy to do such kind of change > as the regression only is seen obviously in micro-benchmark. No evidence > showed the other regressionsin this report is related with madvise. At > least from the perf statstics. Need to check more on stream/ramspeed. FWIW, we had a customer report a significant performance problem when inadvertently using 2MB pages for stacks. They were able to avoid it by using 2044KiB sized stacks ...