From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A44CC35274 for ; Thu, 21 Dec 2023 04:33:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 06F5B6B0075; Wed, 20 Dec 2023 23:33:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 01E766B007B; Wed, 20 Dec 2023 23:33:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E50676B007D; Wed, 20 Dec 2023 23:33:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D5CD66B0075 for ; Wed, 20 Dec 2023 23:33:49 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A73D84043A for ; Thu, 21 Dec 2023 04:33:49 +0000 (UTC) X-FDA: 81589557378.15.1D6098F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id 0D43340007 for ; Thu, 21 Dec 2023 04:33:47 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="HTyM/uIy"; dmarc=none; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703133228; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cB5JX0tcfLHov/oOLKrnY2gF6gOzh9ftJuk4/XCl/z0=; b=Org2+N7uIeZjfOFhHx3YAPGBMui+jtCgtMUT3f6Zulhn08vwOKFa1cUR3cBBp9D3yGtmpu 8wphanzAib888y9IDSwH0OFFZjIAFu53Kz1ohOIXoO4Rx03N83/hmw1a1vhCIAl/rhNu4h LL5n0ydv6/BfpmXwrnblcgkq6bdsVhc= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="HTyM/uIy"; dmarc=none; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703133228; a=rsa-sha256; cv=none; b=WmtbQzJC47Mm+DbbXwHK4t2wV7V/aNjSujQAdEF6wV6dwsyVoCvLrzWPHn3KxfUqlq2tZG hebZZQblOu+RkKFAL3VKKvk4wer1waJbEQ4G/NJK9f2Ukt+yAvAo8X3LFdd9BtYcwtYi3E 2XCMG16lhCzZc4JUKvQ8iGZU4HbfMak= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cB5JX0tcfLHov/oOLKrnY2gF6gOzh9ftJuk4/XCl/z0=; b=HTyM/uIyDJmBjphHYszMh9jD7H 3JXXxZqMtbbq/4YNg/S0iNx94XKARoA+K4F7ARByzGmOOkIi3c9jkyGT8ydHjA/34VEq5a920K/5c mmuLZO1rLYSXeZC6HAfjAgrRmPNl1cKQXJnuJvYptdaqUCKPXqU/Hz6Z0qduM9mjiCr1dTcPlFOl6 1UoD6Gm1eRCx5wsxdmSVg1RWiw2CuCuwDKXKHTI5i6zRcvT4+/O1omxD/v/9nY5Qb/PrONQeyFA/t T4zTRNkWCLDHdrRn5CCGLioaLx1bjUGRrHL44+2ovj1D/MZW1/QDGoOz+Om/WuF4amGKoanCZTY6S AWXvKEYQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rGAke-004f14-MS; Thu, 21 Dec 2023 04:33:40 +0000 Date: Thu, 21 Dec 2023 04:33:40 +0000 From: Matthew Wilcox To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Hugh Dickins , Ryan Roberts , Yin Fengwei , Mike Kravetz , Muchun Song , Peter Xu , Muchun Song Subject: Re: [PATCH v2 01/40] mm/rmap: rename hugepage_add* to hugetlb_add* Message-ID: References: <20231220224504.646757-1-david@redhat.com> <20231220224504.646757-2-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231220224504.646757-2-david@redhat.com> X-Rspamd-Queue-Id: 0D43340007 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: qyjsm8c9ozwbsfghr3pay98whxi1gktz X-HE-Tag: 1703133227-468700 X-HE-Meta: U2FsdGVkX19COYRzb9i54gt26MrSK0QH065vXi5k9yoTHd0WVnmDft3gwPMopcSS79sWuIesIkzCi1qSKnCuIEO1bvm0XlkPflaY4BE1aR3mbV8luAIpITIu/FI+yxOUhPC+p3IC+o4phcsryQeXG6o2t3khbMUATqpU05TVAbLNwmt55jZQs91qxgEFG9ufyJCh8A8wNlzrHotqQ38U4v6Qzgrae1qdQAH3oYfDoDm6ivDj8/GogFdRQee1qLJYkDvrXukL+M149yqqZmxB8Ek0adv9NfgRLeQoERKqGD1KBvyF6H6mArOYXHSecsksJWZO+YuD76DNATnDyEpJmjadWDyl9+SUPFuT22zFMtTZGkXv3r/SUGResAs0K/8LsQ4x4tMO9LAE/I5eQjGpuhq046NYC5DWqG4efW8Qv+Hgi7dFWMMSWqkb+yRpimwXUzPc9B0IfkvLuwguhrQLMsCFnAE5lAC+LZRZ6FLM9dcvFjgKy1AzLRZK0qd2M13qIBCRej+mbLpD3Xw9RVYOQJyN5JNsxbzzwCfbJWWidQzqg19RE21se1Q9iTcGEn6M2yX3A22H2k3Vzjqh95SRqnI+MF0pZ2Ju2Dap/pEDIWCxxO09ouYDK8rEpolOa52ermE4Ya+fQrsrd7WJbNdR19C/4+TTTXY5+9BPQaueaWlkjcaj0VOvLTfcevymzqT1Pcr1tY2hqdA2QlniUM1g4HQNbUz1a2u6eDLJeMAvNWHcWszy7SRL+Ftq+I30maQoh/g6JPyot6Dzh8tsd9/ykspAqtm41ufobvYZ3DG3PnEXxYAI7iJTQYNtdII0EtEvjWUvMAbb1OHUqw7oQ1gGAxlMyqM2fJgbgH/72AiLCWQ5n4yuYmimXPPLcrflwOvvNP1OMjIVZxVHZdcrf8KF0kBW0A/ogcGl4JVf/ZAof6MzsyhcKgjuNNLqfLg4R0jp3Fc1S4R6ka9xRL2nHmh 7xXRfzgt xEPSH/K4+5qLDHGW8rXwsDZXb9DAuCTaUXFepsK7bqxoaqLnQ9msVbAYavcV+yrKRCI3AoTlyWAecnqf6b8XHe+1/RlYYukqEq/UV4XalMP5/MZKzXdaxncSbqcYhXtTRedCURvt/Xz2C+BVTPCk3y2R/2baak8JI+1QlDuZoSxomvPktL8t9zcHRYCVsWoaqWy5wbEWdpNKDz2sx7Kcuie9nL7z3vhE7GtEiaXEOJYSkiwHkfUC3KvQkAhHKONF1xDt/UqL6xSgou13FXiJey8QdgRKuO7GGKAQ3Ry7nn65s5gVcK0dHP++OxxhMwKn11gllRvQDZgSoFTY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 20, 2023 at 11:44:25PM +0100, David Hildenbrand wrote: > Let's just call it "hugetlb_". > > Yes, it's all already inconsistent and confusing because we have a lot > of "hugepage_" functions for legacy reasons. But "hugetlb" cannot possibly > be confused with transparent huge pages, and it matches "hugetlb.c" and > "folio_test_hugetlb()". So let's minimize confusion in rmap code. > > Reviewed-by: Muchun Song > Signed-off-by: David Hildenbrand Reviewed-by: Matthew Wilcox (Oracle)