From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5119DC35274 for ; Thu, 21 Dec 2023 04:24:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9DD506B0078; Wed, 20 Dec 2023 23:24:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 98D376B007B; Wed, 20 Dec 2023 23:24:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 855386B007D; Wed, 20 Dec 2023 23:24:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 721436B0078 for ; Wed, 20 Dec 2023 23:24:46 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 32DEDA19D1 for ; Thu, 21 Dec 2023 04:24:46 +0000 (UTC) X-FDA: 81589534572.18.6CE0027 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 7870DA0008 for ; Thu, 21 Dec 2023 04:24:43 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BJyFJ2i5; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703132683; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WhkevBRKRAIXA24fCJp1C71d7JyUUhFCr+p5mrM6R0s=; b=YZAwBrPJu9FAhmX0+VpHbYTtUl1/vsR8XE6zv5VfqZj5RzFIfRQsN9zj5k5MoMERbsx2Qq WosuOrjN2ZNp+2yJoEBZAp7K2knbIPvaxaBbSNDM5AxyBoeCXTdvzG/Y36avq+D82//dyL 4N3aUo/BF4nVFOdUaAOb3uLA/brcZdE= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BJyFJ2i5; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703132683; a=rsa-sha256; cv=none; b=j9QHIjxzsRx+hV6yBqUM11ZcHYfDNhZCutnQ3GL/EAHhAbo4lYmoGCESwRhmNIPuewH/3c fYv4Be8Ko3HuUWJJCuKDvl8z4BP9t3Gtb+cDBcyv0Z4IKLFHBdbvmb+KvjUISO69zRofD4 ozOT3hYfh+2qC007skVlreVVXyjhJKU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703132682; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WhkevBRKRAIXA24fCJp1C71d7JyUUhFCr+p5mrM6R0s=; b=BJyFJ2i5vSMOm66FOLRDcRN9j8GAE6TpsNARwFnAreP3DB2vUy6WCk1ZHS7z4OmxNJc6q1 6vXUMKRmrpQ5GOqzx7zpXw/+KWntLicPlM0kd5Vc+Yc51DN7cmKWPSB28M+i5u82NdikUQ AV4R0XJF79kiuCtq5I+gasu8q/naZ8Y= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-591-O5_yBCcsMgqWoLnAiNkmRg-1; Wed, 20 Dec 2023 23:24:38 -0500 X-MC-Unique: O5_yBCcsMgqWoLnAiNkmRg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 535C038562CA; Thu, 21 Dec 2023 04:24:37 +0000 (UTC) Received: from localhost (unknown [10.72.116.38]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5A42140C6EB9; Thu, 21 Dec 2023 04:24:36 +0000 (UTC) Date: Thu, 21 Dec 2023 12:24:28 +0800 From: Baoquan He To: Al Viro Cc: kernel test robot , oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management List Subject: Re: arch/sh/kernel/relocate_kernel.S:38: Error: invalid operands for opcode Message-ID: References: <202312182200.Ka7MzifQ-lkp@intel.com> <20231220060030.GV1674809@ZenIV> <20231220173710.GX1674809@ZenIV> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231220173710.GX1674809@ZenIV> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Rspamd-Queue-Id: 7870DA0008 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: kecuziye3uc34g1ont35dbu61dp1znaa X-HE-Tag: 1703132683-108411 X-HE-Meta: U2FsdGVkX19kQ2U8XyGkJEZj7TUQrSHW6claAVMOelFgtv0EWaPUSLKtmFLYp/BfiBGG3iF21SDjazB5JPms07BDh46ApOEP5FaOvq2Y1xSAZb4n3yLdZXHLOAv9MjM2XPKVdUbvos7wMr2qV1Qx4N2yWqDFM3o4XxKgqdlSKhkOFFZ55irLTaiNjDxFhbKvo06M8YBpwcBi2dEkMuhBtM3nq4AR8/9j04deXQgcr/S1QFfhi1Hpc8ZcXSKdswMvA70t985N+2l5MHg7caCy2qQ2/d+HotkVpxlmuylhRNhkr0GCvsnfKaU2FRWhzB2TMcPrBZMmKp+r7+9uklsB0OkWt4GVywUaqcsChyS42AMEfIbTMSDlVYpk3jZsQ6FvfHyHXeWtVwZlaOhuhY2fSPtHqDwA2TaHn+qS4FgkTuBgicuwVwXroxv1a7U4M+qQg9zyFItbz1kxZAhZ3CEQRLDmFPtaOskk5FMyrW1vQ9VjU5Qru4eCft9PKXUWaDVVp21ROE28ikWkK6pGcR1IdHtrn/QDgSm9uehoqyqpcLWcl2F7dSVnjTgUDeCbP63tB+2SuOfg56xR6QtjaKtHlEN6AeZ1eX3JEFIfYBD5q80aRWaposPHOu8wdR7z7rxXbMeftl8XaXz11s8SZfAKWvYUwnnlH+Uqa/Jm6yiEMk3+t2JvG8PB/eABFzOF8qzAwW7jLNQNQ3NbDPNSDUieh/poEmcm+wgBLqHR+JGLJMwH3mZveL280ZUCiePJM8xhDmtUSwEU4KRtf4RiPyG8zfrMLIamhszHFXBxJL2V3A6SEgOcSEdXNvmwdxz2v2xt/yrZ6E6a7dDYjOJ51dv5r8i4nKr8P6z0OxPyMZI6MgfEtbsNxljesEh6TepSNpbRx37KzIxXK/2fLoIxiwNx/vTNl4jeOkeSli+hEtFquoXh/TJ5qKHkVkiOplwu12Eigfq87phC8eaNJfUXyYX KNtGHA67 wWESyUzfuUfAiH8E42NF1zJX/A5XIVKbIKvVKqliNALvwQLCiAZZFETdRIcOaWcWlFy5pwlv4aTWyJo7Wq2F5ics4Jb09GO5rmrb6HG5GiCJvxXQV9pAFkAV92QZjsDamLS2PhbYOStW0DpBslA9MHzC/IC/PeM+cswG9Hnam9DTMSAgfZtw89GL+Vy/9kDYV8n0uCLx4bURgQ0mJyrgmvpiTAMXrY2DvQOsNZWkZ9MK62E0ikwY8yHuFRw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/20/23 at 05:37pm, Al Viro wrote: > On Wed, Dec 20, 2023 at 09:27:32PM +0800, Baoquan He wrote: > > Since the kexec_core code building depends on CONFIG_MMU=y, we may > > need to add dependency on MMU for ARCH_SUPPORTS_CRASH_DUMP. I made below > > change, do you think it's OK? > > > > diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig > > index 7500521b2b98..fe1500871648 100644 > > --- a/arch/sh/Kconfig > > +++ b/arch/sh/Kconfig > > @@ -548,6 +548,7 @@ config ARCH_SUPPORTS_KEXEC > > > > config ARCH_SUPPORTS_CRASH_DUMP > > def_bool BROKEN_ON_SMP > > + depends on MMU > > > > config ARCH_SUPPORTS_KEXEC_JUMP > > def_bool y > > > > I'm *not* familiar with crashdump or kexec machinery, let alone the > current changes in there, so take the following with a cartload of > salt, but... does sh crash dump support depend upon the code in > question? From quick grep it looks like we only want it in machine_kexec(), > so the conditionals used in the commit in question might be wrong... Hmm, I checked commit d70c27b728b8da1 ("sh, kexec: fix the incorrect ifdeffery and dependency of CONFIG_KEXEC") again, those ifdeffery of CONFIG_KEXEC_CORE should be changed to CONFIG_CRASH_CORE because those embraced codes are crash_core related codes. machine_kexec() is needed by kexec reboot and crash dumping. We either enable CONFIG_KEXEC_CORE, CONFIG_KEXEC or CONFIG_KEXEC_FILE only for kexec reboot, or enable CONFIG_KEXEC_CORE, CONFIG_KEXEC or CONFIG_KEXEC_FILE and CONFIG_CRASH_CORE, CONFIG_CRASH_DUMP to support kexec reboot and crash dumping. Seems KEXEC_CORE codes can be built not relying on CRASH_CORE, while CRASH_CORE need be built relying on KEXEC_CORE, otherwise it doesn't make sense. Anyway, I will try to clean up the ifdeffery so that they looks clearer.