From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE1EAC35274 for ; Thu, 21 Dec 2023 04:09:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E64A36B0081; Wed, 20 Dec 2023 23:09:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DED666B0082; Wed, 20 Dec 2023 23:09:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8DF26B0083; Wed, 20 Dec 2023 23:09:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B5B426B0081 for ; Wed, 20 Dec 2023 23:09:32 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8B317A04B4 for ; Thu, 21 Dec 2023 04:09:32 +0000 (UTC) X-FDA: 81589496184.23.E28153E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id 04798C0002 for ; Thu, 21 Dec 2023 04:09:28 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ae7VBn7j; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703131770; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p6d3JusNTbIjN7yfIOJ3VrarRe+uq8kWXbELto6+bKU=; b=lso7i85egWAwlhvYPBs+qD0w7EpeK4d9IpyBKfywUtctKr/NrGls9eRPL8T6PjmHzEkN7S I3DdejNdAVJdE8YwldKB+Cdp4i212jVEwBFHUeM5LNautiF5lKMZfzCD0HfkRFJ0My872K qAnEB9hUGYN2sijlzEvUHnYTZed+cVQ= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ae7VBn7j; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703131770; a=rsa-sha256; cv=none; b=CpcvwXLJchRPyVRcynqGpHeQGuZk/8evy/IsUTxVJs3aHSB/0VhbbewAdJmCfLkCZaRNGk CO6lJ4UGpO5Lax4ZX8h6k/eqYBK5UfEUAo/LQ5s+dcJWI9LpK1UBx7foFxruOQVt0SKI3b kQtaSqPRdWt/l0Qcf1sGXmfOjBNn4vY= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=p6d3JusNTbIjN7yfIOJ3VrarRe+uq8kWXbELto6+bKU=; b=ae7VBn7jMkc059d6wg7B4dq5V+ ghRqhxdB2VsgXmGDT17BciX/HOdKWPNmUr8MA9D1iCwa9WnpkiU+Tr+vkEqwp0xQJXjiraH0ilTmr NDiEsri/7/8seTi1E1z1E1m01RXLSpTDKBHzS5a2IYXKV5AR0vP8AWsJzsYjHiBltqBMsIWM4WOUS n8khQ8McUz6Ozv1Kd+Swr8o8p7tI05Dmn1+c/RmrJR2fQWfSgbVSBY5n8Y9jCAbZb2ImMwFO+t3in 0RhQNvghCDV/3I8B8Z7BcAS4GLmdspdPVy2YEsIFEyenkVE2VQMrl0H4A9MD1y1llLIxfX78tc/En tpMY8/9w==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rGAN2-004e2w-Tg; Thu, 21 Dec 2023 04:09:16 +0000 Date: Thu, 21 Dec 2023 04:09:16 +0000 From: Matthew Wilcox To: Zhaoyang Huang Cc: "zhaoyang.huang" , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, steve.kang@unisoc.com Subject: Re: [RFC PATCH 1/1] mm: mark folio accessed in minor fault Message-ID: References: <20231220102948.1963798-1-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 04798C0002 X-Rspam-User: X-Stat-Signature: kc7tbym95cdx69ain4f7usafakggkts3 X-Rspamd-Server: rspam01 X-HE-Tag: 1703131768-518122 X-HE-Meta: U2FsdGVkX1/tr3Ia9foSg29u0uEeo3jHXjMSqXI+KDZ0xLRNsS9aUVeOn6BMzrkc0XPnOTcwl1U2PEx70JKJC0rkv319Be28R3HCpgaVGG1AtjkS8jA+tNYxPB83hio2CdPLm9VG22pfLrfLcTQ5kmrPadFdbKTl4QrQ5bUQgCFS799Z7/05KMHzxtNFQ6h2y8GDYZcTH05JZtTl8TYc2BYjYK04qdxh6fgJEvgdvf4zOu417ErPE2moG1TMnuwv8EzKuB+3QCmYX9yFyQjrCaptmanL0l8VA/SNStnq4cJMtZnvFP2YRK1nw3SHdzTjNS0KvRCSKEghtmg88CwKHPgcdoI/do5Y+9E6BeZiI9p2eXEDm7NSOnvsApSD6tLQ22Dv1Hc3FuxQtF7ItJQTnm71aWfcJr5a1graUnOB54+yu7CJHZZNKWOzufi8+wdq9MPZ/hrSTGGMRYiAfR8wNTNMK5uQuBWXP0uEzFtWUl+u9wGfDPioyoQ0TbkvBQsvTHe0woXHoUVXD7OOtUGYkh953em5PDXR1iEFW5++btmjpj9eLVigDHskIT9eI5vCkZfdIA7kI3F7tIjoP90iZFX02p5WEqa9hpapMxc2F6lqN0Ckra++VnFDg3ruF9C/Ggm2socsPy/V/YnrEOBUMlszF0Ale9w09oYU4mF3GLduFfpGSC+kDHyElntvkQ4+do3WnhGjMvBLlHxmcaPtXDT4PViNz5QzzngjhEx4x6ZElwn9xcTjgoJ2nDHTeGrsO63HKc2Vp0951pOpJLrfj6YImjVF0sfjVjGXHqJUbHEEnJiKh7xsxxkX1rHkpfhmv82oWXjQz0bQ8dkgqeWCXMRGFT35Ly62+ToCNrNJ6FutSNeCubWIG+Jq7dK6FKSt35ojkosk88+Qu7hxqSoWp1P5LsyG/nMEdCia+omohaOlWxPWsqK8zxhgyEPnG1qjNC/CGjKWFG4cpBWA0q7 D/GI0YIM 4HSgZYgMufh/wOrUnK/1Jn2ykS/iU0XtAro5Nhsz0M5MlnJ9BwojGz/RcmHNLU25LiuS8zBpt8ZHmgdVGASXYhLlW8nSez5prWQMnxNekCkAmo5V0694srgEqmaXrjAaVfPeed9Og+sFmVVSjxvD3fQ8/f68fEmF6fD16XZLerpz6EmoXYmwct1M7CTawJupLnqgixipt0AHH+zV67kUg97HKmenJc1bSYeDdFnzBZg3f+LQujLoZ65M4MYgNVyhjSGks X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 21, 2023 at 09:58:25AM +0800, Zhaoyang Huang wrote: > On Wed, Dec 20, 2023 at 10:14 PM Matthew Wilcox wrote: > > > > On Wed, Dec 20, 2023 at 06:29:48PM +0800, zhaoyang.huang wrote: > > > From: Zhaoyang Huang > > > > > > Inactive mapped folio will be promoted to active only when it is > > > scanned in shrink_inactive_list, while the vfs folio will do this > > > immidiatly when it is accessed. These will introduce two affections: > > > > > > 1. NR_ACTIVE_FILE is not accurate as expected. > > > 2. Low reclaiming efficiency caused by dummy nactive folio which should > > > be kept as earlier as shrink_active_list. > > > > > > I would like to suggest mark the folio be accessed in minor fault to > > > solve this situation. > > > > This isn't going to be as effective as you imagine. Almost all file > > faults are handled through filemap_map_pages(). So I must ask, what > > testing have you done with this patch? > > > > And while you're gathering data, what effect would this patch have on your > > workloads? > Thanks for heads-up, I am out of date for readahead mechanism. My goal It's not a terribly new mechanism ... filemap_map_pages() was added nine years ago in 2014 by commit f1820361f83d > is to have mapped file pages behave like other pages which could be > promoted immediately when they are accessed. I will update the patch > and provide benchmark data in new patch set. Understood. I don't know the history of this, so I'm not sure if the decision to not mark folios as accessed here was intentional or not. I suspect it's entirely unintentional. By the way, rather than inserting an explicit call to folio_set_accessed() in filemap_fault(), change the filemap_get_folio() call to __filemap_get_folio() and add FGP_ACCESSED to the fgp flags.