From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B77E9C3DA6E for ; Wed, 20 Dec 2023 13:27:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 58C7F8D0002; Wed, 20 Dec 2023 08:27:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 53C728D0001; Wed, 20 Dec 2023 08:27:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42C348D0002; Wed, 20 Dec 2023 08:27:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 346118D0001 for ; Wed, 20 Dec 2023 08:27:43 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0BC1C80B3C for ; Wed, 20 Dec 2023 13:27:43 +0000 (UTC) X-FDA: 81587274006.09.D3739DA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 46DDF140012 for ; Wed, 20 Dec 2023 13:27:41 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ciger4O+; spf=pass (imf23.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703078861; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oKIB9gFYr7Un1QLzbk3UPXWE4HqA26pp2IjPiB0lSto=; b=e+bG0hCHe+J15HyLkSKcCqKrteP9aftzcg2MJkANTVcF3jiPdbkH4oH8IyfEnLR7mZ/jkn G6EROQ2SCxUEVv3n4s8P8XLKTqugCgL3fzqhgniXaKZgsfSt54zIQ6h/D7YcybYPWadUC3 lACMoBeQ9mbcumDoPddxJY6xrAaglik= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703078861; a=rsa-sha256; cv=none; b=4jTjKDWdrNm2qaFUmYnRrZ8gxUZnjsU7eCMTTB+/AzFIUNAmC+1y/nkp8LZeGHTnO6uU3z OPH72q8ukeVtt5xTy2R6+vNHXKcreHFA162MzUbJYgZA+TGDdmqB/AE5ociYvLkTiQNZBg Bd3cPpWWz1fXLUIP/nwi/X8Y1nyMRao= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ciger4O+; spf=pass (imf23.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703078860; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oKIB9gFYr7Un1QLzbk3UPXWE4HqA26pp2IjPiB0lSto=; b=ciger4O++PXytOTjomWm0CcgwrIexlO0h1J4j4dmYjzcakeXNXquhn4r5iv9n3tNu5PFeK TuaVYJqNAzdhE53PTp2T7n+KWMGRxD8fjIuvhDGIuz+k0k1b5UUiCCifs28SMQ3NOw5HjT Tn/Gb5XkF0jKVqeyoGru2qx7x+BJiqg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-cz9FcmV8NIeYvcpQSrSHhg-1; Wed, 20 Dec 2023 08:27:37 -0500 X-MC-Unique: cz9FcmV8NIeYvcpQSrSHhg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 61A41836F21; Wed, 20 Dec 2023 13:27:36 +0000 (UTC) Received: from localhost (unknown [10.72.116.38]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AF0B92166B31; Wed, 20 Dec 2023 13:27:35 +0000 (UTC) Date: Wed, 20 Dec 2023 21:27:32 +0800 From: Baoquan He To: Al Viro Cc: kernel test robot , oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management List Subject: Re: arch/sh/kernel/relocate_kernel.S:38: Error: invalid operands for opcode Message-ID: References: <202312182200.Ka7MzifQ-lkp@intel.com> <20231220060030.GV1674809@ZenIV> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231220060030.GV1674809@ZenIV> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Rspamd-Queue-Id: 46DDF140012 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: msq4k3ct1wkwxs63xyeqip5381wfp5r9 X-HE-Tag: 1703078861-281346 X-HE-Meta: U2FsdGVkX1/kU7O4L9kyLNyLztfSEdfrtA/HhvWN9UCNpnIzXj5HBwiNF1KXPlgjZ452gouhT3dqtfFmkukubDbEwr3PRPRI93EsLzNAhXwx0jZSm1EOz58KMeadychZlO/vwj7g6OhhJT7KG5JaTcGIoOQPumzfavJVk4QMpSorPLtq5H3Juw80livdyPn1EJb0B7BpeJ8UZu8sd0NI82mOZPJ7qkBgTvJ246mng+uUvZc1BDVCRv3PkLLRI1qTN0muRkDOxu0I9yMHJcYMvEbr3Bk8TVTGlxWOYgrI+UE0WvRoxd0MDfUWztETsM4N951I8z22KpsMpiRMnxJolsRy2Yre8zaIlW5dAcpnGhXnrZRGGBNiKqMES6BFCxS8Zo10jpviygtLbLvOsbUgX8bQavUwGN6YTL0KV5pwxgnShieIhCs+zJuErrIAa8mhpLAuRAVD/tXbSKp4Jkgn0CVFUH3PA8FGkshnBxmmURyFDUd/Hw/BhRlMFwC0TzmNsGXVbjilHd5rkTftEKbofWmfVdObDe8CXJWh9yS3JT+w4RxAMdcExi9P+qzZjZsxBMeLcjG8JAxwcFGNPV0bGfPd4g3JqxMrv5z5fQNv5ALikAs0oC9/ZHhW1n/g6qiTzz0IyA2GCIOjcXHxLh1OSx6uOOdl4x0QZyNUR3fAMiEID98/vGA2P/WIAqer1oU0Hvc9ma3r3CaGsEO7Uv46bXdRXTIC6kgWnrPdlAV8EqAORcSFXkgQuXhOFToI/4NKO4x1TZN21ua35wZbQ4k0lNs6YpXHA08TTBb6wPIqzQCxBLWBQbyDbbXS79+RC8FLXrBUakX3RYxSYWGUuefrA4IcRZG9wM3EyLf4iIJCkkz48bKlmxUFFs5Hze95HIz3pIFVdKDXuKXQ1wB/Nh37X2hIzV5tVFtGXk3TwKXTjzvUhorGSXP61EAXu+1tVRm/vPHOx/StLH4fcUJbUsr I8/4y07d PXT5p/L35ozX8Vps/SUWAWoQ7wE/rZ40MfjgrO2cM0Ub5CK8g3Mx7u1JSaRf4K8smEd1/3A/yKMylrTE7C1mx5Nj0NvZ+me3JtA9QpJQeA/aGoYu2Zxsof0qB+kNjQdtinE7yLBIJOjcMABw+bLvTYVSLpuKHR+6Z3zVhwQGqqYMiG1QouNX/rGXemWK1ab3QtddkL4u4b6TD2Uo0EytRvgvC2aeavRbPjsljXXpL+L8NsnJtmbh3gFeRTA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/20/23 at 06:00am, Al Viro wrote: > On Wed, Dec 20, 2023 at 01:44:19PM +0800, Baoquan He wrote: > > > > arch/sh/kernel/relocate_kernel.S: Assembler messages: > > > >> arch/sh/kernel/relocate_kernel.S:38: Error: invalid operands for opcode > > > arch/sh/kernel/relocate_kernel.S:41: Error: invalid operands for opcode > > > arch/sh/kernel/relocate_kernel.S:126: Error: invalid operands for opcode > > > arch/sh/kernel/relocate_kernel.S:129: Error: invalid operands for opcode > > > > I reproduced this error, haven't got why and a way to fix it, will come > > back later if I have fix. > > At a guess - after that commit ARCH_SUPPORTS_CRASH_DUMP is enough to enable CRASH_DUMP, > which selects KEXEC_CORE regardless of ARCH_SUPPORTS_KEXEC. And on sh you have > the former selected on any UP build, while the latter - only on MMU ones (i.e. > not SH2). Yeah, you are right. I managed to set CONFIG_CPU_SH4=y and CONFIG_MMU=y, the building passed. --------------------- CONFIG_CPU_SH4=y CONFIG_CPU_SH4A=y CONFIG_CPU_SHX2=y ... CONFIG_MMU=y ... CONFIG_CRASH_CORE=y CONFIG_KEXEC_CORE=y CONFIG_CRASH_DUMP=y ----------------------------- Since the kexec_core code building depends on CONFIG_MMU=y, we may need to add dependency on MMU for ARCH_SUPPORTS_CRASH_DUMP. I made below change, do you think it's OK? diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig index 7500521b2b98..fe1500871648 100644 --- a/arch/sh/Kconfig +++ b/arch/sh/Kconfig @@ -548,6 +548,7 @@ config ARCH_SUPPORTS_KEXEC config ARCH_SUPPORTS_CRASH_DUMP def_bool BROKEN_ON_SMP + depends on MMU config ARCH_SUPPORTS_KEXEC_JUMP def_bool y