From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2F60C3DA6E for ; Wed, 20 Dec 2023 13:10:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 24B566B0080; Wed, 20 Dec 2023 08:10:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FC0B6B0081; Wed, 20 Dec 2023 08:10:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C38F6B0082; Wed, 20 Dec 2023 08:10:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F04A76B0080 for ; Wed, 20 Dec 2023 08:10:00 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A46C4A0B67 for ; Wed, 20 Dec 2023 13:10:00 +0000 (UTC) X-FDA: 81587229360.14.DD0CF08 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id B87FA40013 for ; Wed, 20 Dec 2023 13:09:58 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=geH8Po+2; spf=pass (imf01.hostedemail.com: domain of jszhang@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jszhang@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703077798; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FTZS4YBaJ+PLI1G+1Lqx3Cjaa9VsIGCr/mf0fz2eOeg=; b=6fLAcMedk0pw5dvLBW/L6byj6vazcsS+PB6/8sYRVrobMsaSMnQnEZMhklxM0tZuGJ2AUA LvsmIBZzGTiFlKhXXMTMW2Wppr7RPVCNFQaabdVk4tsGjWfMtpRRoUVRCNDQ8r0QvUOYOi tqaQuL/jSx3+YmfPO0nxNrqYXbI4U5M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703077798; a=rsa-sha256; cv=none; b=Fg5i6vLDtjBjVj3Ix7Hwmb5yGDWSKbdarDlF+LcWLmT6jwSzjpcgoKCK0isrHwbqIg99Bb zOBIQ11fbXmI6EMhK70nXGu56AHXU36H6VZremk2+E4xrVvh+lfAADlj04Sdx3WS1djKJg ynVSs0pRQv2rWA2aj1zNS2nDJb5CLZU= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=geH8Po+2; spf=pass (imf01.hostedemail.com: domain of jszhang@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jszhang@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A1AFB6163C; Wed, 20 Dec 2023 13:09:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19026C433C7; Wed, 20 Dec 2023 13:09:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703077797; bh=kNBcPwaMlCBZq05QdM/ZhosCOAELdn7NQH61Zm2JFdI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=geH8Po+2xTzfgztalOer3avEmmYlxn/45tUCRRhRPkul1OdegcfPNbzZr3tlUU9gL Gr9cAMJrqZuYg4ZXywlT8vSMjii9EQa5EbRzNrvsitbUMRrwbGZ+Vs5h7oma4+HXCX Y6lx9NhOjzB4pblu7fVu8HdFsBrqgIGPmNWbmGUcFzrh5wBtM9iKG3YDgpGMKzvzlh 8vB2ywPk0x3h2DIr7Fq1JC41iWIBZuH9vX9FxlyK05Uq+uzcK1I4v29L51UH7MToRn KnLrmtlosx1RWynwXEXaab9s09kXI2/VKwn3Z8VcssHKf3wD1CPcmCmEDqkbqzUfsQ heTJfZCiYSM3Q== Date: Wed, 20 Dec 2023 20:57:20 +0800 From: Jisheng Zhang To: yunhui cui Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Will Deacon , "Aneesh Kumar K . V" , Andrew Morton , Nick Piggin , Peter Zijlstra , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org Subject: Re: [External] [PATCH 2/4] riscv: tlb: convert __p*d_free_tlb() to inline functions Message-ID: References: <20231219175046.2496-1-jszhang@kernel.org> <20231219175046.2496-3-jszhang@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: B87FA40013 X-Rspam-User: X-Stat-Signature: xkazdyp55abq5m9za67kfbxztyziqtg7 X-Rspamd-Server: rspam03 X-HE-Tag: 1703077798-692323 X-HE-Meta: U2FsdGVkX1/hWLDKXOBwwKWHS+QZu9S9lvGMvPty9/t8GqCDuEnuTdiITUOmtaDxU8ltDBwgst9Gu5uX+GrvNAKoP7aAVvAiAJUxopFtRg5ZI1uxQggpQN5JvjClLvUdLRJ5ZkHljypWSZNdsDCzKnc5JoIg/r7G7CnE2ZRvVZNZ10cf4rzoRMN5/yKspJEqqPJnN9LEdb8dZRdRlhXCyOwhNMfCZuF4pwuniK2aDksSUG5AD3V24eLbTXQNsdKD52RcfDubINcwLlW6GrfrFjA0M10hrI7YFns8sRmEHDKzIPWXxfTTYrEIzJ3cfSS28Wdf3T7RwKPlGhqhGPfsIT8ErpbCjN62QCgfE5uR27c/LnD/uJQ8BBYybVd8v0qU+ynFDZZUUWzHcUdYY8dUWUpIIgS5sYIXwVdQiXVbhNvrE7uwnariQue5Uo7w2fHZveuZdPtZsMkNbJT2a4NaxX5Zlgyd7ugDo1IuaoQH1e64Erl8qZ65rXvNzvNNOjsLkUM14UqKwjzA+osTcJd2jzH/1/FrovSsQApI53kecU7J3uthu8FPnuH8Hv2phNRlsSsQTPsT0XVuNhFFiK26i1fu45OUVST9dobztbVWrz4QuHGpkyuFpEgGnHug4rs6/J4r+ztoJGQozBNjN5MbDCQO0fs3jwa78CXW+WjgjbER/0Ycg67tbjVtr3NFZOn344Wv89Cym5yNRgQfNLLXYlbYc8l+aQmTTqIu27pDDd9pFpQvZbtNtC0ouPVgYNdRWMrilYHLkB9tojF9Qsow4RHSpW4NDr245mWHsMpHv0/XB/HOs3uw0rZeQhuwarnztiLd7umqaUqpog4lhfUDXFum1b12YCeJa0aThf6vX+y+3th+67n4oN2Nm4E1o4gYsDX+aiv3By2Ol1pHEkeCvKrynAQdbzXmLwyUUi7j3j0hWw1EN0oFri3aYmphHRYmpBKuDvDcru0AteI2L32 SSbbSRSF 4uUO+c4vjNXJzvudifIFEBKjUCKrPSuc1ox/RsXnhEE/8kbHjpfQyx18/N9mUn7UzRgqv/X4pbNcSmcfdNZjNcFbLRrYwO1sTi1uQxNsBElKwAEjWuPoNe6TNbeSaZI8sUgWs6pIOVwVSpvadUGTvQUb6pjp0OsW4aAIbSBiM+X9RCUzdbd7Zl4cKPNIxWiSJi/r8SHT+fdIm7X3svgMVsneDarPbaa5PegQDDIzipNjJ3T55fWQw/cev9UZD9rie5sdrDi/1Kvceob0W78RcLl6QypGUlHhD8NA/aj+iOE8uky0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 20, 2023 at 10:59:22AM +0800, yunhui cui wrote: > Hi Jisheng, Hi, > > On Wed, Dec 20, 2023 at 2:04 AM Jisheng Zhang wrote: > > > > This is to prepare for enabling MMU_GATHER_RCU_TABLE_FREE. > > No functionality changes. > > > > Signed-off-by: Jisheng Zhang > > --- > > arch/riscv/include/asm/pgalloc.h | 54 +++++++++++++++++++------------- > > 1 file changed, 32 insertions(+), 22 deletions(-) > > > > diff --git a/arch/riscv/include/asm/pgalloc.h b/arch/riscv/include/asm/pgalloc.h > > index a12fb83fa1f5..3c5e3bd15f46 100644 > > --- a/arch/riscv/include/asm/pgalloc.h > > +++ b/arch/riscv/include/asm/pgalloc.h > > @@ -95,13 +95,16 @@ static inline void pud_free(struct mm_struct *mm, pud_t *pud) > > __pud_free(mm, pud); > > } > > > > -#define __pud_free_tlb(tlb, pud, addr) \ > > -do { \ > > - if (pgtable_l4_enabled) { \ > > - pagetable_pud_dtor(virt_to_ptdesc(pud)); \ > > - tlb_remove_page_ptdesc((tlb), virt_to_ptdesc(pud)); \ > > - } \ > > -} while (0) > > +static inline void __pud_free_tlb(struct mmu_gather *tlb, pud_t *pud, > > + unsigned long addr) > > +{ > > + if (pgtable_l4_enabled) { > > + struct ptdesc *ptdesc = virt_to_ptdesc(pud); > > + > > + pagetable_pud_dtor(ptdesc); > > + tlb_remove_page_ptdesc(tlb, ptdesc); > > + } > > +} > > > > #define p4d_alloc_one p4d_alloc_one > > static inline p4d_t *p4d_alloc_one(struct mm_struct *mm, unsigned long addr) > > @@ -130,11 +133,12 @@ static inline void p4d_free(struct mm_struct *mm, p4d_t *p4d) > > __p4d_free(mm, p4d); > > } > > > > -#define __p4d_free_tlb(tlb, p4d, addr) \ > > -do { \ > > - if (pgtable_l5_enabled) \ > > - tlb_remove_page_ptdesc((tlb), virt_to_ptdesc(p4d)); \ > > -} while (0) > > +static inline void __p4d_free_tlb(struct mmu_gather *tlb, p4d_t *p4d, > > + unsigned long addr) > > +{ > > + if (pgtable_l5_enabled) > > + tlb_remove_page_ptdesc(tlb, virt_to_ptdesc(p4d)); > > +} > > #endif /* __PAGETABLE_PMD_FOLDED */ > > > > static inline void sync_kernel_mappings(pgd_t *pgd) > > @@ -159,19 +163,25 @@ static inline pgd_t *pgd_alloc(struct mm_struct *mm) > > > > #ifndef __PAGETABLE_PMD_FOLDED > > > > -#define __pmd_free_tlb(tlb, pmd, addr) \ > > -do { \ > > - pagetable_pmd_dtor(virt_to_ptdesc(pmd)); \ > > - tlb_remove_page_ptdesc((tlb), virt_to_ptdesc(pmd)); \ > > -} while (0) > > +static inline void __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmd, > > + unsigned long addr) > > +{ > > + struct ptdesc *ptdesc = virt_to_ptdesc(pmd); > > + > > + pagetable_pmd_dtor(ptdesc); > > + tlb_remove_page_ptdesc(tlb, ptdesc); > > +} > > > > #endif /* __PAGETABLE_PMD_FOLDED */ > > > > -#define __pte_free_tlb(tlb, pte, buf) \ > > -do { \ > > - pagetable_pte_dtor(page_ptdesc(pte)); \ > > - tlb_remove_page_ptdesc((tlb), page_ptdesc(pte));\ > > -} while (0) > > +static inline void __pte_free_tlb(struct mmu_gather *tlb, pgtable_t pte, > > + unsigned long addr) > > +{ > > + struct ptdesc *ptdesc = page_ptdesc(pte); > > + > > + pagetable_pte_dtor(ptdesc); > > + tlb_remove_page_ptdesc(tlb, ptdesc); > > +} > > #endif /* CONFIG_MMU */ > > > > #endif /* _ASM_RISCV_PGALLOC_H */ > > -- > > 2.40.0 > > > > Why is it necessary to convert to inline functions? Hmm, it's not necessary but a plus, the inline version's readability and maintainability is better than macros Regards