From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A955FC46CCD for ; Wed, 20 Dec 2023 07:15:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22F2B6B0078; Wed, 20 Dec 2023 02:15:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DEDE6B007D; Wed, 20 Dec 2023 02:15:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A6DD6B007E; Wed, 20 Dec 2023 02:15:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F01676B0078 for ; Wed, 20 Dec 2023 02:15:04 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BC7B9C09C2 for ; Wed, 20 Dec 2023 07:15:04 +0000 (UTC) X-FDA: 81586334928.24.2C4CCF2 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf14.hostedemail.com (Postfix) with ESMTP id D9BB3100012 for ; Wed, 20 Dec 2023 07:15:02 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=h5RKUMIB; spf=pass (imf14.hostedemail.com: domain of htejun@gmail.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703056502; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eJqWdKRl0UBq0Wj+r8chL9QmhrnrulM60eoe1tH98KY=; b=577Q12K/bCzHBcicgLI7VYl/YweijDZBItF+ct7fiWlKT72NiGaZf7p3eM3+w3Y+dhBvO/ nexl5erZOuzQylSmHO+5i7yx/cZ3gcere5ZZtQLtw6PjX5PDFmRo9Qvblr4pEAQyxOMjpc C04/QrRy82fQ76C2JlPs83vKCnaBTX0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703056502; a=rsa-sha256; cv=none; b=WSXXVNbqvlX8fzwgiiAReytaGSfTjR9/gi9TRoxI2WT+dsXB/AAn+zmWaXtsbSHX4vGuBc ffc7y71H3Gjr97b/+0FDn7p7o+vTD40zzgEijnjBg3jMH3i05v3VfXyzZuFCKNGp4AQEPn +l27Wp4xhKKhcAis/FvqL6Omu+V/woM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=h5RKUMIB; spf=pass (imf14.hostedemail.com: domain of htejun@gmail.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-6d5c4cb8a4cso1988856b3a.3 for ; Tue, 19 Dec 2023 23:15:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703056501; x=1703661301; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=eJqWdKRl0UBq0Wj+r8chL9QmhrnrulM60eoe1tH98KY=; b=h5RKUMIBm6/duehmM/K2rJU2StICjVMNyAFNEoNv9n849tyfJEQ34Vyrtoj/kvsed8 j4CGfPM0S8BBLGAH3SW4MCywn+PMt4gWpRk6Y5jsBpPYIwNYqKtd98jbXZdRgTnLmcN5 pox5YyhqG9By2rteRxbH74t2+jTGEHZo9q5gx2zo3nE4j3cj8prhGJYBY3vWXYzzUFgJ Lye6yOCXoPIw7bmOcrqQow48VwSTVEdQ+8AZfQohSC9A7WAfEyG02rFnVDehGFCv0pD1 nH0EKjtiwuhGzxQke/gtQVJ7Fpjv9HZXBYG/7KMhl6fHuinqcV4kT4HaGbyVMrZmakGl mUTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703056501; x=1703661301; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eJqWdKRl0UBq0Wj+r8chL9QmhrnrulM60eoe1tH98KY=; b=JLUTGsGWXi3WfX3dtCsdtymb4pehzpT5CRCUfCSBkFz+Qo3HFElWmRvMxYX1FtoAXG Ck4uvmU2emCYLwPEuV6+KRvpIyE41ntXkrjLnHqEyiqCLsh430U1qAuQbewlQMeZt2XY ZfQTy4X9bfu/1eU3Gs7u9KOvsu1h44JMNVJ8bDwy5jgOKC1OPr7017malDJU8gp46d+m xk+9z41BRSI5W/tNkiePoVuQomxN9OP+PyhIjd1AL/ckUku4g6zQAcCtW22cLpwwUtdI 17U1DeZRnaJUb2rRHZZcIHscd+RhN/+qQsMoLs0zmDjpfqm3E/KvMw4gpM/dEotYl2Vd eaRA== X-Gm-Message-State: AOJu0Yzno4+TKvREYCAXBazGdmIeNHeQXdha0dmGv28AtMacS2+dHaSM 57qvVVPw943LEzKOWhAAfZ0= X-Google-Smtp-Source: AGHT+IH2/KQGWsEEIk+CfQb//I/X1FN9i9PYn0R8hU2YQDfX0MobECujamcRsnvnV4o1L8WIa9T7SQ== X-Received: by 2002:a17:903:947:b0:1d3:be34:7862 with SMTP id ma7-20020a170903094700b001d3be347862mr3583611plb.9.1703056501427; Tue, 19 Dec 2023 23:15:01 -0800 (PST) Received: from localhost (dhcp-72-253-202-210.hawaiiantel.net. [72.253.202.210]) by smtp.gmail.com with ESMTPSA id m2-20020a170902bb8200b001cfd2cb1907sm22210314pls.206.2023.12.19.23.15.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Dec 2023 23:15:00 -0800 (PST) Date: Tue, 19 Dec 2023 21:14:59 -1000 From: Tejun Heo To: Naohiro Aota Cc: Lai Jiangshan , "linux-kernel@vger.kernel.org" , "linux-btrfs@vger.kernel.org" , "ceph-devel@vger.kernel.org" , "cgroups@vger.kernel.org" , "coreteam@netfilter.org" , "dm-devel@lists.linux.dev" , "dri-devel@lists.freedesktop.org" , "gfs2@lists.linux.dev" , "intel-gfx@lists.freedesktop.org" , "iommu@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , "linux-bcachefs@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-cachefs@redhat.com" , "linux-cifs@vger.kernel.org" , "linux-crypto@vger.kernel.org" , "linux-erofs@lists.ozlabs.org" , "linux-f2fs-devel@lists.sourceforge.net" , "linux-fscrypt@vger.kernel.org" , "linux-media@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "linux-mm@kvack.org" , "linux-mmc@vger.kernel.org" , "linux-nfs@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "linux-raid@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "linux-remoteproc@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "linux-trace-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "linux-xfs@vger.kernel.org" , "nbd@other.debian.org" , "netdev@vger.kernel.org" , "ntb@lists.linux.dev" , "open-iscsi@googlegroups.com" , "oss-drivers@corigine.com" , "platform-driver-x86@vger.kernel.org" , "samba-technical@lists.samba.org" , "target-devel@vger.kernel.org" , "virtualization@lists.linux.dev" , "wireguard@lists.zx2c4.com" Subject: Re: Performance drop due to alloc_workqueue() misuse and recent change Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: ubwmiio31wkbbtgx41freph6gi5jyyfj X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: D9BB3100012 X-Rspam-User: X-HE-Tag: 1703056502-345893 X-HE-Meta: U2FsdGVkX1+QByx/Q+G/0JmiSwkR+pksWGb2xY9Hq3JVSUNHnjvdcEgaHIbRWDSacbxkXRijDYqPx6MsHjSx39CJY+9nuOThKsq/TlWNq0YrAogZpyGh7ZgeIYTfyJmsUswB17OBl/mYNdnK3HOmxV4CFqzmfYtbRLvZ0ZGPj3YdHXxG2trU/b4DGvhy9fER+A9cY53tTwe3fFwiP+FXX+VnNjxGk7vcwl5RPXXZS8+Sw7uOn+2fsLSezLCHx2+rNtwZDLqgGhwQn+jrmzU/B1dBgFF9+6maRfIfD9AA8mtidGbfBUm52AjYwmQBN7s2sIJbGUvOoFv62bdgMIpVSz04kfz9ZGonHGp+CPkrXJL+7NMIeH0BPSZJ2XMn1Uo/GWWGy0wtQmf8O7NHYSbe4lHtJZxXub/csymov2S/eG9HeEcA1jd2RLIeKEtuMt3RM+5PXgcYjuCWIchRWB6m9odIt8eWuzP+/l9MKOEeZyRNpgDJ4rNbIGNwHfR1LZDX+NJoIbEm30+J84SOOegILpsqw4xdfrgAnin/PdWKZsyRIvz+pGM8sCss2xqIo82nhYIOCR13gmb9iKk53WO0GRxl6KLX8qE0bewQ98Ax4NORibJgTIghaH2lZSzxQPIhzuZ9JamRlkv+ds2QGv2IHbXp6lC4kIvtv+XdfRLau+Upqgw2PQjhHODuss9SSn5hhYH1dpz/L5J0t6FgYxjMfSAtb8kVP5y2mOv1Wqg1pGFpUO9HYwdRZygNt1E8H9+Gy55K89upMH8cBwnUXb3uZziOtdDZXjuSP6T8GfePI3d3W61sZmi7YJWnwSO53eWsG5M1CGWZy5jSR0abUtFNGtN59w0q47S4mtcu4jiJ/9/6PCR6kElJQ4if2dY1/3ZcpfGeCReWSXsIiI5P6lbg6SSRSm9OOSPIDliSPGRdAnRIaJqm8KOVrQEnh+3Na4z3PxO6GlDb7KctLaQOwJs 6zZjyBtY Iq9dTS83gorMQGewZQnUTqFqyZk+nxJ4Ma3uKfQdDrYmDcZfmnrJI936iVGECevTAZR//pNmKSzk8YZWA0z87WC1kVwAlLmhl0XvvAEhbtwNEi3JpbmH8YG5tXqNk/tY2BeY3gSdvLgFg07rvA5YbUUeS+hDExjuT+2g5AktmyLPbQuNhkHAcRjP2hR38okKHJCG3ZM/2ZO7VNGdjXMGcTiFUiTH5j53bhUp3j6vbsMhscSZnGLoj/CUrU9jvS/tcZIrusUHXT4za0G6R7bdrIbTMAToXguXWfZh+6gOQikdxGl7CmKp/Hcp7b3gvFTbvocextiptYUNiyMkHZDqCDxjoD4bqXJhSsE15aAV4WwwPo7GugJns3uZbxEW2tJXQ8rnTzyQSfYHGSsP0TJikZNaqO8/m+MUlRHJK9Ptuc4B8kGhLn3Y1VYYLZrHfOTGbuQohWIk1wLLfk1v11WrO08TyK5Vsz3EHAYs5YrZ4xqnf2SoOJKzOuJQPg850Xc2i2iP1a+kanMsm0yJd6AJNTCI+6CR8G5WwBfApAr5/cyHm2HacQj8I9QuDssbZru8uvaRtQSXhXdLhDdwELbXB99cZqv6J5lLHRVYSYTy/5YsmnL184QPofU/fFHxJgNyuHJsRz0fCAY21yqdNS/ECpTybMtKSuaC3TNpxjpXm5bOBxx/59NRjFhrxUQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, again. On Mon, Dec 04, 2023 at 04:03:47PM +0000, Naohiro Aota wrote: ... > In summary, we misuse max_active, considering it is a global limit. And, > the recent commit introduced a huge performance drop in some cases. We > need to review alloc_workqueue() usage to check if its max_active setting > is proper or not. Can you please test the following branch? https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git unbound-system-wide-max_active Thanks. -- tejun