From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63A4DC46CCD for ; Tue, 19 Dec 2023 22:52:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D12BD8D0003; Tue, 19 Dec 2023 17:52:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CC1176B00A4; Tue, 19 Dec 2023 17:52:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B89038D0003; Tue, 19 Dec 2023 17:52:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9FA1D6B00A3 for ; Tue, 19 Dec 2023 17:52:48 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 753A6120263 for ; Tue, 19 Dec 2023 22:52:48 +0000 (UTC) X-FDA: 81585069216.07.5203A05 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf25.hostedemail.com (Postfix) with ESMTP id D7DBDA0004 for ; Tue, 19 Dec 2023 22:52:44 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YGxadkup; dmarc=none; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703026366; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MAwg2J+eab2tticeU56XVYHeeqgeTkCX8ApI/spLR+o=; b=u0r5A5C19pdNa69cYioG5PLvGLrPLcUSeMgGQ0cvxwneTKuC/tp7OHefZI/flOuzKRupge GCwtdJpuW310AtlYH/NhblujxH2uFLjTd1QZGS/belM4//aX6wXxxac3GAcJfXfbFbXwmn 6GZvYjPJ7bxW+mGRVLz7XkjlSmyDzoY= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YGxadkup; dmarc=none; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703026366; a=rsa-sha256; cv=none; b=7hxW6C1JEzuW49+Ka1t3Y2StOlAw7WraysV3KfeK+hYfY7gp5NVR4XtNhSbYHP35akauhW M766lglV7N9lWsxJiK10Af8OON9l73QHXQcgiYsrl0YHWsmEgxlts0sBOHIjVK8CaXsYvI LecbbK9BhKkSSeb4gJa/io3BG/pFrzM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MAwg2J+eab2tticeU56XVYHeeqgeTkCX8ApI/spLR+o=; b=YGxadkupXV7DDfETbrj9rF0W8B xk9uC8o7meOixhvXtiPgfToiDkMsrxYnvumZaKOaMMlTdHkmpxY5wy+3T8p7RyiaMdSeOd7mb/XrG kvzgjcXk+mq/O/37+rMOaA0w5+33KWR8zKxocebBVam6BGiTNaSq7mdMybPuPisZjx/8of9U+n4ZL VvE30UdYIyg+it8RYSrs2S5RW3TcJ35R0UvJsLnFnJ5KlSos2ZEcb5CcdzrAsla0X/l1B8KUQyrfz PtWohRH4+LskpvatCBt3SGEoBtPy0PT706QrtrOsK61pydy5vOP8nZN0puaoe6sej/cKQYIjxVLxH w2fechRA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rFiwz-003PwK-M6; Tue, 19 Dec 2023 22:52:33 +0000 Date: Tue, 19 Dec 2023 22:52:33 +0000 From: Matthew Wilcox To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, tj@kernel.org, peterz@infradead.org, mathieu.desnoyers@efficios.com, paulmck@kernel.org, keescook@chromium.org, dave.hansen@linux.intel.com, mingo@redhat.com, will@kernel.org, longman@redhat.com, boqun.feng@gmail.com, brauner@kernel.org Subject: Re: [PATCH 15/50] kernel/numa.c: Move logging out of numa.h Message-ID: References: <20231216024834.3510073-1-kent.overstreet@linux.dev> <20231216032651.3553101-1-kent.overstreet@linux.dev> <20231216032651.3553101-5-kent.overstreet@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231216032651.3553101-5-kent.overstreet@linux.dev> X-Rspam-User: X-Stat-Signature: zpbfbzz5t6cw9kb4qsrqmyjky7nfcokd X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D7DBDA0004 X-HE-Tag: 1703026364-754862 X-HE-Meta: U2FsdGVkX1+D01bZTa6i6A7XdhEJlPrRgBbsLeIez4clhcvT7U3GKdowVKnACRwViZccZjNOrmOoJUE64USAt/+Mh0oqmIc7AfjRXfsr8pZS8h1k2Jc9O+rGzC5bAm8YAbdup5f51Pm3+rnetmYcqQQ7LWOjSubKjyxyo2QU7bY4vj/4GyIsmZ10SjyG25OQSXC6kpdkUnCNViX+ASp67QkBfD0ShRfH2COpAbqfE5xBDfztgj2G46TO5HhSOUUOTKzViCKbLxiheLpgUFMdkUgbW4lYpiUfDqdQnMGQEbBxqvoZWWKD9Kh8fyOWtiECTYRVKzLcY+wcf4OBRkdW0TM9sHNR2fX/fZEiNFafV1eFELC5+ZWOJMui2FJ6k8EAlWducxTEmi0d1Pq3yhRUXk9xMlf/8dP+6rk1WnqvMNfjpW0cHRq8WYeCBTMZYegPbXuncNSkYHqn26frGNwtxKK8hTpFqcVkSIFdowNbQKh5OoNTIiJXJLVQGgeDT/pIIbwLF8HOdRsg7gy7xtxEbUuyPkg3+19sxEiTMRI4XSI0hSF7bM2HUA+YDb+RJsrNcXzrMTq8IJapgQRuTg/gwwdFWgNy37bbhyf5TU98CyPUJ7TRBRKvKBq2TwXcvP9+FODJLxEtMublLqJYwi8gwKcOcyIYK9M0eOjRxvo4dXZr2k0+fVSl2lIOHbZzINF8D0Q4Kjnwf7WpY73tYJHSbPeHtJIOUOTbLv+A5KjA4UZQ3hgBCFk10M2qj5s4MxtGnUB+uDISsHHIeej1ws3J2mG9c8Iv21P5xc0rBTgaZirKHTfkdKzRRo+GV+FxA/ct7X+8pg27dBZ1OvTyt/zVg/4TrK9T+U/xXAQ01ncqxulqbD9HZLnkA9O3nx8qXDAPtF5O+fKeEAa7dlhoH/AKN0NLd5GJP3p5sNw6ILdjGhi0okBw9yza+XPsvr5aManIi0jdp58b9zyG/Q7hzcF yCLFaLGE DKuRwgZuX7Uv3wF0km7uroJBPj2dNItVx97G3i2UNJZQZOe5jAEvVBeqv9MnDxOx+a5pOIxQV6/0CvFjULjrWNagDLzRNMxuUNKoN0I3E3vq5CvhM5un34NJsk9L/Q/aVonFPnkXKPThy2UWqDt08jmbzpXVBKk1kbPw7rXfJx+Lys0QExCy/xWwzddRF0OwIeASWQBgrT2rc8No1sEaReUaYvg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 15, 2023 at 10:26:14PM -0500, Kent Overstreet wrote: > diff --git a/kernel/numa.c b/kernel/numa.c > new file mode 100644 > index 000000000000..c24c72f45989 > --- /dev/null > +++ b/kernel/numa.c Should this be a new file or would these functions fit better in, eg, mempolicy.c which is already built only if CONFIG_NUMA?