From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5E9FC35274 for ; Mon, 18 Dec 2023 21:01:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1CA096B007B; Mon, 18 Dec 2023 16:01:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 152C16B0081; Mon, 18 Dec 2023 16:01:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0E366B0085; Mon, 18 Dec 2023 16:00:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DA7006B007B for ; Mon, 18 Dec 2023 16:00:59 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A6CAAA1EC5 for ; Mon, 18 Dec 2023 21:00:59 +0000 (UTC) X-FDA: 81581158638.30.A110440 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by imf10.hostedemail.com (Postfix) with ESMTP id B1FE4C000A for ; Mon, 18 Dec 2023 21:00:57 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=DgnnqTcg; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf10.hostedemail.com: domain of david@fromorbit.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702933257; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yCl70P2eXwsD32MiqrmB1dJU3mIh1ffQIY/OsyTsmc0=; b=Q9gQPLQJVQVQ/i88RdW5QInqDXEi9sHDjkMBYPu5zvWAXw2Hl9ayoVtB5ooQdGJAlQ/XPK GMiQbKi/Agv9F97EdNsDotSQ0UP0+/8at1RCM3dY5dLiCMveqogyGDbSzTIJibh+l4yxtB eCuT32pGhjDPTz2BwEjeEktK+6bDYko= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=DgnnqTcg; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf10.hostedemail.com: domain of david@fromorbit.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702933257; a=rsa-sha256; cv=none; b=K0dGBFrwFTqU6FW28yp1MIBTcqMVB6H1JgtgCyrJeC0XGhLdRSKWwGANXdNEJr/LM/PzCr HGrVAXSwilx9c1HPRrEVxM5YNojsAMfSH6pF9a1oczRCvq4sjKbGJRvOsqD0l6aJZisTcn AAMiuB9xfp1tuu/aULDS5keNm1Q5+MU= Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-28659348677so2535541a91.0 for ; Mon, 18 Dec 2023 13:00:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1702933256; x=1703538056; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yCl70P2eXwsD32MiqrmB1dJU3mIh1ffQIY/OsyTsmc0=; b=DgnnqTcg/1r5CbMP/NOU2B4J+q7AkzX2XcGN4m3BKchHBBzjG8PuPjHCNndRTa5+vY 4q9TI8Ky+8suN/3ZnpFjsSzJCFmUeZxawg5pYBm7fthYXIj7V1xa1kvFTVQAZVNXcFK7 itZCVfPfzetRWb1R5r42UmNQi3zluFQU/BA+VwAZcIZ1cBsWscq6vuEdWXjgeaFoBHb+ ti2WCPhotyh7dyMgIgWi1QCzjTsSywr1PC0kc/5ttgics+MNFERHLT43MriU+BQKm7Pl 05qGAtIkX8mXg7yNPxgFuZj4IuDC/TRaubTx5Rjr6lBJKt5Z5mxSHTMRcRbMdu+os4vX yvIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702933256; x=1703538056; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yCl70P2eXwsD32MiqrmB1dJU3mIh1ffQIY/OsyTsmc0=; b=SWGC+HMya5u+/gR72gv/pJnFvB3FPwYLoTF0P5c7PFpq0wIapTT2NiEYyIS4a7wJM4 UCotvrvJmSulYA+raBUBv4WVQE76Cj2/iUtMwS6iaSM/DGnOySQup1D9Qgbi+8+nZWNh gQDtUjxU4NN12o0BtrJbHRBr9OLLZL9PXfFCeSYYqDb9UiL+PSaH0y9PMqH+osIjYpNz 0TyHc51pInAtE1XBAfkfTdfoc7pIIonHlROje0vwFgivfz9ze6AALuzi8OWBStGpBMCj 6dtALxzuLp0qF63vzEXlcKbVfNSezj+oGgXvo3pjaiiT/dtHqkB2ywf5lFZdNl01NWz8 Rm8A== X-Gm-Message-State: AOJu0YwJX7zTBsxg6LuvFB+9oQVlB+chPVHehsgQQYzFthTGtCyGVHB4 0gjbS3HbRrHxo/trVmIGlHAdag== X-Google-Smtp-Source: AGHT+IFRkQHZVHpggsuenU8/ddppEpd5S2UPqIefRShVpVOZW68bvcOoHhDR4JetnCX3kBkUOmYAtA== X-Received: by 2002:a17:90a:4b4f:b0:28b:5fc3:36c9 with SMTP id o15-20020a17090a4b4f00b0028b5fc336c9mr2440pjl.29.1702933256147; Mon, 18 Dec 2023 13:00:56 -0800 (PST) Received: from dread.disaster.area (pa49-180-125-5.pa.nsw.optusnet.com.au. [49.180.125.5]) by smtp.gmail.com with ESMTPSA id sh18-20020a17090b525200b00286e0c91d73sm20565584pjb.55.2023.12.18.13.00.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 13:00:55 -0800 (PST) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1rFKjM-00A8r7-12; Tue, 19 Dec 2023 08:00:52 +1100 Date: Tue, 19 Dec 2023 08:00:52 +1100 From: Dave Chinner To: Christoph Hellwig Cc: linux-mm@kvack.org, "Matthew Wilcox (Oracle)" , Jan Kara , David Howells , Brian Foster , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Convert write_cache_pages() to an iterator v3 Message-ID: References: <20231218153553.807799-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231218153553.807799-1-hch@lst.de> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B1FE4C000A X-Stat-Signature: tcfhdm1baq4efbzk44m655r7jkiiiscb X-Rspam-User: X-HE-Tag: 1702933257-797543 X-HE-Meta: U2FsdGVkX1+R9bv+xXrVXofWaCwuY6exuafycEJt0TnB+E/WHfiZOsAUv0c6kWHe+67LmUg0hjtAsv35PtbPj4zxASDu8On3vTBIDLisppz9rDHjnpGslE6GPm25IoozydRpE3DfrY2wlWSMuNpB+9U4BL763KmWdfS+IUIsevloHOGpfi2z9wn4ZW46i24IQFOi9w8JU1WYENfjgT8Xk6egvxNbzxpPhucS7618lso4QDbOvfUDlwVwvgJDq8jnsrvjuv+4z81G5ruiq71JfN8pV2fK3Tv377L7qgGAkUjy8FXIHEIYUYfTpl9hRu+5uda1J87IolYSaMwO59DXewkicQyORMPmqfCaPE+EtppeKXqHEciwrWu/chmwqaXFvx1ohvt+IqSHBTztQ0xfL9YzsABCoC0PAeNMufSz0Dfku2Uo91mSWKNU5+aeb851BSFBEf9iG8igE0huFPDN9OrUgnRyLCsjxZen/wstNo7f/5pWsegX+tLThz4aRxBKF37kwT2P92mJhVs9RqDzAPwnUko3xGCQKmVA66kD2a2eHgPxzGO7VYXj3Zdua6QLqxM5a/5/ibIgkSaorFM/k62hio+dZ/jxpbcAJkmGDQL0QS7mXn4JuHaxi8fz9pOG5XbMSnWh1VRzuxttgbRR2HyhNpx3yHTYEXOa7JOA78xgrpU/vVSrisaJWVUxFAdIJsC3cmfSJJKfFFfEMucMOHV/1eZwAlxHYPTDb5ewyNtVZwL3BSQNajzua3RnqMV34ch/rLRrA8hGLKDqNTi6Tnu0DmzYxjnYo9RFDzZaSaWnP5NQxx8uINQANfJZXi4ei8j7/KaLMJYqOLM5TBc6okHveMWoDMkVW8nAqYntUL3wCL21C2htoyNWg8EiDrNcsKCZR4GUKz6Vac54QZBAFt6hLmxHK91z5M98naPLKkMm5EQvggCWhrrjGwZGR7aPRW59xGb0ykAJ84h13Xp jjpkQ+Rn MPOAwEAf9zxsL3cts3L8N9jyNFq3BeM9fNUJ32IMjxeNER8cSYxC/p9+qzfeaMQKuNlpZkFdBdy5OTD09tADjD2mfURKtyKhftCtYywwy1jK3ctqY7eR1kLz1zxiAtCNjKQpPr2BW5N5iiUKV4x24RjopM5RGnkDQL/fofCSbAcvT2QAVdJHLZHYKMjyDdOtEt0g9O6PurgfmMD7CMX2ZXtQszJ3KAUL7Nv69pOjwN28B+GU3mSkhmlitEgd1odfcnQc8s/WJxJFzoOADOwGgQxO0xSmCsq1sbg6dQE8kokn7yemsCXbJvhgHTvz8ZQGfz68yoKNujOBmy277yOxn5Ne1eh8sQhX5zr2D6jh/bv4/9KGYt9kdDTnc2MC4xmYYYdAceI3iHD42x6foHuM1ffZSlu4BocS3wDzv2WBbuos9iNmSWv83GLgZ9zy52K2/23MoDZj3G2RKC1mwawzWsym5XocbXamiFhpdCT24/z4D6QmaJ8JBiJxVBdC1eWu7aUAK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 18, 2023 at 04:35:36PM +0100, Christoph Hellwig wrote: > Hi all, > > this is basically a evolution of the series Matthew Wilcox originally > set in June. Based on comments from Jan a Brian this now actually > untangles some of the more confusing conditional in the writeback code > before refactoring it into the iterator. Because of that all the > later patches need a fair amount of rebasing and I've not carried any > reviewed-by over. > > The original cover letter is below: > > Dave Howells doesn't like the indirect function call imposed by > write_cache_pages(), so refactor it into an iterator. I took the > opportunity to add the ability to iterate a folio_batch without having > an external variable. > > This is against next-20230623. If you try to apply it on top of a tree > which doesn't include the pagevec removal series, IT WILL CRASH because > it won't reinitialise folio_batch->i and the iteration will index out > of bounds. > > I have a feeling the 'done' parameter could have a better name, but I > can't think what it might be. > > Diffstat: > include/linux/pagevec.h | 18 ++ > include/linux/writeback.h | 19 ++ > mm/page-writeback.c | 333 +++++++++++++++++++++++++--------------------- > 3 files changed, 220 insertions(+), 150 deletions(-) I've just done a quick scan of the code - nothing stands out to me as problematic, and I like how much cleaner the result is. Acked-by: Dave Chinner -- Dave Chinner david@fromorbit.com