From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6028BC47073 for ; Fri, 29 Dec 2023 15:38:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB3046B0122; Fri, 29 Dec 2023 10:38:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D63726B0123; Fri, 29 Dec 2023 10:38:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2AD16B0124; Fri, 29 Dec 2023 10:38:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B13376B0122 for ; Fri, 29 Dec 2023 10:38:48 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 87A4F1608C8 for ; Fri, 29 Dec 2023 15:38:48 +0000 (UTC) X-FDA: 81620263536.26.6809914 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id 930B51A0024 for ; Fri, 29 Dec 2023 15:38:46 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=udNjXux4; dmarc=none; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703864327; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MMUixECVcqZI6/mrGqfR1zbER3vh+C3mM3cXKwGEL8s=; b=2yGAd+7NbeVvqC491V2zXPCRukhfx/hY7lHEHatDllinYc0PeGvmtamP5TiRKYMraus7WX a8TziaXHCvE/A4A+fL3eXUrBOVqPeJTUQQvPHvtWtakUnV6WSnRZg19y846tdVo2lvWuh2 oR+nZKDMlKNnPS7ZwVTOBkq6tO2fqy8= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=udNjXux4; dmarc=none; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703864327; a=rsa-sha256; cv=none; b=D/Wvdj/xqrnqrdxtXkU8do3tCN4GuZrC28EPuRZnmQqWowFtLqKgcK1hvQgSAOuds09g+J S1qJ9NzbD+bqNUhLbU6ewe5QeR8h+RWkrtn7c+ej/PppRh2o0+Io+S3leq+7FZN+LzK9HC /WQk73eA5B9kphAnq4Vvq/DDj3TFwbE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MMUixECVcqZI6/mrGqfR1zbER3vh+C3mM3cXKwGEL8s=; b=udNjXux4MUMTrSoC+YQQIhhvXc LrhlUHntT/e8YWgJ7h0BN5WXGP4LttWNJ3PgRTV6XR5hqI2MzN1/Y5XxrstdxNFtPJNleTAp+WAcn E3OIuoO6CXGseHGk+UdvvvbwJz3I7CDFEnXIs6GG2kO+rqFK9h1immV7yx7KGVE4FdhhvFJ3XR/ZZ jxQnAEn/z4CgqaRnMFpr0/S/s3MfwS5aaUKQVTIkUA+9NCHHZsAAgiVeBe0iXW0+bECFRMq4R0hpE +eCrDVdryXV/KzeJhKYlf0Y5YJJLD8Uzzm2vSedJGBAZni74fM/6tOxxEGkIeudd+RD7x7tYTDWfA QNCDrwnQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rJEwb-006J3z-Qo; Fri, 29 Dec 2023 15:38:41 +0000 Date: Fri, 29 Dec 2023 15:38:41 +0000 From: Matthew Wilcox To: Malkoot Khan Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm/cma: Move opening brace to next line for coding style Message-ID: References: <20231229153238.153627-1-engr.mkhan1990@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231229153238.153627-1-engr.mkhan1990@gmail.com> X-Rspam-User: X-Stat-Signature: gqsz3dcbkmws6i1n5w6wtkwkuyxk3mr5 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 930B51A0024 X-HE-Tag: 1703864326-937960 X-HE-Meta: U2FsdGVkX18hWjuMVwAZFjnSKnMu6AyWHVsFaIg8UMSxh/F8Fi70I6gXsTjNI52gtM+g5Ak05Cc3OoNDSexnxlGhCYG6bjtwe9PBgWuaSQANHkF6GB//fH1+QwMPfBXPtHFQGp+b3p7or9OrHmqqPIGImNt9MvAKTIU2RSO01+Bmw4aTOJ8uc71ODLKma3qmD37lHgnA3dDztS9tst/9GCGlzTBwb+nQ+zfyifTci47Rbk+T7kPJF8AWEPpcNsyh+jVHloLA4QCJfCwQ6JCmL72xTgzGvM7WVfEIL2STD06n8BeTXMGNTaJaEQeEn0+jQfQLah2DQNo9bO9zNljNkkSkBgPe41QxeUv1wN5OCTWalL5BSqseYjVI9F1ETxUALfpmViDI+rumvOsVuGFMk9HiGWhBbafOcic6UWgdOwdrJh4x7fJDgWNF+vBpEe8MhT+1l1simN+VAU1CTNubtHWMQpM6Lya9ume1bT+ZimnrOosf0MARApGmaIl3RbmbcWmq1ZFpAyaPlXfZK512JLH7M2wAR04hxmJw2DmclbIrOCIlBGaRubAVWoVLXYA1h1zqQPQmNzL8GykMkoQR2jVlB3mXoYLCa6IpFw9HheEt36IsRSDOPuuJIxu2hmeHjRVyyOXFkgQVsnU9PHSnS+7kyQvd9u4i0lCOjjImgsp1cD5rQbfFAYvlz4AQenUev1febr+wZlvl70Mh+KDWU7M/l/KUygwH4n06bEuqLTkOdL+nwEcRZ+dN5BdcZ8voH18ocZ8K4IYpySO8k88z1CS3FabO/23GAdNeQ2lxYIQuTlSrKPTP7mBknFbbeASWR4KDXip0Yi+/1dLRf0n30aJwc1EJuwANCgIeDslfFIkxwx9MkOwAZrxOygYfAbkj789irnXOOJPH0RKULcYSAEkFxBVKJZ6PwshCIJJg4Jl+udzEgVffVdtpwka3e4P5jrClYzpuoZbb+3jsaEI GIQq5rPm E1CnY2WvOiUIo3eS3KU57tSFqYj81j2ByBluqypS6fhl54IgqwduGHgIhNu8bHn26n0djc7vFiUw/aKWXprlPlds9IS3WshQqb9SBoNbJdSILT3/vVZfMnVmnOTaf6uyTPXEffV8gS9LT8HjtblgotNhbpYyEZ1bkMTxqoA74s+nksCtsJzE3XACiJQ78eGKmwT7jMKmr21VI8uJ3Yy5XGj2NkIYB7Wqr/qTsLTLaDoc9TrA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 29, 2023 at 03:32:37PM +0000, Malkoot Khan wrote: > Move the opening brace of a function definition 'cma_for_each_area' > to the next line which resolved the error What error? This seems like the _wrong_ coding style to me. > Signed-off-by: Malkoot Khan > --- > mm/cma.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/cma.c b/mm/cma.c > index 2b2494fd6b59..01ccd26e8bc2 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -579,6 +579,7 @@ bool cma_release(struct cma *cma, const struct page *pages, > } > > int cma_for_each_area(int (*it)(struct cma *cma, void *data), void *data) > + > { > int i; > > -- > 2.34.1 > >