From: Matthew Wilcox <willy@infradead.org>
To: Malkoot Khan <engr.mkhan1990@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm/cma: Move opening brace to next line for coding style
Date: Fri, 29 Dec 2023 15:38:41 +0000 [thread overview]
Message-ID: <ZY7oAR7l4HYxJ8y3@casper.infradead.org> (raw)
In-Reply-To: <20231229153238.153627-1-engr.mkhan1990@gmail.com>
On Fri, Dec 29, 2023 at 03:32:37PM +0000, Malkoot Khan wrote:
> Move the opening brace of a function definition 'cma_for_each_area'
> to the next line which resolved the error
What error? This seems like the _wrong_ coding style to me.
> Signed-off-by: Malkoot Khan <engr.mkhan1990@gmail.com>
> ---
> mm/cma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/cma.c b/mm/cma.c
> index 2b2494fd6b59..01ccd26e8bc2 100644
> --- a/mm/cma.c
> +++ b/mm/cma.c
> @@ -579,6 +579,7 @@ bool cma_release(struct cma *cma, const struct page *pages,
> }
>
> int cma_for_each_area(int (*it)(struct cma *cma, void *data), void *data)
> +
> {
> int i;
>
> --
> 2.34.1
>
>
next prev parent reply other threads:[~2023-12-29 15:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-29 15:32 Malkoot Khan
2023-12-29 15:32 ` [PATCH 2/2] mm/cma: Use 'unsigned int' for cma_area_count type clarity Malkoot Khan
2023-12-29 15:39 ` Matthew Wilcox
2023-12-30 16:06 ` malkoot khan
2023-12-29 15:38 ` Matthew Wilcox [this message]
2023-12-30 16:00 ` [PATCH 1/2] mm/cma: Move opening brace to next line for coding style malkoot khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZY7oAR7l4HYxJ8y3@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=engr.mkhan1990@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox