From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 500F6C46CD3 for ; Fri, 29 Dec 2023 14:52:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 614406B011C; Fri, 29 Dec 2023 09:52:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C4EE6B011D; Fri, 29 Dec 2023 09:52:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B32A6B011E; Fri, 29 Dec 2023 09:52:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3D85E6B011C for ; Fri, 29 Dec 2023 09:52:09 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1140FA0724 for ; Fri, 29 Dec 2023 14:52:09 +0000 (UTC) X-FDA: 81620145978.27.2F086EF Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id BA226C0022 for ; Fri, 29 Dec 2023 14:52:06 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="O2/kZo7k"; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703861527; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TuPgDojPHKw6CupQJwG5ikeXW8l957Szqc5prQs1GYE=; b=7d2N36TAlw8LfBNcpapsrlCphByHwbEcD3UDV4HPxQg9QuVRAJJ1mGk0ciPgZh4MogOsZ4 Y0N+N1///N8boy+M8EleI3kOjrhFB15mvTsvkzusHnzW4g6lYKX9hiyaQcjSwBaXol0PPY cyZFBpowgICJpsu6aOAq8tU7LCu8pAo= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="O2/kZo7k"; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703861527; a=rsa-sha256; cv=none; b=myW2wNTdZn0MNJXjMPQAGIlxOR3onOPb5ZbRgseIy04l8iwsXEfyiaUUlDqVBpKU5hphBg WHlll1mT6YHzQeD9dAz5F3/pUTSgrL0ikhO+w1yD5t0sDpTk2jVb6QN3eS6O4oefxRbjnS ROo7n7awxgvpoZkQSygMqpHTwiviEj4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=TuPgDojPHKw6CupQJwG5ikeXW8l957Szqc5prQs1GYE=; b=O2/kZo7k8MHhbMITfFhsRHEtGN SSg362JTpWehiBgATb5XQbubnuuFcdIT5HYWMYgG/JMopjWjU3j2GAyLYm0Ktxl4fIFtdJJsUeTc2 H56iyH8WAyeRr/Gfq8HgnK1dQOVoir4xBUeaddBW9U/Lr+Jt91O1rAKyVX/Fv+VhfC/qmwSyLW0Dj MSKBoRQQqMJMRJ12NMT2Li3XHY3Qm0ljB+hZ6anHWhRIuWP0UC9W2+0ERjW3727M6fZRrWqC2nO2F S/+M6rLLRc+rNz4m9UZwegWEG1DQrqE/3CXT6zE9QnFUAXo4MsvEFRkNtnKRxC+JzM8syg0KejMtL 6hgvC5Ig==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rJEDR-006HV8-I8; Fri, 29 Dec 2023 14:52:01 +0000 Date: Fri, 29 Dec 2023 14:52:01 +0000 From: Matthew Wilcox To: Markus Elfring Cc: linux-mm@kvack.org, kernel-janitors@vger.kernel.org, Muchun Song , LKML Subject: Re: [PATCH 2/2] hugetlbfs: Improve exception handling in hugetlbfs_fill_super() Message-ID: References: <9ce3f553-24bc-4ecd-ac5e-7ba27caeff57@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: BA226C0022 X-Stat-Signature: mx9j6msnb78mnidjs5xudi5y4e6si7dp X-HE-Tag: 1703861526-553347 X-HE-Meta: U2FsdGVkX1+cG/FiZNm61yBs4/MNk2wMmr5K9PMPqkHeThpZvfl7mXqPN5BRenTxQhpvJZzGyphZKPf2VtyyMw/z46zklzrunkCxv4THCBAKrH+4KG/+YDsCxiJUWsHTA5DqIVxBUVg29/DKKvG2pj1UJdL2kGq3bq04X9uLZNEzeeqR/JqtoY5+zSNoMG221H1JwX8uhA6Ea5IK9RgQsYwKvy1VTkRVAJLjLoNI88gTOyRPwvE1rqlcX01wf9dRhkp1gOef/C8iesHSp5pdqKqv6sPzST5kg73lV/rKJSWlI14WMRhP4LEPlr0bJJeHD60JpVAgC1ryp/1wBWTxhz5Vv/YUhRDdnjkgkooUy65JFHsWY06oaTpsl3+uP9a7dsGcmoSKmiowtNMCiuz3LSNUXrdrlh0FUgSrv5lwC7vZcEYNEJYzwum+ytXF4Hc61mpmWP3+DMZJ0sGmTfIsDAHfKqdE5Brr1TG/yEDrSxIq+MrmOsMqhgCsX43jkXu43hO5p+QS6KQrrokFnhlVwmNB7mmZxbSW0FxlJOWhxJWMKE687JfRZ+5Rj7Wmn1X5aa3c4C+0Z+vIhK9CWnw5h5CoHD4ffwCx35CwcrrYlxlKrC+OcBhiWaEiNHa4ZGX6iLz+/9+p8oirfojGDgri/754VUYtQEP+bv0fD/1R06QqAaTybhvrKtuy5Mhyxv7GAPDMxABZnxqjYLDiEcTLnR7H1uIUudVNW8C6JtCFJn4c8F6TReS2Bo6mwvEScsan/iCxY9JT/JS1gQ0nOQhJrvIxPQlDsz9iY6aL81AEQy7gOZg8MkXJLDaejoLveuyctIDYrbwROAExSPLZtQOtrtrku9Dv2Rfqo0FopVv/FJLcEsjyJ8WEifgzWpDTk7K7LXDPgTH4uCYryyOfoXXwo3LNtNnGzZDiD46v0mlJjZHqqCo9GTbFfX6I244EeZTjabC5nWhX5piwzRQj/ac XqK5vJGJ CDaZDWugkWhs/ymVC8i4mFgrIvQpf7DbFuN2TjdwBqsk8XJKBWYYtGmmUACXac8Oz5PcZmbu7YAX4l0VNXjdYn9YxM9UOkW2eiLwbqEnE/X3pgs6v08uwWyuIHI0bciqqlSKm/pMVti92OgVM0my2QvNejSMbd4Min23byi2oP00bgUXFk9qT/VgR1A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 29, 2023 at 12:40:12PM +0100, Markus Elfring wrote: > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > index 24401a5046dd..5687ec574dc4 100644 > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -1483,7 +1483,7 @@ hugetlbfs_fill_super(struct super_block *sb, struct fs_context *fc) > ctx->max_hpages, > ctx->min_hpages); > if (!sbinfo->spool) > - goto out_free; > + goto free_sbinfo; > } > sb->s_maxbytes = MAX_LFS_FILESIZE; > sb->s_blocksize = huge_page_size(ctx->hstate); > @@ -1499,10 +1499,12 @@ hugetlbfs_fill_super(struct super_block *sb, struct fs_context *fc) > sb->s_stack_depth = FILESYSTEM_MAX_STACK_DEPTH; > sb->s_root = d_make_root(hugetlbfs_get_root(sb, ctx)); > if (!sb->s_root) > - goto out_free; > + goto free_spool; > return 0; > -out_free: > + > +free_spool: > kfree(sbinfo->spool); > +free_sbinfo: > kfree(sbinfo); > return -ENOMEM; > } This is more complex. NACK.