From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38EBEC4332F for ; Thu, 14 Dec 2023 19:01:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BDEA08D00DF; Thu, 14 Dec 2023 14:01:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B692E8D00C7; Thu, 14 Dec 2023 14:01:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E5808D00DF; Thu, 14 Dec 2023 14:01:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 85DF98D00C7 for ; Thu, 14 Dec 2023 14:01:47 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5C04BA23D5 for ; Thu, 14 Dec 2023 19:01:47 +0000 (UTC) X-FDA: 81566343054.27.DAB4410 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id AA5CD14000E for ; Thu, 14 Dec 2023 19:01:43 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=CQjNFKbG; dmarc=none; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702580504; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BIjDpnSLfy+/JidKOjaXfU4tgr5UOAxujD+5ylQPn00=; b=Af7w41lWLyHSOy58poiikSAp3PZOOkWN7fibuV9Qc1IqjzIkClZRUl1ry+SrQz7BgWOMQH RN+YiO9Z2+nbUhVirgDo0TPPnn12AO3n7xMZ6uVRd2R2eI7Vblw/LPHJXN53vgU3HZaLPI mO+XbLvJzhkJq/iAICFhY235T+zGfFE= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=CQjNFKbG; dmarc=none; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702580504; a=rsa-sha256; cv=none; b=coOdlcROO0QsaHigisAm5oVq7Da5saDawUpLj12mpVbO5I4dy/XaM5+Pn7JRUk+79hP8qi 21MuDS2L38pwtd2h1z37YA2e1Z/H/5kpfNjJpkg/mj9+FRL2Y6qCenFwr/fIw8DySB7UPX 4K93ZDpaaaktFxKfEMdYiOp6qS3eNn4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BIjDpnSLfy+/JidKOjaXfU4tgr5UOAxujD+5ylQPn00=; b=CQjNFKbGCXrJctffz724MivJGE Lz5D8m7LpMuh6Zt0cgfflMlA01k9xaxqraUuyMlp1rGtMm7ldVTJWQSjhWXsvPqaGT50zUFHYikw1 ifJ5gBmXnpVVAxrYwo3xQ9fkpx4w6OYvwy8QY/p43OKOy+Kb++4u/ioZTy65zPuhfJpmZzmrweW5O 7eyMywno2bhZeUYhIZMTs/CUflon5q552OQm9a+JOcqQms43Oo7tj0YXEwkWFWB8XYoMSkZo2FtM+ rnQF+2L4ZoquufjpE2Vq6BDn6VLJNq0/kiZ5cYZuTNZWQ2BJJaBpNjlrVs0LvSuMvV4GSMDAmUO7f HhMtULnA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rDqxZ-009SqZ-SO; Thu, 14 Dec 2023 19:01:25 +0000 Date: Thu, 14 Dec 2023 19:01:25 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: Namjae Jeon , Sungjong Seo , Jan Kara , OGAWA Hirofumi , Mikulas Patocka , Dave Kleikamp , Bob Copeland , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org Subject: Re: [PATCH 4/9] hfs: remove ->writepage Message-ID: References: <20221113162902.883850-1-hch@lst.de> <20221113162902.883850-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221113162902.883850-5-hch@lst.de> X-Rspamd-Queue-Id: AA5CD14000E X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: cae7ma4m7wcbxb784u35adcn1kd4fuba X-HE-Tag: 1702580503-2648 X-HE-Meta: U2FsdGVkX1/gyAPrXT2Zf+spWe3sovcYFFAH1zFb32C3+6Prb77LUidZMfS4V7O5LH2qcl5eQ1gkbDauD09GxNxbohRxp22yMXvOQblhyWKygVFR3esGH9f0/KPlcufEhCZkO+SDqY9HtbBRlizUGmMAKpoCrQEbhTUuulICLuv1LpjLvmEcz/8HqH6rCpG6shbnziFL0il7tiGLK6gImQW0vom9CXQPbKlUktUhvrN3UdjjOfamiib7Ob+k+2w6fqfF3TEz2XDfAQMIaTrVwZegMGA1pm3KvNtnaNVF0Pjf5axMNoGAD7uT4xscf5/RHl8Tjetuy6kv1VyKZnAT//3677N4l7yshklyDXBUHPXP/eBWsb1vFpw1qz708m74j7igOKgskZzsYRXN08eUxsWl2Y++eZdjz8nDzTk47KfVxYlBCtGp7iCoiYlXKyhSSDwp8wgjooHvZLl1QoSKSe/ztCYy3gG+vlkSUKsng8Qd7G/TIH2rxsIkCFuKxuWRxTER2OS4kJUiiYgRteP5uwzLCBOhNk+R25kSzaVzXAB7BWJO8mdnYV9PXdr8idIIl0iWR6gvoO67Fi17S6DL5n6H/Q4dnSOtijqYzKkL47KxkMn/QOwmq81oMcI9MMmA6LIuD996CxY1DGyHBKUXdr5c9sOsu7TKuhxgpxGvToBaNkqcG8f7tAbkS/IXAwvulG71F0bSo0Fem98seCZQ875C6t9kzypyvIaAXCiM8nqTMvUOLybEOYJCm8cfMa6VPfIR9wIX4/XGvljwUvxoj77Hoau/XT1kW886UW/tzdq/uNtC2iWPJAvthCjbNzcEXDI4sas+qrnywtD8l8Jh/Jrq7Ralvcv60+W93FVm5w8nLdndiQ4DZADy0ZIFkAXA8Tey7BSGuPWpvgofQMC9XNEzmOatJuz5Ju7MDjSWswJB1nmAQ9Af3bquVINkg+Tdv9Rc4SbkSlMcG61nVOq QLSHx48J NcR7kAjYc8FqwNTnuuOLqVYfmM2Yn0GJhQvmajL0CAlUrgFixu/TbiSGxzpj4tc3q55K8WykmWGFYExe5VKQbYhlADraYGaVJHOWh3OPx8zMGUtYATOe220sYRY+pTalKA7nyJHVuhTt4230= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000017, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Nov 13, 2022 at 05:28:57PM +0100, Christoph Hellwig wrote: > ->writepage is a very inefficient method to write back data, and only > used through write_cache_pages or a a fallback when no ->migrate_folio > method is present. > > Set ->migrate_folio to the generic buffer_head based helper, and stop > wiring up ->writepage for hfs_aops. > > Signed-off-by: Christoph Hellwig Was there a reason you only did this for hfs_aops and not for hfs_btree_aops? It feels like anything that just calls block_write_full_page() in the writepage handler should be converted to just calling mpage_writepages() in the writepages handler. I have a few of those conversions done, but obviously they're in filesystems that are basically untestable.