From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89079C4332F for ; Wed, 13 Dec 2023 18:04:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22A836B0544; Wed, 13 Dec 2023 13:04:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DA046B0545; Wed, 13 Dec 2023 13:04:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C91C6B0546; Wed, 13 Dec 2023 13:04:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 00D086B0544 for ; Wed, 13 Dec 2023 13:04:17 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A879314024B for ; Wed, 13 Dec 2023 18:04:17 +0000 (UTC) X-FDA: 81562569354.29.300EDB9 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id DDD90400DA for ; Wed, 13 Dec 2023 18:04:03 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=EEc2Ut8e; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702490644; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j3ZC5EbD0G4TSJuMPyaj+089aRX2W7LOcU54bH3M1OU=; b=LwBYq5kvSfQl6w7stLisR9i50/Zrt/xCnIb5TtryenaAb6VYdlaHtqbiVxykaj3tt0RRpv 640qPXqA0hqfyjzE56M4s8iNRItWTORPS50dk/lzsJ5f7dWUreyRQKfMQtUB17ofAmzuFS 98fj+yiwJi8XoiJugzCKrDOaci5xE3E= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=EEc2Ut8e; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702490644; a=rsa-sha256; cv=none; b=8Ct7iKMAbEsX2z2nHufMvrl6eP8QWlcVXoNpVQTvnlE8LoL6e4oaR4M6PjNzsqfxHRSOr7 Ic8J1DijqKYMeD/EO1KdXsNM7U2Ar+tQhnLc6LiAKxhooDodiB/1RBoWbKs7wMISny8Har AHZ8etBF2t2V6jHrGBgXxws1ILSxNTs= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=j3ZC5EbD0G4TSJuMPyaj+089aRX2W7LOcU54bH3M1OU=; b=EEc2Ut8eH0HnGb/7iuvuIUTpba jgnw2489MXsJwEKNlNTvgJszqzJnzUJU8t89KYZijV9BHG8Wp84Z/gTBm8BhUdPXypJOBsqpFVTmZ 2Not73u+nv0pkrHB7xoXAwNrcpukCuv//B20hObOJs3q5UvlpU+JHFTT2CGtyRy/s835UWhj2s9Zo awLOROUiiWfr+QGnl8PjzYL30b0PaF99RrLgn2SuYLi8daQtqyHpZQaVJB/61czMMDY5vQHoFevyt yc9MOSbeX3DjMpCbE0Uvbxn6L0+EpFYGdFwXcXKyTLgTirwOWrBlUnJa8+KnIvHm8oSAST4vlWVzK nq9yCWTw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rDTaR-002OMJ-Bj; Wed, 13 Dec 2023 18:03:59 +0000 Date: Wed, 13 Dec 2023 18:03:59 +0000 From: Matthew Wilcox To: Vivek Kasireddy Cc: dri-devel@lists.freedesktop.org, linux-mm@kvack.org, David Hildenbrand , Daniel Vetter , Mike Kravetz , Hugh Dickins , Peter Xu , Jason Gunthorpe , Gerd Hoffmann , Dongwon Kim , Junxiao Chang Subject: Re: [PATCH v7 5/6] udmabuf: Pin the pages using memfd_pin_folios() API (v5) Message-ID: References: <20231212073803.3233055-1-vivek.kasireddy@intel.com> <20231212073803.3233055-6-vivek.kasireddy@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231212073803.3233055-6-vivek.kasireddy@intel.com> X-Rspamd-Queue-Id: DDD90400DA X-Rspam-User: X-Stat-Signature: fo4g3u7oj6xzu5gng9ahzy955if7ncg7 X-Rspamd-Server: rspam01 X-HE-Tag: 1702490643-168424 X-HE-Meta: U2FsdGVkX1/mx2ZzRVv/UldCqIkW3yUQxmQhkiUS3+inI0IxpT3tfZsz3FDy5fT0GJBfM5/ukLyAAExX/PfF0TbLlTIEve1N8KpMPn2L/HHQWxAQQNlRDKuWhRSIzFvet92RPy9bihuj2BXa4DbDdIY8mgCJWyoxi+ZLf337WfpBAHQg7sEwMDRv9hCfxFnkfgxjAEGK0LwI/OiSoikvubmvxJjUj2x+lC3hxBjydOJI7RK3qX82z05TGYcQVftekny9ZFLk60NUFLPBPTc3dnrdCSwd4snE8WZ5qj3EMgCEI66JZwlnZc714dzGZaB9GLmy/gYgNpSEt9o8BSpyMEkzOZQuiQc5IeS8FTJyZjXUcCSKniS5K4ycRNOJrpVC/g1RgsWgunUwFvNio3Fe4mSaMflWaD+bZiVryoEvLt/XEnrd0CZfTlIgcUNO2dxkWl3YYw20FJRWBWIGPrgKZIBSGNqLLSVrhA6wLAwnBgwlxG4ySfpT34Xw7Zliy7uDosg9pXqLps+ucZGTHPxV0fNBz6D3jC1VcR2rqS34ClW5t8V6MDd0QF9ddZpLB8/qJSx3bXl4jdxLoEX2UA+MzWQ2Y1Kxw2LIsFsOk3G/F0u/O4yNALFYRtFBopnUHCin/FR/39MiNw5raGUm+ym61kUKUJB46SA7kDUeOO7W5fLmMB5ihC5irjyyCkL1DMVjr63lnbqOURqAKLR+kDgVTtf2LSbMcFl/3Oom7zBV3zpyPo3k33A4JGv964BqiEvIKiGkFL0NLSTzP07ISEqdSPX+YOyqdEWqMqKufJ5QWvUuYxz4V5/S83kYpGmLYUJPCWL6eMVJap3DacDNClOBXpzoZs8qZRMlsRNer3+UVEhdBLecsGZloINU+QvhEIK57Y0bK9rcib+0QF2osEzEXeB4AyQqAdOeCRlcspkWEHWbiQ2TRqflg+BSP8mX1VEgfXTcK6+11TaIeVTByBg RpY+VsdR ahtPRg+ijXSNTwQcYeRrgl3HSDIyo1bSu96oS0j+1qVB9Dkp2EdRG1hDWc+qElwHQ/uP8krPsggJZD9XNMFxO1fXrUDoCzRdd2B96ag6H29ikw4iBjFbj35bmmzpNyoDypWEfqSYiJ9nYXUEWNE2T9o3tTkD7ADCPiVCVIQ8kY4AEo3vIth43cqVfAA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 11, 2023 at 11:38:02PM -0800, Vivek Kasireddy wrote: > +++ b/drivers/dma-buf/udmabuf.c > @@ -42,7 +42,7 @@ static vm_fault_t udmabuf_vm_fault(struct vm_fault *vmf) > if (pgoff >= ubuf->pagecount) > return VM_FAULT_SIGBUS; > > - pfn = page_to_pfn(&ubuf->folios[pgoff]->page); > + pfn = page_to_pfn(folio_page(ubuf->folios[pgoff], 0)); Why are you changing from &folio->page to folio_page(folio, 0) in this patch? Either that should have been done the other way in the earlier patch, or it shouldn't be done at all. My vote is that it shuoldn't be done at all. These all seem like "I have to convert back from folio to page because the APIs I want aren't available", not "I want the first page from this folio".