From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FC6CC4332F for ; Wed, 13 Dec 2023 18:00:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 164E26B037F; Wed, 13 Dec 2023 13:00:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0EFD86B037D; Wed, 13 Dec 2023 13:00:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED08D6B0373; Wed, 13 Dec 2023 13:00:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D53976B0367 for ; Wed, 13 Dec 2023 13:00:43 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A119B804FF for ; Wed, 13 Dec 2023 18:00:43 +0000 (UTC) X-FDA: 81562560366.20.5EFEC31 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id 320C9180072 for ; Wed, 13 Dec 2023 18:00:38 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=eatWHUPR; dmarc=none; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702490439; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ktJZ0d41GyynKto+sqLobmDOIfV0MP6FoedSStsH9RA=; b=6kmFLY4fCbn4VCl1ATtd2e2LkBmMaaYmxso8FB4FR08Rlv5u9qyPwLtjWIF46g+pyzGTgs 78pFGC3vFelDpdTCt05PY7iVyNNRc1hoNfc7VH8ZQPIYn6N3vpvkj0PdTWgl/DFMq/Kjir S69RziFY0UQ4eYW/MgXVf5TstLxIw68= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=eatWHUPR; dmarc=none; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702490439; a=rsa-sha256; cv=none; b=FqlZrfdqs30ga1GL+jH9tlfUMvyjgBTt4d0T5YV28+f7890+6a/FzMfXvjqFjA/HrRrrEc tpt7UCF0FPUh6g8IGh9FWG8HRRi7RTtNSfuuIdaW+y1EF17YB+HWFvg230Hzmk3IQrVzQS GU23TXRl5byT+Uabo4n6fTpwa/8meAc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ktJZ0d41GyynKto+sqLobmDOIfV0MP6FoedSStsH9RA=; b=eatWHUPRWvSEss1GcSYfmY11uk xWhoYIR4TkYsh8pwdvnLUMgn2VG3bL1l73l9YsF85o2CSR+et9jUVhTlsiStvHVdjDN5jsvxC585+ pi1Q2dfJ4h0dCLroWL7jUGQnfUvpdZ+MMsJS2VNIZv7KuO1xWfCD2JM5qnAhC9MCLjrllwdmSwNAI QqL7WvfjkGOxuxklgnX/yJ2Lr+kJWZ5in5FEVDzpM+zcIkkJe27ELH5hUSM8844JilfKW3U7mFEOF 4r+5FGmWsBqB2BI1X15XU1XDt9RCychU0fd/eel7Brhc7qPpkV52U/e4+oTx4XMnAWba9JKee8l8V OduTH1Nw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rDTX5-002Nk0-Oz; Wed, 13 Dec 2023 18:00:31 +0000 Date: Wed, 13 Dec 2023 18:00:31 +0000 From: Matthew Wilcox To: Vivek Kasireddy Cc: dri-devel@lists.freedesktop.org, linux-mm@kvack.org, David Hildenbrand , Daniel Vetter , Mike Kravetz , Hugh Dickins , Peter Xu , Jason Gunthorpe , Gerd Hoffmann , Dongwon Kim , Junxiao Chang Subject: Re: [PATCH v7 4/6] udmabuf: Convert udmabuf driver to use folios Message-ID: References: <20231212073803.3233055-1-vivek.kasireddy@intel.com> <20231212073803.3233055-5-vivek.kasireddy@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231212073803.3233055-5-vivek.kasireddy@intel.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 320C9180072 X-Stat-Signature: s4c5j78hcyhqd75h4tqzyju84rqbbkbm X-HE-Tag: 1702490438-733908 X-HE-Meta: U2FsdGVkX18Oghe0E365Qt18VpryTmOfP29XFiYKbYIXtpOhlPlEt3NJxk7VQbmwMMb9Yo51m+d63UCh3FKgkND/81Kx38aIn7+6YT5wCCxrVxLmC+Ow1wjJhM+4unC1NJ+ov94WbfkquUW0Ll7ZwG8kI6A+PdbLaP+/VDcmUAWB/2Mcu9zAYKhzTENfg1L8ItiFYpX9rw9D4OBLUUJ4RsvkcHt0aW3T/noyiZSb2UD4XJTH3JEHHkiS28cm01YvVME9sA2/DcpdC8x0CPhR5LbQURVHsTMuNt2DzrYY7+XX24+gm6M2a5RqXUksNgVQWWwmsmsJdWAp/IDhLkmjV0HfVVcdOMLiLwQG1PDAeOSLEOXlEx+XpcJJk0tl6j14XJ44ijQa6saVzQnfu79nAZHSo98mUwoXb9XCAnArMBoajmaLIsPOLLBmXQcHgnrwHQm7YoTIuhNHuo936jzktOUNMVNJnTwLitBaaQHkkVcTv613QCQcig7xtsq1p1dXKws/VJ3fA3mI+cGFIeZSI6zkL2mkuul+ctU8PpOtX3d5CvXF3EcuK22InAemIPxpowW/uU6hVrSh03Bo0t6ZsaIrLpuHReML1vBVZ3Jv9boKFhyP5EPXzQ4+eSJ+OkwCl/FnwOzaoJVQHGbCoLfFbA4zd90ofRBk5wqDLESZ9bx+ewKttzJ148C1TpmQ+gBL3ezRXJoCtjrfP1VxxhETjibVlgrS0k8hPQ2sGHm+pKiqd9wFJtO/931P2DQvTK2RFHOGpx4Q92hshr0aSu7h6XIw8gBwsyn3mHkmvlHkcj9z/26Pp+hE2Gnb+JzI7LQyDCzbvRTDlx4vsa4j6wntJsNTwWM3+2Uv243lgWqIUKYZgE8elIMWClmjSyJ2qxHt64bAWwcRKwoh/pMVBG09Bytr6MXm3l1CaZ4v7bOoaTpyJL1dwtrqI56PcDsqn2S2k6PjloZS2HeHUf5QEy+ OM9PVkG3 aXlXpzFPAKTGxch7y6trnrNPiD5WP0kOO111s2gnbHD3bXW7K59y2qDsK+XyyZ6q6zqsZrP9idWExljEGCcYlMwNqU8gIC5Kc7fE+1iPNB4GYlzbcw2QRGMJZSMeJ37RaRFUb6GOV8Hqtkms= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 11, 2023 at 11:38:01PM -0800, Vivek Kasireddy wrote: > @@ -42,7 +42,7 @@ static vm_fault_t udmabuf_vm_fault(struct vm_fault *vmf) > if (pgoff >= ubuf->pagecount) > return VM_FAULT_SIGBUS; > > - pfn = page_to_pfn(ubuf->pages[pgoff]); > + pfn = page_to_pfn(&ubuf->folios[pgoff]->page); We have folio_pfn(). > static int vmap_udmabuf(struct dma_buf *buf, struct iosys_map *map) > { > struct udmabuf *ubuf = buf->priv; > + struct page **pages; > void *vaddr; > + pgoff_t pg; > > dma_resv_assert_held(buf->resv); > > - vaddr = vm_map_ram(ubuf->pages, ubuf->pagecount, -1); > + pages = kmalloc_array(ubuf->pagecount, sizeof(*pages), GFP_KERNEL); > + if (!pages) > + return -ENOMEM; > + > + for (pg = 0; pg < ubuf->pagecount; pg++) > + pages[pg] = &ubuf->folios[pg]->page; > + > + vaddr = vm_map_ram(pages, ubuf->pagecount, -1); > + kfree(pages); We don't yet have a vm_map_ram() variant that takes an array of folios. We probably should; there was _something_ I was looking at recently that would have liked it ... > @@ -254,31 +262,70 @@ static int handle_shmem_pages(struct udmabuf *ubuf, struct file *memfd, > pgoff_t *pgbuf) > { > pgoff_t pgidx, pgoff = offset >> PAGE_SHIFT; > - struct page *page; > + struct folio *folio = NULL; > > for (pgidx = 0; pgidx < pgcnt; pgidx++) { > - page = shmem_read_mapping_page(memfd->f_mapping, > - pgoff + pgidx); > - if (IS_ERR(page)) > - return PTR_ERR(page); > + folio = shmem_read_folio(memfd->f_mapping, > + pgoff + pgidx); You could join these two lines.