From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F1DAC4167D for ; Wed, 13 Dec 2023 16:41:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 100FF8D004B; Wed, 13 Dec 2023 11:41:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B12C8D0049; Wed, 13 Dec 2023 11:41:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EBAE48D004B; Wed, 13 Dec 2023 11:41:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DB28A8D0049 for ; Wed, 13 Dec 2023 11:41:50 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B41ED120B1D for ; Wed, 13 Dec 2023 16:41:49 +0000 (UTC) X-FDA: 81562361538.09.2E98B96 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf19.hostedemail.com (Postfix) with ESMTP id D240D1A0017 for ; Wed, 13 Dec 2023 16:41:47 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CcmlUOV0; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of schatzberg.dan@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=schatzberg.dan@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702485707; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gr+U3ThNAiG15ak/Lw3/3fJKchrsxVjpre1fxBodeHk=; b=gjuZkxnj3FaKMMJGpIDGUnzezyYa9h0Nb5F1PpeszrIdsNLXTDMbgL1UiuYIb1MrHna6sw zRiZV+y6f6qp1n4bBOwRQfjDuTZOwZRTcOfTUWZAHxW9HeIqf8G9o5nGOSFCPwxvYEy3r5 hDpNTHgwsYRlI+nSRNvPZiarkHeK97g= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CcmlUOV0; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of schatzberg.dan@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=schatzberg.dan@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702485707; a=rsa-sha256; cv=none; b=dcR66NdFVgriUROkZ+eUAlCrv0HPBc5T/E9SU2auyh47oKxdFu8pC54Kz8XExh1RMp/G1v YTJyIMu7kgWSwkBFH7C7OzVjGGX4gs0Xjb/oUAB+TbuzbZgGWLMrjSXKvKBfq+hIYHx8iw kwxAXo6GkoMIBe7lSP3M3MfNIWc9q88= Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-6cea0fd9b53so4442320b3a.1 for ; Wed, 13 Dec 2023 08:41:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702485707; x=1703090507; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=gr+U3ThNAiG15ak/Lw3/3fJKchrsxVjpre1fxBodeHk=; b=CcmlUOV0sGhBSMQgWFiwN4x50Ma9zA4kVxjVj+cyxl5mwQ0RSCES1EjJDWKEiBbWE0 ZmLkVJUaDxET0fYnRMbBobqBtecfVSFELRa4T7XL1w/zgUK0VBUWzmrbeVH2EYIb1RFe sMNLepFpOwYabze4Gzz8xKxLUErRZGuG/+6n8+JncIPkC2vxUDUSX+Lfl3LbXFv/3TYX ID1GYZzjPg5YSrgRjQxruFk+PK10Cslu3ztQK60rbZDjx5zslMJZICkezoiiWZGCeCvI 0reHJlEFgR7xPxeJmESvPsHICE0e+Yn4OdsvuDSqomgOb4VToNUz8jlZ0qd9EuUYAQM8 pt/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485707; x=1703090507; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gr+U3ThNAiG15ak/Lw3/3fJKchrsxVjpre1fxBodeHk=; b=NUBtdZtJA+3Nk4ks2Die60KCPiOruZI+GZs4QSOz9yr8pldGN2DDc5tEopMeK2bYdo KRhJGV9TOhToMIxWrvtxDxJNh9+arFeO7KMxg2a5KK/hYAI/tB0OYzlRzw3eUOP9PSVC OkLYELC41Su791dC4pVwNvUF8LrGcXZjrCOfCSZLeudH6cYVCjT5IvyK+DV0Lw9nldZD jau9q/+3WMeqzIcgICJIqeUeOUQ6o8PHG5R0iJ2gZKxj5as8iPkTxSJJOBK6Rco7SDgL D+UfLD8SMVOg4z/DEeDkuDGTjF+PdMbk8KUxoLDP8Czx0klCDtqmkAYsLFMBL/MIqSx5 p3UA== X-Gm-Message-State: AOJu0YxXTyURkDUr67NHCNP3pUe293AkCe7H8tS/79I83A+/79E4tmoX YS6RWcU1drp9IRZeKeM7O60= X-Google-Smtp-Source: AGHT+IEd/aXZEAYYeKeL+Fq0SwOq+XspHrL1Lt7AF+acnSZ5Z0izCV8j8aJOzdEXlyG9NrNmjmtL5w== X-Received: by 2002:a05:6a21:7802:b0:191:e72c:24cf with SMTP id be2-20020a056a21780200b00191e72c24cfmr422281pzc.31.1702485706573; Wed, 13 Dec 2023 08:41:46 -0800 (PST) Received: from dschatzberg-fedora-PF3DHTBV ([2620:10d:c090:500::5:4500]) by smtp.gmail.com with ESMTPSA id s35-20020a056a0017a300b006d0bff2cc81sm2027359pfg.123.2023.12.13.08.41.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:41:44 -0800 (PST) Date: Wed, 13 Dec 2023 11:41:41 -0500 From: Dan Schatzberg To: Huan Yang <11133793@vivo.com> Cc: Johannes Weiner , Roman Gushchin , Yosry Ahmed , Huan Yang , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Tejun Heo , Zefan Li , Jonathan Corbet , Michal Hocko , Shakeel Butt , Muchun Song , Andrew Morton , David Hildenbrand , Matthew Wilcox , Chris Li , Kefeng Wang , Yue Zhao , Hugh Dickins Subject: Re: [PATCH V4 1/2] mm: add defines for min/max swappiness Message-ID: References: <20231213013807.897742-1-schatzberg.dan@gmail.com> <20231213013807.897742-2-schatzberg.dan@gmail.com> <86984d9b-c955-4b06-9097-2a757b1bacfe@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <86984d9b-c955-4b06-9097-2a757b1bacfe@vivo.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: D240D1A0017 X-Stat-Signature: cnhuexin5bds5wqnbndgjho8yfkmdxus X-Rspam-User: X-HE-Tag: 1702485707-378385 X-HE-Meta: U2FsdGVkX1+9+FPIFKByBbO6ABRzn0J6nItq3BANtfIWl3DMRus60FaHGdYgRLdh/GLvqhUJk2HNM5Ge+863Z3KZPM/oVidnIvhKbEbqNwecANAnQN7+iy2P+cEjz2G8fl0qhfZ/5ffdvBoN48OvPEwbfMyFYnFd7Dq6ZM8WE36BlgL3REUtgqNLIo+aGxMOefoC6UnWENw5kaAholoBIpAG4XxNh+jjc+jhkYi4cNDur50jwP7UihK5LGMo1CYuWo0/2PlmnmotI9usVgHEz63Nu27keKwCFK2KeHKk87Y4Sk63zrXu2GG4oaMGxcPSkC0kT6WAF1Qop+Cd1tULWIzYJJ4E5Varv9PlO8JFBEnHZSjypRMXIV9UlCXhjo0QEIqWOO8CLDCi44FssCb4id5sv9NiYQES6AWnm2OZnCAytSGSTpER7AHSDZckUfA6wq7dNN9uSzapahp1585J6H2zGPvjdRqdHR7E7QYRu48kn89McWRk8nga+nm4Fh30ENQC1klSTIo9AHf7g/wa+8clEoyvOzBx6Q1FLQMiRv/Pzh1OIbT2jsMobqRGhgMHDAgHs7xty3s1OMA68yl+PMBPH9PT4ljln+dP2/ZlIXPzijlNbnyrFHIaPehBOv/nSYUtZu6iAGtNsgCprZPm02+ZeR+Tpvc/D2alL4BDLKqExCrYbfuq55REwuanI56OUPcNN0L467IgTktZTbCp00C7G1AsgMQODSsFhTcB4EXi4v0UMt1fderflcBldt6fj7X2S4EYX3PmZl2irThOHPiCEme/E8fIyv1RxWtzRhHdkIiWpMTQ6oYi/CVsPK4eFQtwflFsKSX96eOlbalkV8B6f5bcLFbUCFzkle/Hmpzt2EN/aNyl8TSkX7RXvIa/eL+WSvnzZn7wjeDDy7QcJk2HMjVq3Sr+/2QeRG8DnHAVr3ZRvXoo2RTxcdktQlO61c2LQ/gRGJ8k3Ha7n3Q TG3MPksk 9DJgYoEwfLOQL3hl8hnNPNWC7iiTRHBL8oaV1Wq0U4j7yAi9ZlfUE4Pt6z3mNz0q9DmBLpMNTCUYCE9UEtfeXrXQSP3BMieiqC1Hp9lQFEJiBMexnVH9UFYUzVnL366lFXUGtDgbMUvv5fasRk1aArOjBtWv4jcNz3s7IJsYbOtOZj4I5H/Zm8Chq3bWFACKHNb2bX75fOvwLcBNFKB7/uYrjKpKpqavXPZUyv9HHdK4pET421gpMTWQvktuxH14t5C0PZCtXfz5cD/dtR3nSjD0V6hDqtLHq+mWNqqyrtmr386HbHJGwoCQpn71KzuHkXd/naXiGkiDZeJjVkPN/hUP+8Dio7P+X08ENWSAKLZG//z5utcGDzKvwN0CA2pQCXxrZmWrjpScwE6pYFX2mVqOAH+bCX9e2j0do9MDKoC/65KMibgm3SgDL+cmU9MA4j9A87tv0qYwc+EUGu0TkB0K6kIXhEsMufY/41mv0RlVSsjyCv4Bun9lwY/G07dD0p9p67b/d8Tk5DwoTCkiOtCqe+gAVrjZ9Gay1xtDjl+iDA++KtYmpAroiQYkl7JDrCnrSQnQumgqutfrMPOknhc6IrQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 13, 2023 at 09:58:26AM +0800, Huan Yang wrote: > > 在 2023/12/13 9:38, Dan Schatzberg 写道: > > [????????? schatzberg.dan@gmail.com ????????? https://aka.ms/LearnAboutSenderIdentification,????????????] > > > > We use the constants 0 and 200 in a few places in the mm code when > > referring to the min and max swappiness. This patch adds MIN_SWAPPINESS > > and MAX_SWAPPINESS #defines to improve clarity. There are no functional > > changes. > > > > Signed-off-by: Dan Schatzberg > > --- > > include/linux/swap.h | 2 ++ > > mm/memcontrol.c | 2 +- > > mm/vmscan.c | 10 +++++----- > > 3 files changed, 8 insertions(+), 6 deletions(-) > > > > diff --git a/include/linux/swap.h b/include/linux/swap.h > > index f6dd6575b905..e2ab76c25b4a 100644 > > --- a/include/linux/swap.h > > +++ b/include/linux/swap.h > > @@ -407,6 +407,8 @@ extern unsigned long try_to_free_pages(struct zonelist *zonelist, int order, > > > > #define MEMCG_RECLAIM_MAY_SWAP (1 << 1) > > #define MEMCG_RECLAIM_PROACTIVE (1 << 2) > > +#define MIN_SWAPPINESS 0 > > +#define MAX_SWAPPINESS 200 > > Do MAX_SWAPPINESS apply for all swapppiness? If so, maybe better change > swappiness sysctl define: > ``` > sysctl.c: > > { >         .procname    = "swappiness", >         .data        = &vm_swappiness, >         .maxlen        = sizeof(vm_swappiness), >         .mode        = 0644, >         .proc_handler    = proc_dointvec_minmax, >         .extra1        = SYSCTL_ZERO, >         .extra2        = SYSCTL_TWO_HUNDRED, >     }, > > ``` > > Here hard code swappiness in [0, 200], and now add a new define. Yes, MAX_SWAPPINESS is a hard limit. I'm not sure what you're proposing here - the SYSCTL_ZERO and SYSCTL_TWO_HUNDRED values are a little different than the defines I added. I think most of the value is just consistently using the defines in the core mm code. > > And many other code hard reference 200 into max value of swappiness, like: > > ``` > memcontrol.c: > static int mem_cgroup_swappiness_write(struct cgroup_subsys_state *css, >                        struct cftype *cft, u64 val) > { >     struct mem_cgroup *memcg = mem_cgroup_from_css(css); > >     if (val > 200) >         return -EINVAL; > >     if (!mem_cgroup_is_root(memcg)) >         memcg->swappiness = val; >     else >         vm_swappiness = val; > >     return 0; > } This one is already fixed in my patch.