From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CBA2C4167B for ; Wed, 13 Dec 2023 16:38:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE0D66B039E; Wed, 13 Dec 2023 11:38:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E93C36B039F; Wed, 13 Dec 2023 11:38:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D32996B03A0; Wed, 13 Dec 2023 11:38:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BF7C76B039E for ; Wed, 13 Dec 2023 11:38:41 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 866FF4015D for ; Wed, 13 Dec 2023 16:38:41 +0000 (UTC) X-FDA: 81562353642.01.07F1141 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf17.hostedemail.com (Postfix) with ESMTP id 9FB7740013 for ; Wed, 13 Dec 2023 16:38:39 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=heRjcRRE; spf=pass (imf17.hostedemail.com: domain of schatzberg.dan@gmail.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=schatzberg.dan@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702485519; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WngvNIIdUAOImz6VKCR6KlDDLoKgFI0GBra4+hjHdaY=; b=v0z9AYwiW2/eNMOKBSLKPoEJHLZW4LRWz5elX9RgYqd9Z5okpxiryt9H4kYBMHyozWiIPi fMz5p2eJOO9klEqVi90YBg3eGNj15QVFMNL1k0zKrTUm3YYKDCfgUITExQjdMu9CIcVSa3 hep182eCYkYrF/w6tlX9HaGquw6uUWA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702485519; a=rsa-sha256; cv=none; b=yQXSKVN8Hyfv2sYkZgNN5ClH6yIw6Dkb3+A4o5HQT8yIDV+fy7TNUNk2pY7w870Z6lKKhl EJQZc/sPXVwq+t6s0iIAKDgTVdMl9R/RhdJfEiLHCaorWqfAPQtgTUNKbTe4xMltS6Yuyc nvy7rL48oVXxszgbe3UPNU9dYI5k8vM= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=heRjcRRE; spf=pass (imf17.hostedemail.com: domain of schatzberg.dan@gmail.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=schatzberg.dan@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1d075392ff6so56522325ad.1 for ; Wed, 13 Dec 2023 08:38:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702485518; x=1703090318; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=WngvNIIdUAOImz6VKCR6KlDDLoKgFI0GBra4+hjHdaY=; b=heRjcRREx4YWW3Ie/Ng9rUNzNCJlx1fuRBk4eYW+zqx762eGjNf/6CxRnqjT6dHLuD vQT5kMGbzFDhpqSUXJJMWneJuxv7UpzJmKN2ge5sZqzR/4yPcFicAVW75NakChJbw9vZ Ai40wbvLs/g1UMfUh6FvderMVqF6c6XeB3XVfOxy9GBX1rVG1MvC5S+zzbFoGRgMnX7f mZFWnLiwf3Zi1YXi8vXmVZlpDJRfHXVXgr/lzzyTZoAH+AsP5qtNlqzgToXxg/UcfqI5 GvS7n9uGVEATie/VIrxQBmuS4TdjzhhcE6FBLnd4R0SnziQQltD5guawUwO0+/yn0cEZ qQwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485518; x=1703090318; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WngvNIIdUAOImz6VKCR6KlDDLoKgFI0GBra4+hjHdaY=; b=eOyBOrLcTye2rtOgAQ+wlZIepjsx3TrPUtGD4geQ54JJu/QNSc4VwnAXnJ18zp0QJK XxvnXKj4IPCv8AuR27flCN58Xf25ctD0pqeEWHALwliTwbqyOqhkwb9nXYBqZd4LvZp+ SNpRlGE6YqEhDyi8ziS2j9F84qGuLFmxc7uIMZgu9iB268IdslLUCL0NOuqJ0XVUqYEp E8VBPdsT8et1VFQDT0HUp/viTtbt3SQ7CNxvDnrdjDBuZwh7JW4gvafw5RWLLFM81jzU lGIeKoFOR4Vv29R69cNrr1sKN3NntY+bYVMqWxaoCcQY//Ie43wvUulxRaVkijeYpP41 TLWw== X-Gm-Message-State: AOJu0YwOwHIEy+GpLC4rUQFN7XdgX5BqVXJGZiX0Wp4iaDRGHqaEZUQg 36Z2vqb4+OVBDE09KnWi7v0= X-Google-Smtp-Source: AGHT+IG40cDam0iwIQQ0yixGvC12xVks7Auh91vEMpA9cC4FQkIMzHTpnOC5tJomQzgVmo/Fg54fjQ== X-Received: by 2002:a17:902:e887:b0:1d3:3768:90a0 with SMTP id w7-20020a170902e88700b001d3376890a0mr3641678plg.40.1702485518164; Wed, 13 Dec 2023 08:38:38 -0800 (PST) Received: from dschatzberg-fedora-PF3DHTBV ([2620:10d:c090:500::5:4500]) by smtp.gmail.com with ESMTPSA id az4-20020a170902a58400b001c71ec1866fsm10810814plb.258.2023.12.13.08.38.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:38:37 -0800 (PST) Date: Wed, 13 Dec 2023 11:38:33 -0500 From: Dan Schatzberg To: Yu Zhao Cc: Johannes Weiner , Roman Gushchin , Yosry Ahmed , Huan Yang , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Tejun Heo , Zefan Li , Jonathan Corbet , Michal Hocko , Shakeel Butt , Muchun Song , Andrew Morton , David Hildenbrand , Matthew Wilcox , Kefeng Wang , Yue Zhao , Hugh Dickins Subject: Re: [PATCH V4 2/2] mm: add swapiness= arg to memory.reclaim Message-ID: References: <20231213013807.897742-1-schatzberg.dan@gmail.com> <20231213013807.897742-3-schatzberg.dan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 9FB7740013 X-Rspam-User: X-Stat-Signature: a7g1edjmnpzgo5czjgr4d5uywok1u7xb X-Rspamd-Server: rspam03 X-HE-Tag: 1702485519-544616 X-HE-Meta: U2FsdGVkX1/Dq3krIfcDem4vldgKFvOm8VVNUM/Wzgwpo0IGE+uUrL0i1KIitAFczSP6jJi7iJRlstdyTEv1cjYQaPN7g95Usqmpa4Wnk7YRSR/C8ZOpK1Ob5VUBV/WpRi/GkeQG7usklhUuoIhyiMQuh51HfbI4gqFX35Nb9+LqHRG5af3+xN9IhUIv99jEQs8gQG5PLkXv5Eq86Tc+CPhUWEeY+IWxAjGOx8xmE86D2VwHlyjO2/NuqTVuoVC6YoXvUxbhMMBgOH3Hp4vQKO02brN2DYGhgrcoDkCWu+33q0gHyLgkKVcm+ImAyzcbsQsAxoYgUK9yBTbavfy5SCNJQqM7rFsU+x8lUCxc7WllwaqbaGOxajQF9krpJ5Z4cJUnUQWold+07HKCcRlShDangXi+VmCc1f3BCi/F48+YkjdEHKFSwq5mC/h71u9PHN4YZxzAjkUDVoqZTgvi6SvqW3VOzAQ4jme+6ceBk/izWfhVzgFkI+5BIT2mRfxE2cOIxys3EE+W+Rd1BQQnTk3j29QLKI/qOulL6QRqRNIIivBaHKkTyKGGN3N4b2+VsyofnbAAGavWINwTClwAjo1SSfOpEdEQQLCQVZJURK7xnDub+OvVUmgu7+zNdAxxez3A7t71NuBndbzzQWC/gDe7DFosucHgNwh8ydoq/O/a12HXDew59Rvsl38UsaXh5uuCEKzOEuvLKui/o4JV2SNTKQONzjbCFf+g7uPhTtBaqKRTB9JO2EcsLq2NYbg5n3aRngUzEc+dMiafm5Zrc+QqtqiRcyAZs4lYjSoJTkj4zjJEKDS61y+LpOy/gT2GzgwlwoRaC9lEeJ4fu5Ejt0p3EDqcjyTbtiHjCzWQoofQ/RSBH0Rrssd8Ox0KhFXAVXhXWJZHyRCVAI4WqlVdCm3ApAA8bTMJ10ez2RAxK59l8yeFPEvN+3gqpviXNZQIKcfDxldeVW97/XYod80 74nBG4hA cahR1suaz+LtYJqIc+J6o3u6uKWtdj6SuWTAPMb3nVubaLrDev+T2SmCGAaXGlHb/yT9zzWx0bLXT3jvBNfZ5rHHyXqg/dJUysuv8hUr93DAxNyB9mct8tKEmhVfNr0iAsBnq7xMgVD9IamaErgGVuss4EMzYmiZrParb5vXNDWP8Lpg9ew1t+c94KagVnLwm/L83eKM1brGQqlopqwii0RMhjbDPHIUNTVacDdsAxHBEjkJj2+kGBFKl0YCStW85Kh+YiC9NjnPDPOq1F8UTAsx0uwqsXFKcpwRJn9fNT/wFSdi1Mdrp5jtQge1LC9yU0S05emSO2WO7rFN/95w/eelIW7AbqI5W45ibzUOWkA971//LgT0KMWk3yXmh0bi4wwXNAh0AS10c4q4tjAIPzjc32ROvaQt8q1mtmwUTMvznJSZ4Lc60hPyzNX+GU2mAeXIf1FaSVMpddvht/UaoBMsjrqnOYDIQ855GmtQ9noeTEEN8AL1u9zu4yLhaDeZEyhMFtkNPZwIrRDqEt9O7Z6yzxEWXx6scRAJ6WCfXrg3NKl4g2eiaonz1066ZU1+Dn85AWAVYITFWqaA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 12, 2023 at 07:05:36PM -0700, Yu Zhao wrote: > On Tue, Dec 12, 2023 at 6:39 PM Dan Schatzberg wrote: > > > > Allow proactive reclaimers to submit an additional swappiness= > > argument to memory.reclaim. This overrides the global or per-memcg > > swappiness setting for that reclaim attempt. > > > > For example: > > > > echo "2M swappiness=0" > /sys/fs/cgroup/memory.reclaim > > > > will perform reclaim on the rootcg with a swappiness setting of 0 (no > > swap) regardless of the vm.swappiness sysctl setting. > > > > Signed-off-by: Dan Schatzberg > > NAK. > > Please initialize new variables properly and test code changes > thoroughly before submission. Could you be a bit more specific? The patch is compiling and working locally but perhaps there's some configuration or behavior that I haven't been testing.