From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CE62C4332F for ; Wed, 13 Dec 2023 16:27:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D066E6B03C7; Wed, 13 Dec 2023 11:27:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C917B6B03C9; Wed, 13 Dec 2023 11:27:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B31676B03D0; Wed, 13 Dec 2023 11:27:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9FFE66B03C7 for ; Wed, 13 Dec 2023 11:27:28 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7D75E1C0EC1 for ; Wed, 13 Dec 2023 16:27:28 +0000 (UTC) X-FDA: 81562325376.16.941261A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf02.hostedemail.com (Postfix) with ESMTP id D214A80026 for ; Wed, 13 Dec 2023 16:27:26 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=qnOv5Qv3; dmarc=none; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702484846; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Us7YTN6WMg1UsHkPpL8fh2VaKDzONXOhFAqiscEUm28=; b=chI48k4FuysgFTGmIwgjM+b5IbSt+MSt2Ia5WUK+Q5cNj8PxgHtLDTNSXvZA+j2yyj/bI6 LJeppAO/bGkUXN6nDVmRE8NR6lKlMcseUvRx9ESRY/gLAqgPzAylhvjxLrsf+0iDKg+0s2 kCbXGJhiQ774TdvGG4X7cS9OHdD+Hik= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=qnOv5Qv3; dmarc=none; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702484846; a=rsa-sha256; cv=none; b=j/74hKMsqfuvkGOtzffA8iUL1UqWiV7e7iVx6LqnlvzNPQ+2wHtAmfz0m2p081cSu/CR2h dpA2cqejmVLoI2U4pBiE6EK/Ri1G+35QyH5wa6ynGdnlXeuNxL0ztceEEzpcvHLI3PZUql GZMv0c9VIka6x37iCRJc+BQ7rr7ld68= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Us7YTN6WMg1UsHkPpL8fh2VaKDzONXOhFAqiscEUm28=; b=qnOv5Qv3PAnpQs4tDaviiVpKUd 91cZhJzNtcgCwhpE/7MDv9V8tb0GAJ+/usEJbK4zAMOQV36ZnrtS2Jo/MH2DI0lAQx7hp28lunp3N AbuIx0v3mvEJLXBHfChNhI0ppeaGjjwMJbZKk3JcwrXZgNaz7nbrycJLIltGW8RF9ERbJ8GAHywPd O7S5YyX4d0WyQIlAY8qmkhzrTl0azgLTAEBd533yvtjK7act3OtA90QoN3Woh8IvTgauG6k0HjLep 9MXZs964JzkVakpJO/eXyEKr5NZ7tbx4Td+xbUGJHs8OXQoeB2e1u8kejbwutt/jNPNEqKdRT4qDM l/5E50Dg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rDS4s-002Bed-2R; Wed, 13 Dec 2023 16:27:18 +0000 Date: Wed, 13 Dec 2023 16:27:18 +0000 From: Matthew Wilcox To: Yosry Ahmed Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: memcg: remove direct use of __memcg_kmem_uncharge_page Message-ID: References: <20231213130414.353244-1-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: D214A80026 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 3uxrkgszrgaowzro3bwzmmif6nw1ompb X-HE-Tag: 1702484846-988275 X-HE-Meta: U2FsdGVkX18fDEp0u2deCtv7ZBzz7nTHaehlPz4/sYLPxrjXpbbvkxbuqnsrqfifjh9kkHVLDjiwBBXx6qLI/JtPC+eGWGcY2aXcBzqmGE5SPt/8V7bny5AHGz6lUMl/5tMliLQvTrQi/0E+g/lhwkoqgmkhFFYGMrMfvQRalefijOlpdCJ+nl23y5Vus3w0PhkZTfWTSDcClbgngZLjdbPZGLUtRQSj92eiA/lxgACq2esokWDY9fyyw8lO77RFPcmP/F1gIMbMM8wzJnNe5ifEIXod0XIG/sXINR9E3WWxtdLyEO3EIRjcv7J5+onwgCcgXaxnd8ooVL3DTPLwDA1XpT/ZZqKd9amkvuqfDtdq94lUnDVGlbkBWecENlXXp/oCAONhBFeXE0SKPYM+1ypQ0uuCubzsDQW3716CflPbjlcRiK5J7W78Eq4Lzr6da4wy41UsmE3nGeBs8B63Ch+jS/wWs1pVFwegNHrytrbEltkTvMSGkfCaE4LbQJqil6GFBUnqEx3xjFgqUeDdMRFYM0qEKDcT2GBdNVEwbld2OBXNGy55udSWBLSpHOrpThw/2fF9ZYDCrhC1P1KEkuzvwU3pXImAXS2ffOTSz6zgnHaJIm4RMCTLt/vMPmJTIBd8AUXmQazoD63jH1yyF0VmMVSUySEJSQ4JNSbF2aa46WQQhffBbw5V5zJYxOVc09/h+eLfqhd7i/NFIoV2XfmPpISRQWqy1cQn3gzO1wv6faHobj5jc1jYFUZ6yyvPN+CeXqzvAjxwwSj1PTLrL1UC25EWbUSQkgkzspV0ZmOt6x4ntCXbYqd0nAUJz5c3ctw2oeoCD6M5wc4w5Z1Od7VPYfkMZpEB1H/aoGQ579unKC736GNOUAN5RjhM+lx6wpjn+/pzc2/CnWLjkYYnHPu3dqyGbu0qBrILjMf/YFO7ab00RuhwcOpuwtQe6NVlw1ilvGznKoEL3aH8g6s BEGl5V9D fwEImAksyAf0esXnsHrcCwpbzc4focTG5EZ/yqYgRQrz+ks9BTQdIo40JolhxwFkn9Jg0ge278JcDviN7c+FwlQe+JEt1Dik0EDsyROeFpdfHuOfspcJS0EbyaWvOpVEhJpmCBKe0bT6F3H7WjvX0p9MOZuKBE6AP5SMco6btx3D9ipPzecCbIP9W5g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 13, 2023 at 08:24:04AM -0800, Yosry Ahmed wrote: > I doubt an extra compound_head() will matter in that path, but if you > feel strongly about it that's okay. It's a nice cleanup that's all. i don't even understand why you think it's a nice cleanup.